)]}'
{"tools/generate_sample.sh":[{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"fe48d3ef10c201b26e466fcb286b0e78102a2255","unresolved":false,"context_lines":[{"line_number":17,"context_line":"if [[ -f $ACTIVATE ]]; then"},{"line_number":18,"context_line":"    source $ACTIVATE"},{"line_number":19,"context_line":"else"},{"line_number":20,"context_line":"    echo \"Couldn\u0027t find valid pep8 tox env, please run tox -e pep8 to create one!\""},{"line_number":21,"context_line":"    exit 1"},{"line_number":22,"context_line":"fi"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"1ae5cdf2_a815bbe6","line":20,"updated":"2014-06-16 16:43:56.000000000","message":"So right now it is possible to run this script without a tox venv. Why do we have to error here rather than just running it as before?","commit_id":"bbcdbb9b984f91fa5395700415a31a652cca096c"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"5979612e670d62525d3b146963a7f50e9a6bc368","unresolved":false,"context_lines":[{"line_number":17,"context_line":"if [[ -f $ACTIVATE ]]; then"},{"line_number":18,"context_line":"    source $ACTIVATE"},{"line_number":19,"context_line":"else"},{"line_number":20,"context_line":"    echo \"Couldn\u0027t find valid pep8 tox env, please run tox -e pep8 to create one!\""},{"line_number":21,"context_line":"    exit 1"},{"line_number":22,"context_line":"fi"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"1ae5cdf2_9bc28284","line":20,"in_reply_to":"1ae5cdf2_71dee0db","updated":"2014-06-26 20:11:57.000000000","message":"It should not be a requirement, but right now I can run \u0027tools/generate_sample.sh\u0027 from the tempest dir without having a tox venv. After this change I can\u0027t. I am just suggesting running the old behavior if there is no .tox rather than bombing out.","commit_id":"bbcdbb9b984f91fa5395700415a31a652cca096c"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"179d540021741bbb9e35d7d72c9fc4c291f60d4e","unresolved":false,"context_lines":[{"line_number":17,"context_line":"if [[ -f $ACTIVATE ]]; then"},{"line_number":18,"context_line":"    source $ACTIVATE"},{"line_number":19,"context_line":"else"},{"line_number":20,"context_line":"    echo \"Couldn\u0027t find valid pep8 tox env, please run tox -e pep8 to create one!\""},{"line_number":21,"context_line":"    exit 1"},{"line_number":22,"context_line":"fi"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"1ae5cdf2_71dee0db","line":20,"in_reply_to":"1ae5cdf2_a815bbe6","updated":"2014-06-18 12:41:04.000000000","message":"only if you have the right version of oslo.config locally installed. Which shouldn\u0027t be a requirement for this job.","commit_id":"bbcdbb9b984f91fa5395700415a31a652cca096c"}]}