)]}'
{"tempest/scenario/manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"75b361c711e5b7d3cfc8d55b912b9ddecc829a5a","unresolved":false,"context_lines":[{"line_number":792,"context_line":"            try:"},{"line_number":793,"context_line":"                source.ping_host(dest)"},{"line_number":794,"context_line":"            except exceptions.SSHExecCommandFailed:"},{"line_number":795,"context_line":"                LOG.WARN(\u0027Failed to ping host: %s via a ssh connection to: %s.\u0027"},{"line_number":796,"context_line":"                         % (dest, source.ssh_client.host))"},{"line_number":797,"context_line":"                return not should_succeed"},{"line_number":798,"context_line":"            return should_succeed"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ae8d1ca_2b48d02c","line":795,"updated":"2014-05-27 16:12:30.000000000","message":"s/WARN/warn/?","commit_id":"45838f973424983e4c97ab1f1e0f636d35733210"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7dfd888e45113bcfe8f5d686e59c7124fdaf1638","unresolved":false,"context_lines":[{"line_number":786,"context_line":"        :param dest: and IP to ping against"},{"line_number":787,"context_line":"        :param should_succeed: boolean should ping succeed or not"},{"line_number":788,"context_line":"        :returns: boolean -- should_succeed \u003d\u003d ping"},{"line_number":789,"context_line":"        :returns: ping is false if ping failed"},{"line_number":790,"context_line":"        \"\"\""},{"line_number":791,"context_line":"        def ping_remote():"},{"line_number":792,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_2c9ac413","line":789,"updated":"2014-06-15 12:59:40.000000000","message":"Unrelated, but the double returns docstring here is confusing.","commit_id":"14cbde9c83eace9dd99995e4169c6d267d7b8011"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"6aed58593c4214de32f32ecf38daad8a9f842cbf","unresolved":false,"context_lines":[{"line_number":786,"context_line":"        :param dest: and IP to ping against"},{"line_number":787,"context_line":"        :param should_succeed: boolean should ping succeed or not"},{"line_number":788,"context_line":"        :returns: boolean -- should_succeed \u003d\u003d ping"},{"line_number":789,"context_line":"        :returns: ping is false if ping failed"},{"line_number":790,"context_line":"        \"\"\""},{"line_number":791,"context_line":"        def ping_remote():"},{"line_number":792,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_a24b4529","line":789,"in_reply_to":"1ae5cdf2_2c9ac413","updated":"2014-06-22 10:44:41.000000000","message":"+1","commit_id":"14cbde9c83eace9dd99995e4169c6d267d7b8011"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7dfd888e45113bcfe8f5d686e59c7124fdaf1638","unresolved":false,"context_lines":[{"line_number":792,"context_line":"            try:"},{"line_number":793,"context_line":"                source.ping_host(dest)"},{"line_number":794,"context_line":"            except exceptions.SSHExecCommandFailed:"},{"line_number":795,"context_line":"                LOG.warn(\u0027Failed to ping host: %s via a ssh connection to: %s.\u0027"},{"line_number":796,"context_line":"                         % (dest, source.ssh_client.host))"},{"line_number":797,"context_line":"                return not should_succeed"},{"line_number":798,"context_line":"            return should_succeed"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_eca29c3d","line":795,"updated":"2014-06-15 12:59:40.000000000","message":"The wording here is a little confusing, to me at least. :)\n\nLooking at how this is used, and the docstring above, maybe this would be better worded as something like this:\n\n\"Failed to ping remote IP %s via SSH connection from %s.\"\n\nThe wording as-is sounds to me like the instance is trying to ping itself.","commit_id":"14cbde9c83eace9dd99995e4169c6d267d7b8011"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"33be373d536ad0bd11d81358c825d6dbe4ff6721","unresolved":false,"context_lines":[{"line_number":792,"context_line":"            try:"},{"line_number":793,"context_line":"                source.ping_host(dest)"},{"line_number":794,"context_line":"            except exceptions.SSHExecCommandFailed:"},{"line_number":795,"context_line":"                LOG.warn(\u0027Failed to ping host: %s via a ssh connection to: %s.\u0027"},{"line_number":796,"context_line":"                         % (dest, source.ssh_client.host))"},{"line_number":797,"context_line":"                return not should_succeed"},{"line_number":798,"context_line":"            return should_succeed"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_ebe761e1","line":795,"in_reply_to":"1ae5cdf2_224bb587","updated":"2014-06-25 21:56:31.000000000","message":"Honestly I think the previous message is fine, but whatever. Done.","commit_id":"14cbde9c83eace9dd99995e4169c6d267d7b8011"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cd1d3b462c52a88de83e5aae6ea6ae4311acef04","unresolved":false,"context_lines":[{"line_number":792,"context_line":"            try:"},{"line_number":793,"context_line":"                source.ping_host(dest)"},{"line_number":794,"context_line":"            except exceptions.SSHExecCommandFailed:"},{"line_number":795,"context_line":"                LOG.warn(\u0027Failed to ping host: %s via a ssh connection to: %s.\u0027"},{"line_number":796,"context_line":"                         % (dest, source.ssh_client.host))"},{"line_number":797,"context_line":"                return not should_succeed"},{"line_number":798,"context_line":"            return should_succeed"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_6c6e8c01","line":795,"in_reply_to":"1ae5cdf2_eca29c3d","updated":"2014-06-15 13:02:13.000000000","message":"I guess in the scenario tests that are using this the dest is the instance address and the source is an ssh connection to a floating IP that can talk to the instance via adjusted security group rules.  So maybe the message does make sense and I\u0027m over-thinking this.","commit_id":"14cbde9c83eace9dd99995e4169c6d267d7b8011"},{"author":{"_account_id":8576,"name":"Yair Fried","email":"yfried@redhat.com","username":"yfried"},"change_message_id":"6aed58593c4214de32f32ecf38daad8a9f842cbf","unresolved":false,"context_lines":[{"line_number":792,"context_line":"            try:"},{"line_number":793,"context_line":"                source.ping_host(dest)"},{"line_number":794,"context_line":"            except exceptions.SSHExecCommandFailed:"},{"line_number":795,"context_line":"                LOG.warn(\u0027Failed to ping host: %s via a ssh connection to: %s.\u0027"},{"line_number":796,"context_line":"                         % (dest, source.ssh_client.host))"},{"line_number":797,"context_line":"                return not should_succeed"},{"line_number":798,"context_line":"            return should_succeed"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_224bb587","line":795,"in_reply_to":"1ae5cdf2_eca29c3d","updated":"2014-06-22 10:44:41.000000000","message":"please use Matt\u0027s phrasing:\n\"Failed to ping remote IP %s via SSH connection from %s.\"","commit_id":"14cbde9c83eace9dd99995e4169c6d267d7b8011"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7dfd888e45113bcfe8f5d686e59c7124fdaf1638","unresolved":false,"context_lines":[{"line_number":793,"context_line":"                source.ping_host(dest)"},{"line_number":794,"context_line":"            except exceptions.SSHExecCommandFailed:"},{"line_number":795,"context_line":"                LOG.warn(\u0027Failed to ping host: %s via a ssh connection to: %s.\u0027"},{"line_number":796,"context_line":"                         % (dest, source.ssh_client.host))"},{"line_number":797,"context_line":"                return not should_succeed"},{"line_number":798,"context_line":"            return should_succeed"},{"line_number":799,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_8c8af8bc","line":796,"updated":"2014-06-15 12:59:40.000000000","message":"nit: I\u0027m not crazy about going so many levels deep to get source.ssh_client.host, would be nice if RemoteClient exposed that host value from the internal ssh_client so if you\u0027re using RemoteClient you don\u0027t need to know what ssh.Client exposes.\n\nJust a nit though since I had to go dig into the code to verify that\u0027s a correct call.","commit_id":"14cbde9c83eace9dd99995e4169c6d267d7b8011"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"33be373d536ad0bd11d81358c825d6dbe4ff6721","unresolved":false,"context_lines":[{"line_number":793,"context_line":"                source.ping_host(dest)"},{"line_number":794,"context_line":"            except exceptions.SSHExecCommandFailed:"},{"line_number":795,"context_line":"                LOG.warn(\u0027Failed to ping host: %s via a ssh connection to: %s.\u0027"},{"line_number":796,"context_line":"                         % (dest, source.ssh_client.host))"},{"line_number":797,"context_line":"                return not should_succeed"},{"line_number":798,"context_line":"            return should_succeed"},{"line_number":799,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_abf2b96c","line":796,"in_reply_to":"1ae5cdf2_8c8af8bc","updated":"2014-06-25 21:56:31.000000000","message":"Take a look at http://git.openstack.org/cgit/openstack/tempest/tree/tempest/common/utils/linux/remote_client.py#n27 the address being used is only accessible from there. We\u0027re not preserving the server or address in the RemoteClient object itself. I think fixing that is probably valid but definitely outside the scope here.","commit_id":"14cbde9c83eace9dd99995e4169c6d267d7b8011"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"31925ff9c0bef37917f63fd565df8fc3ec3e34dc","unresolved":false,"context_lines":[{"line_number":793,"context_line":"                source.ping_host(dest)"},{"line_number":794,"context_line":"            except exceptions.SSHExecCommandFailed:"},{"line_number":795,"context_line":"                LOG.warn(\u0027Failed to ping host: %s via a ssh connection to: %s.\u0027"},{"line_number":796,"context_line":"                         % (dest, source.ssh_client.host))"},{"line_number":797,"context_line":"                return not should_succeed"},{"line_number":798,"context_line":"            return should_succeed"},{"line_number":799,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_4951ebd7","line":796,"in_reply_to":"1ae5cdf2_abf2b96c","updated":"2014-06-27 21:26:25.000000000","message":"Yeah, definitely outside the scope of this, was just something I noted while reviewing.","commit_id":"14cbde9c83eace9dd99995e4169c6d267d7b8011"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7dfd888e45113bcfe8f5d686e59c7124fdaf1638","unresolved":false,"context_lines":[{"line_number":797,"context_line":"                return not should_succeed"},{"line_number":798,"context_line":"            return should_succeed"},{"line_number":799,"context_line":""},{"line_number":800,"context_line":"        return tempest.test.call_until_true(ping_remote,"},{"line_number":801,"context_line":"                                            CONF.compute.ping_timeout,"},{"line_number":802,"context_line":"                                            1)"},{"line_number":803,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_4c9d5009","line":800,"updated":"2014-06-15 12:59:40.000000000","message":"Unrelated, but was wondering the other day why call_until_true isn\u0027t in the waiters utility module now.","commit_id":"14cbde9c83eace9dd99995e4169c6d267d7b8011"},{"author":{"_account_id":7428,"name":"Yaroslav Lobankov","email":"lobankovyv@gmail.com","username":"ylobankov"},"change_message_id":"dba4a0224b2a353e857fc3e30c93d033c3b7ca8f","unresolved":false,"context_lines":[{"line_number":943,"context_line":"            try:"},{"line_number":944,"context_line":"                source.ping_host(dest)"},{"line_number":945,"context_line":"            except exceptions.SSHExecCommandFailed:"},{"line_number":946,"context_line":"                LOG.warn(\u0027Failed to ping IP: %s via a ssh connection from: %s.\u0027"},{"line_number":947,"context_line":"                         % (dest, source.ssh_client.host))"},{"line_number":948,"context_line":"                return not should_succeed"},{"line_number":949,"context_line":"            return should_succeed"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_1c605500","line":946,"updated":"2014-07-03 12:35:34.000000000","message":"I am OK with it, but I think the word \"address\" should be added. \n\n    Failed to ping IP address: ...","commit_id":"c4131d818ab82eff218675718e62bd8badd53cca"}]}