)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"61716aed1c8abb6782b107da449ac0cb36ccf794","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2025-09-18 19:21:40 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add test for resize revert with encrypted Cinder volume"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I6a7eb21fcf43c976970be90d66d3cce95ff23e8c"},{"line_number":10,"context_line":"Signed-off-by: melanie witt \u003cmelwittt@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"d773c82a_84334725","line":8,"updated":"2025-10-03 05:33:49.000000000","message":"I created this test to prove something to myself while working on vTPM live migration in Nova. I\u0027m not sure if others might find this test useful in general -- if so, then the test is here to review.","commit_id":"1e26f818a449fcaf946c9c14f8206cf458ac023d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"adf81b9e4ee16adcd34bd9e16b498b3c072ff28c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"eaed74aa_7e67a36e","updated":"2025-10-27 12:40:21.000000000","message":"recheck","commit_id":"1e26f818a449fcaf946c9c14f8206cf458ac023d"},{"author":{"_account_id":32704,"name":"Alfredo Garcia","email":"alfrgarc@redhat.com","username":"alfrgarc"},"change_message_id":"430b9a19dff3f7d324b58394c44056f4274aa189","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"4ae3d07d_ba780763","updated":"2026-02-05 14:21:27.000000000","message":"Ack, understood. From what I see, the comments seem to be addressed. The code itself is clean, direct, tested and well-commented. LGTM.","commit_id":"1a663700fb21303b8e641e438a956828f3875961"},{"author":{"_account_id":32704,"name":"Alfredo Garcia","email":"alfrgarc@redhat.com","username":"alfrgarc"},"change_message_id":"dc48460b2dee0c3d0e98aaf2c1a04a7c14c2d59a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"11aa89b7_9fe321e9","updated":"2026-02-04 15:35:40.000000000","message":"The test itself looks good, but comments need to be resolved.\nHave you been able to test this patch?","commit_id":"1a663700fb21303b8e641e438a956828f3875961"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"10379dc7764fa90fe23c688c70c86156ac5bd5a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3ea37f7c_56052375","in_reply_to":"11aa89b7_9fe321e9","updated":"2026-02-04 18:51:39.000000000","message":"Yes that\u0027s true. It took me a few months to get back to this patch and update it, so I expected the reviewer might not be able to look at this for a while and/or load context. I didn\u0027t want to resolve their comments without their acknowledgement.\n\nThe encrypted volumes tests are not included in every Tempest job but you can see a passing test run for this in the `tempest-slow-py3` job [1] if you are interested:\n\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_daa/openstack/daaabc9bcc664b75badb7390f9b96167/testr_results.html\n\n[1] https://zuul.opendev.org/t/openstack/build/daaabc9bcc664b75badb7390f9b96167/artifacts","commit_id":"1a663700fb21303b8e641e438a956828f3875961"}],"tempest/scenario/test_encrypted_cinder_volumes.py":[{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"0ec528d5e8bda3097543f20bf57205f99c435ed7","unresolved":true,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    @decorators.idempotent_id(\u0027d2108f87-a8d7-4cc6-9b05-40258a28c8b4\u0027)"},{"line_number":109,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":110,"context_line":"    @utils.services(\u0027compute\u0027, \u0027volume\u0027, \u0027image\u0027)"},{"line_number":111,"context_line":"    def test_encrypted_cinder_volumes_resize_revert(self):"},{"line_number":112,"context_line":"        volume \u003d self.create_encrypted_volume(\u0027luks\u0027,"},{"line_number":113,"context_line":"                                              volume_type\u003d\u0027luks\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"323a8fbb_185c7782","line":110,"range":{"start_line":110,"start_character":3,"end_line":110,"end_character":19},"updated":"2025-10-27 12:40:08.000000000","message":"Is image service used in test?","commit_id":"1e26f818a449fcaf946c9c14f8206cf458ac023d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"b6345c90204f7cb16e65e1df33fd35ed69d620a9","unresolved":true,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    @decorators.idempotent_id(\u0027d2108f87-a8d7-4cc6-9b05-40258a28c8b4\u0027)"},{"line_number":109,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":110,"context_line":"    @utils.services(\u0027compute\u0027, \u0027volume\u0027, \u0027image\u0027)"},{"line_number":111,"context_line":"    def test_encrypted_cinder_volumes_resize_revert(self):"},{"line_number":112,"context_line":"        volume \u003d self.create_encrypted_volume(\u0027luks\u0027,"},{"line_number":113,"context_line":"                                              volume_type\u003d\u0027luks\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"81e8b3c6_f45723fe","line":110,"range":{"start_line":110,"start_character":3,"end_line":110,"end_character":19},"in_reply_to":"323a8fbb_185c7782","updated":"2026-01-27 03:18:50.000000000","message":"Yes because this test will create a server from an image.","commit_id":"1e26f818a449fcaf946c9c14f8206cf458ac023d"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"0ec528d5e8bda3097543f20bf57205f99c435ed7","unresolved":true,"context_lines":[{"line_number":108,"context_line":"    @decorators.idempotent_id(\u0027d2108f87-a8d7-4cc6-9b05-40258a28c8b4\u0027)"},{"line_number":109,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":110,"context_line":"    @utils.services(\u0027compute\u0027, \u0027volume\u0027, \u0027image\u0027)"},{"line_number":111,"context_line":"    def test_encrypted_cinder_volumes_resize_revert(self):"},{"line_number":112,"context_line":"        volume \u003d self.create_encrypted_volume(\u0027luks\u0027,"},{"line_number":113,"context_line":"                                              volume_type\u003d\u0027luks\u0027,"},{"line_number":114,"context_line":"                                              wait_until\u003dNone)"}],"source_content_type":"text/x-python","patch_set":6,"id":"b66456f1_10da79a0","line":111,"updated":"2025-10-27 12:40:08.000000000","message":"Missing Doc string with test case steps","commit_id":"1e26f818a449fcaf946c9c14f8206cf458ac023d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"02de6af5f158038192d6585383f1688f3f53e804","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    @decorators.idempotent_id(\u0027d2108f87-a8d7-4cc6-9b05-40258a28c8b4\u0027)"},{"line_number":109,"context_line":"    @decorators.attr(type\u003d\u0027slow\u0027)"},{"line_number":110,"context_line":"    @utils.services(\u0027compute\u0027, \u0027volume\u0027, \u0027image\u0027)"},{"line_number":111,"context_line":"    def test_encrypted_cinder_volumes_resize_revert(self):"},{"line_number":112,"context_line":"        volume \u003d self.create_encrypted_volume(\u0027luks\u0027,"},{"line_number":113,"context_line":"                                              volume_type\u003d\u0027luks\u0027,"},{"line_number":114,"context_line":"                                              wait_until\u003dNone)"}],"source_content_type":"text/x-python","patch_set":6,"id":"a27f281d_f6b95f69","line":111,"in_reply_to":"b66456f1_10da79a0","updated":"2026-01-27 03:38:45.000000000","message":"Done","commit_id":"1e26f818a449fcaf946c9c14f8206cf458ac023d"},{"author":{"_account_id":34510,"name":"Maxim Sava","email":"msava@redhat.com","username":"msava@redhat.com"},"change_message_id":"0ec528d5e8bda3097543f20bf57205f99c435ed7","unresolved":true,"context_lines":[{"line_number":142,"context_line":"        waiters.wait_for_server_status(self.servers_client,"},{"line_number":143,"context_line":"                                       server[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        self.nova_volume_detach(server, attached_volume)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5c5ebd20_dff3fb6a","line":145,"range":{"start_line":145,"start_character":8,"end_line":145,"end_character":56},"updated":"2025-10-27 12:40:08.000000000","message":"Missing resource cleanup","commit_id":"1e26f818a449fcaf946c9c14f8206cf458ac023d"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"b6345c90204f7cb16e65e1df33fd35ed69d620a9","unresolved":true,"context_lines":[{"line_number":142,"context_line":"        waiters.wait_for_server_status(self.servers_client,"},{"line_number":143,"context_line":"                                       server[\u0027id\u0027], \u0027ACTIVE\u0027)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        self.nova_volume_detach(server, attached_volume)"}],"source_content_type":"text/x-python","patch_set":6,"id":"06762755_eacfcb48","line":145,"range":{"start_line":145,"start_character":8,"end_line":145,"end_character":56},"in_reply_to":"5c5ebd20_dff3fb6a","updated":"2026-01-27 03:18:50.000000000","message":"IIUC the cleanup for the volume is built into the self.create_volume() method which is called by self.create_encrypted_volume():\nhttps://github.com/openstack/tempest/blob/4a271b131d777346bd1248e1ab8c07dc878279c7/tempest/scenario/manager.py#L397-L400\nCleanup of volume type appears to be similarly built into self.create_volume_type(). And similar for server in self.create_server().","commit_id":"1e26f818a449fcaf946c9c14f8206cf458ac023d"}]}