)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a6d29881e9199984a5a47e973c021926ff73dafb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ba79a6db_e0bf782f","updated":"2025-12-17 15:22:44.000000000","message":"If we can get some reviews on this, it would be appreciated. It is required for an outstanding ironic-tempest-plugin change and nova change.\n\nhttps://review.opendev.org/c/openstack/ironic-tempest-plugin/+/963643\nhttps://review.opendev.org/c/openstack/nova/+/942528","commit_id":"305175fbfd3cebf8f63babb95d9da54e45e548e7"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"7b901c407473018a6fa236d687cd65c53a24fd70","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0d5c134f_3bfd26fe","updated":"2025-10-09 00:26:08.000000000","message":"This new mixin class likely belongs in tempest.common or tempest.lib but I would need some guidance on where specifically.","commit_id":"305175fbfd3cebf8f63babb95d9da54e45e548e7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c09963a78550321255b831e2057f62ce00d55db8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"93299bde_a3bfa45b","updated":"2025-12-17 18:43:22.000000000","message":"overall idea lgtm but we need to define this reusable class in tempest/common/compute.py\n\nI opened this change but did not know we need this before Nova change and was waiting for Nova change to merge before.","commit_id":"305175fbfd3cebf8f63babb95d9da54e45e548e7"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"31fe970660c4f6480aff746b767bd40f67218eab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f33cbd6e_e16ea0cd","updated":"2025-10-14 19:40:48.000000000","message":"recheck tempest-slow-py3","commit_id":"305175fbfd3cebf8f63babb95d9da54e45e548e7"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"54149c54329456a9229b9ee75a527b6f6a66a8a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8a13fda4_241f092d","updated":"2025-10-09 02:03:20.000000000","message":"recheck tempest-slow-py3 Server did not migrate","commit_id":"305175fbfd3cebf8f63babb95d9da54e45e548e7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8148a5c6ca7c4f00f154debf1869274a8bbc6b66","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1a5de8f4_bb1bd823","updated":"2025-10-09 14:36:16.000000000","message":"this looks reasonable to me\n\nfor wider context i asked for some form of tempest or other end to end validation of the ironic vnc support in https://review.opendev.org/c/openstack/nova/+/942528\n\nso that we can test this end to end in the ci even if in ci it will be talking to a vms vnc interface and not a real servers vnc interface.","commit_id":"305175fbfd3cebf8f63babb95d9da54e45e548e7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5cfda3bfb5848b9e225a9f2748a092cf025f93d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5ed81a7e_1c52910c","updated":"2026-01-05 01:17:13.000000000","message":"lgtm  test is passing - https://zuul.opendev.org/t/openstack/build/be07bdf968a849f8b7df16b1c8f100aa/log/job-output.txt#23860","commit_id":"81f7dfc0257f966a3e7df88fb0e473954cf24b9a"}],"tempest/api/compute/servers/test_novnc.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c09963a78550321255b831e2057f62ce00d55db8","unresolved":true,"context_lines":[{"line_number":27,"context_line":"CONF \u003d config.CONF"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class NoVNCValidateMixin(testtools.TestCase):"},{"line_number":31,"context_line":"    \"\"\"Mixin methods to validate a novnc connection.\"\"\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def validate_novnc_html(self, vnc_url):"}],"source_content_type":"text/x-python","patch_set":2,"id":"47f8a014_a49dd678","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":45},"updated":"2025-12-17 18:43:22.000000000","message":"we should not keep the plugin reusable things in the tests file which are meant to be change and it can easily break the plugins tests. That is why tempest define the stable interface for plugin to use is guaranteed not to change unless we take care of its usage. \n\nTo avoid breaking the ironic tests, we should move this NoVNCValidateMixin class in tempest/common/compute.py and use from there. We do the same for _WebSocket class also.","commit_id":"305175fbfd3cebf8f63babb95d9da54e45e548e7"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"13bc46ccdcafb499c345ddc422c1fb58586e3b00","unresolved":false,"context_lines":[{"line_number":27,"context_line":"CONF \u003d config.CONF"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class NoVNCValidateMixin(testtools.TestCase):"},{"line_number":31,"context_line":"    \"\"\"Mixin methods to validate a novnc connection.\"\"\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def validate_novnc_html(self, vnc_url):"}],"source_content_type":"text/x-python","patch_set":2,"id":"80e1ef34_9c2f104e","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":45},"in_reply_to":"47f8a014_a49dd678","updated":"2026-01-04 22:28:11.000000000","message":"Done","commit_id":"305175fbfd3cebf8f63babb95d9da54e45e548e7"}]}