)]}'
{"tempest/common/isolated_creds.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0c353997a692eacac8d9d92e1c5185b7f7224247","unresolved":false,"context_lines":[{"line_number":162,"context_line":"                                 tenant, email)"},{"line_number":163,"context_line":"        # NOTE(andrey-mp): user needs this role to create containers in swift"},{"line_number":164,"context_line":"        swift_operator_role \u003d CONF.object_storage.operator_role"},{"line_number":165,"context_line":"        self._assign_user_role(tenant, user, swift_operator_role)"},{"line_number":166,"context_line":"        if admin:"},{"line_number":167,"context_line":"            self._assign_user_role(tenant, user, CONF.identity.admin_role)"},{"line_number":168,"context_line":"        return self._get_credentials(user, tenant)"}],"source_content_type":"text/x-python","patch_set":16,"id":"baada198_9d02950a","line":165,"updated":"2014-07-18 15:50:05.000000000","message":"Shouldn\u0027t we only do this if we\u0027re running swift tests?  The code before this change wouldn\u0027t actually get to this point if CONF.service_available.swift was False.","commit_id":"af1fb707fa689df84ef24bef012420cdd47e34c4"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e67336880030ce10d13b8ea85fa1e326aa05142f","unresolved":false,"context_lines":[{"line_number":162,"context_line":"                                 tenant, email)"},{"line_number":163,"context_line":"        # NOTE(andrey-mp): user needs this role to create containers in swift"},{"line_number":164,"context_line":"        swift_operator_role \u003d CONF.object_storage.operator_role"},{"line_number":165,"context_line":"        self._assign_user_role(tenant, user, swift_operator_role)"},{"line_number":166,"context_line":"        if admin:"},{"line_number":167,"context_line":"            self._assign_user_role(tenant, user, CONF.identity.admin_role)"},{"line_number":168,"context_line":"        return self._get_credentials(user, tenant)"}],"source_content_type":"text/x-python","patch_set":16,"id":"baada198_2e04dc13","line":165,"in_reply_to":"baada198_0ee56da3","updated":"2014-07-19 15:08:06.000000000","message":"Ah right, good point - thanks!","commit_id":"af1fb707fa689df84ef24bef012420cdd47e34c4"},{"author":{"_account_id":10234,"name":"Andrey Pavlov","email":"andrey.mp@gmail.com","username":"andrey-mp"},"change_message_id":"1fa40cd7d73d9b8fb5d4431800675acc3e289a75","unresolved":false,"context_lines":[{"line_number":162,"context_line":"                                 tenant, email)"},{"line_number":163,"context_line":"        # NOTE(andrey-mp): user needs this role to create containers in swift"},{"line_number":164,"context_line":"        swift_operator_role \u003d CONF.object_storage.operator_role"},{"line_number":165,"context_line":"        self._assign_user_role(tenant, user, swift_operator_role)"},{"line_number":166,"context_line":"        if admin:"},{"line_number":167,"context_line":"            self._assign_user_role(tenant, user, CONF.identity.admin_role)"},{"line_number":168,"context_line":"        return self._get_credentials(user, tenant)"}],"source_content_type":"text/x-python","patch_set":16,"id":"baada198_0ee56da3","line":165,"in_reply_to":"baada198_9d02950a","updated":"2014-07-18 17:03:00.000000000","message":"We have deployment when glance is configured to store images in swift. And we want to run tempest against this deployment. And if this would be only for swift tests then glance tests will fail in such deployment.","commit_id":"af1fb707fa689df84ef24bef012420cdd47e34c4"}],"tempest/tests/test_tenant_isolation.py":[{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"2d4758a2bfb49c97d08f548a278d7851a7d195c4","unresolved":false,"context_lines":[{"line_number":372,"context_line":"        iso_creds \u003d isolated_creds.IsolatedCreds(\u0027test class\u0027,"},{"line_number":373,"context_line":"                                                 password\u003d\u0027fake_password\u0027)"},{"line_number":374,"context_line":"        self._mock_assign_user_role()"},{"line_number":375,"context_line":"        self._mock_list_role()"},{"line_number":376,"context_line":"        self._mock_user_create(\u00271234\u0027, \u0027fake_alt_user\u0027)"},{"line_number":377,"context_line":"        self._mock_tenant_create(\u00271234\u0027, \u0027fake_alt_tenant\u0027)"},{"line_number":378,"context_line":"        self._mock_network_create(iso_creds, \u00271234\u0027, \u0027fake_alt_net\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_84599500","line":375,"updated":"2014-06-02 14:01:32.000000000","message":"is this really necessary here? \nmock_assign_user_role seems right, cause you create a user, a role is assigned to it.\nbut why mock_list_role? I don\u0027t see any listing of roles here (and in some other tests), so why add it? Can you explain please? (The same comment is valid for several other tests with the same reason)","commit_id":"e74b456d1dca157bec8674489428985b4439a9dc"},{"author":{"_account_id":10234,"name":"Andrey Pavlov","email":"andrey.mp@gmail.com","username":"andrey-mp"},"change_message_id":"45d2a70b268e220471dd7eaf021aea3eb0a4dccb","unresolved":false,"context_lines":[{"line_number":372,"context_line":"        iso_creds \u003d isolated_creds.IsolatedCreds(\u0027test class\u0027,"},{"line_number":373,"context_line":"                                                 password\u003d\u0027fake_password\u0027)"},{"line_number":374,"context_line":"        self._mock_assign_user_role()"},{"line_number":375,"context_line":"        self._mock_list_role()"},{"line_number":376,"context_line":"        self._mock_user_create(\u00271234\u0027, \u0027fake_alt_user\u0027)"},{"line_number":377,"context_line":"        self._mock_tenant_create(\u00271234\u0027, \u0027fake_alt_tenant\u0027)"},{"line_number":378,"context_line":"        self._mock_network_create(iso_creds, \u00271234\u0027, \u0027fake_alt_net\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_a75cd3ee","line":375,"in_reply_to":"1ae5cdf2_84599500","updated":"2014-06-02 14:16:48.000000000","message":"It needs because of logic in isolated_creds.py. Those code tries to list all roles and gets a role id from role name. list_roles mocked previously in tests that need to create admin creds because of same reason - isolated_creds searchs role_id by role name \u0027admin\u0027.","commit_id":"e74b456d1dca157bec8674489428985b4439a9dc"}]}