)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2d1e8a06a756cd02e4842afda2e631acb2107e46","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"43caf07f_fa91587a","updated":"2026-01-07 03:37:33.000000000","message":"we need to handle keystone tests little different way.","commit_id":"44a4317e6ed82905249312df6684a56910935c9f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"83957b65d7c1e888205c94e829ee6f615818cceb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"82fe02d5_533da3e5","updated":"2026-01-17 02:20:43.000000000","message":"lgtm, thanks","commit_id":"8732781c645b3dc5c14d91fa708f840613560bc5"},{"author":{"_account_id":37924,"name":"Abhishek Bongale","display_name":"abongale","email":"abhishekbongale@outlook.com","username":"abhibongale"},"change_message_id":"8fc92e2358f6064ae14b81c1a91acd028bed3657","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"b30326a6_dd7b2ee6","updated":"2026-01-18 19:12:25.000000000","message":"recheck POST_FAILURE","commit_id":"8732781c645b3dc5c14d91fa708f840613560bc5"}],"tempest/api/identity/admin/v3/test_domains.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2d1e8a06a756cd02e4842afda2e631acb2107e46","unresolved":true,"context_lines":[{"line_number":26,"context_line":"class DomainsTestJSON(base.BaseIdentityV3AdminTest):"},{"line_number":27,"context_line":"    \"\"\"Test identity domains\"\"\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027, \u0027system_admin\u0027, \u0027system_reader\u0027]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @classmethod"},{"line_number":32,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7df12244_ffb0a147","line":29,"range":{"start_line":29,"start_character":39,"end_line":29,"end_character":54},"updated":"2026-01-07 03:37:33.000000000","message":"we do not use this so let\u0027s not create this token","commit_id":"44a4317e6ed82905249312df6684a56910935c9f"},{"author":{"_account_id":37924,"name":"Abhishek Bongale","display_name":"abongale","email":"abhishekbongale@outlook.com","username":"abhibongale"},"change_message_id":"253bdb2b44f9be67686206252ea862c19f4a23a4","unresolved":false,"context_lines":[{"line_number":26,"context_line":"class DomainsTestJSON(base.BaseIdentityV3AdminTest):"},{"line_number":27,"context_line":"    \"\"\"Test identity domains\"\"\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027, \u0027system_admin\u0027, \u0027system_reader\u0027]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @classmethod"},{"line_number":32,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":4,"id":"86ff43ca_0cf5a287","line":29,"range":{"start_line":29,"start_character":39,"end_line":29,"end_character":54},"in_reply_to":"1a14997b_d0a1bdb3","updated":"2026-01-15 18:30:02.000000000","message":"Done","commit_id":"44a4317e6ed82905249312df6684a56910935c9f"},{"author":{"_account_id":37924,"name":"Abhishek Bongale","display_name":"abongale","email":"abhishekbongale@outlook.com","username":"abhibongale"},"change_message_id":"c0557e20940525cc373ef8fb1d040440508e7dd8","unresolved":true,"context_lines":[{"line_number":26,"context_line":"class DomainsTestJSON(base.BaseIdentityV3AdminTest):"},{"line_number":27,"context_line":"    \"\"\"Test identity domains\"\"\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027, \u0027system_admin\u0027, \u0027system_reader\u0027]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    @classmethod"},{"line_number":32,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a14997b_d0a1bdb3","line":29,"range":{"start_line":29,"start_character":39,"end_line":29,"end_character":54},"in_reply_to":"7df12244_ffb0a147","updated":"2026-01-07 11:38:16.000000000","message":"I was skeptical about adding system_admin, but adding this variable passed my test.","commit_id":"44a4317e6ed82905249312df6684a56910935c9f"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2d1e8a06a756cd02e4842afda2e631acb2107e46","unresolved":true,"context_lines":[{"line_number":31,"context_line":"    @classmethod"},{"line_number":32,"context_line":"    def setup_clients(cls):"},{"line_number":33,"context_line":"        super(DomainsTestJSON, cls).setup_clients()"},{"line_number":34,"context_line":"        if CONF.enforce_scope.keystone:"},{"line_number":35,"context_line":"            # Use system reader for listing/showing domains"},{"line_number":36,"context_line":"            cls.reader_domains_client \u003d ("},{"line_number":37,"context_line":"                cls.os_system_reader.domains_client)"},{"line_number":38,"context_line":"        else:"},{"line_number":39,"context_line":"            # Use admin client if enforce_scope is not enabled"},{"line_number":40,"context_line":"            cls.reader_domains_client \u003d cls.domains_client"}],"source_content_type":"text/x-python","patch_set":4,"id":"903a5fd8_8029513c","line":37,"range":{"start_line":34,"start_character":0,"end_line":37,"end_character":52},"updated":"2026-01-07 03:37:33.000000000","message":"keystone is little different here. Only ironic and keystone are the two project who support system token (keystone does because if ironic use case). But keystone continue support the project scoped token also for all other services (I will say by default use case).\n\nSo if enforce_scope if enabled keystone still support the project token (which is admin here) means both system reader as well as admin can list the domain.\n\nInstead of checking enforce_scope, I think we should add a new config option in keystone (something like \u0027use_system_token\u0027) and if that is enabled then use the system user to talk to keystone otherwise admin by default.\n\nI am adding that new config option in https://review.opendev.org/c/openstack/tempest/+/972422, you can rebase this change on top of that and use that new config option in keystone tests\n\n        if CONF.identity.use_system_token:\n            # Use system reader for listing/showing domains\n            cls.reader_domains_client \u003d (\n                cls.os_system_reader.domains_client)\n        else:\n            # Use admin client if use_system_token is not enabled\n            cls.reader_domains_client \u003d cls.domains_client","commit_id":"44a4317e6ed82905249312df6684a56910935c9f"},{"author":{"_account_id":37924,"name":"Abhishek Bongale","display_name":"abongale","email":"abhishekbongale@outlook.com","username":"abhibongale"},"change_message_id":"c0557e20940525cc373ef8fb1d040440508e7dd8","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    @classmethod"},{"line_number":32,"context_line":"    def setup_clients(cls):"},{"line_number":33,"context_line":"        super(DomainsTestJSON, cls).setup_clients()"},{"line_number":34,"context_line":"        if CONF.enforce_scope.keystone:"},{"line_number":35,"context_line":"            # Use system reader for listing/showing domains"},{"line_number":36,"context_line":"            cls.reader_domains_client \u003d ("},{"line_number":37,"context_line":"                cls.os_system_reader.domains_client)"},{"line_number":38,"context_line":"        else:"},{"line_number":39,"context_line":"            # Use admin client if enforce_scope is not enabled"},{"line_number":40,"context_line":"            cls.reader_domains_client \u003d cls.domains_client"}],"source_content_type":"text/x-python","patch_set":4,"id":"d07158a8_46673ce8","line":37,"range":{"start_line":34,"start_character":0,"end_line":37,"end_character":52},"in_reply_to":"903a5fd8_8029513c","updated":"2026-01-07 11:38:16.000000000","message":"Acknowledged","commit_id":"44a4317e6ed82905249312df6684a56910935c9f"}],"tempest/api/identity/admin/v3/test_endpoints.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2d1e8a06a756cd02e4842afda2e631acb2107e46","unresolved":true,"context_lines":[{"line_number":30,"context_line":"    # pre-provisioned credentials provider."},{"line_number":31,"context_line":"    force_tenant_isolation \u003d False"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027, \u0027system_admin\u0027, \u0027system_reader\u0027]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @classmethod"},{"line_number":36,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a2665a2_25eeaad0","line":33,"range":{"start_line":33,"start_character":39,"end_line":33,"end_character":53},"updated":"2026-01-07 03:37:33.000000000","message":"ditto and same for other file","commit_id":"44a4317e6ed82905249312df6684a56910935c9f"},{"author":{"_account_id":37924,"name":"Abhishek Bongale","display_name":"abongale","email":"abhishekbongale@outlook.com","username":"abhibongale"},"change_message_id":"253bdb2b44f9be67686206252ea862c19f4a23a4","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    # pre-provisioned credentials provider."},{"line_number":31,"context_line":"    force_tenant_isolation \u003d False"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027, \u0027system_admin\u0027, \u0027system_reader\u0027]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    @classmethod"},{"line_number":36,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":4,"id":"c9b3890c_28ee709a","line":33,"range":{"start_line":33,"start_character":39,"end_line":33,"end_character":53},"in_reply_to":"9a2665a2_25eeaad0","updated":"2026-01-15 18:30:02.000000000","message":"Done","commit_id":"44a4317e6ed82905249312df6684a56910935c9f"}]}