)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8a0ab5a5e52b168383eeab203b907cd5f279c0b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1891b71a_409db200","updated":"2026-02-24 03:48:57.000000000","message":"test failing it valid, you need to update the hacking rule also and then failing test also to replace skip -\u003e skipTest\n\nhttps://github.com/openstack/tempest/blob/c0eccdfecb2bacc26159f892ae6e5207b65b12bf/tempest/hacking/checks.py#L137\n\nI see that hacking rule is still valid and we should update that to track if any test using skipTest as test decorator skip","commit_id":"dd0ca1c6e2177b83832bb53b6f96c940b6a97f84"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"570885ba0011499cfb3cf84ebd1b1e24708ae3ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"53116b92_f92ecfdb","in_reply_to":"1891b71a_409db200","updated":"2026-02-24 10:09:26.000000000","message":"whoops, yeah. That\u0027s what I get for a lazy find-replace 😅 Done now.","commit_id":"dd0ca1c6e2177b83832bb53b6f96c940b6a97f84"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"48255fa965372ea927d63eff01c39df0252e89e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f817a239_e8bd1c8e","in_reply_to":"53116b92_f92ecfdb","updated":"2026-02-24 16:17:49.000000000","message":"sorry for not being clear on the comment. i meant to change this hacking rule also and the tst case. This hacking rule should check skipTest now\n\n- https://github.com/openstack/tempest/blob/c0eccdfecb2bacc26159f892ae6e5207b65b12bf/tempest/hacking/checks.py#L137","commit_id":"dd0ca1c6e2177b83832bb53b6f96c940b6a97f84"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2bb0c51d4c802561aecc26d1daf1422557a134de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d0babd29_4008241a","in_reply_to":"ddde5bea_bc74a835","updated":"2026-02-24 19:29:35.000000000","message":"Actually not needed. `testtools.skip` (the decorator) is still valid/correct. It\u0027s just `testtools.TestCase.skip` (the method) that has been removed.\n\nhttps://github.com/testing-cabal/testtools/blob/2.8.4/testtools/testcase.py#L1159-L1184","commit_id":"dd0ca1c6e2177b83832bb53b6f96c940b6a97f84"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3d8ff5911e5254971b4ee7607e6edc71273e289c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ddde5bea_bc74a835","in_reply_to":"f817a239_e8bd1c8e","updated":"2026-02-24 19:26:11.000000000","message":"done in https://review.opendev.org/c/openstack/tempest/+/977854/1","commit_id":"dd0ca1c6e2177b83832bb53b6f96c940b6a97f84"},{"author":{"_account_id":32704,"name":"Alfredo Garcia","display_name":"Alfredo Garcia","email":"alfrgarc@redhat.com","username":"alfrgarc","status":"Senior Software Quality Engineer @ Red Hat"},"change_message_id":"9338533faf004cb8a8d493f0e128370e6701168e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"161e4e02_1b7e2a40","updated":"2026-02-24 13:25:33.000000000","message":"LGTM","commit_id":"638511282e71aead97a8ee1d5342030103b23c8e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f3eebee653f031a3cd1a14c36b3a6cb396634c52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bfc435c2_f6d9fe4e","updated":"2026-02-25 00:23:06.000000000","message":"recheck timeout","commit_id":"638511282e71aead97a8ee1d5342030103b23c8e"}]}
