)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32704,"name":"Alfredo Garcia","email":"alfrgarc@redhat.com","username":"alfrgarc"},"change_message_id":"17c32691363e0ee24b2de8f8fbdc04e3a77cf8b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e5f5d725_a832c36e","updated":"2026-03-06 14:35:07.000000000","message":"Ack, thank you for clarifying. The change is well structured and commented. LGTM","commit_id":"b2236864483b1b8a445e93ee900c9c9a33ac9220"},{"author":{"_account_id":38173,"name":"Tanvi Nautiyal","email":"tnautiya@redhat.com","username":"tnautiyal"},"change_message_id":"d5a1fca07255fb628a9d34a84a3cecd38fb55ed8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fc49da6d_75a880a9","updated":"2026-02-26 14:55:09.000000000","message":"Cleanup is already handled by delete_containers() in resource_cleanup(). It removes all objects created in the container (including those from this test) and then deletes the container.","commit_id":"b2236864483b1b8a445e93ee900c9c9a33ac9220"},{"author":{"_account_id":38173,"name":"Tanvi Nautiyal","email":"tnautiya@redhat.com","username":"tnautiyal"},"change_message_id":"bc9622fc0275e4002599a2284fa2823941906147","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1ab44bdb_e80207b9","updated":"2026-02-26 09:07:46.000000000","message":"recheck\nLikely infra credential exhaustion (InvalidCredentials in Tempest setup).","commit_id":"b2236864483b1b8a445e93ee900c9c9a33ac9220"},{"author":{"_account_id":38173,"name":"Tanvi Nautiyal","email":"tnautiya@redhat.com","username":"tnautiyal"},"change_message_id":"91cd5a2ea1db6ef470f81b97063862e1514f60f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"54671b72_cff5b405","updated":"2026-04-02 09:17:35.000000000","message":"Hi reviewers, this change is ready. All feedback has been addressed and tests are passing.\nPlease take a look and share your feedback. @alfrgarc@redhat.com, @ashigupt@redhat.com, @gmaan.os14@gmail.com \nThanks!","commit_id":"050fd401597300da7d7a708c47d529d317a047d4"},{"author":{"_account_id":34373,"name":"Jason Paroly","email":"jparoly@redhat.com","username":"jparoly"},"change_message_id":"0f755e00eae4a79d3853f9f61ad61c6f1b1f58f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"203827e7_4d8da8fd","updated":"2026-04-03 13:46:57.000000000","message":"LGTM just one minor suggestion.","commit_id":"050fd401597300da7d7a708c47d529d317a047d4"},{"author":{"_account_id":32704,"name":"Alfredo Garcia","email":"alfrgarc@redhat.com","username":"alfrgarc"},"change_message_id":"86377acd2c689731681a94edff84721bf74c8065","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ad1a288a_3b0600d4","updated":"2026-04-09 15:28:26.000000000","message":"New changes are good, LGTM\nAlthough I would like to see Jason\u0027s comment addressed, it\u0027s good feedback","commit_id":"050fd401597300da7d7a708c47d529d317a047d4"},{"author":{"_account_id":38173,"name":"Tanvi Nautiyal","email":"tnautiya@redhat.com","username":"tnautiyal"},"change_message_id":"d02236bdabb07ba9a3044eb351df383597a616e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"979565d5_af43d325","updated":"2026-03-30 18:22:39.000000000","message":"recheck (failures due to Nova build issues and Neutron policy)","commit_id":"050fd401597300da7d7a708c47d529d317a047d4"},{"author":{"_account_id":32704,"name":"Alfredo Garcia","email":"alfrgarc@redhat.com","username":"alfrgarc"},"change_message_id":"73556fc97880355339b55e31a0b77141285e853b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"72653108_2a243c54","updated":"2026-04-21 12:49:45.000000000","message":"Changes still LGTM. Thanks for addressing the commented concerns","commit_id":"14fbea5fd50f3396fe82ccc458acd730aa08570b"},{"author":{"_account_id":38173,"name":"Tanvi Nautiyal","email":"tnautiya@redhat.com","username":"tnautiyal"},"change_message_id":"e4f35c529c10293bb0984cbb61cc851bac540884","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0fe43e6f_bbdd29b7","updated":"2026-04-10 19:49:38.000000000","message":"Thank you for the feedback the code has been updated @jparoly@redhat.com @alfrgarc@redhat.com","commit_id":"14fbea5fd50f3396fe82ccc458acd730aa08570b"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e3301a1f8ba4a3a0f34dbed192be9a55dd02434b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"48412470_a5014ca7","updated":"2026-05-07 19:02:29.000000000","message":"lgtm, test passing in tempest-full job https://zuul.opendev.org/t/openstack/build/ac567d7cde9d4a89adcda89be211822c/log/job-output.txt#24007","commit_id":"14fbea5fd50f3396fe82ccc458acd730aa08570b"}],"tempest/api/object_storage/test_container_staticweb.py":[{"author":{"_account_id":35153,"name":"Ashish Gupta","email":"ashigupt@redhat.com","username":"ashigupt","status":"Redhat"},"change_message_id":"92ebdfe077dc6f4186ec52b209b8d34ec3fea5c0","unresolved":true,"context_lines":[{"line_number":168,"context_line":"            self.container_name, \"notexisting\")"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    @decorators.idempotent_id(\u0027a1c600c2-dd4b-4f76-a2b4-e79d0959e059\u0027)"},{"line_number":171,"context_line":"    def test_tempurl_with_prefix(self):"},{"line_number":172,"context_line":"        \"\"\"Test TempURL access using prefix using pre-existing container\"\"\""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        # Use the container already created in resource_setup"}],"source_content_type":"text/x-python","patch_set":1,"id":"2c975835_dd9d43ed","line":171,"updated":"2026-03-19 20:59:59.000000000","message":"I believe the test needs a skip check decorator @utils.requires_ext(extension\u003d\u0027tempurl\u0027, service\u003d\u0027object\u0027) \n\nso that the test is skipped when tempurl isn\u0027t enabled ?\n\nI see every temp URL test in https://github.com/openstack/tempest/blob/master/tempest/api/object_storage/test_object_temp_url.py uses that.\n\nAlso wanted to point out maybe that\u0027s the better place for this test to live ?","commit_id":"b2236864483b1b8a445e93ee900c9c9a33ac9220"},{"author":{"_account_id":38173,"name":"Tanvi Nautiyal","email":"tnautiya@redhat.com","username":"tnautiyal"},"change_message_id":"7d6fd1433a2f03eca35e0b54ac6b6c27a75203f6","unresolved":false,"context_lines":[{"line_number":168,"context_line":"            self.container_name, \"notexisting\")"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    @decorators.idempotent_id(\u0027a1c600c2-dd4b-4f76-a2b4-e79d0959e059\u0027)"},{"line_number":171,"context_line":"    def test_tempurl_with_prefix(self):"},{"line_number":172,"context_line":"        \"\"\"Test TempURL access using prefix using pre-existing container\"\"\""},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        # Use the container already created in resource_setup"}],"source_content_type":"text/x-python","patch_set":1,"id":"37af87ad_e4eae17d","line":171,"in_reply_to":"2c975835_dd9d43ed","updated":"2026-03-24 13:13:54.000000000","message":"Done","commit_id":"b2236864483b1b8a445e93ee900c9c9a33ac9220"},{"author":{"_account_id":35153,"name":"Ashish Gupta","email":"ashigupt@redhat.com","username":"ashigupt","status":"Redhat"},"change_message_id":"92ebdfe077dc6f4186ec52b209b8d34ec3fea5c0","unresolved":true,"context_lines":[{"line_number":205,"context_line":"        sig \u003d hmac.new("},{"line_number":206,"context_line":"            tempurl_key.encode(),"},{"line_number":207,"context_line":"            hmac_body.encode(),"},{"line_number":208,"context_line":"            hashlib.sha1"},{"line_number":209,"context_line":"        ).hexdigest()"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        # Construct TempURL"}],"source_content_type":"text/x-python","patch_set":1,"id":"f45531d2_c0265504","line":208,"updated":"2026-03-19 20:59:59.000000000","message":"Maybe instead of hardcoding , we can be consistent and pick from conf as how it is done in https://github.com/openstack/tempest/blob/master/tempest/api/object_storage/test_object_temp_url.py#L85\n\n        hlib \u003d getattr(\n            hashlib,\n            CONF.object_storage_feature_enabled.tempurl_digest_hashlib)\n        sig \u003d hmac.new(\n            tempurl_key.encode(),\n            hmac_body.encode(),\n            hlib\n        ).hexdigest()\n\nor maybe use the _get_temp_url directly if that supports the usecase ?","commit_id":"b2236864483b1b8a445e93ee900c9c9a33ac9220"},{"author":{"_account_id":38173,"name":"Tanvi Nautiyal","email":"tnautiya@redhat.com","username":"tnautiyal"},"change_message_id":"7d6fd1433a2f03eca35e0b54ac6b6c27a75203f6","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        sig \u003d hmac.new("},{"line_number":206,"context_line":"            tempurl_key.encode(),"},{"line_number":207,"context_line":"            hmac_body.encode(),"},{"line_number":208,"context_line":"            hashlib.sha1"},{"line_number":209,"context_line":"        ).hexdigest()"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        # Construct TempURL"}],"source_content_type":"text/x-python","patch_set":1,"id":"38461577_a08e87af","line":208,"in_reply_to":"f45531d2_c0265504","updated":"2026-03-24 13:13:54.000000000","message":"Done","commit_id":"b2236864483b1b8a445e93ee900c9c9a33ac9220"},{"author":{"_account_id":32704,"name":"Alfredo Garcia","email":"alfrgarc@redhat.com","username":"alfrgarc"},"change_message_id":"f88ae419039a9c9310424b36af8a8431de7d1684","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8e0e96a5_d8683db9","line":235,"updated":"2026-02-26 14:42:27.000000000","message":"Should there be a cleanup step after the test is run?","commit_id":"b2236864483b1b8a445e93ee900c9c9a33ac9220"},{"author":{"_account_id":32704,"name":"Alfredo Garcia","email":"alfrgarc@redhat.com","username":"alfrgarc"},"change_message_id":"17c32691363e0ee24b2de8f8fbdc04e3a77cf8b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3954366f_e3b3f7b3","line":235,"in_reply_to":"8e0e96a5_d8683db9","updated":"2026-03-06 14:35:07.000000000","message":"Done","commit_id":"b2236864483b1b8a445e93ee900c9c9a33ac9220"}],"tempest/api/object_storage/test_object_temp_url.py":[{"author":{"_account_id":34373,"name":"Jason Paroly","email":"jparoly@redhat.com","username":"jparoly"},"change_message_id":"0f755e00eae4a79d3853f9f61ad61c6f1b1f58f0","unresolved":true,"context_lines":[{"line_number":206,"context_line":"        Ensures that an object with a prefix in its name can be accessed"},{"line_number":207,"context_line":"        via a TempURL using the prefix parameter."},{"line_number":208,"context_line":"        \"\"\""},{"line_number":209,"context_line":"        container_name \u003d self.container_name"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        # Set TempURL key for container"},{"line_number":212,"context_line":"        tempurl_key \u003d data_utils.rand_name(\"tempurlkey\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"5b4a247b_d4482050","line":209,"updated":"2026-04-03 13:46:57.000000000","message":"The container_name local variable is unnecessary. Just use                                                                                                                                                                \nself.container_name directly, which is consistent with other test methods                                                                                                                                                            \nin this file (e.g., test_get_object_using_temp_url).","commit_id":"050fd401597300da7d7a708c47d529d317a047d4"},{"author":{"_account_id":38173,"name":"Tanvi Nautiyal","email":"tnautiya@redhat.com","username":"tnautiyal"},"change_message_id":"e4f35c529c10293bb0984cbb61cc851bac540884","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        Ensures that an object with a prefix in its name can be accessed"},{"line_number":207,"context_line":"        via a TempURL using the prefix parameter."},{"line_number":208,"context_line":"        \"\"\""},{"line_number":209,"context_line":"        container_name \u003d self.container_name"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        # Set TempURL key for container"},{"line_number":212,"context_line":"        tempurl_key \u003d data_utils.rand_name(\"tempurlkey\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"c3e39ac3_ee146b9e","line":209,"in_reply_to":"5b4a247b_d4482050","updated":"2026-04-10 19:49:38.000000000","message":"Acknowledged","commit_id":"050fd401597300da7d7a708c47d529d317a047d4"}]}