)]}'
{"tempest/api/orchestration/base.py":[{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"fa1e4b4b98f95bbf3ef3d372f088011e034e02d1","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            return content"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    @classmethod"},{"line_number":139,"context_line":"    def read_template(cls, name, ext\u003d\u0027yaml\u0027):"},{"line_number":140,"context_line":"        loc \u003d [\"stacks\", \"templates\", \"%s.%s\" % (name, ext)]"},{"line_number":141,"context_line":"        fullpath \u003d os.path.join(os.path.dirname(__file__), *loc)"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_9e1030ad","line":139,"updated":"2014-06-16 20:02:15.000000000","message":"It is very non-intuitive that load_template is doing a file read returning a string, and read_template is doing a yaml/json load returning a dict. These names should be reversed.","commit_id":"4747a09f18c2be4a113d2743d691ffb9654011e2"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"edd209b80f706a9b1eff8dc96702d142596e7132","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            return content"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    @classmethod"},{"line_number":139,"context_line":"    def read_template(cls, name, ext\u003d\u0027yaml\u0027):"},{"line_number":140,"context_line":"        loc \u003d [\"stacks\", \"templates\", \"%s.%s\" % (name, ext)]"},{"line_number":141,"context_line":"        fullpath \u003d os.path.join(os.path.dirname(__file__), *loc)"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_97f64e8f","line":139,"in_reply_to":"1ae5cdf2_9e1030ad","updated":"2014-06-17 00:26:45.000000000","message":"exactly same i thought when implementing this function and thought of changing the name. But as it need changes in many file that\u0027s y i dropped the idea.\n\nBut yes, it should be changed to have logical name (even I like). I will do that.","commit_id":"4747a09f18c2be4a113d2743d691ffb9654011e2"},{"author":{"_account_id":5371,"name":"Mathew Odden","email":"locke105@gmail.com","username":"locke105"},"change_message_id":"bb67bd9a2f31e76d2ed8b8fb10d071f36f365d28","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            if ext is \u0027yaml\u0027:"},{"line_number":145,"context_line":"                content \u003d yaml.load(f)"},{"line_number":146,"context_line":"            elif ext is \u0027json\u0027:"},{"line_number":147,"context_line":"                content \u003d json.load(f)"},{"line_number":148,"context_line":"            else:"},{"line_number":149,"context_line":"                msg \u003d (\"Unexpected extension is specified (%s)\" % ext)"},{"line_number":150,"context_line":"                raise exceptions.InvalidConfiguration(message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_6a2bae94","line":147,"updated":"2014-07-08 22:52:15.000000000","message":"you can load JSON with the YAML library, so this is actually not needed. JSON is a subset of YAML.\n\nalso, consider using yaml.safe_load(), since yaml.load can be abused to inject arbitrary code at runtime","commit_id":"4b537536195f135d16e28f0da9d059a301896f66"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0168ec33d567cbbc54904719a83561a325de0097","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            if ext is \u0027yaml\u0027:"},{"line_number":145,"context_line":"                content \u003d yaml.load(f)"},{"line_number":146,"context_line":"            elif ext is \u0027json\u0027:"},{"line_number":147,"context_line":"                content \u003d json.load(f)"},{"line_number":148,"context_line":"            else:"},{"line_number":149,"context_line":"                msg \u003d (\"Unexpected extension is specified (%s)\" % ext)"},{"line_number":150,"context_line":"                raise exceptions.InvalidConfiguration(message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_0a8924ca","line":147,"in_reply_to":"baada198_6a2bae94","updated":"2014-07-10 01:17:33.000000000","message":"Yes. Thanks.\nDone","commit_id":"4b537536195f135d16e28f0da9d059a301896f66"}]}