)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"5def5995bd6382148bee66a9cc5903e1d9581cac","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Pooja Tiwari \u003cpooja_tiwari@persistent.co.in\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-06-09 17:06:15 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Added unit test for bug#1325436"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added test_create_update_get_verify_description_delete_alarm unit test case in test_telemetry_alarming_api.py script."},{"line_number":10,"context_line":"It creates an alarm with some specified threshold using default description then update threshold and then verify that default description  get updated accordingly."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ae5cdf2_7aafe22b","line":7,"updated":"2014-06-09 16:20:02.000000000","message":"it\u0027s a integration test, unit tests are within the project and a meaningful title would be good too (no need to reference the bug here, I would prefer to hear about the situation)","commit_id":"f2d4890190159bc69634ea353569eb737c4954df"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"5def5995bd6382148bee66a9cc5903e1d9581cac","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Added unit test for bug#1325436"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added test_create_update_get_verify_description_delete_alarm unit test case in test_telemetry_alarming_api.py script."},{"line_number":10,"context_line":"It creates an alarm with some specified threshold using default description then update threshold and then verify that default description  get updated accordingly."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ie0f9ec3bedbca0d39ebe3d6964b2c0a57014188c"},{"line_number":13,"context_line":"Closes-Bug: #1325436"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1ae5cdf2_3a6d5a05","line":10,"updated":"2014-06-09 16:20:02.000000000","message":"can you format this message according to https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"f2d4890190159bc69634ea353569eb737c4954df"},{"author":{"_account_id":6553,"name":"Abhijeet Jain","username":"abhijeetjpjain","inactive":true},"change_message_id":"d235ff6fd808867658d6e941c0b33bd24c21d9b6","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Test case creates a threshold-type-alarm with default values,"},{"line_number":10,"context_line":"perform update operation and update threshold, comparision operator, statistic,"},{"line_number":11,"context_line":"period and then verify if default description get updated according to the updated values."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie0f9ec3bedbca0d39ebe3d6964b2c0a57014188c"},{"line_number":14,"context_line":"Closes-Bug: #1325436"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"baada198_3e73bf16","line":11,"updated":"2014-07-08 19:13:13.000000000","message":"Commit Message length should be \u003c 72 letters\nPlease check the guidelines.\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_GIT_commit_message_structure","commit_id":"c1bde70d8c8b27d5b70bf18890b3574e2be81ac8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b816d35286a0aed375d7737a77df7be05d03347a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"period and then verify if default description get updated according to the updated values."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie0f9ec3bedbca0d39ebe3d6964b2c0a57014188c"},{"line_number":14,"context_line":"Closes-Bug: #1325436"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ae5cdf2_8e4b222a","line":14,"updated":"2014-06-12 03:46:53.000000000","message":"This commit just testing the update description feature so its not closing the bug 1325436. Please mention Partial-Bug: #1325436.\n\nAnd mention this before Change-Id as this should be in the last","commit_id":"c1bde70d8c8b27d5b70bf18890b3574e2be81ac8"}],"tempest/api/telemetry/test_telemetry_alarming_api.py":[{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"5def5995bd6382148bee66a9cc5903e1d9581cac","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        self.assertRaises(exceptions.NotFound,"},{"line_number":114,"context_line":"                          self.telemetry_client.get_alarm, alarm_id)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"@test.attr(type\u003d\"gate\")"},{"line_number":117,"context_line":"    def test_create_update_get_verify_description_delete_alarm(self):"},{"line_number":118,"context_line":"        # Create an alarm with default description"},{"line_number":119,"context_line":"        alarm_name \u003d data_utils.rand_name(\u0027telemetry_alarm\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_da2b9692","line":116,"updated":"2014-06-09 16:20:02.000000000","message":"you should indent this at the same level of the method you\u0027re decorating, look at L97","commit_id":"f2d4890190159bc69634ea353569eb737c4954df"},{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"5def5995bd6382148bee66a9cc5903e1d9581cac","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                new_rule[\u0027comparison_operator\u0027],"},{"line_number":135,"context_line":"                new_rule[\u0027statistic\u0027],"},{"line_number":136,"context_line":"                new_rule[\u0027threshold\u0027],"},{"line_number":137,"context_line":"                new_rule[\u0027period\u0027])"},{"line_number":138,"context_line":"        alarm_name \u003d data_utils.rand_name(\u0027telemetry-alarm-update\u0027)"},{"line_number":139,"context_line":"        resp, body \u003d self.telemetry_client.update_alarm("},{"line_number":140,"context_line":"            alarm_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_bd3324f5","line":137,"updated":"2014-06-09 16:20:02.000000000","message":"wrong alignment  for those, take a look at pep8 results... It will point to you the places that need to fit on code style rules ( http://logs.openstack.org/51/98751/1/check/gate-tempest-pep8/6081b62/console.html)","commit_id":"f2d4890190159bc69634ea353569eb737c4954df"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b816d35286a0aed375d7737a77df7be05d03347a","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        self.assertEqual(204, resp.status)"},{"line_number":113,"context_line":"        self.assertRaises(exceptions.NotFound,"},{"line_number":114,"context_line":"                          self.telemetry_client.get_alarm, alarm_id)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    @test.attr(type\u003d\"gate\")"},{"line_number":117,"context_line":"    def test_create_update_get_verify_description_delete_alarm(self):"},{"line_number":118,"context_line":"        # Create an alarm with default description"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_8ecec281","line":115,"updated":"2014-06-12 03:46:53.000000000","message":"Skip this test as this is going to fail because of original bug is not yet fixed.\nuse decorator-\n@test.skip_because(bug\u003d\"1325436\")\n\nOnce bug\u003d\"1325436\" is fixed in ceilometer then you can unskip this test.","commit_id":"c1bde70d8c8b27d5b70bf18890b3574e2be81ac8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b816d35286a0aed375d7737a77df7be05d03347a","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                          self.telemetry_client.get_alarm, alarm_id)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    @test.attr(type\u003d\"gate\")"},{"line_number":117,"context_line":"    def test_create_update_get_verify_description_delete_alarm(self):"},{"line_number":118,"context_line":"        # Create an alarm with default description"},{"line_number":119,"context_line":"        alarm_name \u003d data_utils.rand_name(\u0027telemetry_alarm\u0027)"},{"line_number":120,"context_line":"        resp, body \u003d self.telemetry_client.create_alarm("}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_ce5e0a13","line":117,"updated":"2014-06-12 03:46:53.000000000","message":"test name is confusing. Please change the name something like- \ntest_create_update_verify_alarm_description(self):","commit_id":"c1bde70d8c8b27d5b70bf18890b3574e2be81ac8"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b816d35286a0aed375d7737a77df7be05d03347a","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        resp, body \u003d self.telemetry_client.create_alarm("},{"line_number":121,"context_line":"            name\u003dalarm_name, type\u003d\u0027threshold\u0027, threshold_rule\u003dself.rule)"},{"line_number":122,"context_line":"        self.assertEqual(201, resp.status)"},{"line_number":123,"context_line":"        self.assertEqual(alarm_name, body[\u0027name\u0027])"},{"line_number":124,"context_line":"        alarm_id \u003d body[\u0027alarm_id\u0027]"},{"line_number":125,"context_line":"        self.assertDictContainsSubset(self.rule, body[\u0027threshold_rule\u0027])"},{"line_number":126,"context_line":"        # Update alarm with new rule and new name"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_aeac5eee","line":123,"updated":"2014-06-12 03:46:53.000000000","message":"Also add the addcleanUp here to avoid the resource leakage with help of some helper func to pass the exception if it is already deleted.","commit_id":"c1bde70d8c8b27d5b70bf18890b3574e2be81ac8"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"cc939deefacdd05015cb65a60c86588a7693cf4d","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        resp, body \u003d self.telemetry_client.create_alarm("},{"line_number":121,"context_line":"            name\u003dalarm_name, type\u003d\u0027threshold\u0027, threshold_rule\u003dself.rule)"},{"line_number":122,"context_line":"        self.assertEqual(201, resp.status)"},{"line_number":123,"context_line":"        self.assertEqual(alarm_name, body[\u0027name\u0027])"},{"line_number":124,"context_line":"        alarm_id \u003d body[\u0027alarm_id\u0027]"},{"line_number":125,"context_line":"        self.assertDictContainsSubset(self.rule, body[\u0027threshold_rule\u0027])"},{"line_number":126,"context_line":"        # Update alarm with new rule and new name"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_4d8780b5","line":123,"updated":"2014-06-11 11:00:05.000000000","message":"This check(self.assertEqual(alarm_name, body[\u0027name\u0027])) is already done at line53 and it is better to remove this. Copy\u0026paste code makes the test purpose unclear, it would be better to write the test code just for its purpose.","commit_id":"c1bde70d8c8b27d5b70bf18890b3574e2be81ac8"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"cc939deefacdd05015cb65a60c86588a7693cf4d","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        self.assertEqual(201, resp.status)"},{"line_number":123,"context_line":"        self.assertEqual(alarm_name, body[\u0027name\u0027])"},{"line_number":124,"context_line":"        alarm_id \u003d body[\u0027alarm_id\u0027]"},{"line_number":125,"context_line":"        self.assertDictContainsSubset(self.rule, body[\u0027threshold_rule\u0027])"},{"line_number":126,"context_line":"        # Update alarm with new rule and new name"},{"line_number":127,"context_line":"        new_rule \u003d {\u0027meter_name\u0027: \u0027cpu\u0027,"},{"line_number":128,"context_line":"                    \u0027comparison_operator\u0027: \u0027eq\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_2db1548f","line":125,"updated":"2014-06-11 11:00:05.000000000","message":"ditto: the same as line55.","commit_id":"c1bde70d8c8b27d5b70bf18890b3574e2be81ac8"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"cc939deefacdd05015cb65a60c86588a7693cf4d","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        resp, body \u003d self.telemetry_client.update_alarm("},{"line_number":142,"context_line":"            alarm_id,"},{"line_number":143,"context_line":"            threshold_rule\u003dnew_rule,"},{"line_number":144,"context_line":"            name\u003dalarm_name,"},{"line_number":145,"context_line":"            type\u003d\u0027threshold\u0027,"},{"line_number":146,"context_line":"            description\u003dbody[\u0027description\u0027])"},{"line_number":147,"context_line":"        self.assertEqual(200, resp.status)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_4d0a2027","line":144,"updated":"2014-06-11 11:00:05.000000000","message":"Is it necessary to update name also?\nThe name updating feature is already tested in  test_create_update_get_delete_alarm() and this test purpose is for updating the description. So how about specifying description only?","commit_id":"c1bde70d8c8b27d5b70bf18890b3574e2be81ac8"},{"author":{"_account_id":6553,"name":"Abhijeet Jain","username":"abhijeetjpjain","inactive":true},"change_message_id":"d235ff6fd808867658d6e941c0b33bd24c21d9b6","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        resp, body \u003d self.telemetry_client.get_alarm(alarm_id)"},{"line_number":152,"context_line":"        self.assertEqual(200, resp.status)"},{"line_number":153,"context_line":"        self.assertEqual(alarm_name, body[\u0027name\u0027])"},{"line_number":154,"context_line":"        self.assertEqual(updated_description, body[\u0027description\u0027])"},{"line_number":155,"context_line":"        self.assertDictContainsSubset(new_rule, body[\u0027threshold_rule\u0027])"},{"line_number":156,"context_line":"        # Delete alarm and verify if deleted"},{"line_number":157,"context_line":"        resp, _ \u003d self.telemetry_client.delete_alarm(alarm_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_9e43eb6b","line":154,"updated":"2014-07-08 19:13:13.000000000","message":"Code redundancy.\nUse loop instead :\n\nexpected \u003d {\u0027name\u0027 : alarm_name, \u0027description\u0027 : updated_description}\nfor key, value in expected.iteritems():\n    self.assertEqual(value, body[key])","commit_id":"c1bde70d8c8b27d5b70bf18890b3574e2be81ac8"}]}