)]}'
{"tempest/cli/simple_read_only/test_neutron.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"70d898e183ad1e41f3ea2194600c5e3c8c5226f0","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        except cli.CommandFailed as e:"},{"line_number":150,"context_line":"            if \u0027404 Not Found\u0027 not in e.stderr:"},{"line_number":151,"context_line":"                self.fail(\u0027%s: Unexpected failure.\u0027 % command)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":154,"context_line":"    def test_neutron_firewall_list(self):"},{"line_number":155,"context_line":"        self._test_neutron_firewall_command(\u0027firewall-list\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_bd86f2b8","line":152,"updated":"2014-06-16 08:04:42.000000000","message":"what in case of not found error? test will silently pass.","commit_id":"086a8b04f89617374b0263f09715a0ce898bf523"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"cfe2ecafa8b0f6d0a7f56ad5c10d2585579b8dda","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        except cli.CommandFailed as e:"},{"line_number":150,"context_line":"            if \u0027404 Not Found\u0027 not in e.stderr:"},{"line_number":151,"context_line":"                self.fail(\u0027%s: Unexpected failure.\u0027 % command)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":154,"context_line":"    def test_neutron_firewall_list(self):"},{"line_number":155,"context_line":"        self._test_neutron_firewall_command(\u0027firewall-list\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_fcf12597","line":152,"in_reply_to":"1ae5cdf2_37f2da6f","updated":"2014-06-17 11:01:57.000000000","message":"In setupClass there is - if (not CONF.service_available.neutron):\n\nsuppose tempest.conf is such that, there is neutron enabled and also written FWaaS is enabled as compute feature enabled.\n\nAgain, we are using devstack with disabled fwaas in localrc - \n\nwhat will be the case when we will run this test - 404 resource not found.\n\nIn this case, we can think above implementation will be valid.\n\nAlso, I would like to know suggestion from you all :) Please suggest.","commit_id":"086a8b04f89617374b0263f09715a0ce898bf523"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"774b9c7563c7b93e88808be2eabebbee5081bb46","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        except cli.CommandFailed as e:"},{"line_number":150,"context_line":"            if \u0027404 Not Found\u0027 not in e.stderr:"},{"line_number":151,"context_line":"                self.fail(\u0027%s: Unexpected failure.\u0027 % command)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":154,"context_line":"    def test_neutron_firewall_list(self):"},{"line_number":155,"context_line":"        self._test_neutron_firewall_command(\u0027firewall-list\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_37f2da6f","line":152,"in_reply_to":"1ae5cdf2_6d6ad882","updated":"2014-06-17 00:35:30.000000000","message":"Agree. In general standard also, if we catch exception in test, we should raise the one(similar or another) after doing what we want. Test should not pass silently in this type of case.","commit_id":"086a8b04f89617374b0263f09715a0ce898bf523"},{"author":{"_account_id":1192,"name":"David Kranz","email":"dkranz@redhat.com","username":"david-kranz"},"change_message_id":"70a67093f828ae644ca1fd318026add99a75afe6","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        except cli.CommandFailed as e:"},{"line_number":150,"context_line":"            if \u0027404 Not Found\u0027 not in e.stderr:"},{"line_number":151,"context_line":"                self.fail(\u0027%s: Unexpected failure.\u0027 % command)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":154,"context_line":"    def test_neutron_firewall_list(self):"},{"line_number":155,"context_line":"        self._test_neutron_firewall_command(\u0027firewall-list\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_e57c4eee","line":152,"in_reply_to":"1ae5cdf2_98422467","updated":"2014-06-16 16:28:35.000000000","message":"I\u0027m not sure I understand this. If fwaas is not enabled, the test will be skipped. What does it mean to get 404 if fwaas is enabled and why is it ok for that to be happening?","commit_id":"086a8b04f89617374b0263f09715a0ce898bf523"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"db2407973c184d21981122b743d8e007915ba420","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        except cli.CommandFailed as e:"},{"line_number":150,"context_line":"            if \u0027404 Not Found\u0027 not in e.stderr:"},{"line_number":151,"context_line":"                self.fail(\u0027%s: Unexpected failure.\u0027 % command)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":154,"context_line":"    def test_neutron_firewall_list(self):"},{"line_number":155,"context_line":"        self._test_neutron_firewall_command(\u0027firewall-list\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_98422467","line":152,"in_reply_to":"1ae5cdf2_bd86f2b8","updated":"2014-06-16 09:02:28.000000000","message":"In case if tempest.conf says that fwaas is enabled and it actually is not enabled then 404 resource not found error will be there.\n\nIn this case, the test is not going to fail actually.\n\nSimilar approach is followed by - #88 in same file.","commit_id":"086a8b04f89617374b0263f09715a0ce898bf523"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"31beed8cd2cb9bac283487f502c4fa290bc0d161","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        except cli.CommandFailed as e:"},{"line_number":150,"context_line":"            if \u0027404 Not Found\u0027 not in e.stderr:"},{"line_number":151,"context_line":"                self.fail(\u0027%s: Unexpected failure.\u0027 % command)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":154,"context_line":"    def test_neutron_firewall_list(self):"},{"line_number":155,"context_line":"        self._test_neutron_firewall_command(\u0027firewall-list\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_6d6ad882","line":152,"in_reply_to":"1ae5cdf2_e57c4eee","updated":"2014-06-16 22:11:03.000000000","message":"Agreed with dkranz, the 404 part shouldn\u0027t be there.","commit_id":"086a8b04f89617374b0263f09715a0ce898bf523"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"70d898e183ad1e41f3ea2194600c5e3c8c5226f0","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":154,"context_line":"    def test_neutron_firewall_list(self):"},{"line_number":155,"context_line":"        self._test_neutron_firewall_command(\u0027firewall-list\u0027)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":158,"context_line":"    def test_neutron_firewall_policy_list(self):"},{"line_number":159,"context_line":"        self._test_neutron_firewall_command(\u0027firewall-policy-list\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_bdad1235","line":156,"updated":"2014-06-16 08:04:42.000000000","message":"can we check some output filed here. same in below tests","commit_id":"086a8b04f89617374b0263f09715a0ce898bf523"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"774b9c7563c7b93e88808be2eabebbee5081bb46","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":154,"context_line":"    def test_neutron_firewall_list(self):"},{"line_number":155,"context_line":"        self._test_neutron_firewall_command(\u0027firewall-list\u0027)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":158,"context_line":"    def test_neutron_firewall_policy_list(self):"},{"line_number":159,"context_line":"        self._test_neutron_firewall_command(\u0027firewall-policy-list\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_57e766ac","line":156,"in_reply_to":"1ae5cdf2_9310475b","updated":"2014-06-17 00:35:30.000000000","message":"ok","commit_id":"086a8b04f89617374b0263f09715a0ce898bf523"},{"author":{"_account_id":8205,"name":"Mh Raies","email":"raiesmh08@gmail.com","username":"raiesmh08"},"change_message_id":"db2407973c184d21981122b743d8e007915ba420","unresolved":false,"context_lines":[{"line_number":153,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":154,"context_line":"    def test_neutron_firewall_list(self):"},{"line_number":155,"context_line":"        self._test_neutron_firewall_command(\u0027firewall-list\u0027)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":158,"context_line":"    def test_neutron_firewall_policy_list(self):"},{"line_number":159,"context_line":"        self._test_neutron_firewall_command(\u0027firewall-policy-list\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_9310475b","line":156,"in_reply_to":"1ae5cdf2_bdad1235","updated":"2014-06-16 09:02:28.000000000","message":"As neutron firewall-list gives a blank line (not a blank table )in case when no firewall is available in the list.\n\nSo for these CLI no output will be required.","commit_id":"086a8b04f89617374b0263f09715a0ce898bf523"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9de173c344cf328b4c06e1d1c2656a66fd7fc508","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    @test.requires_ext(extension\u003d\u0027lbaas_agent_scheduler\u0027, service\u003d\u0027network\u0027)"},{"line_number":88,"context_line":"    def _test_neutron_lbaas_command(self, command):"},{"line_number":89,"context_line":"        try:"},{"line_number":90,"context_line":"            self.neutron(command)"},{"line_number":91,"context_line":"        except cli.CommandFailed as e:"},{"line_number":92,"context_line":"            if \u0027404 Not Found\u0027 not in e.stderr:"},{"line_number":93,"context_line":"                self.fail(\u0027%s: Unexpected failure.\u0027 % command)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_48cb004a","line":90,"updated":"2014-06-18 09:03:18.000000000","message":"IMO you can fix this also as this has been discussed here (specially to avoid the review effort on another patch).\nPlease add the same in commit msg.","commit_id":"d2873f306c94b26c0afb108b4016b94ec898fd9e"}]}