)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32704,"name":"Alfredo Garcia","display_name":"Alfredo Garcia","email":"alfrgarc@redhat.com","username":"alfrgarc","status":"Senior Software Quality Engineer @ Red Hat"},"change_message_id":"349a63cb66a64b059e955cbe97f8d9b2a2023b69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"225453fd_2e4661a6","updated":"2026-08-19 16:39:18.000000000","message":"Straightforward patch with a detailed commit message, LGTM","commit_id":"c74cbf0d2bbae1a7b2112f5c04f8a10e5df4e2ff"},{"author":{"_account_id":38173,"name":"Tanvi Nautiyal","email":"tnautiya@redhat.com","username":"tnautiyal"},"change_message_id":"e070fcdb31f4bd464fabbbf734f90926c5bfb853","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ae3af796_293ee82c","updated":"2026-09-03 11:26:51.000000000","message":"looks good, skipping makes sense when validation is disabled.","commit_id":"c74cbf0d2bbae1a7b2112f5c04f8a10e5df4e2ff"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ba48f21bb0c9d23f3f1b2a7ba39b6223f0a449dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2bc49dd4_dd2158d2","updated":"2026-09-09 21:07:07.000000000","message":"lgtm, thanks @rohin.gupta@windriver.com for updates","commit_id":"5298f452d2d9f9d44cc6baf3df5f724e38b455a8"}],"tempest/api/compute/servers/test_server_actions.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9de4d1c970a9b9eb39fdc4b822fa15f3cc1a063b","unresolved":true,"context_lines":[{"line_number":874,"context_line":"    def skip_checks(cls):"},{"line_number":875,"context_line":"        if not CONF.service_available.cinder:"},{"line_number":876,"context_line":"            raise cls.skipException(\"Cinder is not available\")"},{"line_number":877,"context_line":"        if not CONF.validation.run_validation:"},{"line_number":878,"context_line":"            raise cls.skipException(\"Validation (SSH) is required for this \""},{"line_number":879,"context_line":"                                    \"test but run_validation is disabled\")"},{"line_number":880,"context_line":"        return super().skip_checks()"},{"line_number":881,"context_line":""},{"line_number":882,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a36dc61_768a4668","line":879,"range":{"start_line":877,"start_character":0,"end_line":879,"end_character":74},"updated":"2026-09-04 18:46:34.000000000","message":"instead of skipping whole test, let\u0027s skip the ssh part of it when run_validation is not enabled","commit_id":"c74cbf0d2bbae1a7b2112f5c04f8a10e5df4e2ff"},{"author":{"_account_id":39079,"name":"Rohin Gupta","display_name":"Rohin Gupta","email":"rohin.gupta@windriver.com","username":"rgupta1"},"change_message_id":"a7fb03f168d84283c8fd561584dd4abe7bfc36c7","unresolved":false,"context_lines":[{"line_number":874,"context_line":"    def skip_checks(cls):"},{"line_number":875,"context_line":"        if not CONF.service_available.cinder:"},{"line_number":876,"context_line":"            raise cls.skipException(\"Cinder is not available\")"},{"line_number":877,"context_line":"        if not CONF.validation.run_validation:"},{"line_number":878,"context_line":"            raise cls.skipException(\"Validation (SSH) is required for this \""},{"line_number":879,"context_line":"                                    \"test but run_validation is disabled\")"},{"line_number":880,"context_line":"        return super().skip_checks()"},{"line_number":881,"context_line":""},{"line_number":882,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"a4a3271a_49e97674","line":879,"range":{"start_line":877,"start_character":0,"end_line":879,"end_character":74},"in_reply_to":"7a36dc61_768a4668","updated":"2026-09-09 12:55:56.000000000","message":"Acknowledged","commit_id":"c74cbf0d2bbae1a7b2112f5c04f8a10e5df4e2ff"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9de4d1c970a9b9eb39fdc4b822fa15f3cc1a063b","unresolved":true,"context_lines":[{"line_number":909,"context_line":"        # Verify that image inside volume is our initial image before rebuild"},{"line_number":910,"context_line":"        self.assertEqual(self.image_ref, image_before_rebuild)"},{"line_number":911,"context_line":""},{"line_number":912,"context_line":"        # Authentication is attempted in the following order of priority:"},{"line_number":913,"context_line":"        # 1.The key passed in, if one was passed in."},{"line_number":914,"context_line":"        # 2.Any key we can find through an SSH agent (if allowed)."},{"line_number":915,"context_line":"        # 3.Any \"id_rsa\", \"id_dsa\" or \"id_ecdsa\" key discoverable in"},{"line_number":916,"context_line":"        #   ~/.ssh/ (if allowed)."},{"line_number":917,"context_line":"        # 4.Plain username/password auth, if a password was given."},{"line_number":918,"context_line":"        linux_client \u003d remote_client.RemoteClient("},{"line_number":919,"context_line":"            self.get_server_ip(server, self.validation_resources),"},{"line_number":920,"context_line":"            self.ssh_user,"},{"line_number":921,"context_line":"            password\u003dNone,"},{"line_number":922,"context_line":"            pkey\u003dself.validation_resources[\u0027keypair\u0027][\u0027private_key\u0027],"},{"line_number":923,"context_line":"            server\u003dserver,"},{"line_number":924,"context_line":"            servers_client\u003dself.servers_client)"},{"line_number":925,"context_line":"        output \u003d linux_client.exec_command(\u0027touch test_file\u0027)"},{"line_number":926,"context_line":"        # No output means success"},{"line_number":927,"context_line":"        self.assertEqual(\u0027\u0027, output.strip())"},{"line_number":928,"context_line":""},{"line_number":929,"context_line":"        # The server should be rebuilt using the provided image and data"},{"line_number":930,"context_line":"        meta \u003d {\u0027rebuild\u0027: \u0027server\u0027}"}],"source_content_type":"text/x-python","patch_set":1,"id":"8cc6c0f1_eb00525c","line":927,"range":{"start_line":912,"start_character":0,"end_line":927,"end_character":44},"updated":"2026-09-04 18:46:34.000000000","message":"this part can be done under the if condition with CONF.validation.run_validation","commit_id":"c74cbf0d2bbae1a7b2112f5c04f8a10e5df4e2ff"},{"author":{"_account_id":39079,"name":"Rohin Gupta","display_name":"Rohin Gupta","email":"rohin.gupta@windriver.com","username":"rgupta1"},"change_message_id":"a7fb03f168d84283c8fd561584dd4abe7bfc36c7","unresolved":false,"context_lines":[{"line_number":909,"context_line":"        # Verify that image inside volume is our initial image before rebuild"},{"line_number":910,"context_line":"        self.assertEqual(self.image_ref, image_before_rebuild)"},{"line_number":911,"context_line":""},{"line_number":912,"context_line":"        # Authentication is attempted in the following order of priority:"},{"line_number":913,"context_line":"        # 1.The key passed in, if one was passed in."},{"line_number":914,"context_line":"        # 2.Any key we can find through an SSH agent (if allowed)."},{"line_number":915,"context_line":"        # 3.Any \"id_rsa\", \"id_dsa\" or \"id_ecdsa\" key discoverable in"},{"line_number":916,"context_line":"        #   ~/.ssh/ (if allowed)."},{"line_number":917,"context_line":"        # 4.Plain username/password auth, if a password was given."},{"line_number":918,"context_line":"        linux_client \u003d remote_client.RemoteClient("},{"line_number":919,"context_line":"            self.get_server_ip(server, self.validation_resources),"},{"line_number":920,"context_line":"            self.ssh_user,"},{"line_number":921,"context_line":"            password\u003dNone,"},{"line_number":922,"context_line":"            pkey\u003dself.validation_resources[\u0027keypair\u0027][\u0027private_key\u0027],"},{"line_number":923,"context_line":"            server\u003dserver,"},{"line_number":924,"context_line":"            servers_client\u003dself.servers_client)"},{"line_number":925,"context_line":"        output \u003d linux_client.exec_command(\u0027touch test_file\u0027)"},{"line_number":926,"context_line":"        # No output means success"},{"line_number":927,"context_line":"        self.assertEqual(\u0027\u0027, output.strip())"},{"line_number":928,"context_line":""},{"line_number":929,"context_line":"        # The server should be rebuilt using the provided image and data"},{"line_number":930,"context_line":"        meta \u003d {\u0027rebuild\u0027: \u0027server\u0027}"}],"source_content_type":"text/x-python","patch_set":1,"id":"1d399e4f_9a5a0070","line":927,"range":{"start_line":912,"start_character":0,"end_line":927,"end_character":44},"in_reply_to":"8cc6c0f1_eb00525c","updated":"2026-09-09 12:55:56.000000000","message":"Acknowledged","commit_id":"c74cbf0d2bbae1a7b2112f5c04f8a10e5df4e2ff"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9de4d1c970a9b9eb39fdc4b822fa15f3cc1a063b","unresolved":true,"context_lines":[{"line_number":964,"context_line":"        # Verify that image inside volume is our final image after rebuild"},{"line_number":965,"context_line":"        self.assertEqual(self.image_ref_alt, image_after_rebuild)"},{"line_number":966,"context_line":""},{"line_number":967,"context_line":"        # Authentication is attempted in the following order of priority:"},{"line_number":968,"context_line":"        # 1.The key passed in, if one was passed in."},{"line_number":969,"context_line":"        # 2.Any key we can find through an SSH agent (if allowed)."},{"line_number":970,"context_line":"        # 3.Any \"id_rsa\", \"id_dsa\" or \"id_ecdsa\" key discoverable in"},{"line_number":971,"context_line":"        #   ~/.ssh/ (if allowed)."},{"line_number":972,"context_line":"        # 4.Plain username/password auth, if a password was given."},{"line_number":973,"context_line":"        linux_client \u003d remote_client.RemoteClient("},{"line_number":974,"context_line":"            self.get_server_ip(rebuilt_server, self.validation_resources),"},{"line_number":975,"context_line":"            self.ssh_alt_user,"},{"line_number":976,"context_line":"            password,"},{"line_number":977,"context_line":"            self.validation_resources[\u0027keypair\u0027][\u0027private_key\u0027],"},{"line_number":978,"context_line":"            server\u003drebuilt_server,"},{"line_number":979,"context_line":"            servers_client\u003dself.servers_client)"},{"line_number":980,"context_line":"        linux_client.validate_authentication()"},{"line_number":981,"context_line":"        e \u003d self.assertRaises(lib_exc.SSHExecCommandFailed,"},{"line_number":982,"context_line":"                              linux_client.exec_command,"},{"line_number":983,"context_line":"                              \u0027cat test_file\u0027)"},{"line_number":984,"context_line":"        # If we rebuilt the boot volume, then we should not find"},{"line_number":985,"context_line":"        # the file we touched."},{"line_number":986,"context_line":"        self.assertIn(\u0027No such file or directory\u0027, str(e))"}],"source_content_type":"text/x-python","patch_set":1,"id":"68708deb_94b2243e","line":986,"range":{"start_line":967,"start_character":0,"end_line":986,"end_character":58},"updated":"2026-09-04 18:46:34.000000000","message":"ditto","commit_id":"c74cbf0d2bbae1a7b2112f5c04f8a10e5df4e2ff"},{"author":{"_account_id":39079,"name":"Rohin Gupta","display_name":"Rohin Gupta","email":"rohin.gupta@windriver.com","username":"rgupta1"},"change_message_id":"a7fb03f168d84283c8fd561584dd4abe7bfc36c7","unresolved":false,"context_lines":[{"line_number":964,"context_line":"        # Verify that image inside volume is our final image after rebuild"},{"line_number":965,"context_line":"        self.assertEqual(self.image_ref_alt, image_after_rebuild)"},{"line_number":966,"context_line":""},{"line_number":967,"context_line":"        # Authentication is attempted in the following order of priority:"},{"line_number":968,"context_line":"        # 1.The key passed in, if one was passed in."},{"line_number":969,"context_line":"        # 2.Any key we can find through an SSH agent (if allowed)."},{"line_number":970,"context_line":"        # 3.Any \"id_rsa\", \"id_dsa\" or \"id_ecdsa\" key discoverable in"},{"line_number":971,"context_line":"        #   ~/.ssh/ (if allowed)."},{"line_number":972,"context_line":"        # 4.Plain username/password auth, if a password was given."},{"line_number":973,"context_line":"        linux_client \u003d remote_client.RemoteClient("},{"line_number":974,"context_line":"            self.get_server_ip(rebuilt_server, self.validation_resources),"},{"line_number":975,"context_line":"            self.ssh_alt_user,"},{"line_number":976,"context_line":"            password,"},{"line_number":977,"context_line":"            self.validation_resources[\u0027keypair\u0027][\u0027private_key\u0027],"},{"line_number":978,"context_line":"            server\u003drebuilt_server,"},{"line_number":979,"context_line":"            servers_client\u003dself.servers_client)"},{"line_number":980,"context_line":"        linux_client.validate_authentication()"},{"line_number":981,"context_line":"        e \u003d self.assertRaises(lib_exc.SSHExecCommandFailed,"},{"line_number":982,"context_line":"                              linux_client.exec_command,"},{"line_number":983,"context_line":"                              \u0027cat test_file\u0027)"},{"line_number":984,"context_line":"        # If we rebuilt the boot volume, then we should not find"},{"line_number":985,"context_line":"        # the file we touched."},{"line_number":986,"context_line":"        self.assertIn(\u0027No such file or directory\u0027, str(e))"}],"source_content_type":"text/x-python","patch_set":1,"id":"207a296b_5b9951ff","line":986,"range":{"start_line":967,"start_character":0,"end_line":986,"end_character":58},"in_reply_to":"68708deb_94b2243e","updated":"2026-09-09 12:55:56.000000000","message":"Acknowledged","commit_id":"c74cbf0d2bbae1a7b2112f5c04f8a10e5df4e2ff"}]}
