)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":38330,"name":"Claudia Watson","email":"claudia@stackhpc.com","username":"claudia-lola"},"change_message_id":"28e2865a36774b6e1b0436cc60de289dc0dafdcb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"27358615_d107e8f3","updated":"2026-10-21 13:00:59.000000000","message":"I have tested this patch. It resolves previous redfish inspect error from simple storage usage. Thank you Jed.","commit_id":"ca235cbae000b24d3faa7d36fd3eacde741bd103"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"1699d853c3f44560093d6fb04207ba86dce69cea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"133f6f2f_1b6911d4","updated":"2026-10-21 16:14:13.000000000","message":"Thanks Jed, it looks good I think. Some optional nits.","commit_id":"ca235cbae000b24d3faa7d36fd3eacde741bd103"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"dc69e443b6290c0b363e99ef67de99fa2bae479b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0d7524f1_a48119c9","updated":"2026-10-22 16:30:04.000000000","message":"recheck","commit_id":"ca235cbae000b24d3faa7d36fd3eacde741bd103"},{"author":{"_account_id":39213,"name":"Jed Preist","display_name":"Jed Preist","email":"jed@stackhpc.com","username":"jed-preist"},"change_message_id":"2f0f564b3bea0fd626392eb7753c78f0ab9ce3c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"350b8317_ddf17532","updated":"2026-10-23 11:56:16.000000000","message":"recheck","commit_id":"ca235cbae000b24d3faa7d36fd3eacde741bd103"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"572eae56128ccf084f3eab9e8cb8c6a889b98ea2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8b2a884c_60b1b4f9","updated":"2026-10-22 13:53:10.000000000","message":"recheck","commit_id":"ca235cbae000b24d3faa7d36fd3eacde741bd103"},{"author":{"_account_id":39213,"name":"Jed Preist","display_name":"Jed Preist","email":"jed@stackhpc.com","username":"jed-preist"},"change_message_id":"afc0114396eef3942f6039dc55f0d1ed4cba3270","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"91feed37_8c9bfd0e","updated":"2026-10-23 13:56:30.000000000","message":"recheck","commit_id":"ca235cbae000b24d3faa7d36fd3eacde741bd103"},{"author":{"_account_id":39213,"name":"Jed Preist","display_name":"Jed Preist","email":"jed@stackhpc.com","username":"jed-preist"},"change_message_id":"d98fdc507f1ba10ce7605120b8c6ed363a38b0d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"985813b1_321e230f","updated":"2026-10-23 10:04:27.000000000","message":"recheck","commit_id":"ca235cbae000b24d3faa7d36fd3eacde741bd103"},{"author":{"_account_id":39213,"name":"Jed Preist","display_name":"Jed Preist","email":"jed@stackhpc.com","username":"jed-preist"},"change_message_id":"48a210daf84aa39ed667981d8176266e3e2f635d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9c675f23_ae982754","updated":"2026-10-23 08:35:55.000000000","message":"recheck","commit_id":"ca235cbae000b24d3faa7d36fd3eacde741bd103"},{"author":{"_account_id":39213,"name":"Jed Preist","display_name":"Jed Preist","email":"jed@stackhpc.com","username":"jed-preist"},"change_message_id":"8928e963bc364917f277a39623adb228ac876de7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d4e7af7f_7f54e902","updated":"2026-10-21 15:56:54.000000000","message":"recheck","commit_id":"ca235cbae000b24d3faa7d36fd3eacde741bd103"},{"author":{"_account_id":39213,"name":"Jed Preist","display_name":"Jed Preist","email":"jed@stackhpc.com","username":"jed-preist"},"change_message_id":"cfc73a76222b9b4c7328895168aa7508906f81f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ef58ea10_3d64f0c0","updated":"2026-10-21 14:26:49.000000000","message":"recheck","commit_id":"ca235cbae000b24d3faa7d36fd3eacde741bd103"},{"author":{"_account_id":39213,"name":"Jed Preist","display_name":"Jed Preist","email":"jed@stackhpc.com","username":"jed-preist"},"change_message_id":"bdd112fb40148ecff3abf2a5b0203cd7267f482d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b93145fa_e97b51fc","updated":"2026-10-26 09:27:31.000000000","message":"recheck please work zuul","commit_id":"ca235cbae000b24d3faa7d36fd3eacde741bd103"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"44b8cccba2f392a9a6a3a280008f7f944f709f06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"51531ab3_e9aa11f1","updated":"2026-10-22 10:25:08.000000000","message":"recheck: mirror issues","commit_id":"ca235cbae000b24d3faa7d36fd3eacde741bd103"}],"ansible/filter_plugins/tenks.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"536e81a36e5396a1260230cbb5be286be002daee","unresolved":false,"context_lines":[{"line_number":233,"context_line":"    \"\"\""},{"line_number":234,"context_line":"    return int(math.ceil(_parse_size_string(size) / 10**9))"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"def size_string_to_bytes(size):"},{"line_number":237,"context_line":"    \"\"\""},{"line_number":238,"context_line":"    Parse a size string, and convert to the integer number of bytes it represents."},{"line_number":239,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"68e2e8bf_47bbd88a","line":236,"updated":"2026-10-21 11:07:53.000000000","message":"pep8: E302 expected 2 blank lines, found 1","commit_id":"71239736da9b6230da4d2838ac59e9a89226ce23"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"536e81a36e5396a1260230cbb5be286be002daee","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":"def size_string_to_bytes(size):"},{"line_number":237,"context_line":"    \"\"\""},{"line_number":238,"context_line":"    Parse a size string, and convert to the integer number of bytes it represents."},{"line_number":239,"context_line":"    \"\"\""},{"line_number":240,"context_line":"    return int(_parse_size_string(size))"},{"line_number":241,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"281b9560_7dd16330","line":238,"updated":"2026-10-21 11:07:53.000000000","message":"pep8: E501 line too long (82 \u003e 79 characters)","commit_id":"71239736da9b6230da4d2838ac59e9a89226ce23"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"dcb9bb7953e2f13d7995531a42effde60c46671e","unresolved":false,"context_lines":[{"line_number":236,"context_line":""},{"line_number":237,"context_line":"def size_string_to_bytes(size):"},{"line_number":238,"context_line":"    \"\"\""},{"line_number":239,"context_line":"    Parse a size string, and convert to the integer number of bytes it represents."},{"line_number":240,"context_line":"    \"\"\""},{"line_number":241,"context_line":"    return int(_parse_size_string(size))"},{"line_number":242,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a785cc0_4b389b6e","line":239,"updated":"2026-10-21 12:28:55.000000000","message":"pep8: E501 line too long (82 \u003e 79 characters)","commit_id":"06ed2199b945d1f901da797352ddad4078946dc7"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"1699d853c3f44560093d6fb04207ba86dce69cea","unresolved":true,"context_lines":[{"line_number":238,"context_line":"    \"\"\""},{"line_number":239,"context_line":"    Convert a size string to the integer number of bytes it represents."},{"line_number":240,"context_line":"    \"\"\""},{"line_number":241,"context_line":"    return int(_parse_size_string(size))"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"def _parse_size_string(size):"}],"source_content_type":"text/x-python","patch_set":4,"id":"a92b8069_14a6f5c1","line":241,"updated":"2026-10-21 16:14:13.000000000","message":"nit: l275 returns an int already, we can remove int() here?","commit_id":"ca235cbae000b24d3faa7d36fd3eacde741bd103"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"1699d853c3f44560093d6fb04207ba86dce69cea","unresolved":true,"context_lines":[{"line_number":272,"context_line":"        base \u003d DEC"},{"line_number":273,"context_line":"    else:"},{"line_number":274,"context_line":"        base \u003d BIN"},{"line_number":275,"context_line":"    return int(number) * (base ** POWERS[power])"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"def _link_name(context, node, physnet, inventory_hostname\u003dNone):"}],"source_content_type":"text/x-python","patch_set":4,"id":"12f3d8d8_b74958a3","line":275,"updated":"2026-10-21 16:14:13.000000000","message":"We could just make this a public method to avoid the wrapper above?","commit_id":"ca235cbae000b24d3faa7d36fd3eacde741bd103"}],"ansible/roles/sushy-redfish/templates/sushy_emulator.conf.j2":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"e8d1792a7760e702d88a0036098cfbd9a5517f34","unresolved":true,"context_lines":[{"line_number":42,"context_line":"{% for volume in node.volumes %}"},{"line_number":43,"context_line":"        {"},{"line_number":44,"context_line":"            \"Id\": \"{{ node.name }}Drive{{ loop.index0 }}\","},{"line_number":45,"context_line":"            \"Name\": \"Drive{{ loop.index0 }}\","},{"line_number":46,"context_line":"            \"CapacityBytes\": {{ volume.capacity | size_string_to_bytes }},"},{"line_number":47,"context_line":"            \"Protocol\": \"SAS\""},{"line_number":48,"context_line":"        }{{ \",\" if not loop.last }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"f3b797df_22adc8ac","line":45,"updated":"2026-10-21 09:44:18.000000000","message":"```suggestion\n            \"Name\": \"{{ volume.name }}\",\n```","commit_id":"6a6898cb474268e6572f77889d68151bb13a3818"},{"author":{"_account_id":39213,"name":"Jed Preist","display_name":"Jed Preist","email":"jed@stackhpc.com","username":"jed-preist"},"change_message_id":"13301933a0e2247aec4de20c4ad9e213ddd780a5","unresolved":false,"context_lines":[{"line_number":42,"context_line":"{% for volume in node.volumes %}"},{"line_number":43,"context_line":"        {"},{"line_number":44,"context_line":"            \"Id\": \"{{ node.name }}Drive{{ loop.index0 }}\","},{"line_number":45,"context_line":"            \"Name\": \"Drive{{ loop.index0 }}\","},{"line_number":46,"context_line":"            \"CapacityBytes\": {{ volume.capacity | size_string_to_bytes }},"},{"line_number":47,"context_line":"            \"Protocol\": \"SAS\""},{"line_number":48,"context_line":"        }{{ \",\" if not loop.last }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"6f38fb4c_45308854","line":45,"in_reply_to":"f3b797df_22adc8ac","updated":"2026-10-21 09:56:50.000000000","message":"Done","commit_id":"6a6898cb474268e6572f77889d68151bb13a3818"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"73c7b9ba57e0aa4beb946880aef0f95794292fd4","unresolved":true,"context_lines":[{"line_number":44,"context_line":"            \"Id\": \"{{ node.name }}Drive{{ loop.index0 }}\","},{"line_number":45,"context_line":"            \"Name\": \"Drive{{ loop.index0 }}\","},{"line_number":46,"context_line":"            \"CapacityBytes\": {{ volume.capacity | size_string_to_bytes }},"},{"line_number":47,"context_line":"            \"Protocol\": \"SAS\""},{"line_number":48,"context_line":"        }{{ \",\" if not loop.last }}"},{"line_number":49,"context_line":"{% endfor %}"},{"line_number":50,"context_line":"    ]{{ \",\" if not loop.last }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"e13b62c7_cc06009f","line":47,"updated":"2026-10-21 09:45:57.000000000","message":"```suggestion\n            \"Protocol\": \"PCIe\"\n```\nTo align with virtio driver","commit_id":"6a6898cb474268e6572f77889d68151bb13a3818"},{"author":{"_account_id":39213,"name":"Jed Preist","display_name":"Jed Preist","email":"jed@stackhpc.com","username":"jed-preist"},"change_message_id":"13301933a0e2247aec4de20c4ad9e213ddd780a5","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            \"Id\": \"{{ node.name }}Drive{{ loop.index0 }}\","},{"line_number":45,"context_line":"            \"Name\": \"Drive{{ loop.index0 }}\","},{"line_number":46,"context_line":"            \"CapacityBytes\": {{ volume.capacity | size_string_to_bytes }},"},{"line_number":47,"context_line":"            \"Protocol\": \"SAS\""},{"line_number":48,"context_line":"        }{{ \",\" if not loop.last }}"},{"line_number":49,"context_line":"{% endfor %}"},{"line_number":50,"context_line":"    ]{{ \",\" if not loop.last }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"e86cc24d_9366b429","line":47,"in_reply_to":"e13b62c7_cc06009f","updated":"2026-10-21 09:56:50.000000000","message":"Done","commit_id":"6a6898cb474268e6572f77889d68151bb13a3818"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"e8d1792a7760e702d88a0036098cfbd9a5517f34","unresolved":true,"context_lines":[{"line_number":56,"context_line":"    (\"{{ node.uuid }}\", \"1\"): ["},{"line_number":57,"context_line":"{% for volume in node.volumes %}"},{"line_number":58,"context_line":"        {"},{"line_number":59,"context_line":"            \"libvirtVolName\": \"{{ volume.name }}\","},{"line_number":60,"context_line":"            \"Id\": \"{{ loop.index }}\","},{"line_number":61,"context_line":"            \"Name\": \"{{ volume.name }}\","},{"line_number":62,"context_line":"            \"CapacityBytes\": {{ volume.capacity | size_string_to_bytes }},"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"17fd063a_b939f62c","line":59,"updated":"2026-10-21 09:44:18.000000000","message":"Set a storage pool: \"libvirtPoolName\": \"{{ sushy_libvirt_pool }}\"","commit_id":"6a6898cb474268e6572f77889d68151bb13a3818"},{"author":{"_account_id":39213,"name":"Jed Preist","display_name":"Jed Preist","email":"jed@stackhpc.com","username":"jed-preist"},"change_message_id":"13301933a0e2247aec4de20c4ad9e213ddd780a5","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    (\"{{ node.uuid }}\", \"1\"): ["},{"line_number":57,"context_line":"{% for volume in node.volumes %}"},{"line_number":58,"context_line":"        {"},{"line_number":59,"context_line":"            \"libvirtVolName\": \"{{ volume.name }}\","},{"line_number":60,"context_line":"            \"Id\": \"{{ loop.index }}\","},{"line_number":61,"context_line":"            \"Name\": \"{{ volume.name }}\","},{"line_number":62,"context_line":"            \"CapacityBytes\": {{ volume.capacity | size_string_to_bytes }},"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"7d40f64a_50bbcffe","line":59,"in_reply_to":"17fd063a_b939f62c","updated":"2026-10-21 09:56:50.000000000","message":"Done. It should use that anyway, as it\u0027s configured as the default storage pool, but no harm in setting it explicitly.","commit_id":"6a6898cb474268e6572f77889d68151bb13a3818"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"e8d1792a7760e702d88a0036098cfbd9a5517f34","unresolved":true,"context_lines":[{"line_number":57,"context_line":"{% for volume in node.volumes %}"},{"line_number":58,"context_line":"        {"},{"line_number":59,"context_line":"            \"libvirtVolName\": \"{{ volume.name }}\","},{"line_number":60,"context_line":"            \"Id\": \"{{ loop.index }}\","},{"line_number":61,"context_line":"            \"Name\": \"{{ volume.name }}\","},{"line_number":62,"context_line":"            \"CapacityBytes\": {{ volume.capacity | size_string_to_bytes }},"},{"line_number":63,"context_line":"            \"VolumeType\": \"Mirrored\""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ae470270_af5f05c9","line":60,"updated":"2026-10-21 09:44:18.000000000","message":"```suggestion\n            \"Id\": \"{{ loop.index0 }}\",\n```\nOr was this deliberately different?","commit_id":"6a6898cb474268e6572f77889d68151bb13a3818"},{"author":{"_account_id":39213,"name":"Jed Preist","display_name":"Jed Preist","email":"jed@stackhpc.com","username":"jed-preist"},"change_message_id":"13301933a0e2247aec4de20c4ad9e213ddd780a5","unresolved":false,"context_lines":[{"line_number":57,"context_line":"{% for volume in node.volumes %}"},{"line_number":58,"context_line":"        {"},{"line_number":59,"context_line":"            \"libvirtVolName\": \"{{ volume.name }}\","},{"line_number":60,"context_line":"            \"Id\": \"{{ loop.index }}\","},{"line_number":61,"context_line":"            \"Name\": \"{{ volume.name }}\","},{"line_number":62,"context_line":"            \"CapacityBytes\": {{ volume.capacity | size_string_to_bytes }},"},{"line_number":63,"context_line":"            \"VolumeType\": \"Mirrored\""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"11b9eb64_73e9ce53","line":60,"in_reply_to":"ae470270_af5f05c9","updated":"2026-10-21 09:56:50.000000000","message":"The IDs in the example config are also 1 indexed.","commit_id":"6a6898cb474268e6572f77889d68151bb13a3818"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"e8d1792a7760e702d88a0036098cfbd9a5517f34","unresolved":true,"context_lines":[{"line_number":60,"context_line":"            \"Id\": \"{{ loop.index }}\","},{"line_number":61,"context_line":"            \"Name\": \"{{ volume.name }}\","},{"line_number":62,"context_line":"            \"CapacityBytes\": {{ volume.capacity | size_string_to_bytes }},"},{"line_number":63,"context_line":"            \"VolumeType\": \"Mirrored\""},{"line_number":64,"context_line":"        }{{ \",\" if not loop.last }}"},{"line_number":65,"context_line":"{% endfor %}"},{"line_number":66,"context_line":"    ]{{ \",\" if not loop.last }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"0ad96b9b_e96bac7a","line":63,"updated":"2026-10-21 09:44:18.000000000","message":"```suggestion\n            \"VolumeType\": \"RawDevice\"\n```","commit_id":"6a6898cb474268e6572f77889d68151bb13a3818"},{"author":{"_account_id":39213,"name":"Jed Preist","display_name":"Jed Preist","email":"jed@stackhpc.com","username":"jed-preist"},"change_message_id":"13301933a0e2247aec4de20c4ad9e213ddd780a5","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            \"Id\": \"{{ loop.index }}\","},{"line_number":61,"context_line":"            \"Name\": \"{{ volume.name }}\","},{"line_number":62,"context_line":"            \"CapacityBytes\": {{ volume.capacity | size_string_to_bytes }},"},{"line_number":63,"context_line":"            \"VolumeType\": \"Mirrored\""},{"line_number":64,"context_line":"        }{{ \",\" if not loop.last }}"},{"line_number":65,"context_line":"{% endfor %}"},{"line_number":66,"context_line":"    ]{{ \",\" if not loop.last }}"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"3ca3b212_fd1cfd78","line":63,"in_reply_to":"0ad96b9b_e96bac7a","updated":"2026-10-21 09:56:50.000000000","message":"Done","commit_id":"6a6898cb474268e6572f77889d68151bb13a3818"}]}
