)]}'
{"ansible/roles/virtualbmc-domain/library/virtualbmc_domain.py":[{"author":{"_account_id":23851,"name":"Riccardo Pittau","email":"elfosardo@gmail.com","username":"elfosardo"},"change_message_id":"7d9167eba5ec6beff86de93af983b92bb65cb904","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python3"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_55c4465f","line":1,"updated":"2020-03-18 17:34:27.000000000","message":"is the shebang necessary?\nisn\u0027t this handled by ansible_python_interpreter ?","commit_id":"634cc1f24095afc261c87379c92eae2a972fa3bb"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"0f8becb4ed53ada9309857e6a29bfe28412bf598","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python3"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_10081cd7","line":1,"in_reply_to":"1fa4df85_55c4465f","updated":"2020-03-18 18:16:15.000000000","message":"It\u0027s not necessary. Just means you can try running the module locally.","commit_id":"634cc1f24095afc261c87379c92eae2a972fa3bb"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"44e5a5a2d15dfe931469fc69b3f3f6b673c19b3a","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        domains \u003d _vbmc_command(module, [\"list\", \"-f\", \"json\"])"},{"line_number":52,"context_line":"        domains \u003d json.loads(domains)"},{"line_number":53,"context_line":"        try:"},{"line_number":54,"context_line":"            return [d for d in domains if d[\"Domain name\"] \u003d\u003d domain_name][0]"},{"line_number":55,"context_line":"        except IndexError:"},{"line_number":56,"context_line":"            return None"},{"line_number":57,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_39fc17b4","line":54,"updated":"2020-03-19 12:03:16.000000000","message":"nit: Arguably, a more readable code could be to turn `domains` into a dict indexed by `Domain name` value and go from there.","commit_id":"c125f50498c6986806520fe985da9b074e3f1a0d"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7e296b59fc0d2d9324c03dbd3a4e86a9890aaf92","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        domains \u003d _vbmc_command(module, [\"list\", \"-f\", \"json\"])"},{"line_number":52,"context_line":"        domains \u003d json.loads(domains)"},{"line_number":53,"context_line":"        try:"},{"line_number":54,"context_line":"            return [d for d in domains if d[\"Domain name\"] \u003d\u003d domain_name][0]"},{"line_number":55,"context_line":"        except IndexError:"},{"line_number":56,"context_line":"            return None"},{"line_number":57,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_07a1b6f8","line":54,"in_reply_to":"1fa4df85_39fc17b4","updated":"2020-03-19 12:57:05.000000000","message":"Done","commit_id":"c125f50498c6986806520fe985da9b074e3f1a0d"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"44e5a5a2d15dfe931469fc69b3f3f6b673c19b3a","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        try:"},{"line_number":54,"context_line":"            return [d for d in domains if d[\"Domain name\"] \u003d\u003d domain_name][0]"},{"line_number":55,"context_line":"        except IndexError:"},{"line_number":56,"context_line":"            return None"},{"line_number":57,"context_line":"    else:"},{"line_number":58,"context_line":"        domain \u003d _vbmc_command(module, [\"show\", domain_name, \"-f\", \"json\"])"},{"line_number":59,"context_line":"        domain \u003d json.loads(domain)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_79c36f8a","line":56,"updated":"2020-03-19 12:03:16.000000000","message":"nit: None is implicit","commit_id":"c125f50498c6986806520fe985da9b074e3f1a0d"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"46a3e8e52beafd6fddf4429ed6231c6ec6eed397","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        try:"},{"line_number":54,"context_line":"            return [d for d in domains if d[\"Domain name\"] \u003d\u003d domain_name][0]"},{"line_number":55,"context_line":"        except IndexError:"},{"line_number":56,"context_line":"            return None"},{"line_number":57,"context_line":"    else:"},{"line_number":58,"context_line":"        domain \u003d _vbmc_command(module, [\"show\", domain_name, \"-f\", \"json\"])"},{"line_number":59,"context_line":"        domain \u003d json.loads(domain)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_07c2165a","line":56,"in_reply_to":"1fa4df85_077c5681","updated":"2020-03-19 13:07:41.000000000","message":"Yeah, triggers my PEP8 instinct.","commit_id":"c125f50498c6986806520fe985da9b074e3f1a0d"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7e296b59fc0d2d9324c03dbd3a4e86a9890aaf92","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        try:"},{"line_number":54,"context_line":"            return [d for d in domains if d[\"Domain name\"] \u003d\u003d domain_name][0]"},{"line_number":55,"context_line":"        except IndexError:"},{"line_number":56,"context_line":"            return None"},{"line_number":57,"context_line":"    else:"},{"line_number":58,"context_line":"        domain \u003d _vbmc_command(module, [\"show\", domain_name, \"-f\", \"json\"])"},{"line_number":59,"context_line":"        domain \u003d json.loads(domain)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_077c5681","line":56,"in_reply_to":"1fa4df85_79c36f8a","updated":"2020-03-19 12:57:05.000000000","message":"It is. Wanted it to be clear that I am returning None to signify no domain found.","commit_id":"c125f50498c6986806520fe985da9b074e3f1a0d"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"44e5a5a2d15dfe931469fc69b3f3f6b673c19b3a","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    for _ in range(RETRIES):"},{"line_number":81,"context_line":"        domain \u003d _get_domain(module, allow_missing\u003dTrue)"},{"line_number":82,"context_line":"        if (exists and domain) or (not exists and not domain):"},{"line_number":83,"context_line":"            break"},{"line_number":84,"context_line":"        time.sleep(INTERVAL)"},{"line_number":85,"context_line":"    else:"},{"line_number":86,"context_line":"        action \u003d \"added\" if exists else \"deleted\""}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_5995533f","line":83,"updated":"2020-03-19 12:03:16.000000000","message":"nit: `return` here would eliminate `else:`","commit_id":"c125f50498c6986806520fe985da9b074e3f1a0d"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7e296b59fc0d2d9324c03dbd3a4e86a9890aaf92","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    for _ in range(RETRIES):"},{"line_number":81,"context_line":"        domain \u003d _get_domain(module, allow_missing\u003dTrue)"},{"line_number":82,"context_line":"        if (exists and domain) or (not exists and not domain):"},{"line_number":83,"context_line":"            break"},{"line_number":84,"context_line":"        time.sleep(INTERVAL)"},{"line_number":85,"context_line":"    else:"},{"line_number":86,"context_line":"        action \u003d \"added\" if exists else \"deleted\""}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_276072cf","line":83,"in_reply_to":"1fa4df85_5995533f","updated":"2020-03-19 12:57:05.000000000","message":"Done","commit_id":"c125f50498c6986806520fe985da9b074e3f1a0d"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"44e5a5a2d15dfe931469fc69b3f3f6b673c19b3a","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    \"\"\"Wait for the domain to reach a particular status.\"\"\""},{"line_number":93,"context_line":"    for _ in range(RETRIES):"},{"line_number":94,"context_line":"        domain \u003d _get_domain(module)"},{"line_number":95,"context_line":"        if domain[\"status\"] \u003d\u003d status:"},{"line_number":96,"context_line":"            break"},{"line_number":97,"context_line":"        time.sleep(INTERVAL)"},{"line_number":98,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_b9b7a7f5","line":95,"updated":"2020-03-19 12:03:16.000000000","message":"nit: `return` here would eliminate `else:`","commit_id":"c125f50498c6986806520fe985da9b074e3f1a0d"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"7e296b59fc0d2d9324c03dbd3a4e86a9890aaf92","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    \"\"\"Wait for the domain to reach a particular status.\"\"\""},{"line_number":93,"context_line":"    for _ in range(RETRIES):"},{"line_number":94,"context_line":"        domain \u003d _get_domain(module)"},{"line_number":95,"context_line":"        if domain[\"status\"] \u003d\u003d status:"},{"line_number":96,"context_line":"            break"},{"line_number":97,"context_line":"        time.sleep(INTERVAL)"},{"line_number":98,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_475d6e13","line":95,"in_reply_to":"1fa4df85_b9b7a7f5","updated":"2020-03-19 12:57:05.000000000","message":"Done","commit_id":"c125f50498c6986806520fe985da9b074e3f1a0d"}]}