)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"bf4df0c92e7797e7e036ccb0bd4733cf965d5cb3","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Bartosz Bezak \u003cbartosz@stackhpc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-07-25 14:30:45 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Name Block tasks to fix \u0027unnamed-task\u0027 ansible-lint errors"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I7324467e54deda1a05063cfa1b52a276f7622442"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"25db8fe4_58c6fa32","line":7,"range":{"start_line":7,"start_character":5,"end_line":7,"end_character":11},"updated":"2022-07-25 13:03:41.000000000","message":"not only block tasks it seems","commit_id":"c73d3143077f173c14e1f9959a5faff3419cbede"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"894b5edf72561ea62333433341cfb587225b4583","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Bartosz Bezak \u003cbartosz@stackhpc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-07-25 14:30:45 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Name Block tasks to fix \u0027unnamed-task\u0027 ansible-lint errors"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I7324467e54deda1a05063cfa1b52a276f7622442"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"e7582620_58a807d7","line":7,"range":{"start_line":7,"start_character":5,"end_line":7,"end_character":11},"in_reply_to":"25db8fe4_58c6fa32","updated":"2022-07-25 13:07:20.000000000","message":"Done","commit_id":"c73d3143077f173c14e1f9959a5faff3419cbede"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f2721755064c26073cf4cd7794f199242bfe7aac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c2fafb0c_eb0088e7","updated":"2022-07-25 20:17:08.000000000","message":"Should we consider making tenks branched?","commit_id":"3d4312175c74ec0d9253ec7c00522ab605c849bc"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1623c4dbd76340873402f411153ab2517ad0b21b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3586ac10_9d10db43","updated":"2022-07-25 13:08:43.000000000","message":"Thanks! (I cannot +2 in tenks [yet 😊].)","commit_id":"3d4312175c74ec0d9253ec7c00522ab605c849bc"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"1d0724d1add1899e5621350539153bf3cfc0b375","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4e477a02_e12175bb","updated":"2022-07-25 20:16:43.000000000","message":"hmm, probably some unpins fried py37","commit_id":"3d4312175c74ec0d9253ec7c00522ab605c849bc"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"ddc380c26066d5d6fda538da23afe602e0093808","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d679c952_bcb8412f","updated":"2022-07-25 17:09:12.000000000","message":"recheck","commit_id":"3d4312175c74ec0d9253ec7c00522ab605c849bc"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"894b5edf72561ea62333433341cfb587225b4583","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2f796819_b651980c","updated":"2022-07-25 13:07:20.000000000","message":"thx!","commit_id":"3d4312175c74ec0d9253ec7c00522ab605c849bc"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"def2c1b6e0ad1304030784388d2da6841eb43168","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"48da1ffc_be3ed713","in_reply_to":"416c443d_fa8b09b4","updated":"2022-07-26 08:53:05.000000000","message":"Well, with the changes in upper constraints we are soon going to lose 3.6 testability as well.","commit_id":"3d4312175c74ec0d9253ec7c00522ab605c849bc"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"de40c97aefee18175efd29d20a0f8dabfc528b3c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"389e3d31_5d00e727","in_reply_to":"48da1ffc_be3ed713","updated":"2022-07-26 08:53:31.000000000","message":"But I agree that for now we can just drop 3.7.","commit_id":"3d4312175c74ec0d9253ec7c00522ab605c849bc"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"1ec19c772d2f0f9adf213eac0117fe064a353401","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"416c443d_fa8b09b4","in_reply_to":"86380abe_85a4f8f8","updated":"2022-07-26 08:27:19.000000000","message":"That might make sense.","commit_id":"3d4312175c74ec0d9253ec7c00522ab605c849bc"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"52ea043028f412590cd393cd62c9efe0a58d97c6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"86380abe_85a4f8f8","in_reply_to":"c2fafb0c_eb0088e7","updated":"2022-07-26 08:22:51.000000000","message":"or dropping python 3.7 job, as it was supported in Victoria release, which is EOL now. Wallaby supports 3.6 and 3.8\nhttps://review.opendev.org/c/openstack/governance/+/743847\nhttps://review.opendev.org/c/openstack/governance/+/693743","commit_id":"3d4312175c74ec0d9253ec7c00522ab605c849bc"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"3378b640f7566805d09757183ed769ba9d3b90ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a5751147_05cf43f6","updated":"2022-07-26 12:21:18.000000000","message":"Thanks","commit_id":"d7312db645d1f62feff49f028ff2d89c1a882c73"}],"ansible/host_setup.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"bf4df0c92e7797e7e036ccb0bd4733cf965d5cb3","unresolved":true,"context_lines":[{"line_number":21,"context_line":"  tags:"},{"line_number":22,"context_line":"    - host-setup"},{"line_number":23,"context_line":"  tasks:"},{"line_number":24,"context_line":"    - name: Set up Host"},{"line_number":25,"context_line":"      block:"},{"line_number":26,"context_line":"        - name: Configure host for Libvirt"},{"line_number":27,"context_line":"          include_role:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b557a30a_c796a988","line":24,"range":{"start_line":24,"start_character":19,"end_line":24,"end_character":23},"updated":"2022-07-25 13:03:41.000000000","message":"nit: host","commit_id":"c73d3143077f173c14e1f9959a5faff3419cbede"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"894b5edf72561ea62333433341cfb587225b4583","unresolved":false,"context_lines":[{"line_number":21,"context_line":"  tags:"},{"line_number":22,"context_line":"    - host-setup"},{"line_number":23,"context_line":"  tasks:"},{"line_number":24,"context_line":"    - name: Set up Host"},{"line_number":25,"context_line":"      block:"},{"line_number":26,"context_line":"        - name: Configure host for Libvirt"},{"line_number":27,"context_line":"          include_role:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f218a342_1af98b75","line":24,"range":{"start_line":24,"start_character":19,"end_line":24,"end_character":23},"in_reply_to":"b557a30a_c796a988","updated":"2022-07-25 13:07:20.000000000","message":"Done","commit_id":"c73d3143077f173c14e1f9959a5faff3419cbede"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"498695641583ba6bdb7338a34693ff72d9d03e81","unresolved":true,"context_lines":[{"line_number":21,"context_line":"  tags:"},{"line_number":22,"context_line":"    - host-setup"},{"line_number":23,"context_line":"  tasks:"},{"line_number":24,"context_line":"    - name: Set up host"},{"line_number":25,"context_line":"      block:"},{"line_number":26,"context_line":"        - name: Configure host for Libvirt"},{"line_number":27,"context_line":"          include_role:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df3f307f_f9715d6f","line":24,"range":{"start_line":24,"start_character":6,"end_line":24,"end_character":23},"updated":"2022-07-26 08:09:30.000000000","message":"I don\u0027t think naming blocks is necessary, although I guess it sets the default name for tasks in the block, which fixes the ansible-lint issue?","commit_id":"3d4312175c74ec0d9253ec7c00522ab605c849bc"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"d81df5a44b1c2196062922eca79069f73da95250","unresolved":true,"context_lines":[{"line_number":21,"context_line":"  tags:"},{"line_number":22,"context_line":"    - host-setup"},{"line_number":23,"context_line":"  tasks:"},{"line_number":24,"context_line":"    - name: Set up host"},{"line_number":25,"context_line":"      block:"},{"line_number":26,"context_line":"        - name: Configure host for Libvirt"},{"line_number":27,"context_line":"          include_role:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5485676d_fbb88aa2","line":24,"range":{"start_line":24,"start_character":6,"end_line":24,"end_character":23},"in_reply_to":"df3f307f_f9715d6f","updated":"2022-07-26 08:31:31.000000000","message":"Indeed, it makes ansible-lint happy now. That was the errors. Alternatively we could add \"unnamed-task\" to warning list\n\nunnamed-task: All tasks should be named.\nansible/host_setup.yml:24 Task/Handler: block/always/rescue\n\nunnamed-task: All tasks should be named.\nansible/hypervisor_setup.yml:32 Task/Handler: block/always/rescue\n\nunnamed-task: All tasks should be named.\nansible/physical_network.yml:38 Task/Handler: block/always/rescue\n\nunnamed-task: All tasks should be named.\nansible/physical_network.yml:61 Task/Handler: block/always/rescue\n\nunnamed-task: All tasks should be named.\nansible/physical_network.yml:147 Task/Handler: block/always/rescue\n\nunnamed-task: All tasks should be named.\nansible/resource_wait.yml:25 Task/Handler: block/always/rescue\n\nunnamed-task: All tasks should be named.\nansible/roles/ironic-enrolment/tasks/main.yml:47 Task/Handler: block/always/rescue\n\nunnamed-task: All tasks should be named.\nansible/roles/veth-pair/tasks/absent.yml:2 Task/Handler: block/always/rescue\n\nunnamed-task: All tasks should be named.\nansible/roles/veth-pair/tasks/present.yml:30 Task/Handler: block/always/rescue\n\nunnamed-task: All tasks should be named.\nansible/roles/veth-pair/tasks/present.yml:45 Task/Handler: block/always/rescue","commit_id":"3d4312175c74ec0d9253ec7c00522ab605c849bc"}],"ansible/roles/ironic-enrolment/tasks/main.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"bf4df0c92e7797e7e036ccb0bd4733cf965d5cb3","unresolved":true,"context_lines":[{"line_number":44,"context_line":"# If using clouds.yaml for authentication we need to pass in the ironic_url"},{"line_number":45,"context_line":"# argument to the os_ironic module, due to a quirk in its implementation."},{"line_number":46,"context_line":"# Grab the endpoint from the file."},{"line_number":47,"context_line":"- name: Pass ironic_url to os_ironic module"},{"line_number":48,"context_line":"  block:"},{"line_number":49,"context_line":"    - name: Query clouds.yaml"},{"line_number":50,"context_line":"      os_client_config:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"93558511_3f85cdc4","line":47,"range":{"start_line":47,"start_character":8,"end_line":47,"end_character":43},"updated":"2022-07-25 13:03:41.000000000","message":"More like \"Set ironic_url for os_ironic module\"","commit_id":"c73d3143077f173c14e1f9959a5faff3419cbede"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"894b5edf72561ea62333433341cfb587225b4583","unresolved":false,"context_lines":[{"line_number":44,"context_line":"# If using clouds.yaml for authentication we need to pass in the ironic_url"},{"line_number":45,"context_line":"# argument to the os_ironic module, due to a quirk in its implementation."},{"line_number":46,"context_line":"# Grab the endpoint from the file."},{"line_number":47,"context_line":"- name: Pass ironic_url to os_ironic module"},{"line_number":48,"context_line":"  block:"},{"line_number":49,"context_line":"    - name: Query clouds.yaml"},{"line_number":50,"context_line":"      os_client_config:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"68825795_f8592af2","line":47,"range":{"start_line":47,"start_character":8,"end_line":47,"end_character":43},"in_reply_to":"93558511_3f85cdc4","updated":"2022-07-25 13:07:20.000000000","message":"Done","commit_id":"c73d3143077f173c14e1f9959a5faff3419cbede"}]}
