)]}'
{".ansible-lint":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"306d3f8e8a106dfd5459de2f3ce847352735c4b3","unresolved":true,"context_lines":[{"line_number":7,"context_line":"  - experimental  # all rules tagged as experimental"},{"line_number":8,"context_line":"  - fqcn-builtins  # Use FQCN for builtin actions."},{"line_number":9,"context_line":"  - jinja[spacing] # Jinja2 spacing could be improved"},{"line_number":10,"context_line":"  - package-latest # We want the latest pip and setuptools. Period."}],"source_content_type":"application/octet-stream","patch_set":9,"id":"e74f4faa_1cef2693","line":10,"updated":"2022-09-09 08:36:19.000000000","message":"Worth doing noqa on the task instead? An example in the code base:\n\nhttps://github.com/openstack/tenks/blob/d7312db645d1f62feff49f028ff2d89c1a882c73/ansible/roles/ironic-enrolment/tasks/main.yml#L12-L21","commit_id":"91541073ae446eac75fa4c78c08b1c31ee742fc8"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"13f94a1d5b8a57c96b83465f08889f49453194d3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  - experimental  # all rules tagged as experimental"},{"line_number":8,"context_line":"  - fqcn-builtins  # Use FQCN for builtin actions."},{"line_number":9,"context_line":"  - jinja[spacing] # Jinja2 spacing could be improved"},{"line_number":10,"context_line":"  - package-latest # We want the latest pip and setuptools. Period."}],"source_content_type":"application/octet-stream","patch_set":9,"id":"ec08b7e8_14106b45","line":10,"in_reply_to":"e74f4faa_1cef2693","updated":"2022-09-09 15:56:40.000000000","message":"Done","commit_id":"91541073ae446eac75fa4c78c08b1c31ee742fc8"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"83ad23cb0fa0a7ee95bd8692d1412cab532d09f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"98682db2_e1e3f9f5","updated":"2022-09-07 15:55:25.000000000","message":"Not tested, awaiting results.","commit_id":"e34d256da96c7ab4a92b78bb390fa7300b4902b3"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"455182a9f745b41b396a19bbd7746b244a5e2eb0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"63f10e7a_bf7c46ba","updated":"2022-09-07 15:59:19.000000000","message":"could be missing site-packages or something like that","commit_id":"f692519c33536c2730a08ae7ddb2b8b56e19722b"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"5d7fb5307c9a0e68b9d4a7b39e445cda1d3b2330","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ddfb06da_9125bc2f","updated":"2022-09-07 19:48:24.000000000","message":"It still tries to install libvirt-python in Kolla-Ansible\u0027s CI though...","commit_id":"28cca825dbc0bd86261b8b8132d963833f6b6dce"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f5befc4418184ae4c99b66e6e2fea9a10e2e54ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"bd005008_3bfa28bb","in_reply_to":"ddfb06da_9125bc2f","updated":"2022-09-07 20:01:10.000000000","message":"Fixing in https://review.opendev.org/c/openstack/kolla-ansible/+/856328","commit_id":"28cca825dbc0bd86261b8b8132d963833f6b6dce"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"94893371f34e7c210250c04a6755151f6363e491","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"245baf73_773d10fb","updated":"2022-09-12 08:44:11.000000000","message":"Some follow ups here: https://review.opendev.org/c/openstack/tenks/+/857008","commit_id":"6c59da3daf416fa4211858ef3a5154d0894fa85f"}],"ansible/host_setup.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ff2ebf5fbacc049574fae45eaacabad534223812","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    - name: Ensure Tenks venv is properly set up"},{"line_number":8,"context_line":"      block:"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"        - name: Init Tenks venv"},{"line_number":11,"context_line":"          command:"},{"line_number":12,"context_line":"            cmd: \"{{ ansible_facts.python.executable }} -m venv {{ virtualenv_path }}\""},{"line_number":13,"context_line":"            creates: \"{{ virtualenv_path }}\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"        - name: Upgrade pip"},{"line_number":16,"context_line":"          pip:"},{"line_number":17,"context_line":"            name: pip"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"00dc053d_6001e238","line":14,"range":{"start_line":10,"start_character":1,"end_line":14,"end_character":0},"updated":"2022-09-07 16:30:21.000000000","message":"Why not just use virtualenv_command in pip module? e.g. virtualenv_command: \"python3.{{ ansible_facts.python.executable }} -m venv\"","commit_id":"04ad1f89549687527d186f8c92ef82ef6d8e7fa9"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"602c4001383046a5d0ce0781c17a2bec26308210","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    - name: Ensure Tenks venv is properly set up"},{"line_number":8,"context_line":"      block:"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"        - name: Init Tenks venv"},{"line_number":11,"context_line":"          command:"},{"line_number":12,"context_line":"            cmd: \"{{ ansible_facts.python.executable }} -m venv {{ virtualenv_path }}\""},{"line_number":13,"context_line":"            creates: \"{{ virtualenv_path }}\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"        - name: Upgrade pip"},{"line_number":16,"context_line":"          pip:"},{"line_number":17,"context_line":"            name: pip"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"988880f8_9933d63a","line":14,"range":{"start_line":10,"start_character":1,"end_line":14,"end_character":0},"in_reply_to":"00dc053d_6001e238","updated":"2022-09-07 16:35:37.000000000","message":"Habit of hating the nature of Ansible\u0027s implementation.","commit_id":"04ad1f89549687527d186f8c92ef82ef6d8e7fa9"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"13f94a1d5b8a57c96b83465f08889f49453194d3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    - name: Ensure Tenks venv is properly set up"},{"line_number":8,"context_line":"      block:"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"        - name: Init Tenks venv"},{"line_number":11,"context_line":"          command:"},{"line_number":12,"context_line":"            cmd: \"{{ ansible_facts.python.executable }} -m venv {{ virtualenv_path }}\""},{"line_number":13,"context_line":"            creates: \"{{ virtualenv_path }}\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"        - name: Upgrade pip"},{"line_number":16,"context_line":"          pip:"},{"line_number":17,"context_line":"            name: pip"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"b7044cad_2fe355a6","line":14,"range":{"start_line":10,"start_character":1,"end_line":14,"end_character":0},"in_reply_to":"988880f8_9933d63a","updated":"2022-09-09 15:56:40.000000000","message":"Done","commit_id":"04ad1f89549687527d186f8c92ef82ef6d8e7fa9"}],"ansible/roles/virtualbmc-daemon/tasks/main.yml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"94893371f34e7c210250c04a6755151f6363e491","unresolved":true,"context_lines":[{"line_number":37,"context_line":"    url: \"{{ vbmcd_python_upper_constraints_url }}\""},{"line_number":38,"context_line":"    dest: \"{{ u_c_file.path }}\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# NOTE(yoctozepto): It is preferable to use the libvirt python binding that"},{"line_number":41,"context_line":"# is delivered with the distribution as it is guaranteed to work with the"},{"line_number":42,"context_line":"# deployed daemon (and the accompanying Python)."},{"line_number":43,"context_line":"- name: Remove libvirt-python from u-c"},{"line_number":44,"context_line":"  lineinfile:"},{"line_number":45,"context_line":"    path: \"{{ u_c_file.path }}\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"39edd988_713d2b96","line":42,"range":{"start_line":40,"start_character":0,"end_line":42,"end_character":48},"updated":"2022-09-12 08:44:11.000000000","message":"Doesn\u0027t this assume that the daemon is deployed on the host, or that the host \u0026 libvirt container OS are using the same packages?","commit_id":"91541073ae446eac75fa4c78c08b1c31ee742fc8"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"08742b2f67bbe00c9b6e5c18bdda449564ff68c4","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    url: \"{{ vbmcd_python_upper_constraints_url }}\""},{"line_number":38,"context_line":"    dest: \"{{ u_c_file.path }}\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# NOTE(yoctozepto): It is preferable to use the libvirt python binding that"},{"line_number":41,"context_line":"# is delivered with the distribution as it is guaranteed to work with the"},{"line_number":42,"context_line":"# deployed daemon (and the accompanying Python)."},{"line_number":43,"context_line":"- name: Remove libvirt-python from u-c"},{"line_number":44,"context_line":"  lineinfile:"},{"line_number":45,"context_line":"    path: \"{{ u_c_file.path }}\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"a208c695_97ada5e8","line":42,"range":{"start_line":40,"start_character":0,"end_line":42,"end_character":48},"in_reply_to":"39edd988_713d2b96","updated":"2022-09-12 08:49:23.000000000","message":"It does. However, the previous approach assumed that we would get compatible host-level libraries anyway so this one actually assumes one level less.\n\n(In a perfect world, we could have a pure-python implementation of only the necessary bolts of communication with libvirtd [the daemon] and not the whole machinery of the libvirt C binding).","commit_id":"91541073ae446eac75fa4c78c08b1c31ee742fc8"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"94893371f34e7c210250c04a6755151f6363e491","unresolved":true,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    - name: \"[selinux] Allow systemd to start vbmcd from venv - restorecon\""},{"line_number":76,"context_line":"      become: true"},{"line_number":77,"context_line":"      command: \"restorecon -r {{ vbmcd_virtualenv_path }}/bin\""},{"line_number":78,"context_line":"      when: sefcontext.changed"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  when: selinux_enabled and vbmcd_virtualenv_path"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"4be79e47_ceaa8b44","line":77,"updated":"2022-09-12 08:44:11.000000000","message":"changed_when: true?","commit_id":"91541073ae446eac75fa4c78c08b1c31ee742fc8"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"08742b2f67bbe00c9b6e5c18bdda449564ff68c4","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    - name: \"[selinux] Allow systemd to start vbmcd from venv - restorecon\""},{"line_number":76,"context_line":"      become: true"},{"line_number":77,"context_line":"      command: \"restorecon -r {{ vbmcd_virtualenv_path }}/bin\""},{"line_number":78,"context_line":"      when: sefcontext.changed"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  when: selinux_enabled and vbmcd_virtualenv_path"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"c5b21f86_cd58f34b","line":77,"in_reply_to":"4be79e47_ceaa8b44","updated":"2022-09-12 08:49:23.000000000","message":"The linter has it off so I did not bother.","commit_id":"91541073ae446eac75fa4c78c08b1c31ee742fc8"}],"playbooks/tenks-deploy-teardown/pre.yml":[{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"306d3f8e8a106dfd5459de2f3ce847352735c4b3","unresolved":true,"context_lines":[{"line_number":26,"context_line":"          - python3-pip"},{"line_number":27,"context_line":"          - python3-setuptools"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    - name: Create venv for tenks"},{"line_number":30,"context_line":"      command:"},{"line_number":31,"context_line":"        cmd: \"{{ ansible_facts.python.executable }} -m venv {{ tenks_venv }}\""},{"line_number":32,"context_line":"        creates: \"{{ tenks_venv }}\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"0ae351c9_01af7c6f","line":29,"updated":"2022-09-09 08:36:19.000000000","message":"Agree that using pip with virtualenv command would be slightly more conventional. Similar to the existing code:\n\nhttps://github.com/openstack/tenks/blob/d7312db645d1f62feff49f028ff2d89c1a882c73/ansible/roles/ironic-enrolment/tasks/main.yml#L12-L21\n\nNot a blocker though.","commit_id":"91541073ae446eac75fa4c78c08b1c31ee742fc8"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"13f94a1d5b8a57c96b83465f08889f49453194d3","unresolved":false,"context_lines":[{"line_number":26,"context_line":"          - python3-pip"},{"line_number":27,"context_line":"          - python3-setuptools"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    - name: Create venv for tenks"},{"line_number":30,"context_line":"      command:"},{"line_number":31,"context_line":"        cmd: \"{{ ansible_facts.python.executable }} -m venv {{ tenks_venv }}\""},{"line_number":32,"context_line":"        creates: \"{{ tenks_venv }}\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"879b252a_6c455c93","line":29,"in_reply_to":"0ae351c9_01af7c6f","updated":"2022-09-09 15:56:40.000000000","message":"Done","commit_id":"91541073ae446eac75fa4c78c08b1c31ee742fc8"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"9187d3406ac3f43af6d1723643fb257eb6304156","unresolved":true,"context_lines":[{"line_number":31,"context_line":"        cmd: \"{{ ansible_facts.python.executable }} -m venv {{ tenks_venv }}\""},{"line_number":32,"context_line":"        creates: \"{{ tenks_venv }}\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    - name: Upgrade pip"},{"line_number":35,"context_line":"      pip:"},{"line_number":36,"context_line":"        name: pip"},{"line_number":37,"context_line":"        state: latest"},{"line_number":38,"context_line":"        virtualenv: \"{{ tenks_venv }}\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    - name: Upgrade setuptools"},{"line_number":41,"context_line":"      pip:"},{"line_number":42,"context_line":"        name: setuptools"},{"line_number":43,"context_line":"        state: latest"},{"line_number":44,"context_line":"        virtualenv: \"{{ tenks_venv }}\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    - name: Install tenks deps"},{"line_number":47,"context_line":"      pip:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9bc51ab1_c27d6dde","line":44,"range":{"start_line":34,"start_character":0,"end_line":44,"end_character":38},"updated":"2022-09-09 08:25:04.000000000","message":"Are you sure that this will not hurt us in 1.5 year from now when Zed will still be supported?\n\npip\u003d\u003d22.* setuptools\u003d\u003d65.* would make it safer.","commit_id":"91541073ae446eac75fa4c78c08b1c31ee742fc8"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"615165bf5fac6bff4261d249c0f592aa00df6733","unresolved":true,"context_lines":[{"line_number":31,"context_line":"        cmd: \"{{ ansible_facts.python.executable }} -m venv {{ tenks_venv }}\""},{"line_number":32,"context_line":"        creates: \"{{ tenks_venv }}\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    - name: Upgrade pip"},{"line_number":35,"context_line":"      pip:"},{"line_number":36,"context_line":"        name: pip"},{"line_number":37,"context_line":"        state: latest"},{"line_number":38,"context_line":"        virtualenv: \"{{ tenks_venv }}\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    - name: Upgrade setuptools"},{"line_number":41,"context_line":"      pip:"},{"line_number":42,"context_line":"        name: setuptools"},{"line_number":43,"context_line":"        state: latest"},{"line_number":44,"context_line":"        virtualenv: \"{{ tenks_venv }}\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    - name: Install tenks deps"},{"line_number":47,"context_line":"      pip:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"ca688158_8f2c89eb","line":44,"range":{"start_line":34,"start_character":0,"end_line":44,"end_character":38},"in_reply_to":"9bc51ab1_c27d6dde","updated":"2022-09-09 08:29:57.000000000","message":"Tenks is branchless so master has to be functional and compatible with all supported releases. We can pin now but if we change it later it will affect all supported releases anyway?","commit_id":"91541073ae446eac75fa4c78c08b1c31ee742fc8"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"306d3f8e8a106dfd5459de2f3ce847352735c4b3","unresolved":true,"context_lines":[{"line_number":31,"context_line":"        cmd: \"{{ ansible_facts.python.executable }} -m venv {{ tenks_venv }}\""},{"line_number":32,"context_line":"        creates: \"{{ tenks_venv }}\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    - name: Upgrade pip"},{"line_number":35,"context_line":"      pip:"},{"line_number":36,"context_line":"        name: pip"},{"line_number":37,"context_line":"        state: latest"},{"line_number":38,"context_line":"        virtualenv: \"{{ tenks_venv }}\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    - name: Upgrade setuptools"},{"line_number":41,"context_line":"      pip:"},{"line_number":42,"context_line":"        name: setuptools"},{"line_number":43,"context_line":"        state: latest"},{"line_number":44,"context_line":"        virtualenv: \"{{ tenks_venv }}\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    - name: Install tenks deps"},{"line_number":47,"context_line":"      pip:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"fe5e476b_543f5583","line":44,"range":{"start_line":34,"start_character":0,"end_line":44,"end_character":38},"in_reply_to":"ca688158_8f2c89eb","updated":"2022-09-09 08:36:19.000000000","message":"Also we are using latest in other parts of the code:\n\nhttps://github.com/openstack/tenks/blob/d7312db645d1f62feff49f028ff2d89c1a882c73/ansible/roles/ironic-enrolment/tasks/main.yml#L12-L21","commit_id":"91541073ae446eac75fa4c78c08b1c31ee742fc8"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"13f94a1d5b8a57c96b83465f08889f49453194d3","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        cmd: \"{{ ansible_facts.python.executable }} -m venv {{ tenks_venv }}\""},{"line_number":32,"context_line":"        creates: \"{{ tenks_venv }}\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    - name: Upgrade pip"},{"line_number":35,"context_line":"      pip:"},{"line_number":36,"context_line":"        name: pip"},{"line_number":37,"context_line":"        state: latest"},{"line_number":38,"context_line":"        virtualenv: \"{{ tenks_venv }}\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    - name: Upgrade setuptools"},{"line_number":41,"context_line":"      pip:"},{"line_number":42,"context_line":"        name: setuptools"},{"line_number":43,"context_line":"        state: latest"},{"line_number":44,"context_line":"        virtualenv: \"{{ tenks_venv }}\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    - name: Install tenks deps"},{"line_number":47,"context_line":"      pip:"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"f1db1857_ffaa5a38","line":44,"range":{"start_line":34,"start_character":0,"end_line":44,"end_character":38},"in_reply_to":"fe5e476b_543f5583","updated":"2022-09-09 15:56:40.000000000","message":"Done","commit_id":"91541073ae446eac75fa4c78c08b1c31ee742fc8"}]}