)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b7f88be6b81a0fa806415404d738401f102f703d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8067086c_f6a043fb","updated":"2026-10-22 14:54:12.000000000","message":"The change looks good but I have one suggestion about the release note.\n\nAlso, do you mind reporting a bug so that users can discover this problem more easily ?","commit_id":"abf01c845147a4e4e691813206ad97f80416396c"},{"author":{"_account_id":39426,"name":"fivetime","display_name":"fivetime","email":"td@fivetime.ltd","username":"fivetime"},"change_message_id":"9a9192234005423ee6a2ecfe13320ed87b630f62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9bb44a22_7030353f","in_reply_to":"8067086c_f6a043fb","updated":"2026-10-24 05:25:04.000000000","message":"Reported as bug 2172097 and added Closes-Bug in PS2.","commit_id":"abf01c845147a4e4e691813206ad97f80416396c"}],"releasenotes/notes/etcd3gw-lock-lease-expired-3b7c1d9e4a2f6058.yaml":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b7f88be6b81a0fa806415404d738401f102f703d","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``etcd3gw`` driver now tells when the lease of a lock expired"},{"line_number":5,"context_line":"    before its heartbeat refreshed it (etcd out of reach, or the heart"},{"line_number":6,"context_line":"    late, for longer than the lease\u0027s TTL): etcd deleted the key with the"},{"line_number":7,"context_line":"    lease, so the lock is held no more. ``Lock.heartbeat()`` returns"},{"line_number":8,"context_line":"    ``False`` and the lock is not ``acquired`` any longer, with a warning"},{"line_number":9,"context_line":"    logged. Before, the refresh\u0027s answer was ignored and the lock was"},{"line_number":10,"context_line":"    reported as held while another holder could take it."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7d7bda81_1ca89541","line":9,"range":{"start_line":6,"start_character":44,"end_line":9,"end_character":11},"updated":"2026-10-22 14:54:12.000000000","message":"This is internal logic which developers using this library don\u0027t always care. Remove it and focus on describing the behavior only.","commit_id":"abf01c845147a4e4e691813206ad97f80416396c"},{"author":{"_account_id":39426,"name":"fivetime","display_name":"fivetime","email":"td@fivetime.ltd","username":"fivetime"},"change_message_id":"9a9192234005423ee6a2ecfe13320ed87b630f62","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    late, for longer than the lease\u0027s TTL): etcd deleted the key with the"},{"line_number":7,"context_line":"    lease, so the lock is held no more. ``Lock.heartbeat()`` returns"},{"line_number":8,"context_line":"    ``False`` and the lock is not ``acquired`` any longer, with a warning"},{"line_number":9,"context_line":"    logged. Before, the refresh\u0027s answer was ignored and the lock was"},{"line_number":10,"context_line":"    reported as held while another holder could take it."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ed49c666_1db577ec","line":9,"in_reply_to":"7d7bda81_1ca89541","updated":"2026-10-24 05:25:04.000000000","message":"Done in PS2: the note now describes only the behaviour users see.","commit_id":"abf01c845147a4e4e691813206ad97f80416396c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"21725f5abd271a7f6e8acb1d2ad8039716872d1d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8f856690_533dffcd","line":9,"range":{"start_line":6,"start_character":67,"end_line":9,"end_character":1},"updated":"2026-10-25 14:50:14.000000000","message":"Re-reading the full content... Could you also remove this part ? I think these are already enough implied by the first sentence.","commit_id":"c1191e0dd1d5908286ec0f433f93c88d35bb3616"}],"tooz/drivers/etcd3gw.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b7f88be6b81a0fa806415404d738401f102f703d","unresolved":true,"context_lines":[{"line_number":171,"context_line":"        with self._exclusive_access:"},{"line_number":172,"context_line":"            if self.acquired:"},{"line_number":173,"context_line":"                if self._lease.refresh() \u003d\u003d -1:"},{"line_number":174,"context_line":"                    # The lease expired before this refresh (etcd was out"},{"line_number":175,"context_line":"                    # of reach, or the heart late, for longer than its"},{"line_number":176,"context_line":"                    # TTL): etcd deleted the key with it, the lock is"},{"line_number":177,"context_line":"                    # held no more."},{"line_number":178,"context_line":"                    LOG.warning("},{"line_number":179,"context_line":"                        \u0027Lease %s of lock %s expired: the lock is lost\u0027,"},{"line_number":180,"context_line":"                        self._lease.id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f4e1d53_7f5b2675","line":177,"range":{"start_line":174,"start_character":0,"end_line":177,"end_character":35},"updated":"2026-10-22 14:54:12.000000000","message":"(nit) The situation can be understood from the log message below, so this can be removed.","commit_id":"abf01c845147a4e4e691813206ad97f80416396c"},{"author":{"_account_id":39426,"name":"fivetime","display_name":"fivetime","email":"td@fivetime.ltd","username":"fivetime"},"change_message_id":"9a9192234005423ee6a2ecfe13320ed87b630f62","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                    # The lease expired before this refresh (etcd was out"},{"line_number":175,"context_line":"                    # of reach, or the heart late, for longer than its"},{"line_number":176,"context_line":"                    # TTL): etcd deleted the key with it, the lock is"},{"line_number":177,"context_line":"                    # held no more."},{"line_number":178,"context_line":"                    LOG.warning("},{"line_number":179,"context_line":"                        \u0027Lease %s of lock %s expired: the lock is lost\u0027,"},{"line_number":180,"context_line":"                        self._lease.id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"6660f245_13960f1f","line":177,"in_reply_to":"1f4e1d53_7f5b2675","updated":"2026-10-24 05:25:04.000000000","message":"Done in PS2, removed.","commit_id":"abf01c845147a4e4e691813206ad97f80416396c"}]}
