)]}'
{"setup-sentinel-env.sh":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"3ff4e11b36e562df7dc8d8d2020e027775af8ba4","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    if [ -n \"$spawned\" ]; then"},{"line_number":10,"context_line":"        kill $(jobs -p)"},{"line_number":11,"context_line":"        rm $CONFFILE"},{"line_number":12,"context_line":"        #rm /tmp/sentinel.26381.log"},{"line_number":13,"context_line":"    fi"},{"line_number":14,"context_line":"    return $error_code"},{"line_number":15,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3a961159_173e8529","line":12,"updated":"2015-01-05 14:56:33.000000000","message":"?","commit_id":"6717b6114a85896a586421391895ff69f9988f7e"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"717bc6277dec15b5f1f6e182ed9eb3128f6de20c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    if [ -n \"$spawned\" ]; then"},{"line_number":10,"context_line":"        kill $(jobs -p)"},{"line_number":11,"context_line":"        rm $CONFFILE"},{"line_number":12,"context_line":"        #rm /tmp/sentinel.26381.log"},{"line_number":13,"context_line":"    fi"},{"line_number":14,"context_line":"    return $error_code"},{"line_number":15,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3a961159_b733f111","line":12,"in_reply_to":"3a961159_173e8529","updated":"2015-01-05 15:05:57.000000000","message":"whoops, left that commented for some debugging","commit_id":"6717b6114a85896a586421391895ff69f9988f7e"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"3ff4e11b36e562df7dc8d8d2020e027775af8ba4","unresolved":false,"context_lines":[{"line_number":31,"context_line":"if [ -n \"$redis_bin\" ]; then"},{"line_number":32,"context_line":"    $redis_bin --port 6381 \u0026"},{"line_number":33,"context_line":"fi"},{"line_number":34,"context_line":"if [ -n \"$sentinel_bin\" ]; then"},{"line_number":35,"context_line":"    $sentinel_bin $CONFFILE \u0026"},{"line_number":36,"context_line":"fi"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"3a961159_971195b1","line":34,"updated":"2015-01-05 14:56:33.000000000","message":"Looks like you should fail the test if we don\u0027t find the binaries actually.","commit_id":"6717b6114a85896a586421391895ff69f9988f7e"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"717bc6277dec15b5f1f6e182ed9eb3128f6de20c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"if [ -n \"$redis_bin\" ]; then"},{"line_number":32,"context_line":"    $redis_bin --port 6381 \u0026"},{"line_number":33,"context_line":"fi"},{"line_number":34,"context_line":"if [ -n \"$sentinel_bin\" ]; then"},{"line_number":35,"context_line":"    $sentinel_bin $CONFFILE \u0026"},{"line_number":36,"context_line":"fi"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"3a961159_1724c5c4","line":34,"in_reply_to":"3a961159_971195b1","updated":"2015-01-05 15:05:57.000000000","message":"True. What does that say about the file I copied this from (setup-redis*)","commit_id":"6717b6114a85896a586421391895ff69f9988f7e"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"52946e203d429ac83b58fbdfc50ef2f3f71493ca","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"set -x -e"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"CONFFILE\u003d$(mktemp)"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"function clean_exit(){"},{"line_number":7,"context_line":"    local error_code\u003d\"$?\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"3a961159_b2fadf74","line":4,"updated":"2015-01-07 11:13:45.000000000","message":"This is not a portable use of mktemp. You need to specify at least -t prefix or a template.","commit_id":"382c56c46479d44ccc69aa05169a5459113da29f"}],"tooz/drivers/redis.py":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"11f558526b3a4e7e7294564364044457316a1176","unresolved":false,"context_lines":[{"line_number":331,"context_line":"            sentinel_server \u003d sentinel.Sentinel("},{"line_number":332,"context_line":"                [(kwargs[\u0027host\u0027], kwargs[\u0027port\u0027])],"},{"line_number":333,"context_line":"                socket_timeout\u003dkwargs[\u0027socket_timeout\u0027])"},{"line_number":334,"context_line":"            master_host, master_port \u003d sentinel_server.discover_master("},{"line_number":335,"context_line":"                kwargs[\u0027sentinel\u0027])"},{"line_number":336,"context_line":"            kwargs[\u0027host\u0027] \u003d master_host"},{"line_number":337,"context_line":"            kwargs[\u0027port\u0027] \u003d master_port"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_19b6acf9","line":334,"updated":"2015-01-05 23:34:42.000000000","message":"Oh, found something, can u wrap this and re-raise a tooz exception instead.\n\nThis seems to potentially throw a redis-py exception that we\u0027ll need translated into a tooz equivalent.\n\nhttps://github.com/andymccurdy/redis-py/blob/master/redis/sentinel.py#L203\n\nMasterNotFoundError there might get thrown...","commit_id":"382c56c46479d44ccc69aa05169a5459113da29f"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"ec2ff510ab33ca608dcec938ce7340cc61bb8a8d","unresolved":false,"context_lines":[{"line_number":331,"context_line":"            sentinel_server \u003d sentinel.Sentinel("},{"line_number":332,"context_line":"                [(kwargs[\u0027host\u0027], kwargs[\u0027port\u0027])],"},{"line_number":333,"context_line":"                socket_timeout\u003dkwargs[\u0027socket_timeout\u0027])"},{"line_number":334,"context_line":"            master_host, master_port \u003d sentinel_server.discover_master("},{"line_number":335,"context_line":"                kwargs[\u0027sentinel\u0027])"},{"line_number":336,"context_line":"            kwargs[\u0027host\u0027] \u003d master_host"},{"line_number":337,"context_line":"            kwargs[\u0027port\u0027] \u003d master_port"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_1c5a1af2","line":334,"in_reply_to":"3a961159_19b6acf9","updated":"2015-01-06 00:00:26.000000000","message":"MasterNotFound isa ConnectionError is a RedisError so the except clause in _start will catch it and reraise as a ToozConnectionError. Is that sufficient  or is a bit more massaging of the message required?","commit_id":"382c56c46479d44ccc69aa05169a5459113da29f"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"90ac9b47c25a8e62e1580344dcd497d27eead48e","unresolved":false,"context_lines":[{"line_number":331,"context_line":"            sentinel_server \u003d sentinel.Sentinel("},{"line_number":332,"context_line":"                [(kwargs[\u0027host\u0027], kwargs[\u0027port\u0027])],"},{"line_number":333,"context_line":"                socket_timeout\u003dkwargs[\u0027socket_timeout\u0027])"},{"line_number":334,"context_line":"            master_host, master_port \u003d sentinel_server.discover_master("},{"line_number":335,"context_line":"                kwargs[\u0027sentinel\u0027])"},{"line_number":336,"context_line":"            kwargs[\u0027host\u0027] \u003d master_host"},{"line_number":337,"context_line":"            kwargs[\u0027port\u0027] \u003d master_port"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a961159_78ff8302","line":334,"in_reply_to":"3a961159_1c5a1af2","updated":"2015-01-07 02:51:39.000000000","message":"Ah, thanks for point that out. All good then.","commit_id":"382c56c46479d44ccc69aa05169a5459113da29f"}]}