)]}'
{"tooz/coordination.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"b5e35739b740bb02cf65e4ce3962e7a7bf6838fb","unresolved":false,"context_lines":[{"line_number":356,"context_line":"    if kwargs:"},{"line_number":357,"context_line":"        options \u003d {}"},{"line_number":358,"context_line":"        for (k, v) in six.iteritems(kwargs):"},{"line_number":359,"context_line":"            options[k] \u003d [v]"},{"line_number":360,"context_line":"        for (k, v) in six.iteritems(parsed_qs):"},{"line_number":361,"context_line":"            if k not in options:"},{"line_number":362,"context_line":"                options[k] \u003d v"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_4fa9c18f","line":359,"updated":"2015-02-13 09:32:50.000000000","message":"Is that options.update(kwargs) or options \u003d kwargs.copy() ?","commit_id":"60bf3af5879e5f5df1a6be69f98e714ed9c17212"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"4b9c30c53451f024a6d9e87529898153f8b67ae0","unresolved":false,"context_lines":[{"line_number":356,"context_line":"    if kwargs:"},{"line_number":357,"context_line":"        options \u003d {}"},{"line_number":358,"context_line":"        for (k, v) in six.iteritems(kwargs):"},{"line_number":359,"context_line":"            options[k] \u003d [v]"},{"line_number":360,"context_line":"        for (k, v) in six.iteritems(parsed_qs):"},{"line_number":361,"context_line":"            if k not in options:"},{"line_number":362,"context_line":"                options[k] \u003d v"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_713ada99","line":359,"in_reply_to":"da86d52c_401b42ca","updated":"2015-02-13 17:04:57.000000000","message":"haha I missed the []!","commit_id":"60bf3af5879e5f5df1a6be69f98e714ed9c17212"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"3a43f55b8306449ef2c3083a4d41e8388d3febe3","unresolved":false,"context_lines":[{"line_number":356,"context_line":"    if kwargs:"},{"line_number":357,"context_line":"        options \u003d {}"},{"line_number":358,"context_line":"        for (k, v) in six.iteritems(kwargs):"},{"line_number":359,"context_line":"            options[k] \u003d [v]"},{"line_number":360,"context_line":"        for (k, v) in six.iteritems(parsed_qs):"},{"line_number":361,"context_line":"            if k not in options:"},{"line_number":362,"context_line":"                options[k] \u003d v"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_401b42ca","line":359,"in_reply_to":"da86d52c_4fa9c18f","updated":"2015-02-13 16:19:04.000000000","message":"It was almost; except pretty much all later users of options are doing something like options[\u0027blah\u0027][-1] due to how parsed_qs (aka the options) retains more than 1 value (if it exists in the query string). So this loop ensures that we also turn the provided kwargs into something that later coordinators will know how to process (aka by putting the value into an array of a single element). If I just did options.update(kwargs) then a later user of options[\u0027blah\u0027][-1] would potentially blowup if options[\u0027blah\u0027] is not an array...\n\nIMHO we should probably fix the above usage in coordinators to stop doing options[\u0027blah\u0027][-1] anyway, but thats a bigger change :-P","commit_id":"60bf3af5879e5f5df1a6be69f98e714ed9c17212"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"b5e35739b740bb02cf65e4ce3962e7a7bf6838fb","unresolved":false,"context_lines":[{"line_number":359,"context_line":"            options[k] \u003d [v]"},{"line_number":360,"context_line":"        for (k, v) in six.iteritems(parsed_qs):"},{"line_number":361,"context_line":"            if k not in options:"},{"line_number":362,"context_line":"                options[k] \u003d v"},{"line_number":363,"context_line":"    else:"},{"line_number":364,"context_line":"        options \u003d parsed_qs"},{"line_number":365,"context_line":"    return driver.DriverManager("}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_8f79f932","line":362,"updated":"2015-02-13 09:32:50.000000000","message":"setdefault?","commit_id":"60bf3af5879e5f5df1a6be69f98e714ed9c17212"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"3a43f55b8306449ef2c3083a4d41e8388d3febe3","unresolved":false,"context_lines":[{"line_number":359,"context_line":"            options[k] \u003d [v]"},{"line_number":360,"context_line":"        for (k, v) in six.iteritems(parsed_qs):"},{"line_number":361,"context_line":"            if k not in options:"},{"line_number":362,"context_line":"                options[k] \u003d v"},{"line_number":363,"context_line":"    else:"},{"line_number":364,"context_line":"        options \u003d parsed_qs"},{"line_number":365,"context_line":"    return driver.DriverManager("}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_c08652db","line":362,"in_reply_to":"da86d52c_8f79f932","updated":"2015-02-13 16:19:04.000000000","message":"Almost did that, but was like meh.","commit_id":"60bf3af5879e5f5df1a6be69f98e714ed9c17212"}]}