)]}'
{"setup-mysql-env.sh":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"93970250bd5d875f26bd98cc73d3cafaa2db9be9","unresolved":false,"context_lines":[{"line_number":28,"context_line":"# Initialize MySQL Data Directory"},{"line_number":29,"context_line":"mysql_install_db --user\u003d${USER} --ldata\u003d${MYSQL_DATA}"},{"line_number":30,"context_line":"# Start mysqld with networking (i.e. - allow connection with TCP/IP)"},{"line_number":31,"context_line":"mysqld --datadir\u003d${MYSQL_DATA} --port\u003d3306 --pid-file\u003d${MYSQL_DATA}/mysql.pid --socket\u003d${MYSQL_DATA}/mysql.socket --slow-query-log-file\u003d${MYSQL_DATA}/mysql-slow.log \u0026\u003e ${MYSQL_DATA}/out \u0026"},{"line_number":32,"context_line":"# Wait for MySQL to start listening to connections"},{"line_number":33,"context_line":"wait_for_line \"mysqld: ready for connections.\" ${MYSQL_DATA}/out"},{"line_number":34,"context_line":"# The default root password is blank"}],"source_content_type":"text/x-sh","patch_set":6,"id":"9a80dd14_dc763fd8","line":31,"updated":"2015-03-04 14:17:34.000000000","message":"Can you remove the socket argument if we are not using it again?","commit_id":"2a298707e945afbb1d896ea07026215c4019e3c8"},{"author":{"_account_id":8300,"name":"Abhijeet Malawade","email":"abhijeet.malawade@gmail.com","username":"abhijeet"},"change_message_id":"b3f67f84d911975700d4b96d66f853e5c90c717f","unresolved":false,"context_lines":[{"line_number":28,"context_line":"# Initialize MySQL Data Directory"},{"line_number":29,"context_line":"mysql_install_db --user\u003d${USER} --ldata\u003d${MYSQL_DATA}"},{"line_number":30,"context_line":"# Start mysqld with networking (i.e. - allow connection with TCP/IP)"},{"line_number":31,"context_line":"mysqld --datadir\u003d${MYSQL_DATA} --port\u003d3306 --pid-file\u003d${MYSQL_DATA}/mysql.pid --socket\u003d${MYSQL_DATA}/mysql.socket --slow-query-log-file\u003d${MYSQL_DATA}/mysql-slow.log \u0026\u003e ${MYSQL_DATA}/out \u0026"},{"line_number":32,"context_line":"# Wait for MySQL to start listening to connections"},{"line_number":33,"context_line":"wait_for_line \"mysqld: ready for connections.\" ${MYSQL_DATA}/out"},{"line_number":34,"context_line":"# The default root password is blank"}],"source_content_type":"text/x-sh","patch_set":6,"id":"9a80dd14_f30fae2c","line":31,"in_reply_to":"9a80dd14_dc763fd8","updated":"2015-03-04 15:33:33.000000000","message":"IMO this socket argument is required to start \u0027mysqld\u0027 properly.\n\nAfter removing \u0027--socket\u0027 argument I am getting bellow error while running test cases:\n\n+ echo \u0027150304  7:25:25 [ERROR] Can\u0027\\\u0027\u0027t start server : Bind on unix socket: Permission denied\u0027\n\n+ grep -q \u0027mysqld: ready for connections.\u0027\n+ read line\n\n+ echo \u0027150304  7:25:25 [ERROR] Do you already have another mysqld server running on socket: /var/run/mysqld/mysqld.sock ?\u0027","commit_id":"2a298707e945afbb1d896ea07026215c4019e3c8"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"ecf688ef0ddf963e2c4c23290151a2db06e650aa","unresolved":false,"context_lines":[{"line_number":28,"context_line":"# Initialize MySQL Data Directory"},{"line_number":29,"context_line":"mysql_install_db --user\u003d${USER} --ldata\u003d${MYSQL_DATA}"},{"line_number":30,"context_line":"# Start mysqld with networking (i.e. - allow connection with TCP/IP)"},{"line_number":31,"context_line":"mysqld --datadir\u003d${MYSQL_DATA} --port\u003d3306 --pid-file\u003d${MYSQL_DATA}/mysql.pid --socket\u003d${MYSQL_DATA}/mysql.socket --slow-query-log-file\u003d${MYSQL_DATA}/mysql-slow.log \u0026\u003e ${MYSQL_DATA}/out \u0026"},{"line_number":32,"context_line":"# Wait for MySQL to start listening to connections"},{"line_number":33,"context_line":"wait_for_line \"mysqld: ready for connections.\" ${MYSQL_DATA}/out"},{"line_number":34,"context_line":"# The default root password is blank"}],"source_content_type":"text/x-sh","patch_set":6,"id":"9a80dd14_ae5f8d71","line":31,"in_reply_to":"9a80dd14_f30fae2c","updated":"2015-03-04 16:04:02.000000000","message":"Right, then don\u0027t touch it :)","commit_id":"2a298707e945afbb1d896ea07026215c4019e3c8"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"93970250bd5d875f26bd98cc73d3cafaa2db9be9","unresolved":false,"context_lines":[{"line_number":33,"context_line":"wait_for_line \"mysqld: ready for connections.\" ${MYSQL_DATA}/out"},{"line_number":34,"context_line":"# The default root password is blank"},{"line_number":35,"context_line":"mysql --user\u003droot --password\u003d  -S ${MYSQL_DATA}/mysql.socket -e \u0027CREATE DATABASE IF NOT EXISTS test;\u0027"},{"line_number":36,"context_line":"export TOOZ_TEST_MYSQL_URL\u003d\"mysql://root@localhost:3306/test\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":" #Yield execution to venv command"},{"line_number":39,"context_line":"$*"}],"source_content_type":"text/x-sh","patch_set":6,"id":"9a80dd14_bc498b8d","line":36,"updated":"2015-03-04 14:17:34.000000000","message":"Not sure that port is the best as it\u0027s the default, maybe pick a random unused one?","commit_id":"2a298707e945afbb1d896ea07026215c4019e3c8"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"c7df40c86856d441695c52680fc075f2df4a46dc","unresolved":false,"context_lines":[{"line_number":34,"context_line":"# The default root password is blank"},{"line_number":35,"context_line":"mysql --user\u003droot --password\u003d  -S ${MYSQL_DATA}/mysql.socket -e \u0027CREATE DATABASE IF NOT EXISTS test;\u0027"},{"line_number":36,"context_line":"export TOOZ_TEST_MYSQL_URL\u003d\"mysql://root@localhost:3306/test\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":" #Yield execution to venv command"},{"line_number":39,"context_line":"$*"}],"source_content_type":"text/x-sh","patch_set":6,"id":"9a80dd14_9572dfe3","line":37,"updated":"2015-03-04 13:25:25.000000000","message":"It\u0027s not clear to me why you changed this file.","commit_id":"2a298707e945afbb1d896ea07026215c4019e3c8"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"93970250bd5d875f26bd98cc73d3cafaa2db9be9","unresolved":false,"context_lines":[{"line_number":34,"context_line":"# The default root password is blank"},{"line_number":35,"context_line":"mysql --user\u003droot --password\u003d  -S ${MYSQL_DATA}/mysql.socket -e \u0027CREATE DATABASE IF NOT EXISTS test;\u0027"},{"line_number":36,"context_line":"export TOOZ_TEST_MYSQL_URL\u003d\"mysql://root@localhost:3306/test\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":" #Yield execution to venv command"},{"line_number":39,"context_line":"$*"}],"source_content_type":"text/x-sh","patch_set":6,"id":"9a80dd14_fcace337","line":37,"in_reply_to":"9a80dd14_7909e594","updated":"2015-03-04 14:17:34.000000000","message":"Ok that makes sense, let\u0027s do that!","commit_id":"2a298707e945afbb1d896ea07026215c4019e3c8"},{"author":{"_account_id":8300,"name":"Abhijeet Malawade","email":"abhijeet.malawade@gmail.com","username":"abhijeet"},"change_message_id":"4a0b30c381cea5a1dc1d112b8fff89bd6b514864","unresolved":false,"context_lines":[{"line_number":34,"context_line":"# The default root password is blank"},{"line_number":35,"context_line":"mysql --user\u003droot --password\u003d  -S ${MYSQL_DATA}/mysql.socket -e \u0027CREATE DATABASE IF NOT EXISTS test;\u0027"},{"line_number":36,"context_line":"export TOOZ_TEST_MYSQL_URL\u003d\"mysql://root@localhost:3306/test\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":" #Yield execution to venv command"},{"line_number":39,"context_line":"$*"}],"source_content_type":"text/x-sh","patch_set":6,"id":"9a80dd14_7909e594","line":37,"in_reply_to":"9a80dd14_9572dfe3","updated":"2015-03-04 13:43:15.000000000","message":"Hi Julien,\n\nPreviously it is using unix socket for connection, because of this even if you give invalid port number or hostname test cases are passing.\n\nTo test if hostname, username and port are valid we need to run mysql with networking, and need to remove \u0027unix_socket\u0027 parameter from \u0027TOOZ_TEST_MYSQL_URL\u0027.","commit_id":"2a298707e945afbb1d896ea07026215c4019e3c8"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"93970250bd5d875f26bd98cc73d3cafaa2db9be9","unresolved":false,"context_lines":[{"line_number":35,"context_line":"mysql --user\u003droot --password\u003d  -S ${MYSQL_DATA}/mysql.socket -e \u0027CREATE DATABASE IF NOT EXISTS test;\u0027"},{"line_number":36,"context_line":"export TOOZ_TEST_MYSQL_URL\u003d\"mysql://root@localhost:3306/test\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":" #Yield execution to venv command"},{"line_number":39,"context_line":"$*"}],"source_content_type":"text/x-sh","patch_set":6,"id":"9a80dd14_dcaf1f2a","line":38,"updated":"2015-03-04 14:17:34.000000000","message":"unrelated change","commit_id":"2a298707e945afbb1d896ea07026215c4019e3c8"}],"test-requirements.txt":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"a3e54fe29963b5a218721c095855ab843deff704","unresolved":false,"context_lines":[{"line_number":14,"context_line":"testscenarios\u003e\u003d0.4"},{"line_number":15,"context_line":"coverage\u003e\u003d3.6"},{"line_number":16,"context_line":"psycopg2"},{"line_number":17,"context_line":"PyMySQL\u003e\u003d0.6.2"},{"line_number":18,"context_line":"sysv_ipc\u003e\u003d0.6.8"}],"source_content_type":"text/plain","patch_set":4,"id":"ba7be1f8_c0ad228a","side":"PARENT","line":17,"updated":"2015-03-02 10:30:36.000000000","message":"This is in test-requirements for a good reason, we don\u0027t force the installation of all drivers","commit_id":"47f831fb1c1f86c18ff98c2ed0c5f75f97d557d1"}],"tooz/tests/test_mysql.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"b160490ff22412c63e51e57e9160e8010cff85c2","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    MYSQL_URL \u003d os.getenv(\"TOOZ_TEST_MYSQL_URL\")"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def _create_coordinator(self, url):"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        def _safe_stop(coord):"},{"line_number":38,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_3a642d21","line":35,"updated":"2015-03-03 12:26:28.000000000","message":"This should be a setUp() I guess.","commit_id":"990f00f2c39b0776de6d6a406c9d3f28b4c6b4a8"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"b160490ff22412c63e51e57e9160e8010cff85c2","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    def test_connect_failure_invalid_db_name_provided(self):"},{"line_number":67,"context_line":"        url \u003d self.MYSQL_URL.replace(\u0027test\u0027, \u0027invalid\u0027)"},{"line_number":68,"context_line":"        c \u003d self._create_coordinator(url)"},{"line_number":69,"context_line":"        self.assertRaises(pymysql.InternalError, c.start)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def test_connect_success(self):"},{"line_number":72,"context_line":"        c \u003d self._create_coordinator(self.MYSQL_URL)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba7be1f8_daadd132","line":69,"updated":"2015-03-03 12:26:28.000000000","message":"This is a bug, I think it should be a ToozConnectionError. Could you fix that in the driver too?","commit_id":"990f00f2c39b0776de6d6a406c9d3f28b4c6b4a8"}]}