)]}'
{"tooz/drivers/zookeeper.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"4a6f1e53502af0ed40fda4be2a4e96055b2631a5","unresolved":false,"context_lines":[{"line_number":358,"context_line":"        # See: https://github.com/python-zk/kazoo/blob/2.2.1/kazoo/client.py"},{"line_number":359,"context_line":"        # for what options a client takes..."},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"        def _do_extract_option(key, convert_to_type\u003dNone, default\u003dNone):"},{"line_number":362,"context_line":"            try:"},{"line_number":363,"context_line":"                value \u003d options[key]"},{"line_number":364,"context_line":"            except KeyError:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_0a8404d2","line":361,"updated":"2015-09-15 09:37:59.000000000","message":"You don\u0027t _really_ need a closure here, making the interpreter compile that over and over again isn\u0027t really friendly. :p","commit_id":"7c0ac5b78f82507c756ebd86c9498cdb6ad81d93"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"733b48afd1de55736f6ee5f371f9cfdaff57dc78","unresolved":false,"context_lines":[{"line_number":358,"context_line":"        # See: https://github.com/python-zk/kazoo/blob/2.2.1/kazoo/client.py"},{"line_number":359,"context_line":"        # for what options a client takes..."},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"        def _do_extract_option(key, convert_to_type\u003dNone, default\u003dNone):"},{"line_number":362,"context_line":"            try:"},{"line_number":363,"context_line":"                value \u003d options[key]"},{"line_number":364,"context_line":"            except KeyError:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_ad78802c","line":361,"in_reply_to":"ba15a1d1_0a8404d2","updated":"2015-09-15 15:31:43.000000000","message":"But but but, ok, ha.","commit_id":"7c0ac5b78f82507c756ebd86c9498cdb6ad81d93"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"4a6f1e53502af0ed40fda4be2a4e96055b2631a5","unresolved":false,"context_lines":[{"line_number":359,"context_line":"        # for what options a client takes..."},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"        def _do_extract_option(key, convert_to_type\u003dNone, default\u003dNone):"},{"line_number":362,"context_line":"            try:"},{"line_number":363,"context_line":"                value \u003d options[key]"},{"line_number":364,"context_line":"            except KeyError:"},{"line_number":365,"context_line":"                return default"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_9d5e1c11","line":362,"updated":"2015-09-15 09:37:59.000000000","message":"Ok you can also write:\n\nreturn convert_to_type(getattr(options, key, default))\n\nand have convert_to_type be the identity function (lambda x: x).\n\nJust saying. You\u0027ll just reduce 10 lines to 1. :p","commit_id":"7c0ac5b78f82507c756ebd86c9498cdb6ad81d93"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"733b48afd1de55736f6ee5f371f9cfdaff57dc78","unresolved":false,"context_lines":[{"line_number":359,"context_line":"        # for what options a client takes..."},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"        def _do_extract_option(key, convert_to_type\u003dNone, default\u003dNone):"},{"line_number":362,"context_line":"            try:"},{"line_number":363,"context_line":"                value \u003d options[key]"},{"line_number":364,"context_line":"            except KeyError:"},{"line_number":365,"context_line":"                return default"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_8d7d7c1e","line":362,"in_reply_to":"ba15a1d1_9d5e1c11","updated":"2015-09-15 15:31:43.000000000","message":"Fair enough :)","commit_id":"7c0ac5b78f82507c756ebd86c9498cdb6ad81d93"}]}
