)]}'
{"tooz/drivers/redis.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"3d0194ec7f2775fa83c0e5063003e8c8c3f60595","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            acquired \u003d self._lock.acquire("},{"line_number":87,"context_line":"                blocking\u003dblocking, blocking_timeout\u003dtimeout)"},{"line_number":88,"context_line":"            if acquired:"},{"line_number":89,"context_line":"                with self._exclusive_access:"},{"line_number":90,"context_line":"                    self._coord._acquired_locks.add(self)"},{"line_number":91,"context_line":"            return acquired"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_690fdd87","line":89,"updated":"2017-03-29 15:32:26.000000000","message":"it is intended that \u0027acquire\u0027 pattern to be different than \u0027release\u0027 and \u0027heartbeat\u0027 seems we lock more around those?","commit_id":"059f2ae5406a325017ad181ace1e5b7c5bff0d22"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"d3def4fada7f16b0e14fec65d76c38f4f83481c7","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            acquired \u003d self._lock.acquire("},{"line_number":87,"context_line":"                blocking\u003dblocking, blocking_timeout\u003dtimeout)"},{"line_number":88,"context_line":"            if acquired:"},{"line_number":89,"context_line":"                with self._exclusive_access:"},{"line_number":90,"context_line":"                    self._coord._acquired_locks.add(self)"},{"line_number":91,"context_line":"            return acquired"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_ec153b3e","line":89,"in_reply_to":"ffe62b97_690fdd87","updated":"2017-03-29 15:39:56.000000000","message":"Yes it is. The previous version was locking too much, preventing the wait to happen on line 86.\n\nThen what we don\u0027t want is this operation on line 90 to happen in a thread while another thread is doing lines 97-103 basically. By locking this lock, this prevents it. same with heartbeat()","commit_id":"059f2ae5406a325017ad181ace1e5b7c5bff0d22"}]}