)]}'
{"tooz/hashring.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"507fad1f6769b54238e901285269017011efee0e","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        replicas \u003d min(replicas, len(candidates))"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        nodes \u003d set()"},{"line_number":130,"context_line":"        while len(nodes) \u003c replicas:"},{"line_number":131,"context_line":"            node \u003d self._get_node(partition)"},{"line_number":132,"context_line":"            if node not in nodes and node not in ignore_nodes:"},{"line_number":133,"context_line":"                nodes.add(node)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_a29ebcb5","line":130,"updated":"2017-04-02 10:11:56.000000000","message":"not sure the condition is the same here as if the numbers of nodes in the ring is \u003c replicas this will loop forever, no?","commit_id":"eea0a1167ab6ad8e88979b12911d98edda124f9d"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"ff52ea8fe385cfb05f615e03fbe4c908c9416a28","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        replicas \u003d min(replicas, len(candidates))"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        nodes \u003d set()"},{"line_number":130,"context_line":"        while len(nodes) \u003c replicas:"},{"line_number":131,"context_line":"            node \u003d self._get_node(partition)"},{"line_number":132,"context_line":"            if node not in nodes and node not in ignore_nodes:"},{"line_number":133,"context_line":"                nodes.add(node)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_13b93c2d","line":130,"in_reply_to":"dfeb2761_a29ebcb5","updated":"2017-04-02 17:44:58.000000000","message":"i wondered that question as well :)\n\nline 127 is the safety catch which ensures replicas will always be less than equal total possible nodes.","commit_id":"eea0a1167ab6ad8e88979b12911d98edda124f9d"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"507fad1f6769b54238e901285269017011efee0e","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        nodes \u003d set()"},{"line_number":130,"context_line":"        while len(nodes) \u003c replicas:"},{"line_number":131,"context_line":"            node \u003d self._get_node(partition)"},{"line_number":132,"context_line":"            if node not in nodes and node not in ignore_nodes:"},{"line_number":133,"context_line":"                nodes.add(node)"},{"line_number":134,"context_line":"            partition \u003d (partition + 1"},{"line_number":135,"context_line":"                         if partition + 1 \u003c len(self._partitions) else 0)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_426a50b3","line":132,"range":{"start_line":132,"start_character":15,"end_line":132,"end_character":32},"updated":"2017-04-02 10:11:56.000000000","message":"that\u0027s not really useful since it\u0027s a set :)","commit_id":"eea0a1167ab6ad8e88979b12911d98edda124f9d"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"ff52ea8fe385cfb05f615e03fbe4c908c9416a28","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        nodes \u003d set()"},{"line_number":130,"context_line":"        while len(nodes) \u003c replicas:"},{"line_number":131,"context_line":"            node \u003d self._get_node(partition)"},{"line_number":132,"context_line":"            if node not in nodes and node not in ignore_nodes:"},{"line_number":133,"context_line":"                nodes.add(node)"},{"line_number":134,"context_line":"            partition \u003d (partition + 1"},{"line_number":135,"context_line":"                         if partition + 1 \u003c len(self._partitions) else 0)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_33aa00d2","line":132,"range":{"start_line":132,"start_character":15,"end_line":132,"end_character":32},"in_reply_to":"dfeb2761_426a50b3","updated":"2017-04-02 17:44:58.000000000","message":"you\u0027re right. i\u0027ll remove it.","commit_id":"eea0a1167ab6ad8e88979b12911d98edda124f9d"}]}