)]}'
{"setup.cfg":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"1feefee49101c9fe9b9efeb7a65b52ec19b8956f","unresolved":false,"context_lines":[{"line_number":48,"context_line":"etcd \u003d"},{"line_number":49,"context_line":"  requests\u003e\u003d2.10.0 # Apache-2.0"},{"line_number":50,"context_line":"etcd3 \u003d"},{"line_number":51,"context_line":"  etcd3\u003e\u003d0.12.0 # Apache-2.0"},{"line_number":52,"context_line":"  grpcio\u003e\u003d1.18.0"},{"line_number":53,"context_line":"etcd3gw \u003d"},{"line_number":54,"context_line":"  etcd3gw\u003e\u003d0.1.0 # Apache-2.0"}],"source_content_type":"text/x-ttcn-cfg","patch_set":8,"id":"df33271e_0bbffcd0","line":51,"range":{"start_line":51,"start_character":2,"end_line":51,"end_character":28},"updated":"2020-04-01 14:17:45.000000000","message":"Looks fine\n\nhttps://github.com/kragniz/python-etcd3/releases/tag/v0.12.0","commit_id":"a598cce62b7764e4ba31f47bde2b745633f33688"}],"test-requirements.txt":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"30143f1fb08b7a5b5887962c4d257e6911ef9b20","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# The order of packages is significant, because pip processes them in the order"},{"line_number":3,"context_line":"# of appearance. Changing the order has an impact on the overall integration"},{"line_number":4,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":5,"context_line":"mock\u003e\u003d2.0 # BSD"},{"line_number":6,"context_line":"python-subunit\u003e\u003d0.0.18 # Apache-2.0/BSD"},{"line_number":7,"context_line":"testtools\u003e\u003d1.4.0 # MIT"},{"line_number":8,"context_line":"coverage\u003e\u003d3.6 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":4,"id":"df33271e_6ecc71bc","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":15},"updated":"2020-03-24 17:17:10.000000000","message":"Not directly related but could be dropped in a follow up patch","commit_id":"d587968e6a51e7873040c691299ba451949f3179"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"3e455530c998a0acfce6c770829e3d67e65b92fc","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# The order of packages is significant, because pip processes them in the order"},{"line_number":3,"context_line":"# of appearance. Changing the order has an impact on the overall integration"},{"line_number":4,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":5,"context_line":"mock\u003e\u003d2.0 # BSD"},{"line_number":6,"context_line":"python-subunit\u003e\u003d0.0.18 # Apache-2.0/BSD"},{"line_number":7,"context_line":"testtools\u003e\u003d1.4.0 # MIT"},{"line_number":8,"context_line":"coverage\u003e\u003d3.6 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":4,"id":"df33271e_519e7256","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":15},"in_reply_to":"df33271e_6ecc71bc","updated":"2020-03-24 18:03:33.000000000","message":"Looks like several unit test files will need to be updated, so agree the cleanup should be handled in a different patch.","commit_id":"d587968e6a51e7873040c691299ba451949f3179"}],"tooz/drivers/etcd3.py":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"d60c62e640d03ad0669d04435167d624914fab84","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":127,"context_line":"    Name                Default"},{"line_number":128,"context_line":"    \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":129,"context_line":"    protocol            http"},{"line_number":130,"context_line":"    timeout             30"},{"line_number":131,"context_line":"    lock_timeout        30"},{"line_number":132,"context_line":"    membership_timeout  30"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_36ad1088","side":"PARENT","line":129,"updated":"2020-03-02 16:06:47.000000000","message":"Oops, it looks like I copy-pasted this from the etcd driver. I\u0027ll push a patch to remove it from the etcd3gw driver too since it also doesn\u0027t seem to apply there.","commit_id":"ba27954b0645398dc7ccd297d47343464f4b1268"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"38164ca7af2e2c73a71df2cade5b5afec0414512","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":127,"context_line":"    Name                Default"},{"line_number":128,"context_line":"    \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":129,"context_line":"    protocol            http"},{"line_number":130,"context_line":"    timeout             30"},{"line_number":131,"context_line":"    lock_timeout        30"},{"line_number":132,"context_line":"    membership_timeout  30"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_6db2d696","side":"PARENT","line":129,"in_reply_to":"1fa4df85_36ad1088","updated":"2020-03-02 17:05:51.000000000","message":"Are you sure? Because I thought the etcd3gw driver does need it!","commit_id":"ba27954b0645398dc7ccd297d47343464f4b1268"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"44379d173c0058c12b5207a81aff94b465df3740","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":127,"context_line":"    Name                Default"},{"line_number":128,"context_line":"    \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":129,"context_line":"    protocol            http"},{"line_number":130,"context_line":"    timeout             30"},{"line_number":131,"context_line":"    lock_timeout        30"},{"line_number":132,"context_line":"    membership_timeout  30"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_9984300e","side":"PARENT","line":129,"in_reply_to":"1fa4df85_60b2dd96","updated":"2020-03-02 21:26:49.000000000","message":"Yeah, etcd3gw does use a protocol value, but it isn\u0027t an option on the connection string so it shouldn\u0027t be listed here.","commit_id":"ba27954b0645398dc7ccd297d47343464f4b1268"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"6b0a10a2efd06d9b4c60b623fb4da501c2706ad7","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":127,"context_line":"    Name                Default"},{"line_number":128,"context_line":"    \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":129,"context_line":"    protocol            http"},{"line_number":130,"context_line":"    timeout             30"},{"line_number":131,"context_line":"    lock_timeout        30"},{"line_number":132,"context_line":"    membership_timeout  30"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_60b2dd96","side":"PARENT","line":129,"in_reply_to":"1fa4df85_6db2d696","updated":"2020-03-02 17:44:42.000000000","message":"Oh, I see. I\u0027ll suggest something for that in my next patchset.","commit_id":"ba27954b0645398dc7ccd297d47343464f4b1268"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"d60c62e640d03ad0669d04435167d624914fab84","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":129,"context_line":"    ca_cert             None"},{"line_number":130,"context_line":"    cert_key            None"},{"line_number":131,"context_line":"    cert_cert           None"},{"line_number":132,"context_line":"    timeout             30"},{"line_number":133,"context_line":"    lock_timeout        30"},{"line_number":134,"context_line":"    membership_timeout  30"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_ea054cc3","line":131,"range":{"start_line":131,"start_character":4,"end_line":131,"end_character":13},"updated":"2020-03-02 16:06:47.000000000","message":"This name is bothering me quite a bit. Could we call these tls_key and tls_cert or something like that instead?","commit_id":"d4ef3e75670d5883463c98ea5387a2c75e8d6a86"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"38164ca7af2e2c73a71df2cade5b5afec0414512","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":129,"context_line":"    ca_cert             None"},{"line_number":130,"context_line":"    cert_key            None"},{"line_number":131,"context_line":"    cert_cert           None"},{"line_number":132,"context_line":"    timeout             30"},{"line_number":133,"context_line":"    lock_timeout        30"},{"line_number":134,"context_line":"    membership_timeout  30"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_ed31e60c","line":131,"range":{"start_line":131,"start_character":4,"end_line":131,"end_character":13},"in_reply_to":"1fa4df85_ea054cc3","updated":"2020-03-02 17:05:51.000000000","message":"I deliberately chose the same names used by etcd3\u0027s client. Are you sure you want me to change them here? I would think that naming them differently would be confusing to some people.","commit_id":"d4ef3e75670d5883463c98ea5387a2c75e8d6a86"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"44379d173c0058c12b5207a81aff94b465df3740","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d  \u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":129,"context_line":"    ca_cert             None"},{"line_number":130,"context_line":"    cert_key            None"},{"line_number":131,"context_line":"    cert_cert           None"},{"line_number":132,"context_line":"    timeout             30"},{"line_number":133,"context_line":"    lock_timeout        30"},{"line_number":134,"context_line":"    membership_timeout  30"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_79cb7471","line":131,"range":{"start_line":131,"start_character":4,"end_line":131,"end_character":13},"in_reply_to":"1fa4df85_ed31e60c","updated":"2020-03-02 21:26:49.000000000","message":"Oh, I didn\u0027t notice that. In that case I agree consistency with the etcd driver is good.\n\nI still don\u0027t like the name they picked though. :-)","commit_id":"d4ef3e75670d5883463c98ea5387a2c75e8d6a86"}],"tooz/drivers/etcd3gw.py":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"d60c62e640d03ad0669d04435167d624914fab84","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        super(Etcd3Lock, self).__init__(name)"},{"line_number":71,"context_line":"        self._timeout \u003d timeout"},{"line_number":72,"context_line":"        self._coord \u003d coord"},{"line_number":73,"context_line":"        self._key \u003d self.LOCK_PREFIX + utils.to_binary(name)"},{"line_number":74,"context_line":"        self._key_b64 \u003d _encode(self._key)"},{"line_number":75,"context_line":"        self._uuid \u003d _encode(uuid.uuid4().bytes)"},{"line_number":76,"context_line":"        self._exclusive_access \u003d threading.Lock()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_b6e7c0e4","line":73,"updated":"2020-03-02 16:06:47.000000000","message":"Was this to fix an unrelated bug? It looks right, but it doesn\u0027t seem related to SSL support.","commit_id":"d4ef3e75670d5883463c98ea5387a2c75e8d6a86"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"38164ca7af2e2c73a71df2cade5b5afec0414512","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        super(Etcd3Lock, self).__init__(name)"},{"line_number":71,"context_line":"        self._timeout \u003d timeout"},{"line_number":72,"context_line":"        self._coord \u003d coord"},{"line_number":73,"context_line":"        self._key \u003d self.LOCK_PREFIX + utils.to_binary(name)"},{"line_number":74,"context_line":"        self._key_b64 \u003d _encode(self._key)"},{"line_number":75,"context_line":"        self._uuid \u003d _encode(uuid.uuid4().bytes)"},{"line_number":76,"context_line":"        self._exclusive_access \u003d threading.Lock()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_cd174a51","line":73,"in_reply_to":"1fa4df85_b6e7c0e4","updated":"2020-03-02 17:05:51.000000000","message":"Whoops, perhaps :-/ I\u0027ve been poking at this code for quite a while before submitting it for review, and I forgot why I had to change this line. I\u0027ll backtrack, and if necessary will submit a separate patch.","commit_id":"d4ef3e75670d5883463c98ea5387a2c75e8d6a86"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"7248a385a3e0f62b6f2aabf6a9d8da2a5e82a4ce","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        super(Etcd3Lock, self).__init__(name)"},{"line_number":71,"context_line":"        self._timeout \u003d timeout"},{"line_number":72,"context_line":"        self._coord \u003d coord"},{"line_number":73,"context_line":"        self._key \u003d self.LOCK_PREFIX + utils.to_binary(name)"},{"line_number":74,"context_line":"        self._key_b64 \u003d _encode(self._key)"},{"line_number":75,"context_line":"        self._uuid \u003d _encode(uuid.uuid4().bytes)"},{"line_number":76,"context_line":"        self._exclusive_access \u003d threading.Lock()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_94f3970a","line":73,"in_reply_to":"1fa4df85_cd174a51","updated":"2020-03-02 21:15:19.000000000","message":"I will drop this change from the patch, and will submit another patch if it\u0027s needed.","commit_id":"d4ef3e75670d5883463c98ea5387a2c75e8d6a86"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"44379d173c0058c12b5207a81aff94b465df3740","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        super(Etcd3Lock, self).__init__(name)"},{"line_number":71,"context_line":"        self._timeout \u003d timeout"},{"line_number":72,"context_line":"        self._coord \u003d coord"},{"line_number":73,"context_line":"        self._key \u003d self.LOCK_PREFIX + utils.to_binary(name)"},{"line_number":74,"context_line":"        self._key_b64 \u003d _encode(self._key)"},{"line_number":75,"context_line":"        self._uuid \u003d _encode(uuid.uuid4().bytes)"},{"line_number":76,"context_line":"        self._exclusive_access \u003d threading.Lock()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_b99c8c5d","line":73,"in_reply_to":"1fa4df85_cd174a51","updated":"2020-03-02 21:26:49.000000000","message":"Thanks.","commit_id":"d4ef3e75670d5883463c98ea5387a2c75e8d6a86"}],"tooz/tests/drivers/test_etcd3.py":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"d60c62e640d03ad0669d04435167d624914fab84","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                               timeout):"},{"line_number":59,"context_line":"        coord \u003d tooz.coordination.get_coordinator(coord_url,"},{"line_number":60,"context_line":"                                                  self.FAKE_MEMBER_ID)"},{"line_number":61,"context_line":"        coord \u003d coord  # So pep8 thinks we used the variable"},{"line_number":62,"context_line":"        mock_etcd3_client.assert_called_with(host\u003dhost,"},{"line_number":63,"context_line":"                                             port\u003dport,"},{"line_number":64,"context_line":"                                             ca_cert\u003dca_cert,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_4a3100ec","line":61,"updated":"2020-03-02 16:06:47.000000000","message":"Couldn\u0027t we just make the get_coordinator call without saving the result?","commit_id":"d4ef3e75670d5883463c98ea5387a2c75e8d6a86"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"38164ca7af2e2c73a71df2cade5b5afec0414512","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                               timeout):"},{"line_number":59,"context_line":"        coord \u003d tooz.coordination.get_coordinator(coord_url,"},{"line_number":60,"context_line":"                                                  self.FAKE_MEMBER_ID)"},{"line_number":61,"context_line":"        coord \u003d coord  # So pep8 thinks we used the variable"},{"line_number":62,"context_line":"        mock_etcd3_client.assert_called_with(host\u003dhost,"},{"line_number":63,"context_line":"                                             port\u003dport,"},{"line_number":64,"context_line":"                                             ca_cert\u003dca_cert,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_0003e90e","line":61,"in_reply_to":"1fa4df85_4a3100ec","updated":"2020-03-02 17:05:51.000000000","message":"Good point, thanks.","commit_id":"d4ef3e75670d5883463c98ea5387a2c75e8d6a86"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"06e4e6ae12fd24edb8f42278397c5d921a229c6a","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"@ddt.ddt"},{"line_number":27,"context_line":"class TestEtcd3(testcase.TestCase):"},{"line_number":28,"context_line":"    FAKE_MEMBER_ID \u003d tooz.tests.get_random_uuid()"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @ddt.data({\u0027coord_url\u0027: \u0027etcd3://\u0027,"},{"line_number":31,"context_line":"               \u0027host\u0027: etcd3_driver.Etcd3Driver.DEFAULT_HOST,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1fa4df85_63fe9539","line":28,"updated":"2020-03-16 17:55:32.000000000","message":"This is really strange. I have a new dev machine, and was finally able to reproduce the earlier CI failures. This change fixed it (it was a concurrency problem when running with multiple workers). The tests consistently pass in my local environment, so I don\u0027t know understand what\u0027s happening now.","commit_id":"d8e27dd49076f09c13e289b8cf9287c0c400c638"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"744dacffb2a57e0fb3c14c58baaa5c7fbb4350bb","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from etcd3.client import Etcd3Client"},{"line_number":23,"context_line":"def no_del(self):"},{"line_number":24,"context_line":"    pass"},{"line_number":25,"context_line":"Etcd3Client.__del__ \u003d no_del"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"import tooz.coordination"},{"line_number":28,"context_line":"import tooz.drivers.etcd3 as etcd3_driver"}],"source_content_type":"text/x-python","patch_set":7,"id":"df33271e_7d44e5b7","line":25,"updated":"2020-03-27 20:04:51.000000000","message":"nice!","commit_id":"155f5fb89098e47fc02492bf0237e9b4b10ad4a6"},{"author":{"_account_id":11356,"name":"Louis Taylor","email":"louis@kragniz.eu","username":"kragniz"},"change_message_id":"832b5d7b73f82f2fa8aa987e905b09c3c5f9994b","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from etcd3.client import Etcd3Client"},{"line_number":23,"context_line":"def no_del(self):"},{"line_number":24,"context_line":"    pass"},{"line_number":25,"context_line":"Etcd3Client.__del__ \u003d no_del"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"import tooz.coordination"},{"line_number":28,"context_line":"import tooz.drivers.etcd3 as etcd3_driver"}],"source_content_type":"text/x-python","patch_set":7,"id":"df33271e_8971940f","line":25,"in_reply_to":"df33271e_29b048dd","updated":"2020-03-30 10:50:23.000000000","message":"fwiw I was planning on cutting a new release this evening if that helps","commit_id":"155f5fb89098e47fc02492bf0237e9b4b10ad4a6"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"192a425bc7f98d359083c33d72eb334eb7b2b035","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from etcd3.client import Etcd3Client"},{"line_number":23,"context_line":"def no_del(self):"},{"line_number":24,"context_line":"    pass"},{"line_number":25,"context_line":"Etcd3Client.__del__ \u003d no_del"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"import tooz.coordination"},{"line_number":28,"context_line":"import tooz.drivers.etcd3 as etcd3_driver"}],"source_content_type":"text/x-python","patch_set":7,"id":"df33271e_29b048dd","line":25,"in_reply_to":"df33271e_7d44e5b7","updated":"2020-03-30 10:44:54.000000000","message":"Normally we\u0027ll pull automatically the latest version of etcd3 when it will be released and when openstack/requirements will be updated.\n\nBy waiting for the etcd3\u0027s new version with the fix embed we could leave this trick here during a couple of time.\n\nhttps://github.com/openstack/tooz/blob/master/setup.cfg#L50","commit_id":"155f5fb89098e47fc02492bf0237e9b4b10ad4a6"},{"author":{"_account_id":9257,"name":"John Eckersberg","email":"jeckersb@redhat.com","username":"jeckersb"},"change_message_id":"e3bc12f1f8581f3cf0ad188009cd86c62dd39232","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from etcd3.client import Etcd3Client"},{"line_number":23,"context_line":"def no_del(self):"},{"line_number":24,"context_line":"    pass"},{"line_number":25,"context_line":"Etcd3Client.__del__ \u003d no_del"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"import tooz.coordination"},{"line_number":28,"context_line":"import tooz.drivers.etcd3 as etcd3_driver"}],"source_content_type":"text/x-python","patch_set":7,"id":"df33271e_1e648e49","line":25,"in_reply_to":"df33271e_8971940f","updated":"2020-03-30 20:25:49.000000000","message":"\u003e fwiw I was planning on cutting a new release this evening if that\n \u003e helps\n\nThat would be quite helpful, thanks!","commit_id":"155f5fb89098e47fc02492bf0237e9b4b10ad4a6"}],"tooz/tests/drivers/test_etcd3gw.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"30143f1fb08b7a5b5887962c4d257e6911ef9b20","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import ddt"},{"line_number":18,"context_line":"import mock"},{"line_number":19,"context_line":"from testtools import testcase"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import tooz.coordination"}],"source_content_type":"text/x-python","patch_set":4,"id":"df33271e_8ed9f584","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":11},"updated":"2020-03-24 17:17:10.000000000","message":"Please use unittest mock, we are full python 3 now so we can use stdlib here now.","commit_id":"d587968e6a51e7873040c691299ba451949f3179"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"3e455530c998a0acfce6c770829e3d67e65b92fc","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import ddt"},{"line_number":18,"context_line":"import mock"},{"line_number":19,"context_line":"from testtools import testcase"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import tooz.coordination"}],"source_content_type":"text/x-python","patch_set":4,"id":"df33271e_d1d722ed","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":11},"in_reply_to":"df33271e_8ed9f584","updated":"2020-03-24 18:03:33.000000000","message":"Will do. I\u0027ll also restore my test_etcd3.py file, since its existence doesn\u0027t seem related to the CI hangs.","commit_id":"d587968e6a51e7873040c691299ba451949f3179"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"7fe332068924ea9e4a89d24b41366165bc2fe794","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import ddt"},{"line_number":18,"context_line":"from testtools import testcase"},{"line_number":19,"context_line":"from unittest import mock"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import tooz.coordination"},{"line_number":22,"context_line":"import tooz.drivers.etcd3gw as etcd3gw_driver"}],"source_content_type":"text/x-python","patch_set":5,"id":"df33271e_31f00e68","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":25},"updated":"2020-03-24 18:11:27.000000000","message":"Linters don\u0027t warn locally but I think there is a PEP8 wrong import order.","commit_id":"23b4cf7723c5fef89cb10e77aca7205d8e69d6b1"}]}