)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"6e5e8e9c46e3bfdf6fdc3c78f657b8bd92392670","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use safe_decode for decoding in zookeeper driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Current behaviour leds to AttributeError because py3 don\u0027t have decode"},{"line_number":10,"context_line":"attribut for the string objects. So it\u0027s better to use safe_decode from"},{"line_number":11,"context_line":"oslo_utils.encodeutils for that purpose"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I22ce4212381511e2b2631a97057d6da938024b99"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_7917ffa4","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":39},"updated":"2020-07-29 14:49:14.000000000","message":"Hello,\n\nAre you facing some issues?\n\nFirst it could be worth to link the related LP (if exist).\n\nAlso I wondering if we could drop decode at all. Tooz only support python3 now (for victoria and ussuri), so I don\u0027t think we will facing a scenario where we need to decode something, even by oslo.utils we will fall in the case where we pass a string and so we will return directly [1], though.\n\nNevertheless, I\u0027m not 100 percent sure about what is returned by zookeeper, and maybe we fall in the case where we handle should bynary type.\n\nThoughts?\n\n[1] https://github.com/openstack/oslo.utils/blob/master/oslo_utils/encodeutils.py#L42\n[2] https://github.com/openstack/oslo.utils/blob/master/oslo_utils/encodeutils.py#L38","commit_id":"924168f93ecf1dddc07f0ee9c86dea8b117c63f6"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"8de8eade76dd954e886f1265d35a6c8363e5ff3d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use safe_decode for decoding in zookeeper driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Current behaviour leds to AttributeError because py3 don\u0027t have decode"},{"line_number":10,"context_line":"attribut for the string objects. So it\u0027s better to use safe_decode from"},{"line_number":11,"context_line":"oslo_utils.encodeutils for that purpose"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I22ce4212381511e2b2631a97057d6da938024b99"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_b986b7da","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":39},"in_reply_to":"9f560f44_7917ffa4","updated":"2020-07-29 14:50:06.000000000","message":"Erratum:\n\nHello,\n\nAre you facing some issues?\n\nFirst it could be worth to link the related LP (if exist).\n\nAlso I wondering if we can\u0027t simply drop decode. Tooz only support python3 now (for victoria and ussuri), so I don\u0027t think we will facing a scenario where we needn\u0027t to decode something all the time, if I\u0027\u0027m right even by using oslo.utils we will fall in the case where we pass a string and so we will return directly [1].\n\nNonetheless, I\u0027m not 100 percent sure about what is returned by zookeeper\n\n[1] https://github.com/openstack/oslo.utils/blob/master/oslo_utils/encodeutils.py#L42","commit_id":"924168f93ecf1dddc07f0ee9c86dea8b117c63f6"}],"tooz/drivers/zookeeper.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"ccd839295f09379e340c840ddfbe866f4efecbcd","unresolved":false,"context_lines":[{"line_number":443,"context_line":"        cleaned_args \u003d []"},{"line_number":444,"context_line":"        for arg in args:"},{"line_number":445,"context_line":"            if isinstance(arg, bytes):"},{"line_number":446,"context_line":"                cleaned_args.append(encodeutils.safe_decode(arg, incoming\u003d\u0027ascii\u0027))"},{"line_number":447,"context_line":"            else:"},{"line_number":448,"context_line":"                cleaned_args.append(arg)"},{"line_number":449,"context_line":"        return paths.join(*cleaned_args)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_94629a3d","line":446,"updated":"2020-07-29 15:39:58.000000000","message":"pep8: E501 line too long (83 \u003e 79 characters)","commit_id":"924168f93ecf1dddc07f0ee9c86dea8b117c63f6"}]}