)]}'
{"id":"openstack%2Ftooz~756497","triplet_id":"openstack%2Ftooz~master~I441abc7b1a2e96656387ff9a9ba134351c4d3fa4","project":"openstack/tooz","branch":"master","topic":"add-shared-lock-characteristic","hashtags":[],"change_id":"I441abc7b1a2e96656387ff9a9ba134351c4d3fa4","subject":"Add SHARED_LOCKS characteristics","status":"ABANDONED","created":"2020-10-07 11:56:44.000000000","updated":"2026-03-05 20:39:35.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b13af5204dc70ed3264da97e260893efc8656ac8","_number":756497,"virtual_id_number":756497,"owner":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2020-10-07 13:21:27.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"all":[{"value":1,"date":"2020-10-07 12:08:49.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2020-10-08 11:55:19.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-10-07 12:08:49.000000000","updated_by":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"reviewer":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"state":"REVIEWER"},{"updated":"2020-10-07 13:21:27.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"999ccd8f78faa826a6bab81ac52eac343fd73bcd","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2020-10-07 11:56:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"457597d5700956eb50190b0ee967a6d9770c1a14","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-10-07 12:08:49.000000000","message":"Patch Set 1: Code-Review+1\n\n+1 for the rationale behind these changes, waiting for CI output.\n\nI\u0027m not sure if we can add few related tests [1], thoughts?\n\n[1] https://opendev.org/openstack/tooz/src/branch/master/tooz/tests/test_coordination.py","accounts_in_message":[],"_revision_number":1},{"id":"fdac21c55dff284d588ea1722c0cf4b3547401e1","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-10-07 13:21:27.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/5891dcc7df6641548a2cf0a64c9311fe : SUCCESS in 1h 20m 05s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/6f6f9351c5384fc4af5aec66b9d4cbf3 : SUCCESS in 5m 22s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b5651a71cb8b4502a9e20560d573ab37 : SUCCESS in 4m 45s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/ac5c96ccb79c4090b715c73da43daeec : SUCCESS in 8m 33s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/5cafc9819e4042c68a8f3bfa6b801160 : SUCCESS in 7m 23s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/caf341682ce442b2b318a9e69af77d39 : SUCCESS in 5m 07s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/a1ef645a2f024be3b38a6f82b02776d7 : SUCCESS in 5m 07s\n- tooz-tox-py38-etcd https://zuul.opendev.org/t/openstack/build/9a6124668365409f847aa884315ba3d9 : SUCCESS in 6m 27s\n- tooz-tox-py36-etcd https://zuul.opendev.org/t/openstack/build/d256493dcb8d42988f94437c3fe6303b : SUCCESS in 8m 09s\n- tooz-tox-py38-etcd3 https://zuul.opendev.org/t/openstack/build/4f301e2a28ce42c5a58b520da089f693 : SUCCESS in 5m 43s\n- tooz-tox-py36-etcd3 https://zuul.opendev.org/t/openstack/build/85ea8470029e45daaf2074b38c6e6017 : SUCCESS in 5m 03s\n- tooz-tox-py38-etcd3gw https://zuul.opendev.org/t/openstack/build/687bf8f618524ac7bb17e5ed1a546fa1 : FAILURE in 5m 08s\n- tooz-tox-py36-etcd3gw https://zuul.opendev.org/t/openstack/build/4504ddd927894e578b289a287990a7cc : FAILURE in 8m 55s\n- tooz-tox-py38-zookeeper https://zuul.opendev.org/t/openstack/build/508825959f4e4d4a96711d32ca43ffe4 : SUCCESS in 5m 37s\n- tooz-tox-py36-zookeeper https://zuul.opendev.org/t/openstack/build/62311e8d42504b3a854c040fbc86b141 : SUCCESS in 8m 16s\n- tooz-tox-py38-redis https://zuul.opendev.org/t/openstack/build/61291da853e94d1982fa60fec211eba3 : SUCCESS in 6m 32s\n- tooz-tox-py36-redis https://zuul.opendev.org/t/openstack/build/2588af4eb7ae4036a579a5c371bd08b4 : SUCCESS in 6m 44s\n- tooz-tox-py38-sentinel https://zuul.opendev.org/t/openstack/build/fc5f7978e30e4576a9ec38005e828104 : SUCCESS in 5m 48s\n- tooz-tox-py36-sentinel https://zuul.opendev.org/t/openstack/build/d57dbcee8d6d43a89c8c7743777cdbba : SUCCESS in 6m 34s\n- tooz-tox-py38-memcached https://zuul.opendev.org/t/openstack/build/ac6dd5d657a44c16b18082e012e22b85 : SUCCESS in 5m 25s\n- tooz-tox-py36-memcached https://zuul.opendev.org/t/openstack/build/dd63dadc052c49d5a56ef38518f42470 : SUCCESS in 5m 58s\n- tooz-tox-py38-postgresql https://zuul.opendev.org/t/openstack/build/97885e70e133473bbb50aca31fef6580 : SUCCESS in 6m 10s\n- tooz-tox-py36-postgresql https://zuul.opendev.org/t/openstack/build/a1329f1e1754450e99ecde61f2d8e0c6 : SUCCESS in 7m 40s\n- tooz-tox-py38-mysql https://zuul.opendev.org/t/openstack/build/eb7d9be36b7042718c32e2992bdc0fd4 : SUCCESS in 5m 21s\n- tooz-tox-py36-mysql https://zuul.opendev.org/t/openstack/build/b6150b436c614efab71fd2929b429281 : SUCCESS in 6m 05s\n- tooz-tox-py38-consul https://zuul.opendev.org/t/openstack/build/0a9254b38ac84043a6f0d9f453817a70 : SUCCESS in 7m 41s\n- tooz-tox-py36-consul https://zuul.opendev.org/t/openstack/build/8aa8a5cd7d7e47178ef7724a9c510efc : SUCCESS in 6m 15s","accounts_in_message":[],"_revision_number":1},{"id":"93e4dfe7f72a94d601c0576a67523868101e8f8d","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2020-10-08 11:55:19.000000000","message":"Patch Set 1: Workflow-1\n\nI just looked at the shared lock implementation in the file driver, and it doesn\u0027t work between processes [1], so we probably shouldn\u0027t even announce that it supports the feature.  :-(\n\n[1]: https://bugs.launchpad.net/python-tooz/+bug/1899022","accounts_in_message":[],"_revision_number":1},{"id":"b13af5204dc70ed3264da97e260893efc8656ac8","tag":"autogenerated:gerrit:abandon","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2026-03-05 20:39:35.000000000","message":"Abandoned\n\nI\u0027m guessing this has stalled","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"e60b9d0100b05bd1a28786963e4e11c92e44b53c","revisions":{"e60b9d0100b05bd1a28786963e4e11c92e44b53c":{"kind":"REWORK","_number":1,"created":"2020-10-07 11:56:44.000000000","uploader":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"ref":"refs/changes/97/756497/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/tooz","ref":"refs/changes/97/756497/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/tooz refs/changes/97/756497/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/tooz refs/changes/97/756497/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/tooz refs/changes/97/756497/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/tooz refs/changes/97/756497/1"}}},"commit":{"parents":[{"commit":"b7fe722e9727455881c1a37e540252efa3a0e41b","subject":"Update master for stable/victoria","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tooz/commit/b7fe722e9727455881c1a37e540252efa3a0e41b"}]}],"author":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2020-10-07 11:52:44.000000000","tz":120},"committer":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2020-10-07 11:56:34.000000000","tz":120},"subject":"Add SHARED_LOCKS characteristics","message":"Add SHARED_LOCKS characteristics\n\nIn change I55a528977e74b27da736f421d2eee28c7aae8aa3 shared locks were\nadded, but currently the only way to know programatically if a driver\nsupports shared locks is to try to create one and see if it raises an\nexception.\n\nSince there is a mechanism to announce driver characteristics, it would\nbe good for drivers to be able to express this specific feature.\n\nThis patch adds a new characteristic called SHARED_LOCKS, currently only\nsupported by the file driver.\n\nChange-Id: I441abc7b1a2e96656387ff9a9ba134351c4d3fa4\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tooz/commit/e60b9d0100b05bd1a28786963e4e11c92e44b53c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/tooz/commit/e60b9d0100b05bd1a28786963e4e11c92e44b53c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":["label:Workflow\u003dMIN"],"failing_atoms":["label:Workflow\u003dMAX"],"atom_explanations":{}}}]}