)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"97858bf2a6f05bfe7e5dc09e87aab5cf30e3dfa4","unresolved":true,"context_lines":[{"line_number":9,"context_line":"since etcd3 3.5 dropped support for v3alpha and v3beta api, replacing"},{"line_number":10,"context_line":"those with v3."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"etcd3gw libbary supports passing api_path (v3alpha by default), but tooz"},{"line_number":13,"context_line":"lacks such possibility and thus can not work with etcd3 3.5."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch adds handling of \"api_version\" in the options to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"e4deacbd_4699bd36","line":12,"range":{"start_line":12,"start_character":8,"end_line":12,"end_character":15},"updated":"2022-08-09 17:25:59.000000000","message":"nit :typo: library","commit_id":"0f102aad6ec472d0e5011ee01e1e49085938f3e8"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"9c97b456b8ba9fe2d07bc2c1f3ff26ebd614fcdc","unresolved":false,"context_lines":[{"line_number":9,"context_line":"since etcd3 3.5 dropped support for v3alpha and v3beta api, replacing"},{"line_number":10,"context_line":"those with v3."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"etcd3gw libbary supports passing api_path (v3alpha by default), but tooz"},{"line_number":13,"context_line":"lacks such possibility and thus can not work with etcd3 3.5."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch adds handling of \"api_version\" in the options to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"e3ad4183_fd11a007","line":12,"range":{"start_line":12,"start_character":8,"end_line":12,"end_character":15},"in_reply_to":"e4deacbd_4699bd36","updated":"2022-08-22 01:37:33.000000000","message":"Done","commit_id":"0f102aad6ec472d0e5011ee01e1e49085938f3e8"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"2a93f5f179ed62ec21224366fb12aaf5f10ba3b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"738f6c0b_ff49cd3b","updated":"2022-02-02 13:16:17.000000000","message":"here\u0027s this place in the etcd3gw client init\n\nhttps://opendev.org/openstack/etcd3gw/src/tag/1.0.0/etcd3gw/client.py#L45","commit_id":"858cea9fd810bf40adde42ef7276007aed802674"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"dcbd64086fb74ee369740c7e6e098f2301de5f34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6c5c6d67_f78168ad","updated":"2022-08-09 15:59:56.000000000","message":"Otherwise, code lgtm!","commit_id":"0f102aad6ec472d0e5011ee01e1e49085938f3e8"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"3153e2df65ab5e58a205f75a64fa50a27b3d0f5f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c3aa555a_1df57df9","updated":"2022-08-09 15:59:32.000000000","message":"This patch needs Depends-On: I49c480f573a4ba8294627a3ce730b816ded10aed","commit_id":"0f102aad6ec472d0e5011ee01e1e49085938f3e8"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"97858bf2a6f05bfe7e5dc09e87aab5cf30e3dfa4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"26f384e2_27058280","updated":"2022-08-09 17:25:59.000000000","message":"just a typo in commit message , can be fixed while updating the Depends-on.\nOtherwise LGTM!","commit_id":"0f102aad6ec472d0e5011ee01e1e49085938f3e8"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"9c97b456b8ba9fe2d07bc2c1f3ff26ebd614fcdc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e8476f3b_cdb3ad51","updated":"2022-08-22 01:37:33.000000000","message":"Thanks Alan for updating the commit message.\nChange LGTM!\n","commit_id":"9c687dc39a84a292c0637319b378cd5033bc776a"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"12f7b85169e1079b579189e29587929f3c3daf99","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"878bb9fd_0b35c10a","updated":"2022-09-02 09:01:00.000000000","message":"+W?","commit_id":"b64623daeb9e0f94fd5322a1c7e47403f187e7ed"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"9c420f5ac8f40de8188f363c0c96915e9d8805fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f15f8fbf_56651691","updated":"2022-08-24 15:54:52.000000000","message":"Argh, looks like zuul isn\u0027t applying the depends-on patch to etcd3gw.","commit_id":"b64623daeb9e0f94fd5322a1c7e47403f187e7ed"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"dd822124a33faab957649882ae3f7c78c8e2e30d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"dcf23648_05cf2454","updated":"2022-08-24 16:02:14.000000000","message":"Yeah, that makes sense. I\u0027m seeking reviews to get the etcd3gw patch merged, but do you know if that\u0027s sufficient or if I\u0027ll need to ask for a new release?","commit_id":"b64623daeb9e0f94fd5322a1c7e47403f187e7ed"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"6776a94a799362fc0815cda2e03b4f64d866dd1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"68b23c3b_af867472","updated":"2022-09-02 04:11:25.000000000","message":"recheck\n\nupper-constraints now includes latest etcd3gw release","commit_id":"b64623daeb9e0f94fd5322a1c7e47403f187e7ed"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"21bd0becaa831d89a4ffcd576c8ae150a3163334","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"25670571_c671642f","in_reply_to":"878bb9fd_0b35c10a","updated":"2022-09-02 13:10:50.000000000","message":"Yeah, I\u0027m really hoping this doesn\u0027t miss the zed library cutoff date. This patch isn\u0027t really a new feature, but is something required in order for tooz+etcd3gw to work with the newer versions of etcd\u0027s grpc gatewau, which no longer support the original /v3alpha path.","commit_id":"b64623daeb9e0f94fd5322a1c7e47403f187e7ed"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"6ef4c3e86281dbfb7b7d92385668ab60664ab5e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"843fd959_e1921db5","in_reply_to":"dcf23648_05cf2454","updated":"2022-08-24 16:33:45.000000000","message":"Uh-oh, I\u0027m afraid you are right with the release, argh. The tooling uses upper-constraints which depend on released versions.","commit_id":"b64623daeb9e0f94fd5322a1c7e47403f187e7ed"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f88a1d99bf95d8cdfbdebdda77c622642fbc0709","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ccca41d3_edc6f8c4","in_reply_to":"f15f8fbf_56651691","updated":"2022-08-24 15:58:59.000000000","message":"Well, it\u0027s more like the tox and devstack know nothing about picking it up.","commit_id":"b64623daeb9e0f94fd5322a1c7e47403f187e7ed"}],"tooz/drivers/etcd3gw.py":[{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"6567b2b12368c3e663df1b69e9316728a7097161","unresolved":true,"context_lines":[{"line_number":212,"context_line":"        cert_cert \u003d options.get(\u0027cert_cert\u0027)"},{"line_number":213,"context_line":"        timeout \u003d int(options.get(\u0027timeout\u0027, self.DEFAULT_TIMEOUT))"},{"line_number":214,"context_line":"        api_version \u003d options.get(\"api_version\", self.DEFAULT_API_VERSION)"},{"line_number":215,"context_line":"        self.client \u003d etcd3gw.Etcd3Client(host\u003dhost,"},{"line_number":216,"context_line":"                                          port\u003dport,"},{"line_number":217,"context_line":"                                          protocol\u003dprotocol,"},{"line_number":218,"context_line":"                                          ca_cert\u003dca_cert,"}],"source_content_type":"text/x-python","patch_set":4,"id":"d294cb50_d021d7bd","line":215,"range":{"start_line":215,"start_character":22,"end_line":215,"end_character":41},"updated":"2022-02-02 15:44:49.000000000","message":"Using etcd3gw.Etcd3Client here since etcd3gw.client does not support passing api_path,\npatch proposed here https://review.opendev.org/c/openstack/etcd3gw/+/827521","commit_id":"0f102aad6ec472d0e5011ee01e1e49085938f3e8"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"bfd6656601010a0b6e3acfdf04b47d791541d10b","unresolved":true,"context_lines":[{"line_number":212,"context_line":"        cert_cert \u003d options.get(\u0027cert_cert\u0027)"},{"line_number":213,"context_line":"        timeout \u003d int(options.get(\u0027timeout\u0027, self.DEFAULT_TIMEOUT))"},{"line_number":214,"context_line":"        api_version \u003d options.get(\"api_version\", self.DEFAULT_API_VERSION)"},{"line_number":215,"context_line":"        self.client \u003d etcd3gw.Etcd3Client(host\u003dhost,"},{"line_number":216,"context_line":"                                          port\u003dport,"},{"line_number":217,"context_line":"                                          protocol\u003dprotocol,"},{"line_number":218,"context_line":"                                          ca_cert\u003dca_cert,"}],"source_content_type":"text/x-python","patch_set":6,"id":"d3ef786d_e2947f42","line":215,"updated":"2022-08-24 14:22:15.000000000","message":"with this change, this patch no longer really depends on the etcd3gw change; I prefer this remained using the factory method but not pushing","commit_id":"9c687dc39a84a292c0637319b378cd5033bc776a"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"7192c8c8ced45ab173a5aad42f0c4d17a3db368c","unresolved":false,"context_lines":[{"line_number":212,"context_line":"        cert_cert \u003d options.get(\u0027cert_cert\u0027)"},{"line_number":213,"context_line":"        timeout \u003d int(options.get(\u0027timeout\u0027, self.DEFAULT_TIMEOUT))"},{"line_number":214,"context_line":"        api_version \u003d options.get(\"api_version\", self.DEFAULT_API_VERSION)"},{"line_number":215,"context_line":"        self.client \u003d etcd3gw.Etcd3Client(host\u003dhost,"},{"line_number":216,"context_line":"                                          port\u003dport,"},{"line_number":217,"context_line":"                                          protocol\u003dprotocol,"},{"line_number":218,"context_line":"                                          ca_cert\u003dca_cert,"}],"source_content_type":"text/x-python","patch_set":6,"id":"f681fd28_80cfd9db","line":215,"in_reply_to":"6fccc5b0_514341b1","updated":"2022-08-24 15:21:17.000000000","message":"Thanks.","commit_id":"9c687dc39a84a292c0637319b378cd5033bc776a"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"ff38b065e59864d7fc98ebce0be4d009bfd9f0f3","unresolved":false,"context_lines":[{"line_number":212,"context_line":"        cert_cert \u003d options.get(\u0027cert_cert\u0027)"},{"line_number":213,"context_line":"        timeout \u003d int(options.get(\u0027timeout\u0027, self.DEFAULT_TIMEOUT))"},{"line_number":214,"context_line":"        api_version \u003d options.get(\"api_version\", self.DEFAULT_API_VERSION)"},{"line_number":215,"context_line":"        self.client \u003d etcd3gw.Etcd3Client(host\u003dhost,"},{"line_number":216,"context_line":"                                          port\u003dport,"},{"line_number":217,"context_line":"                                          protocol\u003dprotocol,"},{"line_number":218,"context_line":"                                          ca_cert\u003dca_cert,"}],"source_content_type":"text/x-python","patch_set":6,"id":"6fccc5b0_514341b1","line":215,"in_reply_to":"d3ef786d_e2947f42","updated":"2022-08-24 15:13:35.000000000","message":"Oh, right, I didn\u0027t notice this change from an earlier patchset. I agree the factory method is preferred.","commit_id":"9c687dc39a84a292c0637319b378cd5033bc776a"}]}
