)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0a3cd457d09f410ead7bd4554d38825be55f2bc5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ea8b32a8_a1442a3f","updated":"2022-03-10 15:56:04.000000000","message":"In TripleO we use etcd backend to implement cinder-volume act-act. However that implementation depends on etcd3gw driver instead of etcd3 driver so this deprecation does not affect our usage.","commit_id":"b250863edaacd39c21c3e5aba7cf18a217ad690d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"b404ce886e50c30969eacea94887085178983020","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"811e51f9_b678c96d","updated":"2022-03-10 15:39:25.000000000","message":"It\u0027s a bummer situation, but understandable given the library situation.","commit_id":"b250863edaacd39c21c3e5aba7cf18a217ad690d"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"9eb3d4b2446d4c6abbbc23b6c87e59d3defd4176","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0047dbe0_0511ac65","updated":"2022-03-14 14:42:04.000000000","message":"Seems good for me and I think it\u0027s a good stuff to do actually.","commit_id":"b250863edaacd39c21c3e5aba7cf18a217ad690d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3e603c87d581b6dbd8b365d0998e01f2c312de2c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dac40aef_05717d0c","updated":"2022-03-14 19:24:31.000000000","message":"Small issue. Should be easily fixed.","commit_id":"b250863edaacd39c21c3e5aba7cf18a217ad690d"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"1d7d2d40c498ecb9b083b68c6037d76eb945bf08","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d4efa5af_07c17ccc","updated":"2022-03-10 15:22:52.000000000","message":"WFM, let\u0027s wait a bit for feedback and CI (only +1 for now).\n\nstoring the ML discussion here: http://lists.openstack.org/pipermail/openstack-discuss/2022-March/027664.html\n\n","commit_id":"b250863edaacd39c21c3e5aba7cf18a217ad690d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7343396205c801419c3c6ca8ef0586049e2b1ac8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f784555a_2189f23b","updated":"2022-06-28 10:58:20.000000000","message":"FYI I\u0027ve proposed [1] to cap the upper version of protobuf, since newer versions are no longer compatible with the last release of etcd3. Reviews appreciated.\n\n[1] https://review.opendev.org/c/openstack/tooz/+/847949","commit_id":"7ee2780af87a013c83fb5a8a5d0c7ab0767b3db8"}],"tooz/drivers/etcd3.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3e603c87d581b6dbd8b365d0998e01f2c312de2c","unresolved":true,"context_lines":[{"line_number":29,"context_line":"import warnings"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"warnings.simplefilter(\"always\")"},{"line_number":33,"context_line":"debtcollector.deprecate("},{"line_number":34,"context_line":"    \"Using the etcd3 tooz driver is deprecated, it will be \""},{"line_number":35,"context_line":"    \"removed in a future release.\""}],"source_content_type":"text/x-python","patch_set":1,"id":"f2fd8307_81acf830","line":32,"updated":"2022-03-14 19:24:31.000000000","message":"I don\u0027t think you want to do this. It\u0027ll turn on every warning for every single module in the system. I realize that deprecation warnings are disabled by default so people might not see this, but what you\u0027re doing here is worse I suspect. How about adding a warning log to the driver __init__ instead?","commit_id":"b250863edaacd39c21c3e5aba7cf18a217ad690d"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"618c9201adf19f54078029f80fc57fd6dfee11d3","unresolved":false,"context_lines":[{"line_number":29,"context_line":"import warnings"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"warnings.simplefilter(\"always\")"},{"line_number":33,"context_line":"debtcollector.deprecate("},{"line_number":34,"context_line":"    \"Using the etcd3 tooz driver is deprecated, it will be \""},{"line_number":35,"context_line":"    \"removed in a future release.\""}],"source_content_type":"text/x-python","patch_set":1,"id":"e859dbab_c1f0d6af","line":32,"in_reply_to":"b121357c_49f1e4a6","updated":"2022-03-14 23:03:15.000000000","message":"Done","commit_id":"b250863edaacd39c21c3e5aba7cf18a217ad690d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8fbcfa3b8b3b8364f0d5f6d677220afddbc7528a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"import warnings"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"warnings.simplefilter(\"always\")"},{"line_number":33,"context_line":"debtcollector.deprecate("},{"line_number":34,"context_line":"    \"Using the etcd3 tooz driver is deprecated, it will be \""},{"line_number":35,"context_line":"    \"removed in a future release.\""}],"source_content_type":"text/x-python","patch_set":1,"id":"b23e71ef_20d698c3","line":32,"in_reply_to":"e859dbab_c1f0d6af","updated":"2022-03-15 10:52:50.000000000","message":"Yup, that\u0027s a mistake (the oslo.utils change). I\u0027m disappointed I didn\u0027t spot that when reviewing it. Thanks for respinning this patch!","commit_id":"b250863edaacd39c21c3e5aba7cf18a217ad690d"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"dd75f33a43dd9c2c36d96c38ba3c9b7541b366fa","unresolved":true,"context_lines":[{"line_number":29,"context_line":"import warnings"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"warnings.simplefilter(\"always\")"},{"line_number":33,"context_line":"debtcollector.deprecate("},{"line_number":34,"context_line":"    \"Using the etcd3 tooz driver is deprecated, it will be \""},{"line_number":35,"context_line":"    \"removed in a future release.\""}],"source_content_type":"text/x-python","patch_set":1,"id":"b121357c_49f1e4a6","line":32,"in_reply_to":"f2fd8307_81acf830","updated":"2022-03-14 22:25:41.000000000","message":"I simply based all this on [1] but I can push a change with your suggestion right away tomorrow morning.\n\n[1] https://review.opendev.org/c/openstack/oslo.utils/+/790429","commit_id":"b250863edaacd39c21c3e5aba7cf18a217ad690d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3e603c87d581b6dbd8b365d0998e01f2c312de2c","unresolved":true,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"warnings.simplefilter(\"always\")"},{"line_number":33,"context_line":"debtcollector.deprecate("},{"line_number":34,"context_line":"    \"Using the etcd3 tooz driver is deprecated, it will be \""},{"line_number":35,"context_line":"    \"removed in a future release.\""},{"line_number":36,"context_line":")"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"79c2058f_a635f7ff","line":34,"range":{"start_line":34,"start_character":5,"end_line":34,"end_character":11},"updated":"2022-03-14 19:24:31.000000000","message":"super nit: This is unnecessary. The whole driver is deprecated. Whether you use it or not doesn\u0027t affect that 😄","commit_id":"b250863edaacd39c21c3e5aba7cf18a217ad690d"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"618c9201adf19f54078029f80fc57fd6dfee11d3","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"warnings.simplefilter(\"always\")"},{"line_number":33,"context_line":"debtcollector.deprecate("},{"line_number":34,"context_line":"    \"Using the etcd3 tooz driver is deprecated, it will be \""},{"line_number":35,"context_line":"    \"removed in a future release.\""},{"line_number":36,"context_line":")"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"4f76a812_db3fb50e","line":34,"range":{"start_line":34,"start_character":5,"end_line":34,"end_character":11},"in_reply_to":"79c2058f_a635f7ff","updated":"2022-03-14 23:03:15.000000000","message":"Done","commit_id":"b250863edaacd39c21c3e5aba7cf18a217ad690d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3e603c87d581b6dbd8b365d0998e01f2c312de2c","unresolved":true,"context_lines":[{"line_number":152,"context_line":"    DEFAULT_PORT \u003d 2379"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def __init__(self, member_id, parsed_url, options):"},{"line_number":155,"context_line":"        super(Etcd3Driver, self).__init__(member_id, parsed_url, options)"},{"line_number":156,"context_line":"        host \u003d parsed_url.hostname or self.DEFAULT_HOST"},{"line_number":157,"context_line":"        port \u003d parsed_url.port or self.DEFAULT_PORT"},{"line_number":158,"context_line":"        options \u003d utils.collapse(options)"}],"source_content_type":"text/x-python","patch_set":1,"id":"f83e4819_f0fd1769","line":155,"updated":"2022-03-14 19:24:31.000000000","message":"Here:\n\n  LOG.warning(\n      \"The etcd3 tooz driver is deprecated, it will be removed in\"\n      \"a future release.\"\n  )","commit_id":"b250863edaacd39c21c3e5aba7cf18a217ad690d"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"618c9201adf19f54078029f80fc57fd6dfee11d3","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    DEFAULT_PORT \u003d 2379"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def __init__(self, member_id, parsed_url, options):"},{"line_number":155,"context_line":"        super(Etcd3Driver, self).__init__(member_id, parsed_url, options)"},{"line_number":156,"context_line":"        host \u003d parsed_url.hostname or self.DEFAULT_HOST"},{"line_number":157,"context_line":"        port \u003d parsed_url.port or self.DEFAULT_PORT"},{"line_number":158,"context_line":"        options \u003d utils.collapse(options)"}],"source_content_type":"text/x-python","patch_set":1,"id":"f85d4352_b12ade26","line":155,"in_reply_to":"f2c68a68_f9d071b9","updated":"2022-03-14 23:03:15.000000000","message":"Done","commit_id":"b250863edaacd39c21c3e5aba7cf18a217ad690d"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"dd75f33a43dd9c2c36d96c38ba3c9b7541b366fa","unresolved":true,"context_lines":[{"line_number":152,"context_line":"    DEFAULT_PORT \u003d 2379"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def __init__(self, member_id, parsed_url, options):"},{"line_number":155,"context_line":"        super(Etcd3Driver, self).__init__(member_id, parsed_url, options)"},{"line_number":156,"context_line":"        host \u003d parsed_url.hostname or self.DEFAULT_HOST"},{"line_number":157,"context_line":"        port \u003d parsed_url.port or self.DEFAULT_PORT"},{"line_number":158,"context_line":"        options \u003d utils.collapse(options)"}],"source_content_type":"text/x-python","patch_set":1,"id":"f2c68a68_f9d071b9","line":155,"in_reply_to":"f83e4819_f0fd1769","updated":"2022-03-14 22:25:41.000000000","message":"will do this^","commit_id":"b250863edaacd39c21c3e5aba7cf18a217ad690d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"68d40153f81c9be96c2eb7c53ccc1387dcb9cf0d","unresolved":true,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def __init__(self, member_id, parsed_url, options):"},{"line_number":145,"context_line":"        super(Etcd3Driver, self).__init__(member_id, parsed_url, options)"},{"line_number":146,"context_line":"        LOG.warning("},{"line_number":147,"context_line":"            \"The etcd3 tooz driver is deprecated, it will be removed in\""},{"line_number":148,"context_line":"            \"a future release.\""},{"line_number":149,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"078a9cfd_7ce07864","line":146,"range":{"start_line":146,"start_character":8,"end_line":146,"end_character":19},"updated":"2022-03-15 00:40:47.000000000","message":"it seems we don\u0027t have oslo_log imported. Should we use warnings.warn instead ?\n\neg. https://review.opendev.org/c/openstack/ceilometer/+/817031/3/ceilometer/network/services/fwaas.py#40","commit_id":"8a321d8983d5273e1f0dbe3f3a82f260fee0930c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ba559025f8013031fbc0b5e5a5aa6ce02bf81a58","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def __init__(self, member_id, parsed_url, options):"},{"line_number":145,"context_line":"        super(Etcd3Driver, self).__init__(member_id, parsed_url, options)"},{"line_number":146,"context_line":"        LOG.warning("},{"line_number":147,"context_line":"            \"The etcd3 tooz driver is deprecated, it will be removed in\""},{"line_number":148,"context_line":"            \"a future release.\""},{"line_number":149,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"bc5d3731_fca61f60","line":146,"range":{"start_line":146,"start_character":8,"end_line":146,"end_character":19},"in_reply_to":"078a9cfd_7ce07864","updated":"2022-03-15 10:53:00.000000000","message":"Done","commit_id":"8a321d8983d5273e1f0dbe3f3a82f260fee0930c"}]}
