)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"fe7daf18f4692010778b12956b10b57432927b2c","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Enable watch functionality for Etcd3Driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Add CoordinationDriverCachedRunWatchers as parent for Etcd3Driver"},{"line_number":10,"context_line":"* Update supported and unsupported methods in driver"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-bug: #1968323"},{"line_number":13,"context_line":"Change-Id: Ibd46a3697b59cd22f386e60d29649acc5c5cd88a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"c3f6fb51_f07ec87b","line":10,"range":{"start_line":10,"start_character":2,"end_line":10,"end_character":42},"updated":"2022-04-11 12:32:50.000000000","message":"What do you meant by supported and unsupported?\nDo you meant that the etcd backend doesn\u0027t support these feature or that the parent classes doesn\u0027t implement them?","commit_id":"d57953c7b31a27727b0f7f8e3e4ac6d103e46230"},{"author":{"_account_id":7549,"name":"Ekaterina Chernova","email":"katyafervent@yandex.ru","username":"efedorova"},"change_message_id":"4b1e89df28447f5e7389ad2078afabd531d9d304","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Enable watch functionality for Etcd3Driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Add CoordinationDriverCachedRunWatchers as parent for Etcd3Driver"},{"line_number":10,"context_line":"* Update supported and unsupported methods in driver"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-bug: #1968323"},{"line_number":13,"context_line":"Change-Id: Ibd46a3697b59cd22f386e60d29649acc5c5cd88a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"778d4e17_ad01c920","line":10,"range":{"start_line":10,"start_character":2,"end_line":10,"end_character":42},"in_reply_to":"c3f6fb51_f07ec87b","updated":"2022-04-12 06:42:09.000000000","message":"I meant etcd doesn\u0027t support. It seems to me the commit message is bad, now I\u0027ve update it. If you have suggestions you are welcome)","commit_id":"d57953c7b31a27727b0f7f8e3e4ac6d103e46230"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"54d5c07d76d72ff5b1493eb89d4fd5f2bc5ba84d","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add run_watchers support to Etcd3Driver."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Raise NotImplemented during leader change watch methods"},{"line_number":12,"context_line":"to let corresponding tests pass since only group"},{"line_number":13,"context_line":"membership is supported"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-bug: #1968323"},{"line_number":16,"context_line":"Change-Id: Ibd46a3697b59cd22f386e60d29649acc5c5cd88a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"16ffa884_9fe9768a","line":13,"range":{"start_line":11,"start_character":0,"end_line":13,"end_character":23},"updated":"2022-04-11 15:25:14.000000000","message":"Thanks for your clarification","commit_id":"c0f6cc0fe5a0ebf43368aab3e8897a0eac0ab489"},{"author":{"_account_id":7549,"name":"Ekaterina Chernova","email":"katyafervent@yandex.ru","username":"efedorova"},"change_message_id":"c9bfa1ace8122f60dabe586dcbd740a05246f892","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add run_watchers support to Etcd3Driver."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Raise NotImplemented during leader change watch methods"},{"line_number":12,"context_line":"to let corresponding tests pass since only group"},{"line_number":13,"context_line":"membership is supported"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-bug: #1968323"},{"line_number":16,"context_line":"Change-Id: Ibd46a3697b59cd22f386e60d29649acc5c5cd88a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"e0e69161_158e0270","line":13,"range":{"start_line":11,"start_character":0,"end_line":13,"end_character":23},"in_reply_to":"16ffa884_9fe9768a","updated":"2022-04-12 06:43:58.000000000","message":"I answered to your previous comments and forgot to push the replay button :)\nThanks for reviewing)","commit_id":"c0f6cc0fe5a0ebf43368aab3e8897a0eac0ab489"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":7549,"name":"Ekaterina Chernova","email":"katyafervent@yandex.ru","username":"efedorova"},"change_message_id":"bc715026d9cefe02ab3e2af87c1aa28f82a76f28","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1506ef89_9863bba0","updated":"2022-04-12 10:27:11.000000000","message":"recheck","commit_id":"c0f6cc0fe5a0ebf43368aab3e8897a0eac0ab489"},{"author":{"_account_id":7549,"name":"Ekaterina Chernova","email":"katyafervent@yandex.ru","username":"efedorova"},"change_message_id":"c9bfa1ace8122f60dabe586dcbd740a05246f892","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"26e8571a_2626bb53","updated":"2022-04-12 06:43:58.000000000","message":"recheck","commit_id":"c0f6cc0fe5a0ebf43368aab3e8897a0eac0ab489"},{"author":{"_account_id":7549,"name":"Ekaterina Chernova","email":"katyafervent@yandex.ru","username":"efedorova"},"change_message_id":"4d130689808de09134e09d2c6780766405651066","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c5619f15_0613d29b","in_reply_to":"1506ef89_9863bba0","updated":"2022-04-19 09:34:10.000000000","message":"Done","commit_id":"c0f6cc0fe5a0ebf43368aab3e8897a0eac0ab489"}],"tooz/drivers/etcd3gw.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"fe7daf18f4692010778b12956b10b57432927b2c","unresolved":true,"context_lines":[{"line_number":425,"context_line":"        return coordination.CoordinatorResult("},{"line_number":426,"context_line":"            self._executor.submit(_get_groups))"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"    @staticmethod"},{"line_number":429,"context_line":"    def watch_elected_as_leader(group_id, callback):"},{"line_number":430,"context_line":"        raise tooz.NotImplemented"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"    @staticmethod"},{"line_number":433,"context_line":"    def unwatch_elected_as_leader(group_id, callback):"},{"line_number":434,"context_line":"        raise tooz.NotImplemented"}],"source_content_type":"text/x-python","patch_set":3,"id":"1af009b1_415f8fce","line":434,"range":{"start_line":428,"start_character":0,"end_line":434,"end_character":33},"updated":"2022-04-11 12:32:50.000000000","message":"You meant that these method are not supported by etcd?\n\nThese methods are provided by the `CoordinationDriver` [1] class which is the parent class of the `CoordinationDriverWithExecutor` [2] class.\n\nThe `CoordinationDriverWithExecutor` is one of the parent classes of the `Etcd3Driver` so these methods are available into this driver.\n\n[1] https://opendev.org/openstack/tooz/src/branch/master/tooz/coordination.py#L231\n[2] https://opendev.org/openstack/tooz/src/branch/master/tooz/coordination.py#L676","commit_id":"d57953c7b31a27727b0f7f8e3e4ac6d103e46230"},{"author":{"_account_id":7549,"name":"Ekaterina Chernova","email":"katyafervent@yandex.ru","username":"efedorova"},"change_message_id":"4b1e89df28447f5e7389ad2078afabd531d9d304","unresolved":false,"context_lines":[{"line_number":425,"context_line":"        return coordination.CoordinatorResult("},{"line_number":426,"context_line":"            self._executor.submit(_get_groups))"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"    @staticmethod"},{"line_number":429,"context_line":"    def watch_elected_as_leader(group_id, callback):"},{"line_number":430,"context_line":"        raise tooz.NotImplemented"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"    @staticmethod"},{"line_number":433,"context_line":"    def unwatch_elected_as_leader(group_id, callback):"},{"line_number":434,"context_line":"        raise tooz.NotImplemented"}],"source_content_type":"text/x-python","patch_set":3,"id":"e32fc48b_328e3ab3","line":434,"range":{"start_line":428,"start_character":0,"end_line":434,"end_character":33},"in_reply_to":"1af009b1_415f8fce","updated":"2022-04-12 06:42:09.000000000","message":"Technically the are available, but there is no realization in driver so tests are falling (see previous build). So these lines are required (another drivers also raise NotImplemented clearly).","commit_id":"d57953c7b31a27727b0f7f8e3e4ac6d103e46230"}]}