)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"dc58bcc4ddf49cd1fdc75d78cea4de74121b8778","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"347236ef_d8651cc4","updated":"2022-05-24 12:53:34.000000000","message":"Without too digging the described issue looks a bit similar too the one described here https://review.opendev.org/c/openstack/tooz/+/842685 .\n\nI\u0027m not a tooz expert so please can you have a look to this other patch and see if the problem fixed by it\u0027s other patch could be the root cause of your problem here.","commit_id":"48ee8bdaaf12e69ed84d590dbf1f625d7e5a7de4"},{"author":{"_account_id":32927,"name":"mitya-eremeev-2","display_name":"Mitya Eremeev","email":"mitossvyaz@mail.ru","username":"mitya-eremeev-2"},"change_message_id":"5ae68d375d541649485d38e0fc8d708015d10898","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e9c62649_60ebb2c4","updated":"2022-05-24 06:25:25.000000000","message":"recheck","commit_id":"48ee8bdaaf12e69ed84d590dbf1f625d7e5a7de4"},{"author":{"_account_id":32927,"name":"mitya-eremeev-2","display_name":"Mitya Eremeev","email":"mitossvyaz@mail.ru","username":"mitya-eremeev-2"},"change_message_id":"3e335c1d4390794938eee72115df5a63ed310a3e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"08ee6309_9a094bdc","in_reply_to":"347236ef_d8651cc4","updated":"2022-05-24 12:58:08.000000000","message":"This review about locks and is not related with current issue.\nMy review is about expired membership lease (etcd client lease).","commit_id":"48ee8bdaaf12e69ed84d590dbf1f625d7e5a7de4"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"aa49357a9ea27758e3cccae2d86f58a690b65f17","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bdb7bbf9_a0881c9a","updated":"2022-05-25 13:54:10.000000000","message":"Hello,\n\nPlease can add a release note too, to describe this fix and highlight this topic to the community.","commit_id":"3ae7d3cf2c9c7b460f70dceb43ea384cc1466d26"},{"author":{"_account_id":32927,"name":"mitya-eremeev-2","display_name":"Mitya Eremeev","email":"mitossvyaz@mail.ru","username":"mitya-eremeev-2"},"change_message_id":"c7b6cc33f64a410ce5bde263890a3d925db8acc6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"895376aa_d06db80d","in_reply_to":"bdb7bbf9_a0881c9a","updated":"2022-05-26 06:45:45.000000000","message":"done","commit_id":"3ae7d3cf2c9c7b460f70dceb43ea384cc1466d26"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"bbebacc3c566b917a4479b1954970f468dc1040c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"35aa7506_7d9fd13f","updated":"2022-06-01 10:04:20.000000000","message":"Hello,\n\nThanks for your latest patch set.\nI have one question, see my inline comment.\n\nThanks by advance for your reply.","commit_id":"ae5adcf3874d3ab40a8f6c475b450e72a75f5d23"}],"tooz/drivers/etcd3gw.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"bbebacc3c566b917a4479b1954970f468dc1040c","unresolved":true,"context_lines":[{"line_number":232,"context_line":""},{"line_number":233,"context_line":"    def heartbeat(self):"},{"line_number":234,"context_line":"        # TODO(kaifeng) use the same lease for locks?"},{"line_number":235,"context_line":"        if self._membership_lease.refresh() \u003d\u003d -1:"},{"line_number":236,"context_line":"            expired_lease \u003d self._membership_lease.id"},{"line_number":237,"context_line":"            self._membership_lease \u003d self.client.lease(self.membership_timeout)"},{"line_number":238,"context_line":"            LOG.debug(\u0027Created new lease %s after previous lease %s expired.\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"2cb03f8f_b730a9e9","line":235,"range":{"start_line":235,"start_character":47,"end_line":235,"end_character":49},"updated":"2022-06-01 10:04:20.000000000","message":"What does `-1` stand for?\n\nBy looking at the etcd documentation and etcd3gw for `lease` and `refresh` I didn\u0027t find `-1` returns.\n\nWhen `refresh` is called Etcd3gw returns the `TTL` of the lease keepalive related to the ID of the lease [1], however I didn\u0027t see that the TTL could be a negative integer [2]. Please can you indicate me where we can ensure that this value will be returned under some conditions and what we should expect in this condition.\n\n[1]https://opendev.org/openstack/etcd3gw/src/commit/7a1a2b5a672605ae549c73ed18302b7abd9e0e30/etcd3gw/lease.py#L64\n[2]https://etcd.io/docs/v3.4/learning/api/#keep-alives","commit_id":"ae5adcf3874d3ab40a8f6c475b450e72a75f5d23"},{"author":{"_account_id":32927,"name":"mitya-eremeev-2","display_name":"Mitya Eremeev","email":"mitossvyaz@mail.ru","username":"mitya-eremeev-2"},"change_message_id":"4df71776d93a84119fb956fdfb881e98406179b5","unresolved":true,"context_lines":[{"line_number":232,"context_line":""},{"line_number":233,"context_line":"    def heartbeat(self):"},{"line_number":234,"context_line":"        # TODO(kaifeng) use the same lease for locks?"},{"line_number":235,"context_line":"        if self._membership_lease.refresh() \u003d\u003d -1:"},{"line_number":236,"context_line":"            expired_lease \u003d self._membership_lease.id"},{"line_number":237,"context_line":"            self._membership_lease \u003d self.client.lease(self.membership_timeout)"},{"line_number":238,"context_line":"            LOG.debug(\u0027Created new lease %s after previous lease %s expired.\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"f5f621ad_26331fe8","line":235,"range":{"start_line":235,"start_character":47,"end_line":235,"end_character":49},"in_reply_to":"2cb03f8f_b730a9e9","updated":"2022-06-01 12:13:28.000000000","message":"Please see commit message:\nDepends-On: https://review.opendev.org/c/openstack/etcd3gw/+/843003","commit_id":"ae5adcf3874d3ab40a8f6c475b450e72a75f5d23"}]}