)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"0149f677426f76ff07a4fcfed56f62733783c303","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The issue with current one is we try to use blocking as timeout"},{"line_number":10,"context_line":"provider."},{"line_number":11,"context_line":"That make the timeout setting in mysql bindled with blocking."},{"line_number":12,"context_line":"And the lock can\u0027t served with scenario that when we don\u0027t need timeout"},{"line_number":13,"context_line":"blocking but still timeout required."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b134388e_2430bc11","line":11,"range":{"start_line":11,"start_character":39,"end_line":11,"end_character":46},"updated":"2023-07-10 08:44:34.000000000","message":"bound?","commit_id":"74a1b78ffbcf94d535fe4b0bcfb21bc532a1fc6f"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"4d56b29c11771e1ad64c0c486923c4ba581c78a8","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The issue with current one is we try to use blocking as timeout"},{"line_number":10,"context_line":"provider."},{"line_number":11,"context_line":"That make the timeout setting in mysql bindled with blocking."},{"line_number":12,"context_line":"And the lock can\u0027t served with scenario that when we don\u0027t need timeout"},{"line_number":13,"context_line":"blocking but still timeout required."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"89b78504_2dec3fad","line":11,"range":{"start_line":11,"start_character":39,"end_line":11,"end_character":46},"in_reply_to":"b134388e_2430bc11","updated":"2023-07-10 14:56:43.000000000","message":"Done","commit_id":"74a1b78ffbcf94d535fe4b0bcfb21bc532a1fc6f"}],"tooz/drivers/mysql.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"0149f677426f76ff07a4fcfed56f62733783c303","unresolved":true,"context_lines":[{"line_number":58,"context_line":"                    raise _retry.TryAgain"},{"line_number":59,"context_line":"                return False"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"            _, timeout \u003d utils.convert_blocking(blocking)"},{"line_number":62,"context_line":"            try:"},{"line_number":63,"context_line":"                if not self._conn.open:"},{"line_number":64,"context_line":"                    self._conn.connect()"}],"source_content_type":"text/x-python","patch_set":1,"id":"bbdf8d04_e21cab9b","side":"PARENT","line":61,"range":{"start_line":61,"start_character":12,"end_line":61,"end_character":57},"updated":"2023-07-10 08:44:34.000000000","message":"Indeed you are right timeout is tiedly coupled to blocking and we are not able to retrieve locks if blocking is false.\n\nThese changes seems to make sense.","commit_id":"d5bf20cbcc3647c08025104d559102f44e30bd15"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"4d56b29c11771e1ad64c0c486923c4ba581c78a8","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                    raise _retry.TryAgain"},{"line_number":59,"context_line":"                return False"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"            _, timeout \u003d utils.convert_blocking(blocking)"},{"line_number":62,"context_line":"            try:"},{"line_number":63,"context_line":"                if not self._conn.open:"},{"line_number":64,"context_line":"                    self._conn.connect()"}],"source_content_type":"text/x-python","patch_set":1,"id":"60503e1d_e210c22c","side":"PARENT","line":61,"range":{"start_line":61,"start_character":12,"end_line":61,"end_character":57},"in_reply_to":"bbdf8d04_e21cab9b","updated":"2023-07-10 14:56:43.000000000","message":"Done","commit_id":"d5bf20cbcc3647c08025104d559102f44e30bd15"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6ba7e001d7e7b2798a01d159905139d253caa0c3","unresolved":true,"context_lines":[{"line_number":37,"context_line":"        self.acquired \u003d False"},{"line_number":38,"context_line":"        self._conn \u003d MySQLDriver.get_connection(parsed_url, options, True)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def acquire(self, blocking\u003dTrue, shared\u003dFalse, timeout\u003d0):"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        if shared:"},{"line_number":43,"context_line":"            raise tooz.NotImplemented"}],"source_content_type":"text/x-python","patch_set":2,"id":"f0170405_9575837a","line":40,"range":{"start_line":40,"start_character":8,"end_line":40,"end_character":15},"updated":"2023-12-22 05:43:26.000000000","message":"We need the same interface change in the other drivers. This is part of the common driver interface and should not be different among drivers.","commit_id":"bed303e9b47b5aef3a9e2d6a5da4b5891e9e6689"}],"tooz/tests/test_mysql.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"0149f677426f76ff07a4fcfed56f62733783c303","unresolved":true,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        )"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    @mock.patch(\"pymysql.Connect\")"},{"line_number":90,"context_line":"    def test_parsing_timeout_settings(self, sql_mock):"},{"line_number":91,"context_line":"        c \u003d self._create_coordinator(\"mysql://localhost:3306/test\")"},{"line_number":92,"context_line":"        c.start()"}],"source_content_type":"text/x-python","patch_set":1,"id":"c44bdbee_8c73d15e","side":"PARENT","line":89,"range":{"start_line":89,"start_character":10,"end_line":89,"end_character":15},"updated":"2023-07-10 08:44:34.000000000","message":"Why removing this test? I mean, still this test seems ok, isn\u0027t?\nat least with the original scenario where blocking is equal to true.\n\nIs it not possible to implement a scenario related to your changes?","commit_id":"d5bf20cbcc3647c08025104d559102f44e30bd15"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"4d56b29c11771e1ad64c0c486923c4ba581c78a8","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        )"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    @mock.patch(\"pymysql.Connect\")"},{"line_number":90,"context_line":"    def test_parsing_timeout_settings(self, sql_mock):"},{"line_number":91,"context_line":"        c \u003d self._create_coordinator(\"mysql://localhost:3306/test\")"},{"line_number":92,"context_line":"        c.start()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ac6dc35_6b1feb37","side":"PARENT","line":89,"range":{"start_line":89,"start_character":10,"end_line":89,"end_character":15},"in_reply_to":"c44bdbee_8c73d15e","updated":"2023-07-10 14:56:43.000000000","message":"Done","commit_id":"d5bf20cbcc3647c08025104d559102f44e30bd15"}]}