)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f23401c2e159b8583afc649f8c1efaed05a74888","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"66ef9bbb_3c510773","updated":"2023-10-17 05:35:38.000000000","message":"I\u0027m wondering if it\u0027s a good idea to introduce sherlock library. It looks like the library also implements locking based on redis and memcached. Will we replace the existing implementation of memcached/redis driver? I feel like pulling the library introduces a bit redundant dependency layer.\n\nmy -1 is mostly about the wrong license mentioned but if the lock mechanism can be implemented relatively easily using raw k8s client then I tend to prefer using the client directly instead of adding another lock library as tooz\u0027s dependencies.","commit_id":"ef396d8b1aa8bccbd7978a014b90f51ff9e5d633"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"efd6000e50d421da0019d84eceb91ea339fe920e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2b5792d3_cb75734a","updated":"2023-10-13 11:18:16.000000000","message":"LGTM","commit_id":"ef396d8b1aa8bccbd7978a014b90f51ff9e5d633"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"726a9353e204c34847a584880826eec0a81f44a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7c3f9468_20b430b2","in_reply_to":"4d1af624_11a8a53c","updated":"2023-10-26 05:45:45.000000000","message":"@Takashi I will mark this as resolved unless you think we need more discussion on the using sherlock lib.","commit_id":"ef396d8b1aa8bccbd7978a014b90f51ff9e5d633"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"ca487b0beb9261a4095c4a3f4b90c5b21587725a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4d1af624_11a8a53c","in_reply_to":"66ef9bbb_3c510773","updated":"2023-10-17 05:43:40.000000000","message":"Fixed, the license part.\nFor the introduce sherlock part, I think that library is fairly defined and implemented. I think of no reason to add another layer to build client by tooz itself.","commit_id":"ef396d8b1aa8bccbd7978a014b90f51ff9e5d633"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b7d9753b547a8ec1dcd264586ebecf52a15fcb2c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"97731f0b_bf2472b5","in_reply_to":"7c3f9468_20b430b2","updated":"2024-03-05 08:24:25.000000000","message":"Re-reviewing the current status of sherlock library I have some doublts about its status.\n\nhttps://github.com/py-sherlock/sherlock\n\n* No update for 1 year\n* There are some open PRs left without any feedback\n * https://github.com/py-sherlock/sherlock/pull/72 For example has had not feedback for almost 1 year\n* There are some open issues left for some time https://github.com/py-sherlock/sherlock/issues\n* pytoml in the repo says it requires kubernetes 24.2.0 but in global upper constraints we have 29.0.0\n\nWe can discuss this further in a separate review (which is required before this is merged) in the requirements repo to add sherlock, but we have to clear these concerns and make sure that this library is kept maintained (at least for a few years from now).","commit_id":"ef396d8b1aa8bccbd7978a014b90f51ff9e5d633"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"d9e0cfa7f55c59708b61a645f5555633e360d7e1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9a8b9d48_c86f833d","in_reply_to":"97731f0b_bf2472b5","updated":"2024-12-16 09:15:47.000000000","message":"There is also another way to just create new k8s lock repo or directly move it in tooz.\nTBH, the functionality is pretty simple. (just one simple lock.py file https://github.com/py-sherlock/sherlock/blob/master/sherlock/lock.py and it\u0027s dependencies)","commit_id":"ef396d8b1aa8bccbd7978a014b90f51ff9e5d633"},{"author":{"_account_id":31245,"name":"Daniel Bengtsson","email":"dbengt@redhat.com","username":"damani42"},"change_message_id":"b04e01d1fa9cd85be57f10d0761d92c8a6b90668","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"001a422e_6ecd0983","updated":"2024-02-12 16:33:19.000000000","message":"What is the status here. Still relevant?","commit_id":"820aba12356a4e1e2be10d87ffb4dc914bf298fc"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"e929872bb2ea67ad075d9bb1193b11185aa2de59","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3375bccb_0d6352e2","updated":"2023-10-17 08:37:20.000000000","message":"recheck","commit_id":"820aba12356a4e1e2be10d87ffb4dc914bf298fc"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"2a374bab6148df604ecf20e167406213e4af529d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"aeb655c8_22bb35c5","in_reply_to":"001a422e_6ecd0983","updated":"2024-03-05 08:06:44.000000000","message":"I\u0027m still looking forward for this to land:)","commit_id":"820aba12356a4e1e2be10d87ffb4dc914bf298fc"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b7d9753b547a8ec1dcd264586ebecf52a15fcb2c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"7fc32a72_533344c2","updated":"2024-03-05 08:24:25.000000000","message":"Sorry this dropped off from my radar.\n\nI noticed that sherlock is not in global requirements and that may need to be fixed first (that\u0027s why I put -1 now. sorry I didn\u0027t notice it in my previous review), but there seems to be some points indicating that the library is not well maintained now, I\u0027m afraid.","commit_id":"7e934b90a410efaec22cf843fea43d250f4b05fb"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"34c57eb9364b3a7d42f1bd02dd38652c4370dcc5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"b3991e74_525f4d9e","updated":"2024-11-22 13:57:20.000000000","message":"recheck dependency updated","commit_id":"d18976458e8b6e21da88e0984db49e1c7b9c52c4"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"af82eb1fb223469b22f68e02d909c52b82370da1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"4a86aa14_734dde35","updated":"2025-04-07 06:09:07.000000000","message":"Or team is more prefering rewrite in tooz?","commit_id":"7b69ca7270714ef125aeeeefe4ba39b021c8a823"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"409c31a15805d6e5cde5150cf7b0a16f046db7f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"c9d1230d_6e45b339","updated":"2024-12-13 15:25:25.000000000","message":"recheck","commit_id":"7b69ca7270714ef125aeeeefe4ba39b021c8a823"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"52bd717e6d25456da90ff1666b4efd62959deac4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"75212abe_a43d44e9","updated":"2025-04-07 06:05:50.000000000","message":"sherlock is now in requirements https://github.com/openstack/requirements/blob/master/upper-constraints.txt#L432C1-L432C9\n\nIMO, now we should be fine to adopt it here right?","commit_id":"7b69ca7270714ef125aeeeefe4ba39b021c8a823"}],"setup.cfg":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f23401c2e159b8583afc649f8c1efaed05a74888","unresolved":true,"context_lines":[{"line_number":71,"context_line":"  sysv-ipc\u003e\u003d0.6.8 # BSD License"},{"line_number":72,"context_line":"kubernetes \u003d"},{"line_number":73,"context_line":"  kubernetes\u003e\u003d2.8.1 # Apache-2.0"},{"line_number":74,"context_line":"  sherlock\u003e\u003d0.4.1 # Apache-2.0"}],"source_content_type":"text/x-ttcn-cfg","patch_set":6,"id":"a6e55fb4_b9efc282","line":74,"range":{"start_line":74,"start_character":20,"end_line":74,"end_character":30},"updated":"2023-10-17 05:35:38.000000000","message":"If I\u0027m looking at the correct repository the MIT license is used.\n\nhttps://github.com/py-sherlock/sherlock/blob/master/LICENSE.rst","commit_id":"ef396d8b1aa8bccbd7978a014b90f51ff9e5d633"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"ca487b0beb9261a4095c4a3f4b90c5b21587725a","unresolved":false,"context_lines":[{"line_number":71,"context_line":"  sysv-ipc\u003e\u003d0.6.8 # BSD License"},{"line_number":72,"context_line":"kubernetes \u003d"},{"line_number":73,"context_line":"  kubernetes\u003e\u003d2.8.1 # Apache-2.0"},{"line_number":74,"context_line":"  sherlock\u003e\u003d0.4.1 # Apache-2.0"}],"source_content_type":"text/x-ttcn-cfg","patch_set":6,"id":"2c49c99d_69de8772","line":74,"range":{"start_line":74,"start_character":20,"end_line":74,"end_character":30},"in_reply_to":"a6e55fb4_b9efc282","updated":"2023-10-17 05:43:40.000000000","message":"Done","commit_id":"ef396d8b1aa8bccbd7978a014b90f51ff9e5d633"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b7d9753b547a8ec1dcd264586ebecf52a15fcb2c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a32eb46c_95419934","line":71,"range":{"start_line":69,"start_character":32,"end_line":71,"end_character":1},"updated":"2024-03-05 08:24:25.000000000","message":"probably we should add this to global-requirements file in requirements repo ?","commit_id":"7e934b90a410efaec22cf843fea43d250f4b05fb"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"d9e0cfa7f55c59708b61a645f5555633e360d7e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"35cfc922_8ad9db50","line":71,"range":{"start_line":69,"start_character":32,"end_line":71,"end_character":1},"in_reply_to":"47cbc94e_4caa47e7","updated":"2024-12-16 09:15:47.000000000","message":"Done","commit_id":"7e934b90a410efaec22cf843fea43d250f4b05fb"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"67a68d95616bce51d903dcddf04d3537fc313df2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"fe76ea22_8580d929","line":71,"range":{"start_line":69,"start_character":32,"end_line":71,"end_character":1},"in_reply_to":"a32eb46c_95419934","updated":"2024-03-17 17:56:21.000000000","message":"It turned out we don\u0027t have requirement check job in tooz and python-consul2 is not in global requirements either.\n\nI\u0027ll check if I can fix it but even if we leave this part, we may need to have a clear strategy about sherlock library.","commit_id":"7e934b90a410efaec22cf843fea43d250f4b05fb"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4d8d66f2f05581760f82a1134a38a3560b856227","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"47cbc94e_4caa47e7","line":71,"range":{"start_line":69,"start_character":32,"end_line":71,"end_character":1},"in_reply_to":"fe76ea22_8580d929","updated":"2024-08-15 10:08:09.000000000","message":"JFYI. I\u0027ve added python-consul2 to global requirements and enabled the requirements check job. So now you have to add sherlock to global requirements.","commit_id":"7e934b90a410efaec22cf843fea43d250f4b05fb"}]}