)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"785fbc9aba77ee2804cdcc2624166cae191b6d99","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This also makes the current implementation consistent with taskflow."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1] 4954e284b9616f5e0c2cea77d94bbe18e0b8fd39"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #2056429"},{"line_number":17,"context_line":"Change-Id: Iaa5f09e8dcfff9e65853f6f89976cf4c025bc864"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"24f50a04_01cce592","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":2},"updated":"2024-03-07 09:04:53.000000000","message":"do you mean https://review.opendev.org/c/openstack/tooz/+/907659 ?\nbecause this ID also points to the commit fixing itself?","commit_id":"94d299c77736dafb9eadb80f080aec3d974d3edf"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b9347f7b91b80098a6f8e9dc7570f4b2c50c5c94","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This also makes the current implementation consistent with taskflow."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1] 4954e284b9616f5e0c2cea77d94bbe18e0b8fd39"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #2056429"},{"line_number":17,"context_line":"Change-Id: Iaa5f09e8dcfff9e65853f6f89976cf4c025bc864"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"59a3be09_18455b3c","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":2},"in_reply_to":"24f50a04_01cce592","updated":"2024-03-07 09:32:31.000000000","message":"Yes. I usually use commit id instead of gerrit id in commit message because commit id can be looked up locally...","commit_id":"94d299c77736dafb9eadb80f080aec3d974d3edf"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"34e8083f2d4309e9f9124a78f0cd2d213d677d44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"54ddd1e7_42590f35","updated":"2024-03-07 08:46:14.000000000","message":"can this be tested somehow other than making a release and running it in kolla?","commit_id":"94d299c77736dafb9eadb80f080aec3d974d3edf"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4224cf1403ff230f52e0e16a4f5be81b5158c740","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c5bea9a6_61853261","in_reply_to":"54ddd1e7_42590f35","updated":"2024-03-07 09:24:42.000000000","message":"We have to dig into the current functional tests to find out why functional tests with redis sentinel didn\u0027t caught the problem but it may take some time. tooz is known to have very low unit test coverage so adding unit tests may still take some time.\n\nFor now I reproduced the problem in my local with tooz 6.0.0 and confirmed that this change resolves the problem.","commit_id":"94d299c77736dafb9eadb80f080aec3d974d3edf"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3b533f18569ffe66a0f1b95adb0c5df1b5ff021b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1d7e31d9_3efe866a","in_reply_to":"c5bea9a6_61853261","updated":"2024-03-07 10:53:30.000000000","message":"https://review.opendev.org/c/openstack/tooz/+/911682/ should address the test coverage problem.","commit_id":"94d299c77736dafb9eadb80f080aec3d974d3edf"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"785fbc9aba77ee2804cdcc2624166cae191b6d99","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3d31f1fb_e12775b1","updated":"2024-03-07 09:04:53.000000000","message":"I agree any kind of test (even if maybe mocked) would be nice so this isn\u0027t just catched downstream once a regression is introduced.","commit_id":"a20ca740cf5ad29c74026937d75314a8823d3361"}],"tooz/drivers/redis.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"34e8083f2d4309e9f9124a78f0cd2d213d677d44","unresolved":true,"context_lines":[{"line_number":473,"context_line":"                for fallback in kwargs.pop(\u0027sentinel_fallback\u0027, [])"},{"line_number":474,"context_line":"            ]"},{"line_number":475,"context_line":"            sentinel_hosts.insert(0, (kwargs.pop(\u0027host\u0027), kwargs.pop(\u0027port\u0027)))"},{"line_number":476,"context_line":"            for fallback in kwargs.pop(\u0027sentinel_fallback\u0027, []):"},{"line_number":477,"context_line":"                sentinel_hosts.append(cls._parse_sentinel(fallback))"},{"line_number":478,"context_line":"            sentinel_name \u003d kwargs.pop(\u0027sentinel\u0027)"},{"line_number":479,"context_line":"            sentinel_server \u003d sentinel.Sentinel("},{"line_number":480,"context_line":"                sentinel_hosts,"}],"source_content_type":"text/x-python","patch_set":1,"id":"681347a9_81a66f5a","line":477,"range":{"start_line":476,"start_character":12,"end_line":477,"end_character":68},"updated":"2024-03-07 08:46:14.000000000","message":"this seems duplicate of the loop above and doesn\u0027t make sense to me","commit_id":"94d299c77736dafb9eadb80f080aec3d974d3edf"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"610227126bdff1c39846cc665ca78e40fc1a5347","unresolved":false,"context_lines":[{"line_number":473,"context_line":"                for fallback in kwargs.pop(\u0027sentinel_fallback\u0027, [])"},{"line_number":474,"context_line":"            ]"},{"line_number":475,"context_line":"            sentinel_hosts.insert(0, (kwargs.pop(\u0027host\u0027), kwargs.pop(\u0027port\u0027)))"},{"line_number":476,"context_line":"            for fallback in kwargs.pop(\u0027sentinel_fallback\u0027, []):"},{"line_number":477,"context_line":"                sentinel_hosts.append(cls._parse_sentinel(fallback))"},{"line_number":478,"context_line":"            sentinel_name \u003d kwargs.pop(\u0027sentinel\u0027)"},{"line_number":479,"context_line":"            sentinel_server \u003d sentinel.Sentinel("},{"line_number":480,"context_line":"                sentinel_hosts,"}],"source_content_type":"text/x-python","patch_set":1,"id":"d46f8587_b8c1e100","line":477,"range":{"start_line":476,"start_character":12,"end_line":477,"end_character":68},"in_reply_to":"681347a9_81a66f5a","updated":"2024-03-07 08:53:57.000000000","message":"Sorry I pulled a change for different topic. Dropped it.","commit_id":"94d299c77736dafb9eadb80f080aec3d974d3edf"}]}