)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"b79fc0cded7aea61f84e2f14612cacc7b230d67e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"baac3b7f_3d20c582","updated":"2025-02-05 08:56:17.000000000","message":"recheck","commit_id":"5c47154a38c9ac3cc691cf00cb62a62af7247592"}],"tooz/drivers/zookeeper.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"96c932a32efb60866bede429c42bb68671f34cb6","unresolved":true,"context_lines":[{"line_number":120,"context_line":"    }"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    if eventlet_handler:"},{"line_number":123,"context_line":"        debtcollector.deprecate("},{"line_number":124,"context_line":"            \"Eventlet support is deprecated \""},{"line_number":125,"context_line":"            \"and will be soon no longer supported. \""},{"line_number":126,"context_line":"            \"Kazoo\u0027s eventlet handler is now deprecated. \""},{"line_number":127,"context_line":"            \"Please prefer using kazoo\u0027s threading handler. \""},{"line_number":128,"context_line":"            \"Please migrate your code and stop monkey patching your \""},{"line_number":129,"context_line":"            \"environment.\")"},{"line_number":130,"context_line":"        HANDLERS[\u0027eventlet\u0027] \u003d eventlet_handler.SequentialEventletHandler"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"54759ad7_9e58988f","line":129,"range":{"start_line":123,"start_character":0,"end_line":129,"end_character":27},"updated":"2025-02-02 14:51:05.000000000","message":"This logic is always called if eventlet is present. We should not add warning here.","commit_id":"d9089c09a39c6dab9c6f541a6b3786cc8474d0e4"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"2a1b7ca2b69e7f976ce12aa03aec39312b433c70","unresolved":false,"context_lines":[{"line_number":120,"context_line":"    }"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    if eventlet_handler:"},{"line_number":123,"context_line":"        debtcollector.deprecate("},{"line_number":124,"context_line":"            \"Eventlet support is deprecated \""},{"line_number":125,"context_line":"            \"and will be soon no longer supported. \""},{"line_number":126,"context_line":"            \"Kazoo\u0027s eventlet handler is now deprecated. \""},{"line_number":127,"context_line":"            \"Please prefer using kazoo\u0027s threading handler. \""},{"line_number":128,"context_line":"            \"Please migrate your code and stop monkey patching your \""},{"line_number":129,"context_line":"            \"environment.\")"},{"line_number":130,"context_line":"        HANDLERS[\u0027eventlet\u0027] \u003d eventlet_handler.SequentialEventletHandler"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"c9a66143_99d7936f","line":129,"range":{"start_line":123,"start_character":0,"end_line":129,"end_character":27},"in_reply_to":"54759ad7_9e58988f","updated":"2025-02-03 09:16:23.000000000","message":"Done","commit_id":"d9089c09a39c6dab9c6f541a6b3786cc8474d0e4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"96c932a32efb60866bede429c42bb68671f34cb6","unresolved":true,"context_lines":[{"line_number":501,"context_line":"            \u0027use_ssl\u0027: strutils.bool_from_string(use_ssl),"},{"line_number":502,"context_line":"            \u0027verify_certs\u0027: strutils.bool_from_string(verify_certs),"},{"line_number":503,"context_line":"        }"},{"line_number":504,"context_line":"        handler_kind \u003d options.get(\u0027handler\u0027)"},{"line_number":505,"context_line":"        if handler_kind:"},{"line_number":506,"context_line":"            try:"},{"line_number":507,"context_line":"                handler_cls \u003d self.HANDLERS[handler_kind]"}],"source_content_type":"text/x-python","patch_set":1,"id":"a8b62ea5_26d7642e","line":504,"range":{"start_line":504,"start_character":8,"end_line":504,"end_character":45},"updated":"2025-02-02 14:51:05.000000000","message":"What we should deprecate instead is usage of handler\u003d\u0027eventlet\u0027. I\u0027ve checked current kazoo code and see it uses threading handler by default.\n\nhttps://github.com/python-zk/kazoo/blob/c5ab98819b3a797e12a0315e97e51851525da70f/kazoo/client.py#L227","commit_id":"d9089c09a39c6dab9c6f541a6b3786cc8474d0e4"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"2a1b7ca2b69e7f976ce12aa03aec39312b433c70","unresolved":false,"context_lines":[{"line_number":501,"context_line":"            \u0027use_ssl\u0027: strutils.bool_from_string(use_ssl),"},{"line_number":502,"context_line":"            \u0027verify_certs\u0027: strutils.bool_from_string(verify_certs),"},{"line_number":503,"context_line":"        }"},{"line_number":504,"context_line":"        handler_kind \u003d options.get(\u0027handler\u0027)"},{"line_number":505,"context_line":"        if handler_kind:"},{"line_number":506,"context_line":"            try:"},{"line_number":507,"context_line":"                handler_cls \u003d self.HANDLERS[handler_kind]"}],"source_content_type":"text/x-python","patch_set":1,"id":"a658c074_beb95181","line":504,"range":{"start_line":504,"start_character":8,"end_line":504,"end_character":45},"in_reply_to":"a8b62ea5_26d7642e","updated":"2025-02-03 09:16:23.000000000","message":"Done","commit_id":"d9089c09a39c6dab9c6f541a6b3786cc8474d0e4"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6a6f563fb33c8c5bd3f4b2316da78b370940c9d1","unresolved":true,"context_lines":[{"line_number":498,"context_line":"        if handler_kind \u003d\u003d \"eventlet\":"},{"line_number":499,"context_line":"            debtcollector.deprecate("},{"line_number":500,"context_line":"                \"Eventlet support is deprecated \""},{"line_number":501,"context_line":"                \"and will be soon no longer supported. \""},{"line_number":502,"context_line":"                \"Kazoo\u0027s eventlet handler is now deprecated. \""},{"line_number":503,"context_line":"                \"Please prefer using kazoo\u0027s threading handler. \""},{"line_number":504,"context_line":"                \"Please migrate your code and stop monkey patching your \""}],"source_content_type":"text/x-python","patch_set":2,"id":"7abae7e1_c2758243","line":501,"range":{"start_line":501,"start_character":21,"end_line":501,"end_character":55},"updated":"2025-02-03 11:18:29.000000000","message":"I noticed this to later, but \"support will not be no longer supported\" is a bit confusing. Probably \"will be soon removed\" is a better wording.","commit_id":"5de6165214004021273a6a68dc9e089c09942670"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"325bc4cb7c6f40d71fea9e632108bafdcc828d5f","unresolved":false,"context_lines":[{"line_number":498,"context_line":"        if handler_kind \u003d\u003d \"eventlet\":"},{"line_number":499,"context_line":"            debtcollector.deprecate("},{"line_number":500,"context_line":"                \"Eventlet support is deprecated \""},{"line_number":501,"context_line":"                \"and will be soon no longer supported. \""},{"line_number":502,"context_line":"                \"Kazoo\u0027s eventlet handler is now deprecated. \""},{"line_number":503,"context_line":"                \"Please prefer using kazoo\u0027s threading handler. \""},{"line_number":504,"context_line":"                \"Please migrate your code and stop monkey patching your \""}],"source_content_type":"text/x-python","patch_set":2,"id":"bcd093a3_7155d48d","line":501,"range":{"start_line":501,"start_character":21,"end_line":501,"end_character":55},"in_reply_to":"7abae7e1_c2758243","updated":"2025-02-04 09:16:46.000000000","message":"Done","commit_id":"5de6165214004021273a6a68dc9e089c09942670"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6a6f563fb33c8c5bd3f4b2316da78b370940c9d1","unresolved":true,"context_lines":[{"line_number":499,"context_line":"            debtcollector.deprecate("},{"line_number":500,"context_line":"                \"Eventlet support is deprecated \""},{"line_number":501,"context_line":"                \"and will be soon no longer supported. \""},{"line_number":502,"context_line":"                \"Kazoo\u0027s eventlet handler is now deprecated. \""},{"line_number":503,"context_line":"                \"Please prefer using kazoo\u0027s threading handler. \""},{"line_number":504,"context_line":"                \"Please migrate your code and stop monkey patching your \""},{"line_number":505,"context_line":"                \"environment.\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"a29eba1f_675047a1","line":502,"range":{"start_line":502,"start_character":17,"end_line":502,"end_character":41},"updated":"2025-02-03 11:18:29.000000000","message":"I think `Using Kazoo\u0027s eventlet handler is now deprecated.` is better, because the eventlet handler is kazoo itself is not deprecated.","commit_id":"5de6165214004021273a6a68dc9e089c09942670"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"325bc4cb7c6f40d71fea9e632108bafdcc828d5f","unresolved":false,"context_lines":[{"line_number":499,"context_line":"            debtcollector.deprecate("},{"line_number":500,"context_line":"                \"Eventlet support is deprecated \""},{"line_number":501,"context_line":"                \"and will be soon no longer supported. \""},{"line_number":502,"context_line":"                \"Kazoo\u0027s eventlet handler is now deprecated. \""},{"line_number":503,"context_line":"                \"Please prefer using kazoo\u0027s threading handler. \""},{"line_number":504,"context_line":"                \"Please migrate your code and stop monkey patching your \""},{"line_number":505,"context_line":"                \"environment.\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"785b297f_2543909e","line":502,"range":{"start_line":502,"start_character":17,"end_line":502,"end_character":41},"in_reply_to":"a29eba1f_675047a1","updated":"2025-02-04 09:16:46.000000000","message":"Done","commit_id":"5de6165214004021273a6a68dc9e089c09942670"}]}