)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1f8faecd7c748379961c164ce2c8a7a08a40da56","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"cccb64e5_3439f8e8","updated":"2026-05-01 17:30:59.000000000","message":"I\u0027ve addressed the comments and my opportunities to work on this are going to be limited for the next few months from Monday. Let\u0027s get it in. We can always revert/propose follow-ups for anything I\u0027ve missed.","commit_id":"a34ab202e9bb5cb641729219684c8fddbe0f1d71"}],"tooz/drivers/kubernetes.py":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"0e2198f301747031cc91b70a960af6fb5fabf864","unresolved":true,"context_lines":[{"line_number":48,"context_line":"                )"},{"line_number":49,"context_line":"        return False"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def acquire("},{"line_number":52,"context_line":"        self,"},{"line_number":53,"context_line":"        blocking: bool \u003d True,"},{"line_number":54,"context_line":"        shared: bool \u003d False,"},{"line_number":55,"context_line":"        timeout: float | None \u003d None,"},{"line_number":56,"context_line":"        expire: int | None \u003d None,"},{"line_number":57,"context_line":"    ) -\u003e bool:"},{"line_number":58,"context_line":"        if shared:"},{"line_number":59,"context_line":"            raise tooz.NotImplemented(\"not implemented\")"},{"line_number":60,"context_line":"        blocking, timeout \u003d utils.convert_blocking(blocking)"}],"source_content_type":"text/x-python","patch_set":6,"id":"6ee7875f_8f96e042","line":57,"range":{"start_line":51,"start_character":4,"end_line":57,"end_character":14},"updated":"2026-04-24 13:28:56.000000000","message":"Looks like this is a correction as well to satisfy the tooz.locking.Lock abstraction but the expire parameter seems to be wrong here, but probably since implementation.\n\nBut this do change the parameter ordering here?","commit_id":"0191e52c6f4ef9453afbb7514f283e31bcf7f139"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"59ed4ee24beaf1060905673fc6b93a806eeb068b","unresolved":true,"context_lines":[{"line_number":48,"context_line":"                )"},{"line_number":49,"context_line":"        return False"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def acquire("},{"line_number":52,"context_line":"        self,"},{"line_number":53,"context_line":"        blocking: bool \u003d True,"},{"line_number":54,"context_line":"        shared: bool \u003d False,"},{"line_number":55,"context_line":"        timeout: float | None \u003d None,"},{"line_number":56,"context_line":"        expire: int | None \u003d None,"},{"line_number":57,"context_line":"    ) -\u003e bool:"},{"line_number":58,"context_line":"        if shared:"},{"line_number":59,"context_line":"            raise tooz.NotImplemented(\"not implemented\")"},{"line_number":60,"context_line":"        blocking, timeout \u003d utils.convert_blocking(blocking)"}],"source_content_type":"text/x-python","patch_set":6,"id":"255c7dfb_e1044649","line":57,"range":{"start_line":51,"start_character":4,"end_line":57,"end_character":14},"in_reply_to":"6ee7875f_8f96e042","updated":"2026-04-27 11:27:37.000000000","message":"\u003e Looks like this is a correction as well to satisfy the tooz.locking.Lock abstraction but the expire parameter seems to be wrong here, but probably since implementation.\n\u003e \n\u003e But this do change the parameter ordering here?\n\nIt would, but I believe it is very unlikely that anyone is calling this positional-only arguments (or even calling it manually, as opposed to letting the driver call it). Let\u0027s defer this change to later though, to be safe.","commit_id":"0191e52c6f4ef9453afbb7514f283e31bcf7f139"}]}
