)]}'
{"toscaparser/prereq/csar.py":[{"author":{"_account_id":6456,"name":"Sahdev Zala","email":"spzala@us.ibm.com","username":"spzala"},"change_message_id":"51bc170e7137ad1cf08d06597613e9acb8a9fe05","unresolved":true,"context_lines":[{"line_number":373,"context_line":"        self.main_template_file_name \u003d root_files[0]"},{"line_number":374,"context_line":"        return True"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"    def _validate_artifact_name(self, node_templates, resource_file):"},{"line_number":377,"context_line":"        artifact_name \u003d \"none\""},{"line_number":378,"context_line":"        for node_template_key in node_templates:"},{"line_number":379,"context_line":"            node_template \u003d node_templates[node_template_key]"}],"source_content_type":"text/x-python","patch_set":5,"id":"754b121f_148d7165","line":376,"updated":"2021-01-12 16:47:28.000000000","message":"How is passed \"resource_file\" used in this func?\nAlso, would suggest to add a test for this func.","commit_id":"ea1b8e3c356d55914e3731373777d9159161271c"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"ea512db4acde2ea57752398ac6cb6d870a0ad107","unresolved":true,"context_lines":[{"line_number":373,"context_line":"        self.main_template_file_name \u003d root_files[0]"},{"line_number":374,"context_line":"        return True"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"    def _validate_artifact_name(self, node_templates, resource_file):"},{"line_number":377,"context_line":"        artifact_name \u003d \"none\""},{"line_number":378,"context_line":"        for node_template_key in node_templates:"},{"line_number":379,"context_line":"            node_template \u003d node_templates[node_template_key]"}],"source_content_type":"text/x-python","patch_set":5,"id":"12107c8e_c1a6fdc3","line":376,"in_reply_to":"754b121f_148d7165","updated":"2021-01-18 04:51:55.000000000","message":"Thank you for your comment.\nI saw that it has no use, so I removed it. It will be reflected in this patch upload.\n\nAdditionally, this function is already tested in  \"test_csar_invalid_artifact\" function, however, when the function returns false, it goes into the else part which sets \"raise_exc\" variable to true and it goes into this condition block which specifies the ValueError for resource_file. I just reused the same error condition for when the resource does not exist.","commit_id":"ea1b8e3c356d55914e3731373777d9159161271c"}],"toscaparser/tests/test_prereq.py":[{"author":{"_account_id":16511,"name":"Bob Haddleton","email":"bob.haddleton@nokia.com","username":"bobh"},"change_message_id":"88463c92de168c968fce8e6b622c5f482a645208","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        self.assertTrue(csar.temp_dir is None or"},{"line_number":134,"context_line":"                        not os.path.exists(csar.temp_dir))"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def test_csar_invalid_script_path(self):"},{"line_number":137,"context_line":"        path \u003d os.path.join(self.base_path,"},{"line_number":138,"context_line":"                            \"data/CSAR/csar_wordpress_invalid_script_path.zip\")"},{"line_number":139,"context_line":"        csar \u003d CSAR(path)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_ac8fe92b","side":"PARENT","line":136,"updated":"2020-09-11 23:59:37.000000000","message":"Why is this test being removed?","commit_id":"9b42fa3d32725fc1f2538878bb9b0fa8c84b9d9b"},{"author":{"_account_id":32219,"name":"Aldinson C. Esto","email":"esto.aln@nec.com","username":"esto-aln"},"change_message_id":"fd925a4b0402390a3b98893c84bd0b0f534e8dfe","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        self.assertTrue(csar.temp_dir is None or"},{"line_number":134,"context_line":"                        not os.path.exists(csar.temp_dir))"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def test_csar_invalid_script_path(self):"},{"line_number":137,"context_line":"        path \u003d os.path.join(self.base_path,"},{"line_number":138,"context_line":"                            \"data/CSAR/csar_wordpress_invalid_script_path.zip\")"},{"line_number":139,"context_line":"        csar \u003d CSAR(path)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_d3287e86","side":"PARENT","line":136,"in_reply_to":"9f560f44_ac8fe92b","updated":"2020-09-26 05:15:44.000000000","message":"I restored it and improved my checking for the valid implementation name if it is not a file. Please review this as well.","commit_id":"9b42fa3d32725fc1f2538878bb9b0fa8c84b9d9b"}]}