)]}'
{"toscaparser/policy.py":[{"author":{"_account_id":31821,"name":"LiangLu","email":"lu.liang@jp.fujitsu.com","username":"LiangLu"},"change_message_id":"64329681d44b44d55b16e9c799578470a21b7909","unresolved":true,"context_lines":[{"line_number":90,"context_line":"                    UnknownFieldError(what\u003d\u0027Policy \"%s\"\u0027 % self.name,"},{"line_number":91,"context_line":"                                      field\u003dkey))"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def validate(self, tosca_tpl\u003dNone):"},{"line_number":94,"context_line":"        self._validate_properties(self.entity_tpl, self.type_definition)"},{"line_number":95,"context_line":"        for prop in self.get_properties_objects():"},{"line_number":96,"context_line":"            prop.validate()"}],"source_content_type":"text/x-python","patch_set":2,"id":"c1d6952e_fa08c5d1","line":93,"range":{"start_line":93,"start_character":23,"end_line":93,"end_character":32},"updated":"2020-11-24 19:47:20.000000000","message":"this parameter is parsed but seems not been used in this module, is there a future use?","commit_id":"0e138e3598927a788114299c4338719676890034"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"1ca5e7522a6b8a54fed6100df4b325a615fdc327","unresolved":true,"context_lines":[{"line_number":90,"context_line":"                    UnknownFieldError(what\u003d\u0027Policy \"%s\"\u0027 % self.name,"},{"line_number":91,"context_line":"                                      field\u003dkey))"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def validate(self, tosca_tpl\u003dNone):"},{"line_number":94,"context_line":"        self._validate_properties(self.entity_tpl, self.type_definition)"},{"line_number":95,"context_line":"        for prop in self.get_properties_objects():"},{"line_number":96,"context_line":"            prop.validate()"}],"source_content_type":"text/x-python","patch_set":2,"id":"a183325c_9050426a","line":93,"range":{"start_line":93,"start_character":23,"end_line":93,"end_character":32},"in_reply_to":"c1d6952e_fa08c5d1","updated":"2020-11-25 10:46:15.000000000","message":"Thanks for your comment.\nThis argument is not needed, so I deleted this argument and also fixed the part that is calling。","commit_id":"0e138e3598927a788114299c4338719676890034"}],"toscaparser/tests/test_toscatplvalidation.py":[{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"a8cc7c0d9a15ea8db7b5fb611ebeb6a380ec5496","unresolved":false,"context_lines":[{"line_number":774,"context_line":"            custom_types[name] \u003d defintion"},{"line_number":775,"context_line":"        return custom_types"},{"line_number":776,"context_line":""},{"line_number":777,"context_line":"    def _custom_types_policy(self):"},{"line_number":778,"context_line":"        custom_types \u003d {}"},{"line_number":779,"context_line":"        def_file \u003d os.path.join("},{"line_number":780,"context_line":"            os.path.dirname(os.path.abspath(__file__)),"},{"line_number":781,"context_line":"            \"data/custom_types/custom_policy.yaml\")"},{"line_number":782,"context_line":"        custom_type \u003d toscaparser.utils.yamlparser.load_yaml(def_file)"},{"line_number":783,"context_line":"        policy_types \u003d custom_type[\u0027policy_types\u0027]"},{"line_number":784,"context_line":"        for name in policy_types:"},{"line_number":785,"context_line":"            defintion \u003d policy_types[name]"},{"line_number":786,"context_line":"            custom_types[name] \u003d defintion"},{"line_number":787,"context_line":"        return custom_types"},{"line_number":788,"context_line":""},{"line_number":789,"context_line":"    def _custom_defs_policy(self):"},{"line_number":790,"context_line":"        custom_types \u003d {}"},{"line_number":791,"context_line":"        def_file \u003d os.path.join("},{"line_number":792,"context_line":"            os.path.dirname(os.path.abspath(__file__)),"},{"line_number":793,"context_line":"            \"data/custom_types/custom_policy.yaml\")"},{"line_number":794,"context_line":"        custom_type \u003d toscaparser.utils.yamlparser.load_yaml(def_file)"},{"line_number":795,"context_line":"        policy_types \u003d custom_type[\u0027policy_types\u0027]"},{"line_number":796,"context_line":"        for name in policy_types:"},{"line_number":797,"context_line":"            defintion \u003d policy_types[name]"},{"line_number":798,"context_line":"            custom_types[name] \u003d defintion"},{"line_number":799,"context_line":"        return custom_types"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"    def _single_node_template_content_test(self, tpl_snippet):"},{"line_number":802,"context_line":"        nodetemplates \u003d (toscaparser.utils.yamlparser."}],"source_content_type":"text/x-python","patch_set":1,"id":"fffc6b78_9518f081","line":799,"range":{"start_line":777,"start_character":0,"end_line":799,"end_character":27},"updated":"2020-11-20 07:05:56.000000000","message":"Could I confirm what is the difference between these two functioins?","commit_id":"37020b104403ff4ae872d9d4cce9de25ab076411"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"79c016503450c258deee3d164c8e0bff25feaecc","unresolved":false,"context_lines":[{"line_number":774,"context_line":"            custom_types[name] \u003d defintion"},{"line_number":775,"context_line":"        return custom_types"},{"line_number":776,"context_line":""},{"line_number":777,"context_line":"    def _custom_types_policy(self):"},{"line_number":778,"context_line":"        custom_types \u003d {}"},{"line_number":779,"context_line":"        def_file \u003d os.path.join("},{"line_number":780,"context_line":"            os.path.dirname(os.path.abspath(__file__)),"},{"line_number":781,"context_line":"            \"data/custom_types/custom_policy.yaml\")"},{"line_number":782,"context_line":"        custom_type \u003d toscaparser.utils.yamlparser.load_yaml(def_file)"},{"line_number":783,"context_line":"        policy_types \u003d custom_type[\u0027policy_types\u0027]"},{"line_number":784,"context_line":"        for name in policy_types:"},{"line_number":785,"context_line":"            defintion \u003d policy_types[name]"},{"line_number":786,"context_line":"            custom_types[name] \u003d defintion"},{"line_number":787,"context_line":"        return custom_types"},{"line_number":788,"context_line":""},{"line_number":789,"context_line":"    def _custom_defs_policy(self):"},{"line_number":790,"context_line":"        custom_types \u003d {}"},{"line_number":791,"context_line":"        def_file \u003d os.path.join("},{"line_number":792,"context_line":"            os.path.dirname(os.path.abspath(__file__)),"},{"line_number":793,"context_line":"            \"data/custom_types/custom_policy.yaml\")"},{"line_number":794,"context_line":"        custom_type \u003d toscaparser.utils.yamlparser.load_yaml(def_file)"},{"line_number":795,"context_line":"        policy_types \u003d custom_type[\u0027policy_types\u0027]"},{"line_number":796,"context_line":"        for name in policy_types:"},{"line_number":797,"context_line":"            defintion \u003d policy_types[name]"},{"line_number":798,"context_line":"            custom_types[name] \u003d defintion"},{"line_number":799,"context_line":"        return custom_types"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"    def _single_node_template_content_test(self, tpl_snippet):"},{"line_number":802,"context_line":"        nodetemplates \u003d (toscaparser.utils.yamlparser."}],"source_content_type":"text/x-python","patch_set":1,"id":"fffc6b78_eaf23606","line":799,"range":{"start_line":777,"start_character":0,"end_line":799,"end_character":27},"in_reply_to":"fffc6b78_9518f081","updated":"2020-11-20 09:16:32.000000000","message":"Thank you for pointing out.\nI have forget deleting the unused method,  so I deleted the `_custom_defs_policy` function.","commit_id":"37020b104403ff4ae872d9d4cce9de25ab076411"}],"toscaparser/topology_template.py":[{"author":{"_account_id":27880,"name":"Yoshito Ito","email":"yoshito.itou.dr@hco.ntt.co.jp","username":"yoshito-ito"},"change_message_id":"9457a4da33719215e7a7d5399ee0ea030df06130","unresolved":false,"context_lines":[{"line_number":140,"context_line":"                policyObj \u003d Policy(policy_name, policy_tpl,"},{"line_number":141,"context_line":"                                   target_objects, targets_type,"},{"line_number":142,"context_line":"                                   self.custom_defs)"},{"line_number":143,"context_line":"                if (policyObj.type_definition and"},{"line_number":144,"context_line":"                    (policyObj.type in policyObj.type_definition.TOSCA_DEF or"},{"line_number":145,"context_line":"                     (policyObj.type not in policyObj.type_definition.TOSCA_DEF"},{"line_number":146,"context_line":"                      and bool(policyObj.custom_def)))):"},{"line_number":147,"context_line":"                    policyObj.validate(self)"},{"line_number":148,"context_line":"                    policies.append(policyObj)"},{"line_number":149,"context_line":"        return policies"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fffc6b78_f5721c7c","line":147,"range":{"start_line":143,"start_character":16,"end_line":147,"end_character":44},"updated":"2020-11-20 05:13:52.000000000","message":"This IF statement is a little complex so it might be better to put a note describing that \"If the policyObj is defined in TOSCA_definition_1_0.yaml or is defined as a custom definition, validate the properties before adding it to the policies list\".","commit_id":"37020b104403ff4ae872d9d4cce9de25ab076411"},{"author":{"_account_id":31857,"name":"Ayumu Ueha","email":"ueha.ayumu@fujitsu.com","username":"ueha"},"change_message_id":"79c016503450c258deee3d164c8e0bff25feaecc","unresolved":false,"context_lines":[{"line_number":140,"context_line":"                policyObj \u003d Policy(policy_name, policy_tpl,"},{"line_number":141,"context_line":"                                   target_objects, targets_type,"},{"line_number":142,"context_line":"                                   self.custom_defs)"},{"line_number":143,"context_line":"                if (policyObj.type_definition and"},{"line_number":144,"context_line":"                    (policyObj.type in policyObj.type_definition.TOSCA_DEF or"},{"line_number":145,"context_line":"                     (policyObj.type not in policyObj.type_definition.TOSCA_DEF"},{"line_number":146,"context_line":"                      and bool(policyObj.custom_def)))):"},{"line_number":147,"context_line":"                    policyObj.validate(self)"},{"line_number":148,"context_line":"                    policies.append(policyObj)"},{"line_number":149,"context_line":"        return policies"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fffc6b78_4ab54231","line":147,"range":{"start_line":143,"start_character":16,"end_line":147,"end_character":44},"in_reply_to":"fffc6b78_d509d831","updated":"2020-11-20 09:16:32.000000000","message":"Thanks for your suggestion!\nI added a comment to explain the IF statement.","commit_id":"37020b104403ff4ae872d9d4cce9de25ab076411"},{"author":{"_account_id":25701,"name":"Yasufumi Ogawa","email":"yasufum.o@gmail.com","username":"yasufum"},"change_message_id":"a8cc7c0d9a15ea8db7b5fb611ebeb6a380ec5496","unresolved":false,"context_lines":[{"line_number":140,"context_line":"                policyObj \u003d Policy(policy_name, policy_tpl,"},{"line_number":141,"context_line":"                                   target_objects, targets_type,"},{"line_number":142,"context_line":"                                   self.custom_defs)"},{"line_number":143,"context_line":"                if (policyObj.type_definition and"},{"line_number":144,"context_line":"                    (policyObj.type in policyObj.type_definition.TOSCA_DEF or"},{"line_number":145,"context_line":"                     (policyObj.type not in policyObj.type_definition.TOSCA_DEF"},{"line_number":146,"context_line":"                      and bool(policyObj.custom_def)))):"},{"line_number":147,"context_line":"                    policyObj.validate(self)"},{"line_number":148,"context_line":"                    policies.append(policyObj)"},{"line_number":149,"context_line":"        return policies"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fffc6b78_d509d831","line":147,"range":{"start_line":143,"start_character":16,"end_line":147,"end_character":44},"in_reply_to":"fffc6b78_f5721c7c","updated":"2020-11-20 07:05:56.000000000","message":"+1","commit_id":"37020b104403ff4ae872d9d4cce9de25ab076411"}]}