)]}'
{"test-requirements.txt":[{"author":{"_account_id":9178,"name":"Sayali Lunkad","email":"sayali.lunkad@suse.com","username":"sayalilunkad"},"change_message_id":"077ee85a6e9ba378f17c9f923d3a14ada0b2739f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"oslosphinx"},{"line_number":8,"context_line":"sphinx\u003e\u003d1.1.2,\u003c1.2"},{"line_number":9,"context_line":"hieroglyph\u003e\u003d0.5"},{"line_number":10,"context_line":"bashate #pep8 equivalent for bash scripts"}],"source_content_type":"text/plain","patch_set":4,"id":"baa041b7_e326af15","line":10,"updated":"2015-04-02 06:02:59.000000000","message":"Please insert a space after the #","commit_id":"fd6c81dfc6e117ab6d397bf442512ab557eeadcd"}],"tox.ini":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"cca7570931a22cb87daef0f90fafc3f3e3c043db","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  # Build training labs scripts"},{"line_number":30,"context_line":"  bash {toxinidir}/tools/generatelabs"},{"line_number":31,"context_line":"  # Bashate all scripts under labs folder"},{"line_number":32,"context_line":"  python {toxinidir}/example.py"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"[doc8]"},{"line_number":35,"context_line":"# Settings for doc8:"}],"source_content_type":"text/x-properties","patch_set":1,"id":"9a80dd14_93494d62","line":32,"updated":"2015-03-15 19:17:51.000000000","message":"You need to add bashate to test-requirements so that it is installed.\n\nAlso, I don\u0027t see a reason to use script. Why not use something like:\nbash -c \"find XXX -iname \u0027*.sh\u0027 -print0 | xargs -0 bashate\"","commit_id":"0880ce89314f44e26dfc52b88b00001a36d877de"},{"author":{"_account_id":9178,"name":"Sayali Lunkad","email":"sayali.lunkad@suse.com","username":"sayalilunkad"},"change_message_id":"5de298d27613d5a77471742c8eef9f07279834b2","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  # Build training labs scripts"},{"line_number":30,"context_line":"  bash {toxinidir}/tools/generatelabs"},{"line_number":31,"context_line":"  # Bashate all scripts"},{"line_number":32,"context_line":"  bash -c \"find labs/ -iname \u0027*.sh\u0027 -print0 | xargs -0 bashate\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"[doc8]"},{"line_number":35,"context_line":"# Settings for doc8:"}],"source_content_type":"text/x-properties","patch_set":3,"id":"1a6ced46_783b49d1","line":32,"updated":"2015-03-24 18:32:23.000000000","message":"I would also prefer this to be added as a separate section.\nSomething similar to this:\n\n[testenv:bashate]\ncommands \u003d\n  bash -c \"find labs/ -iname \u0027*.sh\u0027 -print0 | xargs -0 bashate\"\n\nThis also enables us to run the test individually and does not interfere with the other checks.","commit_id":"984de069b7a82122a8037fd561b7304e7f1f99b9"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"c5447dea64336aed5e477916c2e44e941003f63d","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  # Build training labs scripts"},{"line_number":30,"context_line":"  bash {toxinidir}/tools/generatelabs"},{"line_number":31,"context_line":"  # Bashate all scripts"},{"line_number":32,"context_line":"  bash -c \"find labs/ -iname \u0027*.sh\u0027 -print0 | xargs -0 bashate\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"[doc8]"},{"line_number":35,"context_line":"# Settings for doc8:"}],"source_content_type":"text/x-properties","patch_set":3,"id":"1a6ced46_d88c3d82","line":32,"in_reply_to":"1a6ced46_783b49d1","updated":"2015-03-24 18:35:32.000000000","message":"Please do not. You already have lint checking in this test (doc8), let\u0027s avoid another job if possible. Every job means setup of a new node for testing and the less jobs we use for testing, the more we can test.","commit_id":"984de069b7a82122a8037fd561b7304e7f1f99b9"},{"author":{"_account_id":9178,"name":"Sayali Lunkad","email":"sayali.lunkad@suse.com","username":"sayalilunkad"},"change_message_id":"ca40e6ab247e323d0d4266356ffd77c6f3cf8e8f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  # Build training labs scripts"},{"line_number":30,"context_line":"  bash {toxinidir}/tools/generatelabs"},{"line_number":31,"context_line":"  # Bashate all scripts"},{"line_number":32,"context_line":"  bash -c \"find labs/ -iname \u0027*.sh\u0027 -print0 | xargs -0 bashate\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"[doc8]"},{"line_number":35,"context_line":"# Settings for doc8:"}],"source_content_type":"text/x-properties","patch_set":3,"id":"1a6ced46_180a55d2","line":32,"in_reply_to":"1a6ced46_d88c3d82","updated":"2015-03-24 18:40:24.000000000","message":"Alright then. This works fine in that case.","commit_id":"984de069b7a82122a8037fd561b7304e7f1f99b9"},{"author":{"_account_id":7007,"name":"Pranav Salunke","email":"dguitarbite@gmail.com","username":"dguitarbite"},"change_message_id":"334de06897a0d22f8c0c432c9d160f31a5ed7cd3","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  # Build training labs scripts"},{"line_number":30,"context_line":"  bash {toxinidir}/tools/generatelabs"},{"line_number":31,"context_line":"  # Bashate all scripts"},{"line_number":32,"context_line":"  bash -c \"find labs/ -iname \u0027*.sh\u0027 -print0 | xargs -0 bashate\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"[doc8]"},{"line_number":35,"context_line":"# Settings for doc8:"}],"source_content_type":"text/x-properties","patch_set":4,"id":"9aa53dc9_75ddac41","line":32,"updated":"2015-04-07 09:26:56.000000000","message":"I believe that we need to create new check here. Do not add this to slides please.","commit_id":"fd6c81dfc6e117ab6d397bf442512ab557eeadcd"}]}