)]}'
{"labs/config/scripts.ubuntu_cluster":[{"author":{"_account_id":11109,"name":"Roger Luethi","email":"rl@patchworkscience.org","username":"rluethi"},"change_message_id":"25155aaa1e6909eab322d0f7f478cd279b143dd5","unresolved":false,"context_lines":[{"line_number":36,"context_line":"cmd snapshot_cycle -n controller controller_node_installed"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"cmd queue ubuntu/setup_heat_controller.sh"},{"line_number":39,"context_line":"cmd snapshot_cycle -n controller heat_installed"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"cmd boot -n controller"},{"line_number":42,"context_line":"#\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"7aaa499b_2c3b66ed","line":39,"updated":"2015-04-13 04:05:44.000000000","message":"You can\u0027t have two snapshots with the same name (heat_installed). Following the other services, this one would be called \"heat-controller_installed\".\nHowever, the _previous_ snapshot is called \"controller_node_installed\", which is now misleading, because there is an additional service being installed now.\nI suggest you rename the previous snapshot \"lbaas-controller_installed\".","commit_id":"ea338b23e8d1c3230639625bfb044a986a9e3530"},{"author":{"_account_id":11109,"name":"Roger Luethi","email":"rl@patchworkscience.org","username":"rluethi"},"change_message_id":"25155aaa1e6909eab322d0f7f478cd279b143dd5","unresolved":false,"context_lines":[{"line_number":76,"context_line":"cmd snapshot_cycle -n network network_node_installed"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"cmd queue ubuntu/setup_heat_network.sh"},{"line_number":79,"context_line":"cmd snapshot_cycle -n network heat_installed"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"# - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -"},{"line_number":82,"context_line":"# Take snapshot of database changes on controller VM, too"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"7aaa499b_4c1d9272","line":79,"updated":"2015-04-13 04:05:44.000000000","message":"Same problem as above with the previous snapshot now having a misleading name.","commit_id":"ea338b23e8d1c3230639625bfb044a986a9e3530"},{"author":{"_account_id":7007,"name":"Pranav Salunke","email":"dguitarbite@gmail.com","username":"dguitarbite"},"change_message_id":"2e8db601c4b833dfde2e5676f5edaa7efcd1f0a1","unresolved":false,"context_lines":[{"line_number":33,"context_line":"cmd snapshot_cycle -n controller openstack_networks_configured"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"cmd queue setup_lbaas_controller.sh"},{"line_number":36,"context_line":"cmd snapshot_cycle -n controller lbaas_controller_installed"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"cmd queue ubuntu/setup_heat_controller.sh"},{"line_number":39,"context_line":"cmd snapshot_cycle -n controller heat_controller_installed"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"5aa745d1_9e9f3e5f","line":36,"updated":"2015-04-16 13:10:57.000000000","message":"Please fix Lbaas related part in another patch. If required make this patch as dependent patch.","commit_id":"7abf92514881963d637f82cbea5c002226e305f9"},{"author":{"_account_id":9178,"name":"Sayali Lunkad","email":"sayali.lunkad@suse.com","username":"sayalilunkad"},"change_message_id":"95fc1be98ec9d7117ced67abed53509a09eec01b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"cmd snapshot_cycle -n controller openstack_networks_configured"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"cmd queue setup_lbaas_controller.sh"},{"line_number":36,"context_line":"cmd snapshot_cycle -n controller lbaas_controller_installed"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"cmd queue ubuntu/setup_heat_controller.sh"},{"line_number":39,"context_line":"cmd snapshot_cycle -n controller heat_controller_installed"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"5aa745d1_7296d44d","line":36,"in_reply_to":"5aa745d1_9e9f3e5f","updated":"2015-04-16 19:44:20.000000000","message":"Done","commit_id":"7abf92514881963d637f82cbea5c002226e305f9"},{"author":{"_account_id":7007,"name":"Pranav Salunke","email":"dguitarbite@gmail.com","username":"dguitarbite"},"change_message_id":"2e8db601c4b833dfde2e5676f5edaa7efcd1f0a1","unresolved":false,"context_lines":[{"line_number":73,"context_line":"cmd snapshot_cycle -n network neutron_configured"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"cmd queue ubuntu/setup_lbaas_network.sh"},{"line_number":76,"context_line":"cmd snapshot_cycle -n network lbaas_network_installed"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"cmd queue ubuntu/setup_heat_network.sh"},{"line_number":79,"context_line":"cmd snapshot_cycle -n network heat_network_installed"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"5aa745d1_7e9c7269","line":76,"updated":"2015-04-16 13:10:57.000000000","message":"Same as above.","commit_id":"7abf92514881963d637f82cbea5c002226e305f9"},{"author":{"_account_id":9178,"name":"Sayali Lunkad","email":"sayali.lunkad@suse.com","username":"sayalilunkad"},"change_message_id":"95fc1be98ec9d7117ced67abed53509a09eec01b","unresolved":false,"context_lines":[{"line_number":73,"context_line":"cmd snapshot_cycle -n network neutron_configured"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"cmd queue ubuntu/setup_lbaas_network.sh"},{"line_number":76,"context_line":"cmd snapshot_cycle -n network lbaas_network_installed"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"cmd queue ubuntu/setup_heat_network.sh"},{"line_number":79,"context_line":"cmd snapshot_cycle -n network heat_network_installed"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"5aa745d1_5293d85b","line":76,"in_reply_to":"5aa745d1_7e9c7269","updated":"2015-04-16 19:44:20.000000000","message":"Done","commit_id":"7abf92514881963d637f82cbea5c002226e305f9"}],"labs/scripts/ubuntu/apt_pre-download.sh":[{"author":{"_account_id":11109,"name":"Roger Luethi","email":"rl@patchworkscience.org","username":"rluethi"},"change_message_id":"25155aaa1e6909eab322d0f7f478cd279b143dd5","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    neutron-plugin-openvswitch-agent neutron-l3-agent neutron-dhcp-agent"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"# Heat"},{"line_number":87,"context_line":"apt-download heat-api heat-api-cfn heat-engine python-heatclient"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7aaa499b_ec0c5e44","line":87,"updated":"2015-04-13 04:05:44.000000000","message":"s/apt-download/apt_download/\nShouldn\u0027t this give an error when testing?","commit_id":"ea338b23e8d1c3230639625bfb044a986a9e3530"}],"labs/scripts/ubuntu/setup_heat_controller.sh":[{"author":{"_account_id":11109,"name":"Roger Luethi","email":"rl@patchworkscience.org","username":"rluethi"},"change_message_id":"27cb727af6e5ae59dde541f8fb84273f4f1c830c","unresolved":false,"context_lines":[{"line_number":119,"context_line":"sudo service heat-engine restart"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"echo \"Removing default SQLite database.\""},{"line_number":122,"context_line":"sudo rm -f /var/lib/glance/glance.sqlite"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7aaa499b_5755014e","line":122,"updated":"2015-04-13 18:59:08.000000000","message":"Oh noes! You were doing so well. On the last line!\ns/glance/heat/g","commit_id":"7ebd8d589de4e123d246e41bed6d6981aa26b6fd"}],"labs/scripts/ubuntu/setup_heat_network.sh":[{"author":{"_account_id":11109,"name":"Roger Luethi","email":"rl@patchworkscience.org","username":"rluethi"},"change_message_id":"27cb727af6e5ae59dde541f8fb84273f4f1c830c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7aaa499b_570d013d","updated":"2015-04-13 18:59:08.000000000","message":"This file is not bashate clean, and we are about to add a gate check for it.","commit_id":"7ebd8d589de4e123d246e41bed6d6981aa26b6fd"},{"author":{"_account_id":11109,"name":"Roger Luethi","email":"rl@patchworkscience.org","username":"rluethi"},"change_message_id":"823b1796dd88e5aa7e64109292325721577333fe","unresolved":false,"context_lines":[{"line_number":64,"context_line":"until node_ssh controller-mgmt \"$AUTH; heat stack-list\" | grep \"CREATION_COMPLETE\"; do"},{"line_number":65,"context_line":"    cnt\u003d$((cnt + 1))"},{"line_number":66,"context_line":"    if [ $cnt -eq 20 ]; then"},{"line_number":67,"context_line":"        echo \"Heat stack creation failed.\""},{"line_number":68,"context_line":"        break"},{"line_number":69,"context_line":"    else"},{"line_number":70,"context_line":"        sleep 1"}],"source_content_type":"text/x-sh","patch_set":6,"id":"fabf19d9_406202da","line":67,"updated":"2015-04-18 07:31:59.000000000","message":"There are several ways to wait for success:\n1) There are still some cases where we wait forever. That\u0027s not ideal for automated testing, and a no-go for testing on the OpenStack CI infrastructure.\n2) We can wait for some time, then give up and continue. That\u0027s what the code here does. It does not seem to make sense: why test, if we ignore the results? This would need an explanation in the code, and probably also in the log file (\"Failed, but ignored because...\").\n3) We can wait for some time, then give up and return/exit with an error. That should be the standard, especially if we plan to do regression testing via CI.","commit_id":"42a5ec3576120fad139002dca8a57ce1328b574f"}]}