)]}'
{"labs/lib/functions-common-devstack":[{"author":{"_account_id":11109,"name":"Roger Luethi","email":"rl@patchworkscience.org","username":"rluethi"},"change_message_id":"4fd46c4907b3ef78047ae025bb4d6dfb1ff998a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5aa745d1_79791e93","updated":"2015-04-16 18:08:52.000000000","message":"Is this a new version of or a cherry-pick from the canonical version? (cf. top 5 lines this file)\n\nIf not, I would prefer this code in some other file.","commit_id":"7af54f6bf2e1a8bcefad43d146f5c8eb84db24a3"},{"author":{"_account_id":9178,"name":"Sayali Lunkad","email":"sayali.lunkad@suse.com","username":"sayalilunkad"},"change_message_id":"6e72223ffce26d28749d8bef2e802841bbd8c407","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5aa745d1_cfa61fc1","in_reply_to":"5aa745d1_79791e93","updated":"2015-04-16 19:10:46.000000000","message":"No it isn\u0027t. In that case I think I can move this to functions.guest.","commit_id":"7af54f6bf2e1a8bcefad43d146f5c8eb84db24a3"}],"labs/lib/functions.guest":[{"author":{"_account_id":11109,"name":"Roger Luethi","email":"rl@patchworkscience.org","username":"rluethi"},"change_message_id":"4fd46c4907b3ef78047ae025bb4d6dfb1ff998a6","unresolved":false,"context_lines":[{"line_number":148,"context_line":"# Root wrapper around devstack function for manipulating config files"},{"line_number":149,"context_line":"#-------------------------------------------------------------------------------"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"function iniset_sudo {"},{"line_number":152,"context_line":"    local file\u003d$1"},{"line_number":153,"context_line":"    shift"},{"line_number":154,"context_line":"    local tmpfile\u003d$(mktemp)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5aa745d1_5982e201","side":"PARENT","line":151,"updated":"2015-04-16 18:08:52.000000000","message":"This patch turns the iniset_sudo into a variadic function where the _first_ argument can be omitted. That\u0027s a rather unusual interface. I would prefer iniset_no_section_sudo, clumsy as it may look, because in my experience interfaces should not surprise people.\n\nIf we keep it the way it is, we should add a comment above the function to explain the interface.","commit_id":"4e887b798f05ffc1a599ab1405d5a20982193caf"},{"author":{"_account_id":9178,"name":"Sayali Lunkad","email":"sayali.lunkad@suse.com","username":"sayalilunkad"},"change_message_id":"6e72223ffce26d28749d8bef2e802841bbd8c407","unresolved":false,"context_lines":[{"line_number":148,"context_line":"# Root wrapper around devstack function for manipulating config files"},{"line_number":149,"context_line":"#-------------------------------------------------------------------------------"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"function iniset_sudo {"},{"line_number":152,"context_line":"    local file\u003d$1"},{"line_number":153,"context_line":"    shift"},{"line_number":154,"context_line":"    local tmpfile\u003d$(mktemp)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5aa745d1_2f77c33b","side":"PARENT","line":151,"in_reply_to":"5aa745d1_5982e201","updated":"2015-04-16 19:10:46.000000000","message":"ok, that makes sense. I will separate it into a new function.","commit_id":"4e887b798f05ffc1a599ab1405d5a20982193caf"}]}