)]}'
{"doc/upstream-training/source/14-gerrit.rst":[{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"f834d97b7ffc3ccc9e368a8afae1e4e388e8e299","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"review.openstack.org"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":".. image:: ./_assets/os_background.png"},{"line_number":6,"context_line":"   :class: fill"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a8ec9b2_dbb981ee","line":3,"range":{"start_line":1,"start_character":0,"end_line":3,"end_character":20},"updated":"2016-09-14 03:43:22.000000000","message":"Do we want to keep this slide as contribution process overview? As if yes I would change the title as well.","commit_id":"d5691c95a58378939035c459535fba15a3047a62"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"f834d97b7ffc3ccc9e368a8afae1e4e388e8e299","unresolved":false,"context_lines":[{"line_number":6,"context_line":"   :class: fill"},{"line_number":7,"context_line":"   :width: 100%"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"review.openstack.org"},{"line_number":10,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":".. image:: ./_assets/14-01-review.png"},{"line_number":13,"context_line":"  :width: 100%"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a8ec9b2_3bb505cd","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":20},"updated":"2016-09-14 03:43:22.000000000","message":"Move this before \u0027gerrit patchset history\u0027 section.","commit_id":"d5691c95a58378939035c459535fba15a3047a62"},{"author":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"change_message_id":"718730ab925be806712b14b1b425965b744ee8a6","unresolved":false,"context_lines":[{"line_number":6,"context_line":"   :class: fill"},{"line_number":7,"context_line":"   :width: 100%"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"review.openstack.org"},{"line_number":10,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":".. image:: ./_assets/14-01-review.png"},{"line_number":13,"context_line":"  :width: 100%"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a8ec9b2_465cb425","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":20},"in_reply_to":"7a8ec9b2_3bb505cd","updated":"2016-09-14 04:18:25.000000000","message":"I think it depends on the style on trainers. It means 1) trainers want to show what Gerrit on OpenStack is by showing review.openstack.org first. 2) trainers would like to show that \"Your commit change will be shown in Gerrit\". I think Ildiko mentions the comment for the second purpose, but IMO leaving the content here is also good for the first purpose.","commit_id":"d5691c95a58378939035c459535fba15a3047a62"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"db4c7e9d0f4ef1649d613ae21f1efc605dd74b9c","unresolved":false,"context_lines":[{"line_number":6,"context_line":"   :class: fill"},{"line_number":7,"context_line":"   :width: 100%"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"review.openstack.org"},{"line_number":10,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":".. image:: ./_assets/14-01-review.png"},{"line_number":13,"context_line":"  :width: 100%"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a8ec9b2_81a06692","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":20},"in_reply_to":"7a8ec9b2_465cb425","updated":"2016-09-14 05:08:18.000000000","message":"If this slide set is purely about Gerrit, then I would leave out how the patch is created and focus on what Gerrit is and what it is used for. Additionally to this also mention what the review process is and provide best practices. The parts related to version control and how to create a patch and test the code etc would be a separate module for me.\n\nIf we want to give an overview of what is the order of things when someone tries to put together a contribution then review comes at the end of it, when the patch is uploaded.","commit_id":"d5691c95a58378939035c459535fba15a3047a62"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"f3730a2f97f1f81aa15a6af38a7a580b2ce31934","unresolved":false,"context_lines":[{"line_number":45,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":".. image:: ./_assets/14-06-git-clone.png"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"git checkout -b TOPIC-BRANCH"},{"line_number":50,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a89bdaa_380afd8a","line":48,"updated":"2016-09-12 15:06:35.000000000","message":"I think we can \"git review -s\" to test the git repository itself and gerrit before the development(checkout and unit tests). As the typical workflow, also, we can skip \"git review -s\".","commit_id":"d5691c95a58378939035c459535fba15a3047a62"},{"author":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"change_message_id":"9dd87eb42cf197546bdb063cdef3e71077dc6155","unresolved":false,"context_lines":[{"line_number":54,"context_line":"running unit tests"},{"line_number":55,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":".. image:: ./_assets/14-09-unit-tests.png"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"git review -s"},{"line_number":60,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a89bdaa_ac432a12","line":57,"range":{"start_line":57,"start_character":0,"end_line":57,"end_character":41},"updated":"2016-09-12 17:37:21.000000000","message":"I would suggest to change with \"tox\" command execution results.","commit_id":"d5691c95a58378939035c459535fba15a3047a62"},{"author":{"_account_id":11889,"name":"Matjaz Pancur","email":"matjaz.pancur@fri.uni-lj.si","username":"matjazp"},"change_message_id":"f57ec679540d5da05a0fe51446ff44857f7da4d7","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":".. image:: ./_assets/14-09-unit-tests.png"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"git review -s"},{"line_number":60,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":".. image:: ./_assets/14-07-git-review-s.png"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a89bdaa_58317c59","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":13},"updated":"2016-09-12 16:15:25.000000000","message":"I agree with Kato, the original order is correct. See http://docs.openstack.org/infra/manual/developers.html#development-workflow\n\nafter you clone a repo, you set it up with git review. You could do it  some other way too, but let\u0027s just stick with what everyone else is using.","commit_id":"d5691c95a58378939035c459535fba15a3047a62"},{"author":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"change_message_id":"718730ab925be806712b14b1b425965b744ee8a6","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":".. image:: ./_assets/14-09-unit-tests.png"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"git review -s"},{"line_number":60,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":".. image:: ./_assets/14-07-git-review-s.png"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a8ec9b2_bb2cb5ac","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":13},"in_reply_to":"7a8ec9b2_3b5c2525","updated":"2016-09-14 04:18:25.000000000","message":"The best documentation about \"git review -s\" would be: http://docs.openstack.org/infra/manual/developers.html\n\nThe importance of \"git review -s\" is related with \"Change-Id:\" line on the last part of commit messages. The followings are also helpful if readers are familiar with commit messages:\n\n- https://review.openstack.org/Documentation/user-changeid.html\n- https://review.openstack.org/Documentation/error-missing-changeid.html","commit_id":"d5691c95a58378939035c459535fba15a3047a62"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"db4c7e9d0f4ef1649d613ae21f1efc605dd74b9c","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":".. image:: ./_assets/14-09-unit-tests.png"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"git review -s"},{"line_number":60,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":".. image:: ./_assets/14-07-git-review-s.png"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a8ec9b2_21b4f2f0","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":13},"in_reply_to":"7a8ec9b2_bb2cb5ac","updated":"2016-09-14 05:08:18.000000000","message":"Yeap, it ensures the remote is set up correctly and additionally downloads the commit-msg hook script. I think it\u0027s beneficial to mention the steps within the block where the repo is set up.","commit_id":"d5691c95a58378939035c459535fba15a3047a62"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"f834d97b7ffc3ccc9e368a8afae1e4e388e8e299","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":".. image:: ./_assets/14-09-unit-tests.png"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"git review -s"},{"line_number":60,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":".. image:: ./_assets/14-07-git-review-s.png"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a8ec9b2_3b5c2525","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":13},"in_reply_to":"9a89bdaa_4cbb7ee5","updated":"2016-09-14 03:43:22.000000000","message":"Is it described anywhere what git review does at the setup phase and when they use it after? If not we might mention that too if someone would rather be familiar/use those instead.","commit_id":"d5691c95a58378939035c459535fba15a3047a62"},{"author":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"change_message_id":"9dd87eb42cf197546bdb063cdef3e71077dc6155","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":".. image:: ./_assets/14-09-unit-tests.png"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"git review -s"},{"line_number":60,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":".. image:: ./_assets/14-07-git-review-s.png"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a89bdaa_4cbb7ee5","line":59,"range":{"start_line":59,"start_character":0,"end_line":59,"end_character":13},"in_reply_to":"9a89bdaa_58317c59","updated":"2016-09-12 17:37:21.000000000","message":"I think actually instead of the order, two things seem to be missing on this slide:\n\n- committing result: \"git commit -a\" \n- first \"git review\" execution\n\n\"git review -s\" should be executed before those two steps. Moreover, it is natural to mention \"git commit --amend\" and later patchsets after mentioning the above two things.","commit_id":"d5691c95a58378939035c459535fba15a3047a62"},{"author":{"_account_id":10497,"name":"KATO Tomoyuki","email":"kato.tomoyuki@jp.fujitsu.com","username":"to222"},"change_message_id":"f3730a2f97f1f81aa15a6af38a7a580b2ce31934","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":".. image:: ./_assets/14-07-git-review-s.png"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"git commit --amend"},{"line_number":65,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":".. image:: ./_assets/14-13-git-commit-amend.png"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a89bdaa_18bb79e6","line":64,"updated":"2016-09-12 15:06:35.000000000","message":"I think \"--amend\" and new patchsets are usually the next step after the review, if needed. Therefore, I think the original order is correct.","commit_id":"d5691c95a58378939035c459535fba15a3047a62"},{"author":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"change_message_id":"9dd87eb42cf197546bdb063cdef3e71077dc6155","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":".. image:: ./_assets/14-17-patchset-diffs.png"},{"line_number":85,"context_line":"  :width: 100%"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"Exercise"},{"line_number":88,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a89bdaa_8c96663c","line":86,"updated":"2016-09-12 17:37:21.000000000","message":"leaving \u0027Draft\u0027 comments and publishing them is missing on this slide I think.","commit_id":"d5691c95a58378939035c459535fba15a3047a62"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"9d04ff565df79abff8a6cf539f8b590491344c9c","unresolved":false,"context_lines":[{"line_number":47,"context_line":"Exercise"},{"line_number":48,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Review a patch out in the community and invite reviewers."}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a8ec9b2_29ed11b7","line":50,"range":{"start_line":50,"start_character":15,"end_line":50,"end_character":35},"updated":"2016-09-16 17:19:52.000000000","message":"Maybe refer to the Sandbox repository for this introduction exercise to avoid random reviews on \"real\" patches.","commit_id":"8fcfec9250d47bdd201e804416718b19972cd69a"}]}
