)]}'
{"doc/upstream-training/source/slides/workflow-commit-message.rst":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"46f5cbca79b96682c6fe51077aecc96c37794d8d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Commit Messages"},{"line_number":10,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- Brief explaination with context about the patch"},{"line_number":13,"context_line":"- They provide a description of the history of changes in a"},{"line_number":14,"context_line":"  repository"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bff0334d_5dc2c85a","line":11,"updated":"2017-04-11 00:54:23.000000000","message":"I would like to add a note here that they are the first thing a reviewer sees and are as important if not more than the code.  I think people lose that context.","commit_id":"09e28efa031527b621c8b861d9b445f95a44bd08"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"d3a6f91dcaefb913a246902d14a1c92b22d99325","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Commit Messages"},{"line_number":10,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- Brief explaination with context about the patch"},{"line_number":13,"context_line":"- They provide a description of the history of changes in a"},{"line_number":14,"context_line":"  repository"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bff0334d_fda3dc9c","line":11,"in_reply_to":"bff0334d_5dc2c85a","updated":"2017-04-11 01:11:04.000000000","message":"Done","commit_id":"09e28efa031527b621c8b861d9b445f95a44bd08"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"46f5cbca79b96682c6fe51077aecc96c37794d8d","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Write a summary line for each of the following scenarios:"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"- Someone left a print statement that was used for testing while"},{"line_number":37,"context_line":"  developing that is being added to the logs."},{"line_number":38,"context_line":"- There are unused arguments being passed into a method that is"},{"line_number":39,"context_line":"  used in several different files."},{"line_number":40,"context_line":"- A new capability was added to the project that should be"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bff0334d_fdc63c9a","line":37,"range":{"start_line":36,"start_character":59,"end_line":37,"end_character":12},"updated":"2017-04-11 00:54:23.000000000","message":"during development","commit_id":"09e28efa031527b621c8b861d9b445f95a44bd08"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"d3a6f91dcaefb913a246902d14a1c92b22d99325","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Write a summary line for each of the following scenarios:"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"- Someone left a print statement that was used for testing while"},{"line_number":37,"context_line":"  developing that is being added to the logs."},{"line_number":38,"context_line":"- There are unused arguments being passed into a method that is"},{"line_number":39,"context_line":"  used in several different files."},{"line_number":40,"context_line":"- A new capability was added to the project that should be"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bff0334d_dda01893","line":37,"range":{"start_line":36,"start_character":59,"end_line":37,"end_character":12},"in_reply_to":"bff0334d_fdc63c9a","updated":"2017-04-11 01:11:04.000000000","message":"Done","commit_id":"09e28efa031527b621c8b861d9b445f95a44bd08"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"46f5cbca79b96682c6fe51077aecc96c37794d8d","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"- Lines limited to 72 characters"},{"line_number":49,"context_line":"- Explanation of issue being solved and why it should be fixed"},{"line_number":50,"context_line":"- Explain how problem is solved"},{"line_number":51,"context_line":"- Other possible content"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"  - Does it improve code structure?"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bff0334d_3d3ee48a","line":50,"range":{"start_line":50,"start_character":2,"end_line":50,"end_character":31},"updated":"2017-04-11 00:54:23.000000000","message":"Explain how the problem is solved","commit_id":"09e28efa031527b621c8b861d9b445f95a44bd08"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"d3a6f91dcaefb913a246902d14a1c92b22d99325","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"- Lines limited to 72 characters"},{"line_number":49,"context_line":"- Explanation of issue being solved and why it should be fixed"},{"line_number":50,"context_line":"- Explain how problem is solved"},{"line_number":51,"context_line":"- Other possible content"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"  - Does it improve code structure?"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bff0334d_5dbe48b4","line":50,"range":{"start_line":50,"start_character":2,"end_line":50,"end_character":31},"in_reply_to":"bff0334d_3d3ee48a","updated":"2017-04-11 01:11:04.000000000","message":"Done","commit_id":"09e28efa031527b621c8b861d9b445f95a44bd08"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"46f5cbca79b96682c6fe51077aecc96c37794d8d","unresolved":false,"context_lines":[{"line_number":60,"context_line":"Write a body to expand on each summary line. Feel free to make up details"},{"line_number":61,"context_line":"to make the context more realistic."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"- Cleanup deprecated methods"},{"line_number":64,"context_line":"- Minimize database queries"},{"line_number":65,"context_line":"- Added unit tests to cover untested methods"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Do not assume ..."},{"line_number":68,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bff0334d_dd713878","line":65,"range":{"start_line":63,"start_character":0,"end_line":65,"end_character":44},"updated":"2017-04-11 00:54:23.000000000","message":"Are these the summary lines you want expanded upon?  If so I would say \u0027Write a body to expand on each of the following summary lines.\"  At first I thought they needed to write a body for the summary lines they previously wrote.","commit_id":"09e28efa031527b621c8b861d9b445f95a44bd08"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"d3a6f91dcaefb913a246902d14a1c92b22d99325","unresolved":false,"context_lines":[{"line_number":60,"context_line":"Write a body to expand on each summary line. Feel free to make up details"},{"line_number":61,"context_line":"to make the context more realistic."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"- Cleanup deprecated methods"},{"line_number":64,"context_line":"- Minimize database queries"},{"line_number":65,"context_line":"- Added unit tests to cover untested methods"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"Do not assume ..."},{"line_number":68,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bff0334d_bdc2f432","line":65,"range":{"start_line":63,"start_character":0,"end_line":65,"end_character":44},"in_reply_to":"bff0334d_dd713878","updated":"2017-04-11 01:11:04.000000000","message":"Done","commit_id":"09e28efa031527b621c8b861d9b445f95a44bd08"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"46f5cbca79b96682c6fe51077aecc96c37794d8d","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    - Bug (Partial-Bug, Related-Bug, Closes-Bug)"},{"line_number":83,"context_line":"    - Blueprint (Partial-Implements, Implements)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"- Optional:"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"  - DocImpact"},{"line_number":88,"context_line":"  - APIImpact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bff0334d_bd18b41d","line":85,"range":{"start_line":85,"start_character":0,"end_line":85,"end_character":11},"updated":"2017-04-11 00:54:23.000000000","message":"We need to fix this as these aren\u0027t really optional.\n\nLets call them \"Additional External References\"\n\nand add a few words like:\n-------------------\nIf you change impacts Documentation, API\u0027s, Security or Upgrade processes one of the following tags would need to be added.  If it is dependent on a change in another repository the \u0027Depends-On\u0027 tag should be used to make a cross repository dependency.\n----------------\n\nMaybe that is too wordy, but I think they are worth explaining.  Maybe make them on their own slide.","commit_id":"09e28efa031527b621c8b861d9b445f95a44bd08"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"d3a6f91dcaefb913a246902d14a1c92b22d99325","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    - Bug (Partial-Bug, Related-Bug, Closes-Bug)"},{"line_number":83,"context_line":"    - Blueprint (Partial-Implements, Implements)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"- Optional:"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"  - DocImpact"},{"line_number":88,"context_line":"  - APIImpact"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bff0334d_7d158c9b","line":85,"range":{"start_line":85,"start_character":0,"end_line":85,"end_character":11},"in_reply_to":"bff0334d_bd18b41d","updated":"2017-04-11 01:11:04.000000000","message":"I added a note to cover the information. Does that work?","commit_id":"09e28efa031527b621c8b861d9b445f95a44bd08"},{"author":{"_account_id":15993,"name":"Amy Marrich","display_name":"Amy Marrich (spotz)","email":"amy@demarco.com","username":"amarrich"},"change_message_id":"04f2c8fef82ffe99e57f7fb9ef3d89b14e1a5219","unresolved":false,"context_lines":[{"line_number":58,"context_line":"Exercise"},{"line_number":59,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Write a body to expand on each of the following summary lines. Feel"},{"line_number":62,"context_line":"free to make up details to make the context more realistic."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"- Cleanup deprecated methods"}],"source_content_type":"text/x-rst","patch_set":2,"id":"bff0334d_731c5177","line":61,"range":{"start_line":61,"start_character":8,"end_line":61,"end_character":12},"updated":"2017-04-12 19:48:38.000000000","message":"Not sure if this wouldn\u0027t be clearer as \u0027commit message body\u0027 vs body","commit_id":"8ac93b93b2645e84946fd25624ea4d260986b20d"},{"author":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"change_message_id":"b460c4330b32473f85c8b0d8e13e3e48732bfc13","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Commit messages"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":".. image:: ./_assets/os_background.png"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9ff52f3f_137de5b0","line":2,"range":{"start_line":2,"start_character":7,"end_line":2,"end_character":8},"updated":"2017-04-13 15:20:05.000000000","message":"-\u003e Would you also change to \"M\"?","commit_id":"9cf2755011f3fa86b5316b09595216fb990e5972"},{"author":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"change_message_id":"b460c4330b32473f85c8b0d8e13e3e48732bfc13","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Commit Messages"},{"line_number":10,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- Its the first thing a reviewer sees and its as important as the code"},{"line_number":13,"context_line":"- Brief explaination with context about the patch"},{"line_number":14,"context_line":"- They provide a description of the history of changes in a"},{"line_number":15,"context_line":"  repository"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9ff52f3f_535c8d4a","line":12,"range":{"start_line":12,"start_character":2,"end_line":12,"end_character":5},"updated":"2017-04-13 15:20:05.000000000","message":"-\u003e \"It is\"?","commit_id":"9cf2755011f3fa86b5316b09595216fb990e5972"},{"author":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"change_message_id":"b460c4330b32473f85c8b0d8e13e3e48732bfc13","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Commit Messages"},{"line_number":10,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- Its the first thing a reviewer sees and its as important as the code"},{"line_number":13,"context_line":"- Brief explaination with context about the patch"},{"line_number":14,"context_line":"- They provide a description of the history of changes in a"},{"line_number":15,"context_line":"  repository"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9ff52f3f_f330410a","line":12,"range":{"start_line":12,"start_character":42,"end_line":12,"end_character":45},"updated":"2017-04-13 15:20:05.000000000","message":"-\u003e \"it is\"?","commit_id":"9cf2755011f3fa86b5316b09595216fb990e5972"},{"author":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"change_message_id":"b460c4330b32473f85c8b0d8e13e3e48732bfc13","unresolved":false,"context_lines":[{"line_number":10,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- Its the first thing a reviewer sees and its as important as the code"},{"line_number":13,"context_line":"- Brief explaination with context about the patch"},{"line_number":14,"context_line":"- They provide a description of the history of changes in a"},{"line_number":15,"context_line":"  repository"},{"line_number":16,"context_line":"- They cannot be modified once merged"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9ff52f3f_53212db4","line":13,"range":{"start_line":13,"start_character":8,"end_line":13,"end_character":20},"updated":"2017-04-13 15:20:05.000000000","message":"-\u003e \"explanation\"","commit_id":"9cf2755011f3fa86b5316b09595216fb990e5972"},{"author":{"_account_id":14482,"name":"Ian Y. Choi","email":"ianyrchoi@gmail.com","username":"ianychoi"},"change_message_id":"b460c4330b32473f85c8b0d8e13e3e48732bfc13","unresolved":false,"context_lines":[{"line_number":91,"context_line":"  - UpgradeImpact"},{"line_number":92,"context_line":"  - Depends-On"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":".. note"},{"line_number":95,"context_line":"   Explain the tags and when you use them. Documentation, API,"},{"line_number":96,"context_line":"   Security or Upgrade Impacts are for patches with changes that"},{"line_number":97,"context_line":"   alter the existing state. Depends-On is for cross repository"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9ff52f3f_8e0d4c39","line":94,"range":{"start_line":94,"start_character":0,"end_line":94,"end_character":7},"updated":"2017-04-13 15:20:05.000000000","message":"-\u003e \".. note::\"","commit_id":"9cf2755011f3fa86b5316b09595216fb990e5972"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"a6a0ece5954b2f9c46714e02a598fc9f6a62de55","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Commit Messages"},{"line_number":10,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- It is the first thing a reviewer sees and it is as important as the code"},{"line_number":13,"context_line":"- Brief explanation with context about the patch"},{"line_number":14,"context_line":"- They provide a description of the history of changes in a"},{"line_number":15,"context_line":"  repository"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7ffa3b31_a84a3b24","line":12,"range":{"start_line":12,"start_character":2,"end_line":12,"end_character":11},"updated":"2017-04-15 20:17:04.000000000","message":"The first ...","commit_id":"62dad9f3edb51925a976dc4d4ec751e2327bbdf7"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"a6a0ece5954b2f9c46714e02a598fc9f6a62de55","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"- It is the first thing a reviewer sees and it is as important as the code"},{"line_number":13,"context_line":"- Brief explanation with context about the patch"},{"line_number":14,"context_line":"- They provide a description of the history of changes in a"},{"line_number":15,"context_line":"  repository"},{"line_number":16,"context_line":"- They cannot be modified once merged"},{"line_number":17,"context_line":"- Format:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7ffa3b31_685433cb","line":14,"range":{"start_line":14,"start_character":2,"end_line":14,"end_character":35},"updated":"2017-04-15 20:17:04.000000000","message":"Provide the history ...","commit_id":"62dad9f3edb51925a976dc4d4ec751e2327bbdf7"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"a6a0ece5954b2f9c46714e02a598fc9f6a62de55","unresolved":false,"context_lines":[{"line_number":13,"context_line":"- Brief explanation with context about the patch"},{"line_number":14,"context_line":"- They provide a description of the history of changes in a"},{"line_number":15,"context_line":"  repository"},{"line_number":16,"context_line":"- They cannot be modified once merged"},{"line_number":17,"context_line":"- Format:"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  - Summary Line"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7ffa3b31_28606ba5","line":16,"range":{"start_line":16,"start_character":2,"end_line":16,"end_character":13},"updated":"2017-04-15 20:17:04.000000000","message":"Cannot be ...","commit_id":"62dad9f3edb51925a976dc4d4ec751e2327bbdf7"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"e5059b555a06193086a5cce43d845d4ceed3fc89","unresolved":false,"context_lines":[{"line_number":59,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Write a commit message body to expand on each of the following summary"},{"line_number":62,"context_line":"lines. Feel free to make up details to make the context more realistic."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"- Cleanup deprecated methods"},{"line_number":65,"context_line":"- Minimize database queries"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7ffa3b31_9c91e855","line":62,"range":{"start_line":62,"start_character":7,"end_line":62,"end_character":71},"updated":"2017-04-17 19:18:10.000000000","message":"Do we want them to share their favorite in IRC like with the other exercise?","commit_id":"62dad9f3edb51925a976dc4d4ec751e2327bbdf7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0e171f805a091aeed279054ceaad3ec70a4aedcc","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"- Cleanup deprecated methods"},{"line_number":65,"context_line":"- Minimize database queries"},{"line_number":66,"context_line":"- Added unit tests to cover untested methods"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Do not assume ..."},{"line_number":69,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7ffa3b31_50d0dc1f","line":66,"range":{"start_line":66,"start_character":0,"end_line":66,"end_character":44},"updated":"2017-04-18 01:53:43.000000000","message":"can we add one more set of exercise for cross project changes, something like:\n\n- Implements serial console for baremetal node in Ironic\n\n- Add Support for serial console in nova for ironic hypervisor driver.\n\nhere Nova change depends on ironic changes which are also under review and you need to use Depends-On tag.\nThis can show how gate tests both changes across project and zuul make sure nova changes not gets merged before ironic.","commit_id":"62dad9f3edb51925a976dc4d4ec751e2327bbdf7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0e171f805a091aeed279054ceaad3ec70a4aedcc","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"- Required:"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  - Change-id"},{"line_number":81,"context_line":"  - Task Tracking Info:"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    - Bug (Partial-Bug, Related-Bug, Closes-Bug)"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7ffa3b31_10c0147b","line":80,"range":{"start_line":80,"start_character":4,"end_line":80,"end_character":13},"updated":"2017-04-18 01:53:43.000000000","message":"s/Change-id/Change-Id","commit_id":"62dad9f3edb51925a976dc4d4ec751e2327bbdf7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0e171f805a091aeed279054ceaad3ec70a4aedcc","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"- Required:"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  - Change-id"},{"line_number":81,"context_line":"  - Task Tracking Info:"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    - Bug (Partial-Bug, Related-Bug, Closes-Bug)"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7ffa3b31_70cf58b0","line":80,"range":{"start_line":80,"start_character":2,"end_line":80,"end_character":13},"updated":"2017-04-18 01:53:43.000000000","message":"should we mention that explicitly that do not use gerrit review link and always use Change-Id.","commit_id":"62dad9f3edb51925a976dc4d4ec751e2327bbdf7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0e171f805a091aeed279054ceaad3ec70a4aedcc","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    - Bug (Partial-Bug, Related-Bug, Closes-Bug)"},{"line_number":84,"context_line":"    - Blueprint (Partial-Implements, Implements)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"- Additional External References:"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  - DocImpact"},{"line_number":89,"context_line":"  - APIImpact"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7ffa3b31_109ff45f","line":86,"range":{"start_line":86,"start_character":0,"end_line":86,"end_character":33},"updated":"2017-04-18 01:53:43.000000000","message":"Many people use logs link etc which are not permanent and will be gone after specific time.\n\nit will be nice to explain them not not to use any link which is not permanent.","commit_id":"62dad9f3edb51925a976dc4d4ec751e2327bbdf7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"0e171f805a091aeed279054ceaad3ec70a4aedcc","unresolved":false,"context_lines":[{"line_number":92,"context_line":"  - Depends-On"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":".. note::"},{"line_number":95,"context_line":"   Explain the tags and when you use them. Documentation, API,"},{"line_number":96,"context_line":"   Security or Upgrade Impacts are for patches with changes that"},{"line_number":97,"context_line":"   alter the existing state. Depends-On is for cross repository"},{"line_number":98,"context_line":"   dependecies."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Exercise"},{"line_number":101,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7ffa3b31_d04d0c73","line":98,"range":{"start_line":95,"start_character":0,"end_line":98,"end_character":15},"updated":"2017-04-18 01:53:43.000000000","message":"To give a glance of what all tags means, can we redirect them into specific section of https://wiki.openstack.org/wiki/GitCommitMessages like # Including external references\n\nFor example: \n- Explaining how Depends-On work on gate (gate checkout/merge the Depends-On patch along with proposed changes and test them all together)\n- Proposed changes cannot be merged till Depends-On patch gets merged.\n\nsomething like explained in https://docs.openstack.org/infra/manual/developers.html#cross-repository-dependencies\n\nOr give link here and explain a little bit about those.","commit_id":"62dad9f3edb51925a976dc4d4ec751e2327bbdf7"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"a6a0ece5954b2f9c46714e02a598fc9f6a62de55","unresolved":false,"context_lines":[{"line_number":95,"context_line":"   Explain the tags and when you use them. Documentation, API,"},{"line_number":96,"context_line":"   Security or Upgrade Impacts are for patches with changes that"},{"line_number":97,"context_line":"   alter the existing state. Depends-On is for cross repository"},{"line_number":98,"context_line":"   dependecies."},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"Exercise"},{"line_number":101,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":4,"id":"7ffa3b31_a8735b80","line":98,"range":{"start_line":98,"start_character":3,"end_line":98,"end_character":14},"updated":"2017-04-15 20:17:04.000000000","message":"dependencies","commit_id":"62dad9f3edb51925a976dc4d4ec751e2327bbdf7"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"a6a0ece5954b2f9c46714e02a598fc9f6a62de55","unresolved":false,"context_lines":[{"line_number":105,"context_line":"along with any optional external references you think it may benefit from."},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"Share the commit message with one of two people at your table. Give them"},{"line_number":109,"context_line":"feedback on their commit messages."}],"source_content_type":"text/x-rst","patch_set":4,"id":"7ffa3b31_28050bc3","line":108,"range":{"start_line":108,"start_character":30,"end_line":108,"end_character":40},"updated":"2017-04-15 20:17:04.000000000","message":"one or two?","commit_id":"62dad9f3edb51925a976dc4d4ec751e2327bbdf7"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"7adafea99bbcc4323a91dc05e1d2648430ec4b69","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"- The reviewer understands what the original problem was"},{"line_number":58,"context_line":"- The reviewer has access to external web services/site"},{"line_number":59,"context_line":"- The code is self-evident/self-documenting"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"Required external references"},{"line_number":62,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":5,"id":"5ff73747_c519fc88","side":"PARENT","line":59,"updated":"2017-04-24 09:46:51.000000000","message":"There\u0027s another common assumption that perhaps ought to be covered here:\n\nDo not assume that the reader of the commit log is reading it near in time to when you wrote it. Someone years later may be reading the commit to understand why it was done. So it\u0027s not just the reviewers we need to be concerned with.","commit_id":"00e6b93066b00129d8d0e85b70e1fd2896b0a772"}]}
