)]}'
{"tools/generate-labs.sh":[{"author":{"_account_id":11109,"name":"Roger Luethi","email":"rl@patchworkscience.org","username":"rluethi"},"change_message_id":"66d7acbb3277caa4508a636cf916465e840feb88","unresolved":false,"context_lines":[{"line_number":20,"context_line":"labs/osbash/osbash.sh -w cluster"},{"line_number":21,"context_line":"# Create zip file of labs scripts for Windows users"},{"line_number":22,"context_line":"zip -r build/labs.zip labs/osbash \\"},{"line_number":23,"context_line":"    -x *.iso *.vdi *.log *.auto"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"dae33548_9cbbaac3","side":"PARENT","line":23,"updated":"2016-02-18 19:44:13.000000000","message":"You may want to fix this while you are at it: the asterisks here need escaping or they will match any suitable file that just happens to be there.","commit_id":"3c0fdfa1d295e3eb38b88bd6bc69cca5d8698c13"},{"author":{"_account_id":7007,"name":"Pranav Salunke","email":"dguitarbite@gmail.com","username":"dguitarbite"},"change_message_id":"d1a5a6735f8499ea37d760d7604c895dfa67a41f","unresolved":false,"context_lines":[{"line_number":20,"context_line":"labs/osbash/osbash.sh -w cluster"},{"line_number":21,"context_line":"# Create zip file of labs scripts for Windows users"},{"line_number":22,"context_line":"zip -r build/labs.zip labs/osbash \\"},{"line_number":23,"context_line":"    -x *.iso *.vdi *.log *.auto"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"bae84128_9fbe5a63","side":"PARENT","line":23,"in_reply_to":"dae33548_9cbbaac3","updated":"2016-02-23 09:10:44.000000000","message":"Done","commit_id":"3c0fdfa1d295e3eb38b88bd6bc69cca5d8698c13"},{"author":{"_account_id":11109,"name":"Roger Luethi","email":"rl@patchworkscience.org","username":"rluethi"},"change_message_id":"66d7acbb3277caa4508a636cf916465e840feb88","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"set -o nounset  # Treat unset variables as an error"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"release\u003d$1"},{"line_number":14,"context_line":"release\u003d${release////-}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"echo $release"}],"source_content_type":"text/x-sh","patch_set":4,"id":"dae33548_fc58f68b","line":13,"updated":"2016-02-18 19:44:13.000000000","message":"\"master\" is not really a release, is it? Do we have a plan for building branch releases (say, kilo, liberty) with correct names? (this is not urgent, we can still improve upon it once we have something that builds zip files and tar balls.)","commit_id":"11124d8ffd9b8198c4ac8ac296aead887db8aabb"},{"author":{"_account_id":7007,"name":"Pranav Salunke","email":"dguitarbite@gmail.com","username":"dguitarbite"},"change_message_id":"d1a5a6735f8499ea37d760d7604c895dfa67a41f","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"set -o nounset  # Treat unset variables as an error"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"release\u003d$1"},{"line_number":14,"context_line":"release\u003d${release////-}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"echo $release"}],"source_content_type":"text/x-sh","patch_set":4,"id":"bae84128_9f7bfaf4","line":13,"in_reply_to":"dae33548_fc58f68b","updated":"2016-02-23 09:10:44.000000000","message":"This will be fed by the zuul/jenkins jobs after merging the patch in openstack ci/infra.\n\nIt makes sense to publish master zip/tar balls just for the sake of it. I dont see a problem with that. May be its not a good idea to publish this on the docs.openstack.org/training-labs landing page. :)","commit_id":"11124d8ffd9b8198c4ac8ac296aead887db8aabb"},{"author":{"_account_id":11109,"name":"Roger Luethi","email":"rl@patchworkscience.org","username":"rluethi"},"change_message_id":"66d7acbb3277caa4508a636cf916465e840feb88","unresolved":false,"context_lines":[{"line_number":11,"context_line":"set -o nounset  # Treat unset variables as an error"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"release\u003d$1"},{"line_number":14,"context_line":"release\u003d${release////-}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"echo $release"},{"line_number":17,"context_line":"# Delete and recreate required folders"}],"source_content_type":"text/x-sh","patch_set":4,"id":"dae33548_dcac12a1","line":14,"updated":"2016-02-18 19:44:13.000000000","message":"This needs a comment explaining what it is trying to accomplish. It certainly does not do a whole lot for the default \"master\" argument.","commit_id":"11124d8ffd9b8198c4ac8ac296aead887db8aabb"},{"author":{"_account_id":7007,"name":"Pranav Salunke","email":"dguitarbite@gmail.com","username":"dguitarbite"},"change_message_id":"d1a5a6735f8499ea37d760d7604c895dfa67a41f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"set -o nounset  # Treat unset variables as an error"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"release\u003d$1"},{"line_number":14,"context_line":"release\u003d${release////-}"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"echo $release"},{"line_number":17,"context_line":"# Delete and recreate required folders"}],"source_content_type":"text/x-sh","patch_set":4,"id":"bae84128_bfd4febc","line":14,"in_reply_to":"dae33548_dcac12a1","updated":"2016-02-23 09:10:44.000000000","message":"Done","commit_id":"11124d8ffd9b8198c4ac8ac296aead887db8aabb"},{"author":{"_account_id":11109,"name":"Roger Luethi","email":"rl@patchworkscience.org","username":"rluethi"},"change_message_id":"66d7acbb3277caa4508a636cf916465e840feb88","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"echo $release"},{"line_number":17,"context_line":"# Delete and recreate required folders"},{"line_number":18,"context_line":"mkdir -p ./build/dist/"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# Create tarball of labs scripts for Linux/OS X users"},{"line_number":21,"context_line":"tar --exclude\u003d*.iso \\"}],"source_content_type":"text/x-sh","patch_set":4,"id":"dae33548_bc2dceff","line":18,"updated":"2016-02-18 19:44:13.000000000","message":"The code does not match the comment: it creates folders but deletes nothing.","commit_id":"11124d8ffd9b8198c4ac8ac296aead887db8aabb"},{"author":{"_account_id":7007,"name":"Pranav Salunke","email":"dguitarbite@gmail.com","username":"dguitarbite"},"change_message_id":"d1a5a6735f8499ea37d760d7604c895dfa67a41f","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"echo $release"},{"line_number":17,"context_line":"# Delete and recreate required folders"},{"line_number":18,"context_line":"mkdir -p ./build/dist/"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# Create tarball of labs scripts for Linux/OS X users"},{"line_number":21,"context_line":"tar --exclude\u003d*.iso \\"}],"source_content_type":"text/x-sh","patch_set":4,"id":"bae84128_dfe622af","line":18,"in_reply_to":"dae33548_bc2dceff","updated":"2016-02-23 09:10:44.000000000","message":"That would be my mistake. I thought I would have to delete the build/ folder but I decided against it somewhere during writing the code. I will update the commit message. Thanks for catching this issue.","commit_id":"11124d8ffd9b8198c4ac8ac296aead887db8aabb"}]}