)]}'
{"tricircle/nova_apigw/controllers/server.py":[{"author":{"_account_id":11819,"name":"Chaoyi Huang","email":"joehuang@huawei.com","username":"joehuang"},"change_message_id":"7c89dce770bede9f22700889659233cd4bc05ac7","unresolved":false,"context_lines":[{"line_number":386,"context_line":"            for add_rule in add_rules:"},{"line_number":387,"context_line":"                add_rule[\u0027security_group_id\u0027] \u003d b_sg_id"},{"line_number":388,"context_line":"                rule_body \u003d {\u0027security_group_rule\u0027: add_rule}"},{"line_number":389,"context_line":"                self._safe_create_security_group_rule(context,"},{"line_number":390,"context_line":"                                                      client, rule_body)"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"    def _handle_sg_rule_for_new_group(self, context, pod, top_sgs,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_bfea0a72","line":389,"range":{"start_line":389,"start_character":21,"end_line":389,"end_character":53},"updated":"2016-03-01 07:16:59.000000000","message":"add rules in batch to reduce rest api calling. delete can be done only one by one","commit_id":"f68071fb653b81afab1cbfbf440313b94f322abf"},{"author":{"_account_id":11819,"name":"Chaoyi Huang","email":"joehuang@huawei.com","username":"joehuang"},"change_message_id":"7c89dce770bede9f22700889659233cd4bc05ac7","unresolved":false,"context_lines":[{"line_number":396,"context_line":"            b_sg_id \u003d bottom_sg_ids[i]"},{"line_number":397,"context_line":"            new_b_rules \u003d []"},{"line_number":398,"context_line":"            for t_rule in t_sg[\u0027security_group_rules\u0027]:"},{"line_number":399,"context_line":"                if t_rule[\u0027remote_group_id\u0027]:"},{"line_number":400,"context_line":"                    # we do not handle remote group rule for non-default"},{"line_number":401,"context_line":"                    # security group, actually tricircle plugin in neutron"},{"line_number":402,"context_line":"                    # will reject such rule"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_ff3812d5","line":399,"range":{"start_line":399,"start_character":19,"end_line":399,"end_character":25},"updated":"2016-03-01 07:16:59.000000000","message":"and !\u003d default. Need to dealt with if t-rule \u003d\u003d default","commit_id":"f68071fb653b81afab1cbfbf440313b94f322abf"},{"author":{"_account_id":11819,"name":"Chaoyi Huang","email":"joehuang@huawei.com","username":"joehuang"},"change_message_id":"7c89dce770bede9f22700889659233cd4bc05ac7","unresolved":false,"context_lines":[{"line_number":409,"context_line":"                    self._safe_delete_security_group_rule("},{"line_number":410,"context_line":"                        context, client, b_rule[\u0027id\u0027])"},{"line_number":411,"context_line":"                for new_rule in new_b_rules:"},{"line_number":412,"context_line":"                    rule_body \u003d {\u0027security_group_rule\u0027: new_rule}"},{"line_number":413,"context_line":"                    self._safe_create_security_group_rule(context, client,"},{"line_number":414,"context_line":"                                                          rule_body)"},{"line_number":415,"context_line":"            except Exception:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_64aabb1a","line":412,"range":{"start_line":412,"start_character":34,"end_line":412,"end_character":53},"updated":"2016-03-01 07:16:59.000000000","message":"use security-group-rules to create rules in a batch","commit_id":"f68071fb653b81afab1cbfbf440313b94f322abf"},{"author":{"_account_id":11819,"name":"Chaoyi Huang","email":"joehuang@huawei.com","username":"joehuang"},"change_message_id":"b611626712dd2c0761bcfc1f8cdf06078c876618","unresolved":false,"context_lines":[{"line_number":339,"context_line":"        top_client \u003d self._get_client()"},{"line_number":340,"context_line":"        new_b_rules \u003d []"},{"line_number":341,"context_line":"        for t_rule in default_sg[\u0027security_group_rules\u0027]:"},{"line_number":342,"context_line":"            if not t_rule[\u0027remote_group_id\u0027]:"},{"line_number":343,"context_line":"                # leave sg_id empty here"},{"line_number":344,"context_line":"                new_b_rules.append("},{"line_number":345,"context_line":"                    self._construct_bottom_rule(t_rule, \u0027\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_c9ed378d","line":342,"range":{"start_line":342,"start_character":27,"end_line":342,"end_character":42},"updated":"2016-03-08 01:27:15.000000000","message":"default SEG group should be allowed to update the rules. So only for these rules where \"remote group id \u003d\u003d defualt\" needs to be handled here.","commit_id":"662bd389971f3f60b233f5cf95b24919e5be7770"}]}
