)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21023,"name":"Ronghui Cao","email":"CR_hui@126.com","username":"CR_hui"},"change_message_id":"3650f324b5816e0ffdfdfe58123894a7dea5e52b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhangxiaohan \u003czmj1981123@163.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-03-14 09:08:14 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"In a non-local network, delete a vm from one reigon, and use its port to"},{"line_number":8,"context_line":"create a vm in another region, the port in the original region is not"},{"line_number":9,"context_line":"deleted."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: If6819bf67ea2d206cc735039d8c55733dae54ee9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"df7087c5_1f0c673f","line":9,"range":{"start_line":7,"start_character":0,"end_line":9,"end_character":8},"updated":"2018-03-14 01:57:28.000000000","message":"Please fix the commit message like \"1. What is the problem?....\"","commit_id":"0e33da8fa7279f4097a69ec22184068dce8ae682"},{"author":{"_account_id":21023,"name":"Ronghui Cao","email":"CR_hui@126.com","username":"CR_hui"},"change_message_id":"7fe0a833765efffdf5d46dddd281c0dd8f8d94b9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhangxiaohan \u003czmj1981123@163.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-04-19 15:55:01 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"modify code for release port when delete vm"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. What is the problem?"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"9f6a8fd7_6403d7b9","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":6},"updated":"2018-04-19 08:41:40.000000000","message":"Modify","commit_id":"f0d2a2cdb2e1c78ef9202e0a261f88316e73db3d"},{"author":{"_account_id":26133,"name":"zhangxiaohan","email":"zmj1981123@163.com","username":"zhangxiaohan"},"change_message_id":"2ba158d0be0cc7809f29c946681fa85afb010bec","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhangxiaohan \u003czmj1981123@163.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-04-19 15:55:01 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"modify code for release port when delete vm"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. What is the problem?"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"9f6a8fd7_24a2bfaf","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":6},"in_reply_to":"9f6a8fd7_6403d7b9","updated":"2018-04-19 08:47:48.000000000","message":"Done","commit_id":"f0d2a2cdb2e1c78ef9202e0a261f88316e73db3d"}],"tricircle/network/central_plugin.py":[{"author":{"_account_id":12076,"name":"Zhiyuan Cai","email":"luckyvega.g@gmail.com","username":"zhiyuan_cai"},"change_message_id":"896f201f96465fd4a034735ba2543b0c5da66761","unresolved":false,"context_lines":[{"line_number":741,"context_line":"        mappings \u003d db_api.get_bottom_mappings_by_top_id("},{"line_number":742,"context_line":"            t_ctx, port_id, t_constants.RT_PORT)"},{"line_number":743,"context_line":"        if mappings:"},{"line_number":744,"context_line":"            region_name \u003d mappings[0][0][\u0027region_name\u0027]"},{"line_number":745,"context_line":"            bottom_port_id \u003d mappings[0][1]"},{"line_number":746,"context_line":"            bottom_port \u003d self._get_client(region_name).get_ports("},{"line_number":747,"context_line":"                t_ctx, bottom_port_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f96bb07_71fdacaf","line":744,"range":{"start_line":744,"start_character":12,"end_line":744,"end_character":23},"updated":"2018-01-16 14:53:08.000000000","message":"you can check if region_name is not the region passed by PROFILE_REGION","commit_id":"eb53a8336a46dac317d6353e14972ea7ce5923de"},{"author":{"_account_id":26133,"name":"zhangxiaohan","email":"zmj1981123@163.com","username":"zhangxiaohan"},"change_message_id":"12ab32ed09834df6d5a5bc9a8bde3f589211b01a","unresolved":false,"context_lines":[{"line_number":741,"context_line":"        mappings \u003d db_api.get_bottom_mappings_by_top_id("},{"line_number":742,"context_line":"            t_ctx, port_id, t_constants.RT_PORT)"},{"line_number":743,"context_line":"        if mappings:"},{"line_number":744,"context_line":"            region_name \u003d mappings[0][0][\u0027region_name\u0027]"},{"line_number":745,"context_line":"            bottom_port_id \u003d mappings[0][1]"},{"line_number":746,"context_line":"            bottom_port \u003d self._get_client(region_name).get_ports("},{"line_number":747,"context_line":"                t_ctx, bottom_port_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f96bb07_0f0c2eea","line":744,"range":{"start_line":744,"start_character":12,"end_line":744,"end_character":23},"in_reply_to":"7f96bb07_71fdacaf","updated":"2018-01-18 02:09:24.000000000","message":"Done","commit_id":"eb53a8336a46dac317d6353e14972ea7ce5923de"},{"author":{"_account_id":12076,"name":"Zhiyuan Cai","email":"luckyvega.g@gmail.com","username":"zhiyuan_cai"},"change_message_id":"896f201f96465fd4a034735ba2543b0c5da66761","unresolved":false,"context_lines":[{"line_number":750,"context_line":"                     or bottom_port[\u0027device_id\u0027] \u003d\u003d \u0027\u0027):"},{"line_number":751,"context_line":"                self._get_client(region_name).delete_resources("},{"line_number":752,"context_line":"                    t_constants.RT_PORT, t_ctx, bottom_port[\u0027id\u0027])"},{"line_number":753,"context_line":"                with t_ctx.session.begin():"},{"line_number":754,"context_line":"                    core.delete_resources(t_ctx,"},{"line_number":755,"context_line":"                                          models.ResourceRouting,"},{"line_number":756,"context_line":"                                          filters\u003d[{"},{"line_number":757,"context_line":"                                              \u0027key\u0027: \u0027top_id\u0027,"},{"line_number":758,"context_line":"                                              \u0027comparator\u0027: \u0027eq\u0027,"},{"line_number":759,"context_line":"                                              \u0027value\u0027: bottom_port[\u0027id\u0027]}])"},{"line_number":760,"context_line":""},{"line_number":761,"context_line":"    def update_port(self, context, port_id, port):"},{"line_number":762,"context_line":"        t_ctx \u003d t_context.get_context_from_neutron_context(context)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f96bb07_11d5481c","line":759,"range":{"start_line":753,"start_character":16,"end_line":759,"end_character":75},"updated":"2018-01-16 14:53:08.000000000","message":"I remember that we have a delete_mapping function","commit_id":"eb53a8336a46dac317d6353e14972ea7ce5923de"},{"author":{"_account_id":26133,"name":"zhangxiaohan","email":"zmj1981123@163.com","username":"zhangxiaohan"},"change_message_id":"12ab32ed09834df6d5a5bc9a8bde3f589211b01a","unresolved":false,"context_lines":[{"line_number":750,"context_line":"                     or bottom_port[\u0027device_id\u0027] \u003d\u003d \u0027\u0027):"},{"line_number":751,"context_line":"                self._get_client(region_name).delete_resources("},{"line_number":752,"context_line":"                    t_constants.RT_PORT, t_ctx, bottom_port[\u0027id\u0027])"},{"line_number":753,"context_line":"                with t_ctx.session.begin():"},{"line_number":754,"context_line":"                    core.delete_resources(t_ctx,"},{"line_number":755,"context_line":"                                          models.ResourceRouting,"},{"line_number":756,"context_line":"                                          filters\u003d[{"},{"line_number":757,"context_line":"                                              \u0027key\u0027: \u0027top_id\u0027,"},{"line_number":758,"context_line":"                                              \u0027comparator\u0027: \u0027eq\u0027,"},{"line_number":759,"context_line":"                                              \u0027value\u0027: bottom_port[\u0027id\u0027]}])"},{"line_number":760,"context_line":""},{"line_number":761,"context_line":"    def update_port(self, context, port_id, port):"},{"line_number":762,"context_line":"        t_ctx \u003d t_context.get_context_from_neutron_context(context)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f96bb07_cff966c8","line":759,"range":{"start_line":753,"start_character":16,"end_line":759,"end_character":75},"in_reply_to":"7f96bb07_11d5481c","updated":"2018-01-18 02:09:24.000000000","message":"db_api.delete_mappings_by_bottom_id(t_ctx, bottom_port[\u0027id\u0027])","commit_id":"eb53a8336a46dac317d6353e14972ea7ce5923de"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"06027854150f502101a3ff9ee8eee828776f8992","unresolved":false,"context_lines":[{"line_number":840,"context_line":"            bottom_port_id \u003d mappings[0][1]"},{"line_number":841,"context_line":"            bottom_port \u003d self._get_client(region_name).get_ports("},{"line_number":842,"context_line":"                t_ctx, bottom_port_id)"},{"line_number":843,"context_line":"            if \u0027device_id\u0027 in bottom_port and \\"},{"line_number":844,"context_line":"                    (bottom_port[\u0027device_id\u0027] is None"},{"line_number":845,"context_line":"                     or bottom_port[\u0027device_id\u0027] \u003d\u003d \u0027\u0027) and \\"},{"line_number":846,"context_line":"                    (not bottom_port[\u0027device_owner\u0027].startswith("},{"line_number":847,"context_line":"                        \u0027compute:shadow\u0027)):"},{"line_number":848,"context_line":"                db_api.delete_mappings_by_bottom_id(t_ctx, bottom_port[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f6a8fd7_f56f948f","line":845,"range":{"start_line":843,"start_character":16,"end_line":845,"end_character":55},"updated":"2018-04-19 07:31:36.000000000","message":"just make it simple:\n\n  bottom_port.get(\u0027device_id\u0027) in [None, \u0027\u0027]\n\nor much simple:\n\n  bottom_port.get(\u0027device_id\u0027) is None","commit_id":"c75a552fa15d37487a87d2fa021405faee690db8"},{"author":{"_account_id":26133,"name":"zhangxiaohan","email":"zmj1981123@163.com","username":"zhangxiaohan"},"change_message_id":"5e3ff204cd50a4a74dea4d61a216e88d725ab567","unresolved":false,"context_lines":[{"line_number":840,"context_line":"            bottom_port_id \u003d mappings[0][1]"},{"line_number":841,"context_line":"            bottom_port \u003d self._get_client(region_name).get_ports("},{"line_number":842,"context_line":"                t_ctx, bottom_port_id)"},{"line_number":843,"context_line":"            if \u0027device_id\u0027 in bottom_port and \\"},{"line_number":844,"context_line":"                    (bottom_port[\u0027device_id\u0027] is None"},{"line_number":845,"context_line":"                     or bottom_port[\u0027device_id\u0027] \u003d\u003d \u0027\u0027) and \\"},{"line_number":846,"context_line":"                    (not bottom_port[\u0027device_owner\u0027].startswith("},{"line_number":847,"context_line":"                        \u0027compute:shadow\u0027)):"},{"line_number":848,"context_line":"                db_api.delete_mappings_by_bottom_id(t_ctx, bottom_port[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f6a8fd7_55f1a06a","line":845,"range":{"start_line":843,"start_character":16,"end_line":845,"end_character":55},"in_reply_to":"9f6a8fd7_f56f948f","updated":"2018-04-19 07:53:26.000000000","message":"Done","commit_id":"c75a552fa15d37487a87d2fa021405faee690db8"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"06027854150f502101a3ff9ee8eee828776f8992","unresolved":false,"context_lines":[{"line_number":853,"context_line":"                for nw_map in nw_mappings:"},{"line_number":854,"context_line":"                    region_name \u003d nw_map[0][\u0027region_name\u0027]"},{"line_number":855,"context_line":"                    if region_name !\u003d profile_region:"},{"line_number":856,"context_line":"                        self._get_client(region_name).update_ports("},{"line_number":857,"context_line":"                            t_ctx, port_id, {\u0027port\u0027: {"},{"line_number":858,"context_line":"                                \u0027device_id\u0027: \u0027\u0027, \u0027device_owner\u0027: \u0027\u0027,"},{"line_number":859,"context_line":"                                portbindings.HOST_ID: None,"},{"line_number":860,"context_line":"                                \u0027name\u0027: bottom_port[\u0027name\u0027]"},{"line_number":861,"context_line":"                            }})"},{"line_number":862,"context_line":""},{"line_number":863,"context_line":"    def update_port(self, context, port_id, port):"},{"line_number":864,"context_line":"        t_ctx \u003d t_context.get_context_from_neutron_context(context)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f6a8fd7_d5f930c8","line":861,"range":{"start_line":856,"start_character":67,"end_line":861,"end_character":30},"updated":"2018-04-19 07:31:36.000000000","message":"please re-indent this, each item in one line","commit_id":"c75a552fa15d37487a87d2fa021405faee690db8"},{"author":{"_account_id":26133,"name":"zhangxiaohan","email":"zmj1981123@163.com","username":"zhangxiaohan"},"change_message_id":"5e3ff204cd50a4a74dea4d61a216e88d725ab567","unresolved":false,"context_lines":[{"line_number":853,"context_line":"                for nw_map in nw_mappings:"},{"line_number":854,"context_line":"                    region_name \u003d nw_map[0][\u0027region_name\u0027]"},{"line_number":855,"context_line":"                    if region_name !\u003d profile_region:"},{"line_number":856,"context_line":"                        self._get_client(region_name).update_ports("},{"line_number":857,"context_line":"                            t_ctx, port_id, {\u0027port\u0027: {"},{"line_number":858,"context_line":"                                \u0027device_id\u0027: \u0027\u0027, \u0027device_owner\u0027: \u0027\u0027,"},{"line_number":859,"context_line":"                                portbindings.HOST_ID: None,"},{"line_number":860,"context_line":"                                \u0027name\u0027: bottom_port[\u0027name\u0027]"},{"line_number":861,"context_line":"                            }})"},{"line_number":862,"context_line":""},{"line_number":863,"context_line":"    def update_port(self, context, port_id, port):"},{"line_number":864,"context_line":"        t_ctx \u003d t_context.get_context_from_neutron_context(context)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f6a8fd7_d58930ca","line":861,"range":{"start_line":856,"start_character":67,"end_line":861,"end_character":30},"in_reply_to":"9f6a8fd7_d5f930c8","updated":"2018-04-19 07:53:26.000000000","message":"Done","commit_id":"c75a552fa15d37487a87d2fa021405faee690db8"},{"author":{"_account_id":12076,"name":"Zhiyuan Cai","email":"luckyvega.g@gmail.com","username":"zhiyuan_cai"},"change_message_id":"a60b79193a79945b413b1d32ebedee0bf57f0f09","unresolved":false,"context_lines":[{"line_number":776,"context_line":"            bottom_port_id \u003d mappings[0][1]"},{"line_number":777,"context_line":"            bottom_port \u003d self._get_client(region_name).get_ports("},{"line_number":778,"context_line":"                t_ctx, bottom_port_id)"},{"line_number":779,"context_line":"            if \u0027device_id\u0027 in bottom_port and \\"},{"line_number":780,"context_line":"                    (bottom_port.get(\u0027device_id\u0027) is None"},{"line_number":781,"context_line":"                     or bottom_port[\u0027device_id\u0027] \u003d\u003d \u0027\u0027) and \\"},{"line_number":782,"context_line":"                    (not bottom_port[\u0027device_owner\u0027].startswith("},{"line_number":783,"context_line":"                        \u0027compute:shadow\u0027)):"},{"line_number":784,"context_line":"                db_api.delete_mappings_by_bottom_id(t_ctx, bottom_port[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f6a8fd7_9ef602d7","line":781,"range":{"start_line":779,"start_character":12,"end_line":781,"end_character":55},"updated":"2018-04-25 00:47:56.000000000","message":"\"\u0027device_id\u0027 in bottom_port\" and \"bottom_port.get(\u0027device_id\u0027) is None\" seem contradictory","commit_id":"82f3d7b85562079f6ac3bc648924f0a1ce86a559"},{"author":{"_account_id":26133,"name":"zhangxiaohan","email":"zmj1981123@163.com","username":"zhangxiaohan"},"change_message_id":"8e00dec08279fed6ff0b33b46a3206a30d0d57f3","unresolved":false,"context_lines":[{"line_number":776,"context_line":"            bottom_port_id \u003d mappings[0][1]"},{"line_number":777,"context_line":"            bottom_port \u003d self._get_client(region_name).get_ports("},{"line_number":778,"context_line":"                t_ctx, bottom_port_id)"},{"line_number":779,"context_line":"            if \u0027device_id\u0027 in bottom_port and \\"},{"line_number":780,"context_line":"                    (bottom_port.get(\u0027device_id\u0027) is None"},{"line_number":781,"context_line":"                     or bottom_port[\u0027device_id\u0027] \u003d\u003d \u0027\u0027) and \\"},{"line_number":782,"context_line":"                    (not bottom_port[\u0027device_owner\u0027].startswith("},{"line_number":783,"context_line":"                        \u0027compute:shadow\u0027)):"},{"line_number":784,"context_line":"                db_api.delete_mappings_by_bottom_id(t_ctx, bottom_port[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f6a8fd7_34aa7718","line":781,"range":{"start_line":779,"start_character":12,"end_line":781,"end_character":55},"in_reply_to":"9f6a8fd7_9ef602d7","updated":"2018-04-25 06:15:29.000000000","message":"if bottom_port[\u0027device_id\u0027] in (\u0027\u0027, None) and \\\n                    (not bottom_port[\u0027device_owner\u0027].startswith(\n                        \u0027compute:shadow\u0027)):","commit_id":"82f3d7b85562079f6ac3bc648924f0a1ce86a559"},{"author":{"_account_id":27215,"name":"baisen","email":"songbaisen@szzt.com.cn","username":"songbaisen"},"change_message_id":"3dd2511efd8c5441da276fcb1bab6140a6963735","unresolved":false,"context_lines":[{"line_number":776,"context_line":"            bottom_port_id \u003d mappings[0][1]"},{"line_number":777,"context_line":"            bottom_port \u003d self._get_client(region_name).get_ports("},{"line_number":778,"context_line":"                t_ctx, bottom_port_id)"},{"line_number":779,"context_line":"            if bottom_port[\u0027device_id\u0027] in (\u0027\u0027, None) and \\"},{"line_number":780,"context_line":"                    (not bottom_port[\u0027device_owner\u0027].startswith("},{"line_number":781,"context_line":"                        \u0027compute:shadow\u0027)):"},{"line_number":782,"context_line":"                db_api.delete_mappings_by_bottom_id(t_ctx, bottom_port[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":16,"id":"9f6a8fd7_2e06a353","line":779,"updated":"2018-04-25 07:30:56.000000000","message":"if device_id not in bttom_port use \u0027if bottom_port[\u0027device_id\u0027] in (\u0027\u0027, None)\u0027 may raise key not exist error?","commit_id":"32a85d996d7a7b69896af6fae2e6b73458ec40f5"},{"author":{"_account_id":27215,"name":"baisen","email":"songbaisen@szzt.com.cn","username":"songbaisen"},"change_message_id":"20045681aad70a4bb12c0aa0cf8e633384aace22","unresolved":false,"context_lines":[{"line_number":776,"context_line":"            bottom_port_id \u003d mappings[0][1]"},{"line_number":777,"context_line":"            bottom_port \u003d self._get_client(region_name).get_ports("},{"line_number":778,"context_line":"                t_ctx, bottom_port_id)"},{"line_number":779,"context_line":"            if bottom_port[\u0027device_id\u0027] in (\u0027\u0027, None) and \\"},{"line_number":780,"context_line":"                    (not bottom_port[\u0027device_owner\u0027].startswith("},{"line_number":781,"context_line":"                        \u0027compute:shadow\u0027)):"},{"line_number":782,"context_line":"                db_api.delete_mappings_by_bottom_id(t_ctx, bottom_port[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":16,"id":"9f6a8fd7_d1522813","line":779,"in_reply_to":"9f6a8fd7_0e287f94","updated":"2018-04-25 07:41:15.000000000","message":"yeah!","commit_id":"32a85d996d7a7b69896af6fae2e6b73458ec40f5"},{"author":{"_account_id":26133,"name":"zhangxiaohan","email":"zmj1981123@163.com","username":"zhangxiaohan"},"change_message_id":"fb324ee3721353b2a22415c40f092149b0635e02","unresolved":false,"context_lines":[{"line_number":776,"context_line":"            bottom_port_id \u003d mappings[0][1]"},{"line_number":777,"context_line":"            bottom_port \u003d self._get_client(region_name).get_ports("},{"line_number":778,"context_line":"                t_ctx, bottom_port_id)"},{"line_number":779,"context_line":"            if bottom_port[\u0027device_id\u0027] in (\u0027\u0027, None) and \\"},{"line_number":780,"context_line":"                    (not bottom_port[\u0027device_owner\u0027].startswith("},{"line_number":781,"context_line":"                        \u0027compute:shadow\u0027)):"},{"line_number":782,"context_line":"                db_api.delete_mappings_by_bottom_id(t_ctx, bottom_port[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":16,"id":"9f6a8fd7_0e287f94","line":779,"in_reply_to":"9f6a8fd7_2e06a353","updated":"2018-04-25 07:37:39.000000000","message":"when get_ports() function args fields\u003dNone, \u0027device_id\u0027 is sure exist.","commit_id":"32a85d996d7a7b69896af6fae2e6b73458ec40f5"}],"tricircle/network/local_plugin.py":[{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"06027854150f502101a3ff9ee8eee828776f8992","unresolved":false,"context_lines":[{"line_number":540,"context_line":"                # clear binding profile set by xmanager"},{"line_number":541,"context_line":"                port_body[portbindings.PROFILE] \u003d {}"},{"line_number":542,"context_line":"                if port_body[\u0027id\u0027] in b_port_list:"},{"line_number":543,"context_line":"                    port_body.pop(\u0027security_groups\u0027)"},{"line_number":544,"context_line":"                    self.update_port(context, port_body[\u0027id\u0027], port)"},{"line_number":545,"context_line":"                    ports[\u0027ports\u0027].remove(port)"},{"line_number":546,"context_line":"            elif (port_body[\u0027device_owner\u0027] \u003d\u003d"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f6a8fd7_b517dced","line":543,"range":{"start_line":543,"start_character":20,"end_line":543,"end_character":52},"updated":"2018-04-19 07:31:36.000000000","message":"this one can throw exception, therefore, use:\n\n  port_body.pop(\u0027security_group\u0027, None)","commit_id":"c75a552fa15d37487a87d2fa021405faee690db8"},{"author":{"_account_id":26133,"name":"zhangxiaohan","email":"zmj1981123@163.com","username":"zhangxiaohan"},"change_message_id":"5e3ff204cd50a4a74dea4d61a216e88d725ab567","unresolved":false,"context_lines":[{"line_number":540,"context_line":"                # clear binding profile set by xmanager"},{"line_number":541,"context_line":"                port_body[portbindings.PROFILE] \u003d {}"},{"line_number":542,"context_line":"                if port_body[\u0027id\u0027] in b_port_list:"},{"line_number":543,"context_line":"                    port_body.pop(\u0027security_groups\u0027)"},{"line_number":544,"context_line":"                    self.update_port(context, port_body[\u0027id\u0027], port)"},{"line_number":545,"context_line":"                    ports[\u0027ports\u0027].remove(port)"},{"line_number":546,"context_line":"            elif (port_body[\u0027device_owner\u0027] \u003d\u003d"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f6a8fd7_75c2a4eb","line":543,"range":{"start_line":543,"start_character":20,"end_line":543,"end_character":52},"in_reply_to":"9f6a8fd7_b517dced","updated":"2018-04-19 07:53:26.000000000","message":"Done","commit_id":"c75a552fa15d37487a87d2fa021405faee690db8"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"06027854150f502101a3ff9ee8eee828776f8992","unresolved":false,"context_lines":[{"line_number":698,"context_line":""},{"line_number":699,"context_line":"    @staticmethod"},{"line_number":700,"context_line":"    def _need_top_update(port_old, port, update_body):"},{"line_number":701,"context_line":"        if port_old.get(\u0027device_owner\u0027, \u0027\u0027) \u003d\u003d \\"},{"line_number":702,"context_line":"                t_constants.DEVICE_OWNER_SHADOW and \\"},{"line_number":703,"context_line":"                port[\u0027device_owner\u0027] \u003d\u003d \u0027\u0027 and \\"},{"line_number":704,"context_line":"                port[\u0027device_id\u0027] \u003d\u003d \u0027\u0027:"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f6a8fd7_95f178d0","line":701,"range":{"start_line":701,"start_character":47,"end_line":701,"end_character":48},"updated":"2018-04-19 07:31:36.000000000","message":"use parentheses instead of backslash for multi-lines","commit_id":"c75a552fa15d37487a87d2fa021405faee690db8"},{"author":{"_account_id":26133,"name":"zhangxiaohan","email":"zmj1981123@163.com","username":"zhangxiaohan"},"change_message_id":"5e3ff204cd50a4a74dea4d61a216e88d725ab567","unresolved":false,"context_lines":[{"line_number":698,"context_line":""},{"line_number":699,"context_line":"    @staticmethod"},{"line_number":700,"context_line":"    def _need_top_update(port_old, port, update_body):"},{"line_number":701,"context_line":"        if port_old.get(\u0027device_owner\u0027, \u0027\u0027) \u003d\u003d \\"},{"line_number":702,"context_line":"                t_constants.DEVICE_OWNER_SHADOW and \\"},{"line_number":703,"context_line":"                port[\u0027device_owner\u0027] \u003d\u003d \u0027\u0027 and \\"},{"line_number":704,"context_line":"                port[\u0027device_id\u0027] \u003d\u003d \u0027\u0027:"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f6a8fd7_f509d430","line":701,"range":{"start_line":701,"start_character":47,"end_line":701,"end_character":48},"in_reply_to":"9f6a8fd7_95f178d0","updated":"2018-04-19 07:53:26.000000000","message":"Done","commit_id":"c75a552fa15d37487a87d2fa021405faee690db8"},{"author":{"_account_id":12076,"name":"Zhiyuan Cai","email":"luckyvega.g@gmail.com","username":"zhiyuan_cai"},"change_message_id":"a60b79193a79945b413b1d32ebedee0bf57f0f09","unresolved":false,"context_lines":[{"line_number":543,"context_line":"                if port_body[\u0027id\u0027] in b_port_list:"},{"line_number":544,"context_line":"                    port_body.pop(\u0027security_groups\u0027, None)"},{"line_number":545,"context_line":"                    self.update_port(context, port_body[\u0027id\u0027], port)"},{"line_number":546,"context_line":"                    ports[\u0027ports\u0027].remove(port)"},{"line_number":547,"context_line":"            elif (port_body[\u0027device_owner\u0027] \u003d\u003d"},{"line_number":548,"context_line":"                    t_constants.DEVICE_OWNER_SUBPORT):"},{"line_number":549,"context_line":"                port_body[\u0027id\u0027] \u003d port_body[\u0027device_id\u0027]"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f6a8fd7_fed5be1c","line":546,"range":{"start_line":546,"start_character":20,"end_line":546,"end_character":47},"updated":"2018-04-25 00:47:56.000000000","message":"is it safe to remove item from a list when iterating the list?","commit_id":"82f3d7b85562079f6ac3bc648924f0a1ce86a559"},{"author":{"_account_id":27215,"name":"baisen","email":"songbaisen@szzt.com.cn","username":"songbaisen"},"change_message_id":"20045681aad70a4bb12c0aa0cf8e633384aace22","unresolved":false,"context_lines":[{"line_number":543,"context_line":"                if port_body[\u0027id\u0027] in b_port_list:"},{"line_number":544,"context_line":"                    port_body.pop(\u0027security_groups\u0027, None)"},{"line_number":545,"context_line":"                    self.update_port(context, port_body[\u0027id\u0027], port)"},{"line_number":546,"context_line":"                    ports[\u0027ports\u0027].remove(port)"},{"line_number":547,"context_line":"            elif (port_body[\u0027device_owner\u0027] \u003d\u003d"},{"line_number":548,"context_line":"                    t_constants.DEVICE_OWNER_SUBPORT):"},{"line_number":549,"context_line":"                port_body[\u0027id\u0027] \u003d port_body[\u0027device_id\u0027]"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f6a8fd7_112f4088","line":546,"range":{"start_line":546,"start_character":20,"end_line":546,"end_character":47},"in_reply_to":"9f6a8fd7_146973f7","updated":"2018-04-25 07:41:15.000000000","message":"good method! learn it!","commit_id":"82f3d7b85562079f6ac3bc648924f0a1ce86a559"},{"author":{"_account_id":26133,"name":"zhangxiaohan","email":"zmj1981123@163.com","username":"zhangxiaohan"},"change_message_id":"8e00dec08279fed6ff0b33b46a3206a30d0d57f3","unresolved":false,"context_lines":[{"line_number":543,"context_line":"                if port_body[\u0027id\u0027] in b_port_list:"},{"line_number":544,"context_line":"                    port_body.pop(\u0027security_groups\u0027, None)"},{"line_number":545,"context_line":"                    self.update_port(context, port_body[\u0027id\u0027], port)"},{"line_number":546,"context_line":"                    ports[\u0027ports\u0027].remove(port)"},{"line_number":547,"context_line":"            elif (port_body[\u0027device_owner\u0027] \u003d\u003d"},{"line_number":548,"context_line":"                    t_constants.DEVICE_OWNER_SUBPORT):"},{"line_number":549,"context_line":"                port_body[\u0027id\u0027] \u003d port_body[\u0027device_id\u0027]"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f6a8fd7_146973f7","line":546,"range":{"start_line":546,"start_character":20,"end_line":546,"end_character":47},"in_reply_to":"9f6a8fd7_fed5be1c","updated":"2018-04-25 06:15:29.000000000","message":"\u0027for port in ports[\u0027ports\u0027]\u0027 change to \n\u0027for port in ports[\u0027ports\u0027][:]\u0027","commit_id":"82f3d7b85562079f6ac3bc648924f0a1ce86a559"}],"tricircle/xjob/xmanager.py":[{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"06027854150f502101a3ff9ee8eee828776f8992","unresolved":false,"context_lines":[{"line_number":1083,"context_line":"                if pod_id !\u003d target_pod_id and \\"},{"line_number":1084,"context_line":"                        target_nova_port in pod_port_ids_map[pod_id]:"},{"line_number":1085,"context_line":"                    pod_port_ids_map[pod_id] \u003d \\"},{"line_number":1086,"context_line":"                        pod_port_ids_map[pod_id] - (target_nova_port, )"},{"line_number":1087,"context_line":""},{"line_number":1088,"context_line":"        all_port_ids \u003d set()"},{"line_number":1089,"context_line":"        for port_ids in six.itervalues(pod_port_ids_map):"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f6a8fd7_959f385e","line":1086,"range":{"start_line":1086,"start_character":49,"end_line":1086,"end_character":52},"updated":"2018-04-19 07:31:36.000000000","message":"minus tuple? do you mean minus set?","commit_id":"c75a552fa15d37487a87d2fa021405faee690db8"},{"author":{"_account_id":26133,"name":"zhangxiaohan","email":"zmj1981123@163.com","username":"zhangxiaohan"},"change_message_id":"5e3ff204cd50a4a74dea4d61a216e88d725ab567","unresolved":false,"context_lines":[{"line_number":1083,"context_line":"                if pod_id !\u003d target_pod_id and \\"},{"line_number":1084,"context_line":"                        target_nova_port in pod_port_ids_map[pod_id]:"},{"line_number":1085,"context_line":"                    pod_port_ids_map[pod_id] \u003d \\"},{"line_number":1086,"context_line":"                        pod_port_ids_map[pod_id] - (target_nova_port, )"},{"line_number":1087,"context_line":""},{"line_number":1088,"context_line":"        all_port_ids \u003d set()"},{"line_number":1089,"context_line":"        for port_ids in six.itervalues(pod_port_ids_map):"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f6a8fd7_50776ea1","line":1086,"range":{"start_line":1086,"start_character":49,"end_line":1086,"end_character":52},"in_reply_to":"9f6a8fd7_959f385e","updated":"2018-04-19 07:53:26.000000000","message":"Just like the following:\n\nall_port_ids - (\n            pod_port_ids_map[target_pod_id] | pod_sw_port_ids_map[\n                target_pod_id])","commit_id":"c75a552fa15d37487a87d2fa021405faee690db8"}]}
