)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"1c97a4c0e5a1e256eff839bf57fe43e8495b72c4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add openstack-tox-molecule job"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This enables standardized molecule job that detects all molecule enables"},{"line_number":10,"context_line":"roles and run their scenarios."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This should enable us to remove the individual molecule jobs."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fb8cfa7_fd042f17","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":30},"updated":"2019-06-24 18:08:29.000000000","message":"At this time, it\u0027s not desirable to run all scenarios on every review.","commit_id":"3666a877ce0ca9f9069277ff5c58e77725f96131"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"75e79edd8515b4b566fffced18d00e0d47d3baa4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add openstack-tox-molecule job"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This enables standardized molecule job that detects all molecule enables"},{"line_number":10,"context_line":"roles and run their scenarios."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This should enable us to remove the individual molecule jobs."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fb8cfa7_ec9b1514","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":30},"in_reply_to":"9fb8cfa7_c901633a","updated":"2019-06-25 14:23:22.000000000","message":"Right now the longest job time we have is 15 minutes and while I know we\u0027ll have longer running jobs as we add more complex roles, the goal here is to have targeted jobs executed based on need.\n\nAs for sudo access, if we think about this on the a general openstack CI front, most everything is executed on the underlying test node, not in containers, so we\u0027re not creating a new, more risky, test pattern. Additionally tox-sudo jobs are limited to very few jobs, only the ones that can not be executed in docker containers. So it is my belief that there\u0027s no new security issue in CI or elsewhere and requiring sudo where its needed makes the most sense, especially when confronted with the fact that not everything can or should run in a container.","commit_id":"3666a877ce0ca9f9069277ff5c58e77725f96131"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"39150945785e82c4d9179650fd83dea0f89b0bd4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add openstack-tox-molecule job"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This enables standardized molecule job that detects all molecule enables"},{"line_number":10,"context_line":"roles and run their scenarios."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This should enable us to remove the individual molecule jobs."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fb8cfa7_c901633a","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":30},"in_reply_to":"9fb8cfa7_fd042f17","updated":"2019-06-25 13:20:07.000000000","message":"You could make use of openstack-tox-molecule as a parent and use the params to limit which mo\u0027tests are run by each job.\n\nExample for command line: `tox -e molecule -- -k myrole`\n\nThis would effectively run `pytest -k myrole`.\n\nI will work to add extra functionaly to openstack-tox-molecule like enabling vagrant provisioning or enabling openstack cloud credentials so you could spawn real VMs. \n\nStill, I have some doubts regarding enabling sudo on the build machine itself: that would be a security risk for both CI and local development.\n\nI am still concerned about the scalability as tripleo is already facing long zuul queues because it runs too many jobs.","commit_id":"3666a877ce0ca9f9069277ff5c58e77725f96131"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"1c97a4c0e5a1e256eff839bf57fe43e8495b72c4","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This enables standardized molecule job that detects all molecule enables"},{"line_number":10,"context_line":"roles and run their scenarios."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This should enable us to remove the individual molecule jobs."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I98e21078100bda35654dc47235c6ba16a708ed96"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fb8cfa7_5d13fb5c","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":61},"updated":"2019-06-24 18:08:29.000000000","message":"The individual molecule jobs is what we want to have, especially as we now have scenarios that are not testing using docker and are requiring sudo access.\n\nThe independent jobs gate faster and will allow multiple developers to work-on the same repo in different work streams.","commit_id":"3666a877ce0ca9f9069277ff5c58e77725f96131"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"39150945785e82c4d9179650fd83dea0f89b0bd4","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This enables standardized molecule job that detects all molecule enables"},{"line_number":10,"context_line":"roles and run their scenarios."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This should enable us to remove the individual molecule jobs."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I98e21078100bda35654dc47235c6ba16a708ed96"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fb8cfa7_89f7eb59","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":61},"in_reply_to":"9fb8cfa7_5d13fb5c","updated":"2019-06-25 13:20:07.000000000","message":"Yeah, probably I should adapt the message as there is a clear business case for sharding tests into multiple jobs. I think is more of a tunning issue.","commit_id":"3666a877ce0ca9f9069277ff5c58e77725f96131"}],"tox.ini":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"1c97a4c0e5a1e256eff839bf57fe43e8495b72c4","unresolved":false,"context_lines":[{"line_number":238,"context_line":"changedir \u003d {toxinidir}/tripleo_ansible/roles/tripleo-ssh-known-hosts"},{"line_number":239,"context_line":"commands \u003d python -m pytest --color\u003dyes --html\u003d{envlogdir}/reports.html --self-contained-html {tty:-s} {toxinidir}/tests/test_molecule.py"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"[testenv:molecule]"},{"line_number":242,"context_line":"deps \u003d"},{"line_number":243,"context_line":"    ansi2html"},{"line_number":244,"context_line":"    docker\u003e\u003d3.7"}],"source_content_type":"text/x-properties","patch_set":2,"id":"9fb8cfa7_7a2285bb","line":241,"range":{"start_line":241,"start_character":0,"end_line":241,"end_character":18},"updated":"2019-06-24 18:08:29.000000000","message":"we already have a molecule environment, under \"mol\". Can this be consolidated into that section?","commit_id":"3666a877ce0ca9f9069277ff5c58e77725f96131"}],"zuul.d/layout.yaml":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"change_message_id":"17ba80cba0b1180dde9d46749bcc79ca557f2040","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- project:"},{"line_number":3,"context_line":"    templates:"},{"line_number":4,"context_line":"    - publish-openstack-docs-pti"},{"line_number":5,"context_line":"    - openstack-tox-jobs"},{"line_number":6,"context_line":"    - release-notes-jobs-python3"},{"line_number":7,"context_line":"    - tripleo-ansible-molecule-jobs"},{"line_number":8,"context_line":"    check:"},{"line_number":9,"context_line":"      jobs:"},{"line_number":10,"context_line":"      - openstack-tox-linters"},{"line_number":11,"context_line":"      - tripleo-ansible-docs"},{"line_number":12,"context_line":"    gate:"},{"line_number":13,"context_line":"      jobs:"},{"line_number":14,"context_line":"      - openstack-tox-linters"},{"line_number":15,"context_line":"      - tripleo-ansible-docs"},{"line_number":16,"context_line":"    post:"},{"line_number":17,"context_line":"      jobs:"},{"line_number":18,"context_line":"      - publish-openstack-python-branch-tarball"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_9a6979f9","line":18,"range":{"start_line":2,"start_character":2,"end_line":18,"end_character":0},"updated":"2019-06-24 17:56:33.000000000","message":"The project template \"openstack-tox-jobs\" was not found.","commit_id":"3135751a91fa172d106cc132ce6297ccf0f2860e"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"1c97a4c0e5a1e256eff839bf57fe43e8495b72c4","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- project:"},{"line_number":3,"context_line":"    templates:"},{"line_number":4,"context_line":"    - publish-openstack-docs-pti"},{"line_number":5,"context_line":"    - openstack-tox-molecule"},{"line_number":6,"context_line":"    - release-notes-jobs-python3"},{"line_number":7,"context_line":"    - tripleo-ansible-molecule-jobs    "},{"line_number":8,"context_line":"    check:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_da1a917b","line":5,"range":{"start_line":5,"start_character":6,"end_line":5,"end_character":28},"updated":"2019-06-24 18:08:29.000000000","message":"As this stands, it will run all tests for all roles which will create long job times especially as we add more roles with ever increasing complexity. Within this repository we\u0027re adding molecule jobs for each role so they can be worked-on and tested independently from every other role.","commit_id":"3666a877ce0ca9f9069277ff5c58e77725f96131"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"1c97a4c0e5a1e256eff839bf57fe43e8495b72c4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    - publish-openstack-docs-pti"},{"line_number":5,"context_line":"    - openstack-tox-molecule"},{"line_number":6,"context_line":"    - release-notes-jobs-python3"},{"line_number":7,"context_line":"    - tripleo-ansible-molecule-jobs    "},{"line_number":8,"context_line":"    check:"},{"line_number":9,"context_line":"      jobs:"},{"line_number":10,"context_line":"      - openstack-tox-linters"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_9a10995b","line":7,"range":{"start_line":7,"start_character":35,"end_line":7,"end_character":39},"updated":"2019-06-24 18:08:29.000000000","message":"whitespace.","commit_id":"3666a877ce0ca9f9069277ff5c58e77725f96131"}]}