)]}'
{"tripleo_ansible/roles/tripleo-container-tag/tasks/main.yml":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"dc08ff4ed6c54ded6b7365b13c07d79345abd2ee","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# \"tripleo-container-tag\" will search for and load any operating system variable file"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Fail if container image is undefined"},{"line_number":21,"context_line":"  fail:"},{"line_number":22,"context_line":"    msg: \u003e-"},{"line_number":23,"context_line":"      The variable `container_image` is undefined, check settings and try again."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_bcfa1e72","line":20,"range":{"start_line":20,"start_character":35,"end_line":20,"end_character":44},"updated":"2019-06-26 05:17:49.000000000","message":"It may confuse because \"undefined\" is more about ansible undefined variable and that can make people search for container_image in variables. \"Empty\", \"no set\" would be mode clear imho.","commit_id":"75a175b2c4bf8077acdb1c94961f90192f0c52a9"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"2a2ad168baea405f5fe5c3a71ecade8bce69beb9","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# \"tripleo-container-tag\" will search for and load any operating system variable file"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Fail if container image is undefined"},{"line_number":21,"context_line":"  fail:"},{"line_number":22,"context_line":"    msg: \u003e-"},{"line_number":23,"context_line":"      The variable `container_image` is undefined, check settings and try again."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_9c1b9ac8","line":20,"range":{"start_line":20,"start_character":35,"end_line":20,"end_character":44},"in_reply_to":"9fb8cfa7_bcfa1e72","updated":"2019-06-26 05:23:15.000000000","message":"Done","commit_id":"75a175b2c4bf8077acdb1c94961f90192f0c52a9"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"dc08ff4ed6c54ded6b7365b13c07d79345abd2ee","unresolved":false,"context_lines":[{"line_number":20,"context_line":"- name: Fail if container image is undefined"},{"line_number":21,"context_line":"  fail:"},{"line_number":22,"context_line":"    msg: \u003e-"},{"line_number":23,"context_line":"      The variable `container_image` is undefined, check settings and try again."},{"line_number":24,"context_line":"  when:"},{"line_number":25,"context_line":"    - (tripleo_container_image | length) \u003c 1"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_7cf02692","line":23,"range":{"start_line":23,"start_character":20,"end_line":23,"end_character":35},"updated":"2019-06-26 05:17:49.000000000","message":"variable is tripleo_container_image","commit_id":"75a175b2c4bf8077acdb1c94961f90192f0c52a9"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"2a2ad168baea405f5fe5c3a71ecade8bce69beb9","unresolved":false,"context_lines":[{"line_number":20,"context_line":"- name: Fail if container image is undefined"},{"line_number":21,"context_line":"  fail:"},{"line_number":22,"context_line":"    msg: \u003e-"},{"line_number":23,"context_line":"      The variable `container_image` is undefined, check settings and try again."},{"line_number":24,"context_line":"  when:"},{"line_number":25,"context_line":"    - (tripleo_container_image | length) \u003c 1"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9fb8cfa7_7c1ee6bb","line":23,"range":{"start_line":23,"start_character":20,"end_line":23,"end_character":35},"in_reply_to":"9fb8cfa7_7cf02692","updated":"2019-06-26 05:23:15.000000000","message":"Done","commit_id":"75a175b2c4bf8077acdb1c94961f90192f0c52a9"},{"author":{"_account_id":24162,"name":"Sorin Sbârnea","display_name":"zbr","email":"ssbarnea@redhat.com","username":"ssbarnea","status":"do not feed the troll 🥕"},"change_message_id":"af87c6da9d35a0963e998cad4a7e38f9f5130f6d","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    msg: \u003e-"},{"line_number":23,"context_line":"      The variable `tripleo_container_image` is an empty set. Check the settings."},{"line_number":24,"context_line":"  when:"},{"line_number":25,"context_line":"    - (tripleo_container_image | length) \u003c 1"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- name: Pull {{ tripleo_container_image }} image"},{"line_number":28,"context_line":"  shell: \"{{ tripleo_container_cli }} pull {{ tripleo_container_image }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fb8cfa7_d66fae25","line":25,"range":{"start_line":25,"start_character":6,"end_line":25,"end_character":44},"updated":"2019-06-26 08:46:45.000000000","message":"There is a more python way to do it, just \"not var_name\": it will fail on empty string or list.","commit_id":"f13fb3f3bc96489529989bf14e08c4fab358ed29"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"e1f6d21206dcc04d6c9510dcfc059db31d79e312","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    msg: \u003e-"},{"line_number":23,"context_line":"      The variable `tripleo_container_image` is an empty set. Check the settings."},{"line_number":24,"context_line":"  when:"},{"line_number":25,"context_line":"    - (tripleo_container_image | length) \u003c 1"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- name: Pull {{ tripleo_container_image }} image"},{"line_number":28,"context_line":"  shell: \"{{ tripleo_container_cli }} pull {{ tripleo_container_image }}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9fb8cfa7_d9b83f12","line":25,"range":{"start_line":25,"start_character":6,"end_line":25,"end_character":44},"in_reply_to":"9fb8cfa7_d66fae25","updated":"2019-06-26 09:14:42.000000000","message":"Right, but let\u0027s merge it and fix in followup patches, because it blocks promotion. I was also wrong about variable name, it\u0027s actually container_image variable, when tripleo_container_image is derived from it.","commit_id":"f13fb3f3bc96489529989bf14e08c4fab358ed29"}]}