)]}'
{"doc/source/roles/role-tripleo-container-stop.rst":[{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"4f9bebdb614c07daf60922bd5292b40154bcf57e","unresolved":false,"context_lines":[{"line_number":2,"context_line":"Role - tripleo-container-stop"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"This role provides for the following services:"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    * tripleo-container-stop"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"7faddb67_5fc7ac46","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":46},"updated":"2019-07-09 14:46:14.000000000","message":"what does it provide? it isn\u0027t really clear here, am I missing something?","commit_id":"903a29611b2f4489e24d84ed046a5019239e1373"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"feca6ca8aebc58e75a3d6b22e846f37da4577ecb","unresolved":false,"context_lines":[{"line_number":2,"context_line":"Role - tripleo-container-stop"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"This role provides for the following services:"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    * tripleo-container-stop"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"7faddb67_ba4d8e73","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":46},"in_reply_to":"7faddb67_5fc7ac46","updated":"2019-07-09 15:11:39.000000000","message":"This is a totally general statement, in this case it\u0027s mentioning the role as the thing it provides, however, feel free to update or change this documentation as needed.","commit_id":"903a29611b2f4489e24d84ed046a5019239e1373"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"65a2007a6ccf682650173484086a74c3bb8b65da","unresolved":false,"context_lines":[{"line_number":2,"context_line":"Role - tripleo-container-stop"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"This role provides for the following services:"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    * tripleo-container-stop"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"7faddb67_da796a93","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":46},"in_reply_to":"7faddb67_ba4d8e73","updated":"2019-07-09 15:12:23.000000000","message":"The rendered docs can be seen here https://docs.openstack.org/tripleo-ansible/latest/roles/role-tripleo-container-rm.html","commit_id":"903a29611b2f4489e24d84ed046a5019239e1373"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"5bac6208dfb51c87701322f41d24fa586f37c47a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"Role - tripleo-container-stop"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"This role provides for the following services:"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    * tripleo-container-stop"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Default variables"},{"line_number":11,"context_line":"~~~~~~~~~~~~~~~~~"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":".. literalinclude:: ../../../tripleo_ansible/roles/tripleo-container-stop/defaults/main.yml"},{"line_number":14,"context_line":"  :language: yaml"},{"line_number":15,"context_line":"  :start-after: under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Example default playbook"},{"line_number":19,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":".. literalinclude:: ../../../tripleo_ansible/roles/tripleo-container-stop/molecule/default/playbook.yml"},{"line_number":22,"context_line":"  :language: yaml"},{"line_number":23,"context_line":"  :start-after: under the License."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Example podman playbook"},{"line_number":27,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":".. literalinclude:: ../../../tripleo_ansible/roles/tripleo-container-stop/molecule/podman/playbook.yml"},{"line_number":30,"context_line":"  :language: yaml"},{"line_number":31,"context_line":"  :start-after: under the License."}],"source_content_type":"text/x-rst","patch_set":11,"id":"7faddb67_2b421dac","line":31,"range":{"start_line":5,"start_character":0,"end_line":31,"end_character":34},"updated":"2019-07-18 16:28:52.000000000","message":"Now that the sphinx plugin has merged, this can all be simplified to \n\n.. ansibleautoplugin::\n   :role: tripleo_ansible/roles/tripleo-container-stop","commit_id":"726caa9beb7d052faade4ff3efbc6b83a594a6c6"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"224bf72e9a5a7fe269b4ddd8cea39e7a6b73857d","unresolved":false,"context_lines":[{"line_number":2,"context_line":"Role - tripleo-container-stop"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"This role provides for the following services:"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    * tripleo-container-stop"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Default variables"},{"line_number":11,"context_line":"~~~~~~~~~~~~~~~~~"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":".. literalinclude:: ../../../tripleo_ansible/roles/tripleo-container-stop/defaults/main.yml"},{"line_number":14,"context_line":"  :language: yaml"},{"line_number":15,"context_line":"  :start-after: under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Example default playbook"},{"line_number":19,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":".. literalinclude:: ../../../tripleo_ansible/roles/tripleo-container-stop/molecule/default/playbook.yml"},{"line_number":22,"context_line":"  :language: yaml"},{"line_number":23,"context_line":"  :start-after: under the License."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Example podman playbook"},{"line_number":27,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":".. literalinclude:: ../../../tripleo_ansible/roles/tripleo-container-stop/molecule/podman/playbook.yml"},{"line_number":30,"context_line":"  :language: yaml"},{"line_number":31,"context_line":"  :start-after: under the License."}],"source_content_type":"text/x-rst","patch_set":11,"id":"7faddb67_53b4e4f1","line":31,"range":{"start_line":5,"start_character":0,"end_line":31,"end_character":34},"in_reply_to":"7faddb67_2b421dac","updated":"2019-07-19 13:58:48.000000000","message":"Done","commit_id":"726caa9beb7d052faade4ff3efbc6b83a594a6c6"}],"tripleo_ansible/roles/tripleo-container-stop/README.md":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"987036351f1add0897978325d22cccd17f86e80a","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"An Ansible role to stop containers."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Role variables"},{"line_number":7,"context_line":"--------------"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- container_cli: -- Name of the Container CLI tool (default to podman)."}],"source_content_type":"text/x-gfm","patch_set":1,"id":"7faddb67_a40fc12c","line":6,"updated":"2019-07-08 19:07:10.000000000","message":"This will be auto-documented when the role is imported.","commit_id":"a0ef227c2342600d18dd2f59b6d7ec84a207c87b"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"96c875814f30824446366b5fa6217210e3efcf00","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"An Ansible role to stop containers."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Role variables"},{"line_number":7,"context_line":"--------------"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- container_cli: -- Name of the Container CLI tool (default to podman)."}],"source_content_type":"text/x-gfm","patch_set":1,"id":"7faddb67_e307e81b","line":6,"in_reply_to":"7faddb67_a40fc12c","updated":"2019-07-09 08:51:49.000000000","message":"Done","commit_id":"a0ef227c2342600d18dd2f59b6d7ec84a207c87b"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"987036351f1add0897978325d22cccd17f86e80a","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Example Playbook"},{"line_number":13,"context_line":"----------------"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Sample playbook to call the role:"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  - name: Stop a set of container"},{"line_number":18,"context_line":"    hosts: all"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"7faddb67_e40db937","line":15,"updated":"2019-07-08 19:07:10.000000000","message":"if we pull this in as a molecule scenario we wont need this as the sample playbook will actually be the default coverage.","commit_id":"a0ef227c2342600d18dd2f59b6d7ec84a207c87b"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"96c875814f30824446366b5fa6217210e3efcf00","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Example Playbook"},{"line_number":13,"context_line":"----------------"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Sample playbook to call the role:"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"  - name: Stop a set of container"},{"line_number":18,"context_line":"    hosts: all"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"7faddb67_03032411","line":15,"in_reply_to":"7faddb67_e40db937","updated":"2019-07-09 08:51:49.000000000","message":"Done","commit_id":"a0ef227c2342600d18dd2f59b6d7ec84a207c87b"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"987036351f1add0897978325d22cccd17f86e80a","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        - nova_api"},{"line_number":24,"context_line":"        - nova_api_cron"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"License"},{"line_number":27,"context_line":"-------"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Free software: Apache License (2.0)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Author Information"},{"line_number":32,"context_line":"------------------"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"OpenStack TripleO team"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"7faddb67_6419c977","line":34,"range":{"start_line":26,"start_character":0,"end_line":34,"end_character":22},"updated":"2019-07-08 19:07:10.000000000","message":"this is not needed as it\u0027s covered by the root license.","commit_id":"a0ef227c2342600d18dd2f59b6d7ec84a207c87b"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"96c875814f30824446366b5fa6217210e3efcf00","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        - nova_api"},{"line_number":24,"context_line":"        - nova_api_cron"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"License"},{"line_number":27,"context_line":"-------"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Free software: Apache License (2.0)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Author Information"},{"line_number":32,"context_line":"------------------"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"OpenStack TripleO team"}],"source_content_type":"text/x-gfm","patch_set":1,"id":"7faddb67_b5ffe7ff","line":34,"range":{"start_line":26,"start_character":0,"end_line":34,"end_character":22},"in_reply_to":"7faddb67_6419c977","updated":"2019-07-09 08:51:49.000000000","message":"Done","commit_id":"a0ef227c2342600d18dd2f59b6d7ec84a207c87b"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"8e5069c8f75672c73fd108f65b0bb4d4f3322dc8","unresolved":false,"context_lines":[{"line_number":6,"context_line":"Requirements"},{"line_number":7,"context_line":"------------"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"None"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Role Variables"},{"line_number":12,"context_line":"--------------"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- container_cli: -- Name of the Container CLI tool (default to podman)."},{"line_number":15,"context_line":"- containers_to_stop: -- Containers names to stop."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Dependencies"},{"line_number":18,"context_line":"------------"}],"source_content_type":"text/x-gfm","patch_set":5,"id":"7faddb67_c44d0f73","line":15,"range":{"start_line":9,"start_character":0,"end_line":15,"end_character":50},"updated":"2019-07-09 13:53:56.000000000","message":"This isn\u0027t required, this will be documented here https://review.opendev.org/#/c/669650/5/doc/source/roles/role-tripleo-container-stop.rst@10","commit_id":"895eed54b4fa43c460526d5b040a40a155b662fc"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"67ac5135692be33a90e42cbe514dd92556fa7544","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"An Ansible role to stop containers."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Requirements"},{"line_number":7,"context_line":"------------"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"None"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Role Variables"},{"line_number":12,"context_line":"--------------"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"- container_cli: -- Name of the Container CLI tool (default to podman)."},{"line_number":15,"context_line":"- containers_to_stop: -- Containers names to stop."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Dependencies"},{"line_number":18,"context_line":"------------"}],"source_content_type":"text/x-gfm","patch_set":6,"id":"7faddb67_7fab8888","line":15,"range":{"start_line":6,"start_character":0,"end_line":15,"end_character":50},"updated":"2019-07-09 14:44:43.000000000","message":"this will be documented automatically here https://review.opendev.org/#/c/669650/6/doc/source/roles/role-tripleo-container-stop.rst@10","commit_id":"903a29611b2f4489e24d84ed046a5019239e1373"}],"tripleo_ansible/roles/tripleo-container-stop/defaults/main.yaml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"987036351f1add0897978325d22cccd17f86e80a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7faddb67_e474d99b","updated":"2019-07-08 19:07:10.000000000","message":"This role follows a very similar process as other roles, like tripleo_container_rm, as such, I\u0027d like to see us adopt defaults so we maintain a consistent user experience. Here are the defaults for the tripleo-container-rm role, please follow this pattern here.\n\n  https://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/roles/tripleo-container-rm/defaults/main.yml#L20-L32","commit_id":"a0ef227c2342600d18dd2f59b6d7ec84a207c87b"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"96c875814f30824446366b5fa6217210e3efcf00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7faddb67_d502a309","in_reply_to":"7faddb67_e474d99b","updated":"2019-07-09 08:51:49.000000000","message":"Done","commit_id":"a0ef227c2342600d18dd2f59b6d7ec84a207c87b"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"987036351f1add0897978325d22cccd17f86e80a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"container_cli: podman"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_242d1195","line":2,"updated":"2019-07-08 19:07:10.000000000","message":"defaults should be namespaced so this would be something like \n\n  tripleo_container_cli: podman","commit_id":"a0ef227c2342600d18dd2f59b6d7ec84a207c87b"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"96c875814f30824446366b5fa6217210e3efcf00","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"container_cli: podman"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_75096f2a","line":2,"in_reply_to":"7faddb67_242d1195","updated":"2019-07-09 08:51:49.000000000","message":"Done","commit_id":"a0ef227c2342600d18dd2f59b6d7ec84a207c87b"}],"tripleo_ansible/roles/tripleo-container-stop/defaults/main.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"0b6e8b0848e140d992feaae7eedb45d317d37093","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"tripleo_containers_to_stop: \"{{ default([]) }}\""},{"line_number":18,"context_line":"tripleo_delegate_to: \"localhost\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7faddb67_abde0d3b","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":19},"updated":"2019-07-18 16:22:19.000000000","message":"is this option supposed to always be a list or a string? Based on the stop task I think this would need to be \n\n  tripleo_delegate_to: [\"localhost\"]","commit_id":"726caa9beb7d052faade4ff3efbc6b83a594a6c6"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"224bf72e9a5a7fe269b4ddd8cea39e7a6b73857d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"tripleo_containers_to_stop: \"{{ default([]) }}\""},{"line_number":18,"context_line":"tripleo_delegate_to: \"localhost\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7faddb67_d3c77463","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":19},"in_reply_to":"7faddb67_abde0d3b","updated":"2019-07-19 13:58:48.000000000","message":"Done","commit_id":"726caa9beb7d052faade4ff3efbc6b83a594a6c6"}],"tripleo_ansible/roles/tripleo-container-stop/molecule/default/molecule.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"67ac5135692be33a90e42cbe514dd92556fa7544","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"driver:"},{"line_number":3,"context_line":"  name: docker"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"log: true"},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_1f8db47a","line":3,"range":{"start_line":2,"start_character":0,"end_line":3,"end_character":14},"updated":"2019-07-09 14:44:43.000000000","message":"given this role test is testing docker interactions maybe I think it\u0027d be best to just run the test on the local machine. Like so: https://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/roles/tripleo-container-rm/molecule/default/molecule.yml#L1-L17\n\nIn that way we\u0027re not trying to mess with nested docker in docker (or podman in podman).","commit_id":"903a29611b2f4489e24d84ed046a5019239e1373"}],"tripleo_ansible/roles/tripleo-container-stop/molecule/default/playbook.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"67ac5135692be33a90e42cbe514dd92556fa7544","unresolved":false,"context_lines":[{"line_number":23,"context_line":"      tripleo-container-stop_containers_to_stop:"},{"line_number":24,"context_line":"        - docker-container1"},{"line_number":25,"context_line":"        - docker-container2"},{"line_number":26,"context_line":"      tripleo-container-stop_container_cli: docker"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  vars:"},{"line_number":29,"context_line":"    ansible_python_interpreter: \"{{ ansible_user_dir }}/test-python/bin/python\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_3fdd1070","line":26,"updated":"2019-07-09 14:44:43.000000000","message":"this would probably be a good thing to test as a second scenario. This is an example of a scenario that\u0027s doing a similar thing, https://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/roles/tripleo-container-rm/molecule/docker_rm/playbook.yml#L22-L33","commit_id":"903a29611b2f4489e24d84ed046a5019239e1373"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"0b6e8b0848e140d992feaae7eedb45d317d37093","unresolved":false,"context_lines":[{"line_number":23,"context_line":"      tripleo_containers_to_stop:"},{"line_number":24,"context_line":"        - docker-container1"},{"line_number":25,"context_line":"        - docker-container2"},{"line_number":26,"context_line":"      tripleo_delegate_to:"},{"line_number":27,"context_line":"        - controller-0"},{"line_number":28,"context_line":"        - controller-1"},{"line_number":29,"context_line":"        - controller-2"},{"line_number":30,"context_line":"  vars:"},{"line_number":31,"context_line":"    ansible_python_interpreter: \"{{ ansible_user_dir }}/test-python/bin/python\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7faddb67_0bc88171","line":29,"range":{"start_line":26,"start_character":0,"end_line":29,"end_character":22},"updated":"2019-07-18 16:22:19.000000000","message":"This will need to be defined in the molecule inventory.","commit_id":"726caa9beb7d052faade4ff3efbc6b83a594a6c6"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"224bf72e9a5a7fe269b4ddd8cea39e7a6b73857d","unresolved":false,"context_lines":[{"line_number":23,"context_line":"      tripleo_containers_to_stop:"},{"line_number":24,"context_line":"        - docker-container1"},{"line_number":25,"context_line":"        - docker-container2"},{"line_number":26,"context_line":"      tripleo_delegate_to:"},{"line_number":27,"context_line":"        - controller-0"},{"line_number":28,"context_line":"        - controller-1"},{"line_number":29,"context_line":"        - controller-2"},{"line_number":30,"context_line":"  vars:"},{"line_number":31,"context_line":"    ansible_python_interpreter: \"{{ ansible_user_dir }}/test-python/bin/python\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7faddb67_f3707042","line":29,"range":{"start_line":26,"start_character":0,"end_line":29,"end_character":22},"in_reply_to":"7faddb67_0bc88171","updated":"2019-07-19 13:58:48.000000000","message":"Done","commit_id":"726caa9beb7d052faade4ff3efbc6b83a594a6c6"}],"tripleo_ansible/roles/tripleo-container-stop/molecule/default/prepare.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"67ac5135692be33a90e42cbe514dd92556fa7544","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        - ansible_user_dir is undefined"},{"line_number":46,"context_line":"  roles:"},{"line_number":47,"context_line":"    - role: test_deps"},{"line_number":48,"context_line":"    - role: install-docker"},{"line_number":49,"context_line":"      when:"},{"line_number":50,"context_line":"        - (docker_cli.rc !\u003d 0) or"},{"line_number":51,"context_line":"          (docker_ps.rc !\u003d 0)"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_9fcf64af","line":48,"range":{"start_line":48,"start_character":4,"end_line":48,"end_character":26},"updated":"2019-07-09 14:44:43.000000000","message":"This is a good setup however this is being executed in the docker container, I think a change in the molecule driver to the delegated driver will make this go.","commit_id":"903a29611b2f4489e24d84ed046a5019239e1373"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"2c825f1a85b743fa7535098610c1882555324df5","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    - role: install-docker"},{"line_number":49,"context_line":"      when:"},{"line_number":50,"context_line":"        - (docker_cli.rc !\u003d 0) or"},{"line_number":51,"context_line":"          (docker_ps.rc !\u003d 0)"},{"line_number":52,"context_line":"  post_tasks:"},{"line_number":53,"context_line":"    - name: Install docker-sdk"},{"line_number":54,"context_line":"      pip:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_99877662","line":51,"range":{"start_line":51,"start_character":11,"end_line":51,"end_character":29},"updated":"2019-07-10 10:13:52.000000000","message":"do we need \"install-docker\" when \"ps\" doesn\u0027t work? (permission problem for example)","commit_id":"650dd32adbf79152265aa05257823b85dceb293a"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"5ef45b1af2537ebe79eaaf5d1334850ec0a1eb60","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    - role: install-docker"},{"line_number":49,"context_line":"      when:"},{"line_number":50,"context_line":"        - (docker_cli.rc !\u003d 0) or"},{"line_number":51,"context_line":"          (docker_ps.rc !\u003d 0)"},{"line_number":52,"context_line":"  post_tasks:"},{"line_number":53,"context_line":"    - name: Install docker-sdk"},{"line_number":54,"context_line":"      pip:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_a807761c","line":51,"range":{"start_line":51,"start_character":11,"end_line":51,"end_character":29},"in_reply_to":"7faddb67_99877662","updated":"2019-07-10 12:13:33.000000000","message":"we wont always need it, however, this is done because the zuul role will install docker and / or start it as needed.","commit_id":"650dd32adbf79152265aa05257823b85dceb293a"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"2c825f1a85b743fa7535098610c1882555324df5","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  post_tasks:"},{"line_number":53,"context_line":"    - name: Install docker-sdk"},{"line_number":54,"context_line":"      pip:"},{"line_number":55,"context_line":"        name: docker"},{"line_number":56,"context_line":"        virtualenv: \"{{ ansible_user_dir }}/test-python\""},{"line_number":57,"context_line":"        virtualenv_site_packages: true"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_d98c0e81","line":55,"range":{"start_line":55,"start_character":14,"end_line":55,"end_character":20},"updated":"2019-07-10 10:13:52.000000000","message":"shouldn\u0027t it be docker-py? It\u0027s a newer package iirc","commit_id":"650dd32adbf79152265aa05257823b85dceb293a"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"5ef45b1af2537ebe79eaaf5d1334850ec0a1eb60","unresolved":false,"context_lines":[{"line_number":52,"context_line":"  post_tasks:"},{"line_number":53,"context_line":"    - name: Install docker-sdk"},{"line_number":54,"context_line":"      pip:"},{"line_number":55,"context_line":"        name: docker"},{"line_number":56,"context_line":"        virtualenv: \"{{ ansible_user_dir }}/test-python\""},{"line_number":57,"context_line":"        virtualenv_site_packages: true"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_e8248ec8","line":55,"range":{"start_line":55,"start_character":14,"end_line":55,"end_character":20},"in_reply_to":"7faddb67_d98c0e81","updated":"2019-07-10 12:13:33.000000000","message":"This is using pip to install the docker sdk in a venv.","commit_id":"650dd32adbf79152265aa05257823b85dceb293a"}],"tripleo_ansible/roles/tripleo-container-stop/molecule/podman/molecule.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"0b6e8b0848e140d992feaae7eedb45d317d37093","unresolved":false,"context_lines":[{"line_number":28,"context_line":"      fact_caching: jsonfile"},{"line_number":29,"context_line":"      fact_caching_connection: /tmp/molecule/facts"},{"line_number":30,"context_line":"  inventory:"},{"line_number":31,"context_line":"    hosts:"},{"line_number":32,"context_line":"      all:"},{"line_number":33,"context_line":"        hosts:"},{"line_number":34,"context_line":"          instance:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7faddb67_ab5b6df3","line":31,"updated":"2019-07-18 16:22:19.000000000","message":"This is where the hosts must be defined for the delegation tasks to work.\n\nSomething like this should work.\n\n  controller-0:\n    ansible_connection: local\n    ansible_host: localhost\n  controller-1:\n    ansible_connection: local\n    ansible_host: localhost\n  controller-2:\n    ansible_connection: local\n    ansible_host: localhost\n\n\nNOTE: we\u0027ll need to get this change in the other molecule scenario as well.","commit_id":"726caa9beb7d052faade4ff3efbc6b83a594a6c6"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"224bf72e9a5a7fe269b4ddd8cea39e7a6b73857d","unresolved":false,"context_lines":[{"line_number":28,"context_line":"      fact_caching: jsonfile"},{"line_number":29,"context_line":"      fact_caching_connection: /tmp/molecule/facts"},{"line_number":30,"context_line":"  inventory:"},{"line_number":31,"context_line":"    hosts:"},{"line_number":32,"context_line":"      all:"},{"line_number":33,"context_line":"        hosts:"},{"line_number":34,"context_line":"          instance:"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7faddb67_337b6828","line":31,"in_reply_to":"7faddb67_ab5b6df3","updated":"2019-07-19 13:58:48.000000000","message":"Done","commit_id":"726caa9beb7d052faade4ff3efbc6b83a594a6c6"}],"tripleo_ansible/roles/tripleo-container-stop/molecule/podman/playbook.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"0b6e8b0848e140d992feaae7eedb45d317d37093","unresolved":false,"context_lines":[{"line_number":23,"context_line":"      tripleo_containers_to_stop:"},{"line_number":24,"context_line":"        - podman-container1"},{"line_number":25,"context_line":"        - podman-container2"},{"line_number":26,"context_line":"      tripleo_delegate_to:"},{"line_number":27,"context_line":"        - controller-0"},{"line_number":28,"context_line":"        - controller-1"},{"line_number":29,"context_line":"        - controller-2"},{"line_number":30,"context_line":"  vars:"},{"line_number":31,"context_line":"    ansible_python_interpreter: \"{{ ansible_user_dir }}/test-python/bin/python\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7faddb67_6b48152c","line":29,"range":{"start_line":26,"start_character":0,"end_line":29,"end_character":22},"updated":"2019-07-18 16:22:19.000000000","message":"This will need to be defined in the molecule inventory.","commit_id":"726caa9beb7d052faade4ff3efbc6b83a594a6c6"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"224bf72e9a5a7fe269b4ddd8cea39e7a6b73857d","unresolved":false,"context_lines":[{"line_number":23,"context_line":"      tripleo_containers_to_stop:"},{"line_number":24,"context_line":"        - podman-container1"},{"line_number":25,"context_line":"        - podman-container2"},{"line_number":26,"context_line":"      tripleo_delegate_to:"},{"line_number":27,"context_line":"        - controller-0"},{"line_number":28,"context_line":"        - controller-1"},{"line_number":29,"context_line":"        - controller-2"},{"line_number":30,"context_line":"  vars:"},{"line_number":31,"context_line":"    ansible_python_interpreter: \"{{ ansible_user_dir }}/test-python/bin/python\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7faddb67_533944ef","line":29,"range":{"start_line":26,"start_character":0,"end_line":29,"end_character":22},"in_reply_to":"7faddb67_6b48152c","updated":"2019-07-19 13:58:48.000000000","message":"Done","commit_id":"726caa9beb7d052faade4ff3efbc6b83a594a6c6"}],"tripleo_ansible/roles/tripleo-container-stop/molecule/podman/prepare.yml":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"2c825f1a85b743fa7535098610c1882555324df5","unresolved":false,"context_lines":[{"line_number":35,"context_line":"      command: \"podman pull fedora:28\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    - name: Create test containers"},{"line_number":38,"context_line":"      command: \"podman run -itd --systemd --name {{ item }} fedora bash\""},{"line_number":39,"context_line":"      with_items:"},{"line_number":40,"context_line":"        - podman-container1"},{"line_number":41,"context_line":"        - podman-container2"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_39f3e20c","line":38,"range":{"start_line":38,"start_character":60,"end_line":38,"end_character":66},"updated":"2019-07-10 10:13:52.000000000","message":"fedora:28","commit_id":"650dd32adbf79152265aa05257823b85dceb293a"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"5ef45b1af2537ebe79eaaf5d1334850ec0a1eb60","unresolved":false,"context_lines":[{"line_number":35,"context_line":"      command: \"podman pull fedora:28\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    - name: Create test containers"},{"line_number":38,"context_line":"      command: \"podman run -itd --systemd --name {{ item }} fedora bash\""},{"line_number":39,"context_line":"      with_items:"},{"line_number":40,"context_line":"        - podman-container1"},{"line_number":41,"context_line":"        - podman-container2"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_f2a55c05","line":38,"range":{"start_line":38,"start_character":60,"end_line":38,"end_character":66},"in_reply_to":"7faddb67_39f3e20c","updated":"2019-07-10 12:13:33.000000000","message":"I think \"fedora\" works OK when there\u0027s only the one image, however, +1 for being more explicit.","commit_id":"650dd32adbf79152265aa05257823b85dceb293a"}],"tripleo_ansible/roles/tripleo-container-stop/tasks/container_stop.yaml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"67ac5135692be33a90e42cbe514dd92556fa7544","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    # but we might have the containers running with docker."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    set -eu"},{"line_number":10,"context_line":"    if type {{ tripleo-container-stop_container_cli }} \u0026\u003e /dev/null \u0026\u0026 {{ tripleo-container-stop_container_cli }} exec {{ container }} /bin/true; then"},{"line_number":11,"context_line":"        {{ tripleo-container-stop_container_cli }} stop {{ container }}"},{"line_number":12,"context_line":"    elif type docker \u0026\u003e /dev/null \u0026\u0026 docker exec {{ container }} /bin/true; then"},{"line_number":13,"context_line":"        docker stop {{ container }}"},{"line_number":14,"context_line":"    fi"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_5fe24c03","line":14,"range":{"start_line":10,"start_character":0,"end_line":14,"end_character":6},"updated":"2019-07-09 14:44:43.000000000","message":"While breaking this out into different tasks will create more tasks, I think it\u0027d be best to use the ansible modules to run these tasks.\n\nhttps://docs.ansible.com/ansible/latest/modules/docker_container_module.html\n\nhttps://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/ansible_plugins/modules/podman_container.py\n\nour use of the internal podman_container module is being upstreamed into ansible proper, so some of that interaction might change, however, using the modules should provide a more stable task interaction.","commit_id":"903a29611b2f4489e24d84ed046a5019239e1373"}],"tripleo_ansible/roles/tripleo-container-stop/tasks/main.yaml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"987036351f1add0897978325d22cccd17f86e80a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- include_tasks: \"container_stop.yaml\""},{"line_number":3,"context_line":"  vars:"},{"line_number":4,"context_line":"    container: \"{{ item }}\""},{"line_number":5,"context_line":"  with_items: \"{{ containers_to_stop }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_643229f4","line":5,"range":{"start_line":5,"start_character":18,"end_line":5,"end_character":36},"updated":"2019-07-08 19:07:10.000000000","message":"this is an undefined default, we should have this in the file\n\n  defaults/main.yml\n\nThis option should also be namespaced.","commit_id":"a0ef227c2342600d18dd2f59b6d7ec84a207c87b"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"96c875814f30824446366b5fa6217210e3efcf00","unresolved":false,"context_lines":[{"line_number":2,"context_line":"- include_tasks: \"container_stop.yaml\""},{"line_number":3,"context_line":"  vars:"},{"line_number":4,"context_line":"    container: \"{{ item }}\""},{"line_number":5,"context_line":"  with_items: \"{{ containers_to_stop }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_43091c2f","line":5,"range":{"start_line":5,"start_character":18,"end_line":5,"end_character":36},"in_reply_to":"7faddb67_643229f4","updated":"2019-07-09 08:51:49.000000000","message":"Done","commit_id":"a0ef227c2342600d18dd2f59b6d7ec84a207c87b"}],"tripleo_ansible/roles/tripleo-container-stop/tasks/main.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"67ac5135692be33a90e42cbe514dd92556fa7544","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# found within the \"vars/\" path. If no OS files are found the task will skip."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- include_tasks: \"container_stop.yaml\""},{"line_number":23,"context_line":"  vars:"},{"line_number":24,"context_line":"    container: \"{{ item }}\""},{"line_number":25,"context_line":"  with_items: \"{{ tripleo-container-stop_containers_to_stop }}\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_3fd0b01f","line":22,"range":{"start_line":22,"start_character":18,"end_line":22,"end_character":32},"updated":"2019-07-09 14:44:43.000000000","message":"we should namespace this task file, `tripleo_container_stop.yml`.","commit_id":"903a29611b2f4489e24d84ed046a5019239e1373"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"0b6e8b0848e140d992feaae7eedb45d317d37093","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# \"tripleo-container-stop\" will search for and load any operating system variable file"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# found within the \"vars/\" path. If no OS files are found the task will skip."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- include_tasks: \"tripleo_container_stop.yaml\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7faddb67_2b153de5","line":19,"updated":"2019-07-18 16:22:19.000000000","message":"Now that `tripleo_delegate_to` is required it might be good to add a failed task here to ensure the variable is defined and has at least one host within it.","commit_id":"726caa9beb7d052faade4ff3efbc6b83a594a6c6"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"224bf72e9a5a7fe269b4ddd8cea39e7a6b73857d","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# \"tripleo-container-stop\" will search for and load any operating system variable file"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# found within the \"vars/\" path. If no OS files are found the task will skip."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- include_tasks: \"tripleo_container_stop.yaml\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7faddb67_1362ec0a","line":19,"in_reply_to":"7faddb67_2b153de5","updated":"2019-07-19 13:58:48.000000000","message":"Done","commit_id":"726caa9beb7d052faade4ff3efbc6b83a594a6c6"}],"tripleo_ansible/roles/tripleo-container-stop/tasks/tripleo_container_stop.yaml":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"2c825f1a85b743fa7535098610c1882555324df5","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    # them. I.e the container_cli might be setted to be podman"},{"line_number":7,"context_line":"    # but we might have the containers running with docker."},{"line_number":8,"context_line":"    set -eu"},{"line_number":9,"context_line":"    if type podman \u0026\u003e /dev/null \u0026\u0026 podman exec {{ container }} /bin/true; then"},{"line_number":10,"context_line":"        podman stop {{ container }}"},{"line_number":11,"context_line":"    elif type docker \u0026\u003e /dev/null \u0026\u0026 docker exec {{ container }} /bin/true; then"},{"line_number":12,"context_line":"        docker stop {{ container }}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_59cfbeaf","line":9,"range":{"start_line":9,"start_character":7,"end_line":9,"end_character":20},"updated":"2019-07-10 10:13:52.000000000","message":"type podman \u0026\u003e /dev/null -\u003e command -v podman","commit_id":"650dd32adbf79152265aa05257823b85dceb293a"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"5ef45b1af2537ebe79eaaf5d1334850ec0a1eb60","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    # them. I.e the container_cli might be setted to be podman"},{"line_number":7,"context_line":"    # but we might have the containers running with docker."},{"line_number":8,"context_line":"    set -eu"},{"line_number":9,"context_line":"    if type podman \u0026\u003e /dev/null \u0026\u0026 podman exec {{ container }} /bin/true; then"},{"line_number":10,"context_line":"        podman stop {{ container }}"},{"line_number":11,"context_line":"    elif type docker \u0026\u003e /dev/null \u0026\u0026 docker exec {{ container }} /bin/true; then"},{"line_number":12,"context_line":"        docker stop {{ container }}"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_d23ce0c0","line":9,"range":{"start_line":9,"start_character":7,"end_line":9,"end_character":20},"in_reply_to":"7faddb67_59cfbeaf","updated":"2019-07-10 12:13:33.000000000","message":"+1 the use of `command` would be preferable.","commit_id":"650dd32adbf79152265aa05257823b85dceb293a"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"2c825f1a85b743fa7535098610c1882555324df5","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    set -eu"},{"line_number":9,"context_line":"    if type podman \u0026\u003e /dev/null \u0026\u0026 podman exec {{ container }} /bin/true; then"},{"line_number":10,"context_line":"        podman stop {{ container }}"},{"line_number":11,"context_line":"    elif type docker \u0026\u003e /dev/null \u0026\u0026 docker exec {{ container }} /bin/true; then"},{"line_number":12,"context_line":"        docker stop {{ container }}"},{"line_number":13,"context_line":"    fi"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_59449e1b","line":11,"range":{"start_line":11,"start_character":4,"end_line":11,"end_character":8},"updated":"2019-07-10 10:13:52.000000000","message":"if wee have 2 containers with same name we need \"if\", not \"elif\"\n\nmaybe better to split it to 2 tasks?","commit_id":"650dd32adbf79152265aa05257823b85dceb293a"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"5ef45b1af2537ebe79eaaf5d1334850ec0a1eb60","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    set -eu"},{"line_number":9,"context_line":"    if type podman \u0026\u003e /dev/null \u0026\u0026 podman exec {{ container }} /bin/true; then"},{"line_number":10,"context_line":"        podman stop {{ container }}"},{"line_number":11,"context_line":"    elif type docker \u0026\u003e /dev/null \u0026\u0026 docker exec {{ container }} /bin/true; then"},{"line_number":12,"context_line":"        docker stop {{ container }}"},{"line_number":13,"context_line":"    fi"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_1226f8b8","line":11,"range":{"start_line":11,"start_character":4,"end_line":11,"end_character":8},"in_reply_to":"7faddb67_59449e1b","updated":"2019-07-10 12:13:33.000000000","message":"+1","commit_id":"650dd32adbf79152265aa05257823b85dceb293a"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"987b62eaa251e8bcf991b0579afb6b210a8b8c6d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    # but we might have the containers running with docker."},{"line_number":8,"context_line":"    set -eu"},{"line_number":9,"context_line":"    if command -v podman \u0026\u0026 podman exec {{ container }} /bin/true; then"},{"line_number":10,"context_line":"        podman stop {{ container }}"},{"line_number":11,"context_line":"    fi"},{"line_number":12,"context_line":"    if type docker \u0026\u003e /dev/null \u0026\u0026 docker exec {{ container }} /bin/true; then"},{"line_number":13,"context_line":"        docker stop {{ container }}"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7faddb67_1ea1ba46","line":10,"updated":"2019-07-17 14:05:44.000000000","message":"This is wrong btw. it needs to be stopped via systemd","commit_id":"aec8de648fd8a98ef361e6da2f11c86f3b5e2927"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"0b6e8b0848e140d992feaae7eedb45d317d37093","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    # but we might have the containers running with docker."},{"line_number":9,"context_line":"    set -eu"},{"line_number":10,"context_line":"    if command -v podman \u0026\u0026 podman exec {{ container }} /bin/true; then"},{"line_number":11,"context_line":"        systemctl stop tripleo_{{ container }}.service"},{"line_number":12,"context_line":"    fi"},{"line_number":13,"context_line":"    if type docker \u0026\u003e /dev/null \u0026\u0026 docker exec {{ container }} /bin/true; then"},{"line_number":14,"context_line":"        docker stop {{ container }}"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7faddb67_2b98dd72","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":54},"updated":"2019-07-18 16:22:19.000000000","message":"Do we think there will ever be a case where a podman container is running without the systemd integration? I\u0027m not 100% here but if we think its possible, then maybe we should fallback to using `podman stop ...`?\n\nSomething like\n\n  if ! systemctl stop tripleo_{{ container }}.service; then\n    podman stop {{ container }}\n  fi","commit_id":"726caa9beb7d052faade4ff3efbc6b83a594a6c6"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"224bf72e9a5a7fe269b4ddd8cea39e7a6b73857d","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    # but we might have the containers running with docker."},{"line_number":9,"context_line":"    set -eu"},{"line_number":10,"context_line":"    if command -v podman \u0026\u0026 podman exec {{ container }} /bin/true; then"},{"line_number":11,"context_line":"        systemctl stop tripleo_{{ container }}.service"},{"line_number":12,"context_line":"    fi"},{"line_number":13,"context_line":"    if type docker \u0026\u003e /dev/null \u0026\u0026 docker exec {{ container }} /bin/true; then"},{"line_number":14,"context_line":"        docker stop {{ container }}"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7faddb67_93333c14","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":54},"in_reply_to":"7faddb67_2b98dd72","updated":"2019-07-19 13:58:48.000000000","message":"It shouldn\u0027t, we should have only containers handled with systemd (paunch)","commit_id":"726caa9beb7d052faade4ff3efbc6b83a594a6c6"},{"author":{"_account_id":8042,"name":"Jiří Stránský","email":"jistr@redhat.com","username":"jistr"},"change_message_id":"7da3547e740ffa6e33f0ee4cd35bd43ec0fc2b54","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  delegate_to: \"{{ tripleo_delegate_to_item }}\""},{"line_number":17,"context_line":"  with_items: \"{{ tripleo_delegate_to }}\""},{"line_number":18,"context_line":"  loop_control:"},{"line_number":19,"context_line":"    loop_var: tripleo_delegate_to_item"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"7faddb67_fd2b6491","line":19,"updated":"2019-08-06 11:24:38.000000000","message":"Thank you Carlos for implementing this, +1 for now, if there are no complaints i will +2 upon another read-through (i\u0027m still not very familiar with molecule yet).\n\nHowever, i think we should probably think about how we want to approach such changes in the future, and perhaps include Kevin in the discussion to help us set up some approach for contributing relatively small pieces of reusable logic into tripleo-ansible. I like well tested code, but i think we\u0027re probably hitting an edge case here -- the logic (most of it here in this 19-line file) vs. test code ratio in this patch is IMO extreme and likely not a rational use of developer time.\n\nMaybe we could make less granular roles and utilize `include_role/tasks_from` a lot, which would allow us to reuse some test code for different small bits? Or make a role with nested smaller roles, with only the outer layer role containing all the testing boilerplate?","commit_id":"15f1a76ffd4fbb9d8a87490f1e294d42915151b1"}],"tripleo_ansible/roles/tripleo-container-stop/vars/main.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"8e5069c8f75672c73fd108f65b0bb4d4f3322dc8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7faddb67_643c5bbf","updated":"2019-07-09 13:53:56.000000000","message":"If this file won\u0027t be used in the role it can be removed.","commit_id":"895eed54b4fa43c460526d5b040a40a155b662fc"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"67ac5135692be33a90e42cbe514dd92556fa7544","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7faddb67_5fcb2c71","updated":"2019-07-09 14:44:43.000000000","message":"If this file is not being used we should delete it.","commit_id":"903a29611b2f4489e24d84ed046a5019239e1373"}],"zuul.d/molecule.yaml":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"change_message_id":"63f7e5d1ca24b6ac4e211492a695562cbc37eb7f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- project-template:"},{"line_number":3,"context_line":"    check:"},{"line_number":4,"context_line":"      jobs:"},{"line_number":5,"context_line":"      - tripleo-ansible-centos-7-molecule-aide"},{"line_number":6,"context_line":"      - tripleo-ansible-centos-7-molecule-test_deps"},{"line_number":7,"context_line":"      - tripleo-ansible-centos-7-molecule-test_json_error_callback"},{"line_number":8,"context_line":"      - tripleo-ansible-centos-7-molecule-test_package_action"},{"line_number":9,"context_line":"      - tripleo-ansible-centos-7-molecule-tripleo-bootstrap"},{"line_number":10,"context_line":"      - tripleo-ansible-centos-7-molecule-tuned"},{"line_number":11,"context_line":"      - tripleo-ansible-centos-7-role-addition"},{"line_number":12,"context_line":"      - tripleo-ansible-centos-7-molecule-tripleo-create-admin"},{"line_number":13,"context_line":"      - tripleo-ansible-centos-7-molecule-tripleo-module-load"},{"line_number":14,"context_line":"      - tripleo-ansible-centos-7-molecule-tripleo-ssh-known-hosts"},{"line_number":15,"context_line":"      - tripleo-ansible-centos-7-molecule-tripleo-container-tag"},{"line_number":16,"context_line":"      - tripleo-ansible-centos-7-molecule-tripleo-container-rm"},{"line_number":17,"context_line":"      - tripleo-ansible-centos-7-molecule-tripleo-image-serve"},{"line_number":18,"context_line":"      - tripleo-ansible-centos-7-molecule-tripleo-transfer"},{"line_number":19,"context_line":"      - tripleo-ansible-centos-7-molecule-tripleo-container-stop"},{"line_number":20,"context_line":"    gate:"},{"line_number":21,"context_line":"      jobs:"},{"line_number":22,"context_line":"      - tripleo-ansible-centos-7-molecule-aide"},{"line_number":23,"context_line":"      - tripleo-ansible-centos-7-molecule-test_deps"},{"line_number":24,"context_line":"      - tripleo-ansible-centos-7-molecule-test_json_error_callback"},{"line_number":25,"context_line":"      - tripleo-ansible-centos-7-molecule-test_package_action"},{"line_number":26,"context_line":"      - tripleo-ansible-centos-7-molecule-tripleo-bootstrap"},{"line_number":27,"context_line":"      - tripleo-ansible-centos-7-molecule-tuned"},{"line_number":28,"context_line":"      - tripleo-ansible-centos-7-role-addition"},{"line_number":29,"context_line":"      - tripleo-ansible-centos-7-molecule-tripleo-create-admin"},{"line_number":30,"context_line":"      - tripleo-ansible-centos-7-molecule-tripleo-module-load"},{"line_number":31,"context_line":"      - tripleo-ansible-centos-7-molecule-tripleo-ssh-known-hosts"},{"line_number":32,"context_line":"      - tripleo-ansible-centos-7-molecule-tripleo-container-tag"},{"line_number":33,"context_line":"      - tripleo-ansible-centos-7-molecule-tripleo-container-rm"},{"line_number":34,"context_line":"      - tripleo-ansible-centos-7-molecule-tripleo-image-serve"},{"line_number":35,"context_line":"      - tripleo-ansible-centos-7-molecule-tripleo-transfer"},{"line_number":36,"context_line":"      - tripleo-ansible-centos-7-molecule-tripleo-container-stop"},{"line_number":37,"context_line":"    name: tripleo-ansible-molecule-jobs"},{"line_number":38,"context_line":"- job:"},{"line_number":39,"context_line":"    files:"},{"line_number":40,"context_line":"    - ^tripleo_ansible/roles/aide/.*"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7faddb67_955aeb27","line":37,"range":{"start_line":2,"start_character":2,"end_line":37,"end_character":0},"updated":"2019-07-09 08:54:44.000000000","message":"Job tripleo-ansible-centos-7-molecule-tripleo-container-stop not defined","commit_id":"91d76019f64b7118067b333416cf043648a2a238"}]}