)]}'
{"doc/source/roles/role-tripleo-persist.rst":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"8ec23ab078a27158407fa93cd7a70bcb5ca5561f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    * tripleo-persist"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Default variables"},{"line_number":11,"context_line":"~~~~~~~~~~~~~~~~~"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":".. literalinclude:: ../../../tripleo_ansible/roles/tripleo-persist/defaults/main.yml"},{"line_number":14,"context_line":"  :language: yaml"},{"line_number":15,"context_line":"  :start-after: under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Example playbook"},{"line_number":19,"context_line":"~~~~~~~~~~~~~~~~"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":".. literalinclude:: ../../../tripleo_ansible/roles/tripleo-persist/molecule/default/playbook.yml"},{"line_number":22,"context_line":"  :language: yaml"},{"line_number":23,"context_line":"  :start-after: under the License."}],"source_content_type":"text/x-rst","patch_set":7,"id":"7faddb67_d7224752","line":23,"range":{"start_line":10,"start_character":0,"end_line":23,"end_character":34},"updated":"2019-07-15 18:11:33.000000000","message":"This is new, but the role docs can now be simplified to\n\n  .. ansibleautoplugin::\n     :role: tripleo_ansible/roles/tripleo-persist\n\nWith that everything about the role will be auto-generated.","commit_id":"e302fc37620aabae4783f47f8bacf1d51685aedc"},{"author":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"change_message_id":"a41e1b3c31afe403464cdf28edb10a847e0f20ea","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    * tripleo-persist"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Default variables"},{"line_number":11,"context_line":"~~~~~~~~~~~~~~~~~"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":".. literalinclude:: ../../../tripleo_ansible/roles/tripleo-persist/defaults/main.yml"},{"line_number":14,"context_line":"  :language: yaml"},{"line_number":15,"context_line":"  :start-after: under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Example playbook"},{"line_number":19,"context_line":"~~~~~~~~~~~~~~~~"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":".. literalinclude:: ../../../tripleo_ansible/roles/tripleo-persist/molecule/default/playbook.yml"},{"line_number":22,"context_line":"  :language: yaml"},{"line_number":23,"context_line":"  :start-after: under the License."}],"source_content_type":"text/x-rst","patch_set":7,"id":"7faddb67_7b6240da","line":23,"range":{"start_line":10,"start_character":0,"end_line":23,"end_character":34},"in_reply_to":"7faddb67_d7224752","updated":"2019-07-17 12:57:04.000000000","message":"Done","commit_id":"e302fc37620aabae4783f47f8bacf1d51685aedc"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"e78e5bebf9d3ae0dea9ec72173219475379f3485","unresolved":false,"context_lines":[{"line_number":2,"context_line":"TripleO-Ansible Role - tripleo-persist"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"This role provides for the following services:"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    * tripleo-persist"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Default variables"},{"line_number":11,"context_line":"~~~~~~~~~~~~~~~~~"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":".. literalinclude:: ../../../tripleo_ansible/roles/tripleo-persist/defaults/main.yml"},{"line_number":14,"context_line":"  :language: yaml"},{"line_number":15,"context_line":"  :start-after: under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Example playbook"},{"line_number":19,"context_line":"~~~~~~~~~~~~~~~~"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":".. literalinclude:: ../../../tripleo_ansible/roles/tripleo-persist/molecule/default/playbook.yml"},{"line_number":22,"context_line":"  :language: yaml"},{"line_number":23,"context_line":"  :start-after: under the License."}],"source_content_type":"text/x-rst","patch_set":10,"id":"7faddb67_0bc4013f","line":23,"range":{"start_line":5,"start_character":0,"end_line":23,"end_character":34},"updated":"2019-07-18 16:25:56.000000000","message":"Now that the sphinx plugin has merged, this can all be simplified to:\n\n.. ansibleautoplugin::\n   :role: tripleo_ansible/roles/tripleo-persist","commit_id":"2c88aacb9b9b7030bff283ad76940680f9b836e8"},{"author":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"change_message_id":"434bed05fc10fe2bd9526d7f8c06876d76bc35a1","unresolved":false,"context_lines":[{"line_number":2,"context_line":"TripleO-Ansible Role - tripleo-persist"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"This role provides for the following services:"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    * tripleo-persist"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Default variables"},{"line_number":11,"context_line":"~~~~~~~~~~~~~~~~~"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":".. literalinclude:: ../../../tripleo_ansible/roles/tripleo-persist/defaults/main.yml"},{"line_number":14,"context_line":"  :language: yaml"},{"line_number":15,"context_line":"  :start-after: under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Example playbook"},{"line_number":19,"context_line":"~~~~~~~~~~~~~~~~"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":".. literalinclude:: ../../../tripleo_ansible/roles/tripleo-persist/molecule/default/playbook.yml"},{"line_number":22,"context_line":"  :language: yaml"},{"line_number":23,"context_line":"  :start-after: under the License."}],"source_content_type":"text/x-rst","patch_set":10,"id":"7faddb67_311b6eca","line":23,"range":{"start_line":5,"start_character":0,"end_line":23,"end_character":34},"in_reply_to":"7faddb67_0bc4013f","updated":"2019-07-18 18:16:32.000000000","message":"Dejavu. I thought I already updated this. I sent a new patch to address this.","commit_id":"2c88aacb9b9b7030bff283ad76940680f9b836e8"}],"tripleo_ansible/roles/tripleo-persist/README.md":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"c89e33e8f7b0ea9c822100e6d7a9074c392a73b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7faddb67_11ca596c","updated":"2019-07-11 19:01:15.000000000","message":"we can get rid of this file. It\u0027s at best duplicate documentation and at worst incorrect documentation.","commit_id":"399e014b21bd213b2dae2747bd470a6e15037902"}],"tripleo_ansible/roles/tripleo-persist/defaults/main.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"c89e33e8f7b0ea9c822100e6d7a9074c392a73b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7faddb67_91aba987","updated":"2019-07-11 19:01:15.000000000","message":"this should have our boilerplate heading and \"---\" indicating its a yaml document.","commit_id":"399e014b21bd213b2dae2747bd470a6e15037902"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"94825fb8b392e2e18c67998cfbe37b6bd576249a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7faddb67_b1ed858c","in_reply_to":"7faddb67_91aba987","updated":"2019-07-11 19:07:54.000000000","message":"example boilerplate https://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/roles/tripleo-container-tag/tasks/main.yml#L1-L15","commit_id":"399e014b21bd213b2dae2747bd470a6e15037902"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"2d05e2a1aebb28f5e9dc497b0b9d81f7715d6ad3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7faddb67_6c6f3292","updated":"2019-07-11 19:40:42.000000000","message":"given `tripleo_persist_storage_root_become` is a required default, and is defined as a var in the test playbook, maybe we could add it here as something like so, \n\n    tripleo_persist_storage_root_become: \"{{ lookup(\u0027env\u0027, \u0027TRIPLEO_PERSIST_USER\u0027) or ansible_user }}\"","commit_id":"585a21f668145a7c628bf56ae2579022c0122d21"}],"tripleo_ansible/roles/tripleo-persist/molecule/default/Dockerfile.j2":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"c89e33e8f7b0ea9c822100e6d7a9074c392a73b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7faddb67_119fb95f","updated":"2019-07-11 19:01:15.000000000","message":"this file should just be \"Dockerfile\" following the other roles we have.","commit_id":"399e014b21bd213b2dae2747bd470a6e15037902"}],"tripleo_ansible/roles/tripleo-persist/molecule/default/molecule.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"c89e33e8f7b0ea9c822100e6d7a9074c392a73b0","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  - name: centos7"},{"line_number":9,"context_line":"    hostname: centos7"},{"line_number":10,"context_line":"    image: centos:7"},{"line_number":11,"context_line":"    #dockerfile: Dockerfile.j2"},{"line_number":12,"context_line":"    pkg_extras: python-setuptools"},{"line_number":13,"context_line":"    easy_install:"},{"line_number":14,"context_line":"      - pip"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_d18a8119","line":11,"updated":"2019-07-11 19:01:15.000000000","message":"is this not needed?","commit_id":"399e014b21bd213b2dae2747bd470a6e15037902"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"c89e33e8f7b0ea9c822100e6d7a9074c392a73b0","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  - name: centos7"},{"line_number":9,"context_line":"    hostname: centos7"},{"line_number":10,"context_line":"    image: centos:7"},{"line_number":11,"context_line":"    #dockerfile: Dockerfile.j2"},{"line_number":12,"context_line":"    pkg_extras: python-setuptools"},{"line_number":13,"context_line":"    easy_install:"},{"line_number":14,"context_line":"      - pip"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_71794d2d","line":11,"range":{"start_line":11,"start_character":17,"end_line":11,"end_character":30},"updated":"2019-07-11 19:01:15.000000000","message":"should be \"Dockerfile\".","commit_id":"399e014b21bd213b2dae2747bd470a6e15037902"}],"tripleo_ansible/roles/tripleo-persist/molecule/default/playbook.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"c89e33e8f7b0ea9c822100e6d7a9074c392a73b0","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        state: directory"},{"line_number":33,"context_line":"        mode: 0700"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  tasks:"},{"line_number":36,"context_line":"    - name: Run persist"},{"line_number":37,"context_line":"      import_tasks: ../../tasks/persist.yml"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    - name: Run restore"},{"line_number":40,"context_line":"      import_tasks: ../../tasks/restore.yml"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    - name: Run cleanup"},{"line_number":43,"context_line":"      import_tasks: ../../tasks/cleanup.yml"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_51cc5169","line":43,"range":{"start_line":35,"start_character":0,"end_line":43,"end_character":43},"updated":"2019-07-11 19:01:15.000000000","message":"should this be using import_role: and tasks_from:?","commit_id":"399e014b21bd213b2dae2747bd470a6e15037902"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"2d05e2a1aebb28f5e9dc497b0b9d81f7715d6ad3","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  hosts: all"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"  vars:"},{"line_number":22,"context_line":"    tripleo_persist_storage_root_become: \"{{ lookup(\u0027env\u0027, \u0027TRIPLEO_PERSIST_USER\u0027) |"},{"line_number":23,"context_line":"                                             default(\u0027zuul\u0027) }}\""},{"line_number":24,"context_line":"    tripleo_persist_storage_root_dir: |"},{"line_number":25,"context_line":"      /home/{{ tripleo_persist_storage_root_become}}/tripleo_persist_storage"},{"line_number":26,"context_line":"    tripleo_persist_dir: /root"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_ac2bea2d","line":23,"range":{"start_line":22,"start_character":83,"end_line":23,"end_character":60},"updated":"2019-07-11 19:40:42.000000000","message":"I don\u0027t think the default filter works in environment lookups. I believe the lookup will always succeed even if the environment variable is undefined.","commit_id":"585a21f668145a7c628bf56ae2579022c0122d21"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"2d05e2a1aebb28f5e9dc497b0b9d81f7715d6ad3","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"  vars:"},{"line_number":22,"context_line":"    tripleo_persist_storage_root_become: \"{{ lookup(\u0027env\u0027, \u0027TRIPLEO_PERSIST_USER\u0027) |"},{"line_number":23,"context_line":"                                             default(\u0027zuul\u0027) }}\""},{"line_number":24,"context_line":"    tripleo_persist_storage_root_dir: |"},{"line_number":25,"context_line":"      /home/{{ tripleo_persist_storage_root_become}}/tripleo_persist_storage"},{"line_number":26,"context_line":"    tripleo_persist_dir: /root"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_4cf916c6","line":23,"range":{"start_line":23,"start_character":54,"end_line":23,"end_character":58},"updated":"2019-07-11 19:40:42.000000000","message":"I\u0027m not sure we want to assume the executing user is \"zuul\" maybe better just to set this to `ansible_user` so an undefined environment variable falls back to the user executing the playbook.\n\nMaybe something like \n\n  tripleo_persist_storage_root_become: \"{{ lookup(\u0027env\u0027, \u0027TRIPLEO_PERSIST_USER\u0027) or ansible_user }}\"","commit_id":"585a21f668145a7c628bf56ae2579022c0122d21"},{"author":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"change_message_id":"284c2e44fc1a9810c5176ac01608bd7bed3e426b","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"  vars:"},{"line_number":22,"context_line":"    tripleo_persist_storage_root_become: \"{{ lookup(\u0027env\u0027, \u0027TRIPLEO_PERSIST_USER\u0027) |"},{"line_number":23,"context_line":"                                             default(\u0027zuul\u0027) }}\""},{"line_number":24,"context_line":"    tripleo_persist_storage_root_dir: |"},{"line_number":25,"context_line":"      /home/{{ tripleo_persist_storage_root_become}}/tripleo_persist_storage"},{"line_number":26,"context_line":"    tripleo_persist_dir: /root"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_4c2836e1","line":23,"range":{"start_line":23,"start_character":54,"end_line":23,"end_character":58},"in_reply_to":"7faddb67_4cf916c6","updated":"2019-07-11 20:11:57.000000000","message":"ansible_user is defaulting to \"root\" for me using the docker driver in Molecule. This test does not require root so I was trying to workaround that by having the test use the \"zuul\" user in CI. Then local workstation testers could override it with an environment variable and avoid root being used on their workstation, too.","commit_id":"585a21f668145a7c628bf56ae2579022c0122d21"},{"author":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"change_message_id":"284c2e44fc1a9810c5176ac01608bd7bed3e426b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  hosts: all"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"  vars:"},{"line_number":22,"context_line":"    tripleo_persist_storage_root_become: \"{{ lookup(\u0027env\u0027, \u0027TRIPLEO_PERSIST_USER\u0027) |"},{"line_number":23,"context_line":"                                             default(\u0027zuul\u0027) }}\""},{"line_number":24,"context_line":"    tripleo_persist_storage_root_dir: |"},{"line_number":25,"context_line":"      /home/{{ tripleo_persist_storage_root_become}}/tripleo_persist_storage"},{"line_number":26,"context_line":"    tripleo_persist_dir: /root"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_2ce05a96","line":23,"range":{"start_line":22,"start_character":83,"end_line":23,"end_character":60},"in_reply_to":"7faddb67_ac2bea2d","updated":"2019-07-11 20:11:57.000000000","message":"You\u0027re right, the default is not working as expected. I\u0027ll have to re-evaluate this.","commit_id":"585a21f668145a7c628bf56ae2579022c0122d21"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"0c077ef120571316ccf859c5d06d2a5daea1ae81","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"  pre_tasks:"},{"line_number":26,"context_line":"    - name: Create directory"},{"line_number":27,"context_line":"      file:"},{"line_number":28,"context_line":"        path: \"{{ tripleo_persist_storage_root_dir }}\""},{"line_number":29,"context_line":"        state: directory"},{"line_number":30,"context_line":"        mode: 0700"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  tasks:"},{"line_number":33,"context_line":"    - name: Run persist"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_61d95f7d","line":30,"range":{"start_line":27,"start_character":6,"end_line":30,"end_character":18},"updated":"2019-07-14 08:51:15.000000000","message":"should it be with \"delegate_to: localhost\"?","commit_id":"44741e063f0fad19d65f887286b507e06a09c38a"}],"tripleo_ansible/roles/tripleo-persist/tasks/cleanup.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"c89e33e8f7b0ea9c822100e6d7a9074c392a73b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7faddb67_31c1952f","updated":"2019-07-11 19:01:15.000000000","message":"missing boilerplate","commit_id":"399e014b21bd213b2dae2747bd470a6e15037902"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"092e75997e4d3ea13f86534ba5e549e4c823d16d","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    path: \"{{ tripleo_persist_storage_root_dir }}\""},{"line_number":20,"context_line":"    state: absent"},{"line_number":21,"context_line":"  delegate_to: localhost"},{"line_number":22,"context_line":"  become: \"{{ tripleo_persist_storage_root_become }}\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_f62397a5","line":22,"range":{"start_line":22,"start_character":10,"end_line":22,"end_character":53},"updated":"2019-07-18 07:50:30.000000000","message":"please use \"|bool\" for boolean","commit_id":"e302fc37620aabae4783f47f8bacf1d51685aedc"},{"author":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"change_message_id":"56b252f2bd51b91970e8b52a6b5ccd94eb97b4f5","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    path: \"{{ tripleo_persist_storage_root_dir }}\""},{"line_number":20,"context_line":"    state: absent"},{"line_number":21,"context_line":"  delegate_to: localhost"},{"line_number":22,"context_line":"  become: \"{{ tripleo_persist_storage_root_become }}\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_c2080e93","line":22,"range":{"start_line":22,"start_character":10,"end_line":22,"end_character":53},"in_reply_to":"7faddb67_f62397a5","updated":"2019-07-18 14:24:34.000000000","message":"Done","commit_id":"e302fc37620aabae4783f47f8bacf1d51685aedc"}],"tripleo_ansible/roles/tripleo-persist/tasks/persist.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"c89e33e8f7b0ea9c822100e6d7a9074c392a73b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7faddb67_f1e0ddce","updated":"2019-07-11 19:01:15.000000000","message":"missing boilerplate","commit_id":"399e014b21bd213b2dae2747bd470a6e15037902"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"0c077ef120571316ccf859c5d06d2a5daea1ae81","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    tripleo_persist_dir_safe: \"{{ tripleo_persist_dir|regex_replace(\u0027\\\\/$\u0027, \u0027\u0027) }}\""},{"line_number":35,"context_line":"    cacheable: false"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# Using the \"archive\" module lists lists all tarred files in module"},{"line_number":38,"context_line":"# output, if there\u0027s too many files, it can crash ansible even with"},{"line_number":39,"context_line":"# \"no_log: true\"."},{"line_number":40,"context_line":"- name: create the archive"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_a1e1972c","line":37,"range":{"start_line":37,"start_character":29,"end_line":37,"end_character":40},"updated":"2019-07-14 08:51:15.000000000","message":"lists lists","commit_id":"44741e063f0fad19d65f887286b507e06a09c38a"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"092e75997e4d3ea13f86534ba5e549e4c823d16d","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    mode: 0700"},{"line_number":23,"context_line":"    state: directory"},{"line_number":24,"context_line":"  delegate_to: localhost"},{"line_number":25,"context_line":"  become: \"{{ tripleo_persist_storage_root_become }}\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- name: create tempfile for the archive"},{"line_number":28,"context_line":"  tempfile:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_963ee3be","line":25,"range":{"start_line":25,"start_character":10,"end_line":25,"end_character":53},"updated":"2019-07-18 07:50:30.000000000","message":"please use \"|bool\" for boolean","commit_id":"e302fc37620aabae4783f47f8bacf1d51685aedc"},{"author":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"change_message_id":"56b252f2bd51b91970e8b52a6b5ccd94eb97b4f5","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    mode: 0700"},{"line_number":23,"context_line":"    state: directory"},{"line_number":24,"context_line":"  delegate_to: localhost"},{"line_number":25,"context_line":"  become: \"{{ tripleo_persist_storage_root_become }}\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"- name: create tempfile for the archive"},{"line_number":28,"context_line":"  tempfile:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_a2107201","line":25,"range":{"start_line":25,"start_character":10,"end_line":25,"end_character":53},"in_reply_to":"7faddb67_963ee3be","updated":"2019-07-18 14:24:34.000000000","message":"Done","commit_id":"e302fc37620aabae4783f47f8bacf1d51685aedc"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"092e75997e4d3ea13f86534ba5e549e4c823d16d","unresolved":false,"context_lines":[{"line_number":38,"context_line":"# output, if there\u0027s too many files, it can crash ansible even with"},{"line_number":39,"context_line":"# \"no_log: true\"."},{"line_number":40,"context_line":"- name: create the archive"},{"line_number":41,"context_line":"  shell: |"},{"line_number":42,"context_line":"    tar -czf \"{{ tripleo_persist_tempfile.path }}\" -C \"{{ tripleo_persist_dir_safe|dirname }}\" \"{{ tripleo_persist_dir_safe|basename }}\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"- name: fetch the archive"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_76448747","line":41,"range":{"start_line":41,"start_character":1,"end_line":41,"end_character":7},"updated":"2019-07-18 07:50:30.000000000","message":"can ansible archive module be helpful here? https://docs.ansible.com/ansible/latest/modules/archive_module.html","commit_id":"e302fc37620aabae4783f47f8bacf1d51685aedc"},{"author":{"_account_id":25877,"name":"Luke Short","email":"ekultails@gmail.com","username":"ekultails"},"change_message_id":"56b252f2bd51b91970e8b52a6b5ccd94eb97b4f5","unresolved":false,"context_lines":[{"line_number":38,"context_line":"# output, if there\u0027s too many files, it can crash ansible even with"},{"line_number":39,"context_line":"# \"no_log: true\"."},{"line_number":40,"context_line":"- name: create the archive"},{"line_number":41,"context_line":"  shell: |"},{"line_number":42,"context_line":"    tar -czf \"{{ tripleo_persist_tempfile.path }}\" -C \"{{ tripleo_persist_dir_safe|dirname }}\" \"{{ tripleo_persist_dir_safe|basename }}\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"- name: fetch the archive"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7faddb67_c216cea8","line":41,"range":{"start_line":41,"start_character":1,"end_line":41,"end_character":7},"in_reply_to":"7faddb67_76448747","updated":"2019-07-18 14:24:34.000000000","message":"There are two problems with using archive. (1) The comment above the task indicates that there were previous issues with Ansible handling a large number of inodes. (2) There is currently no way to set the current directory via `tar -C` in Ansible. This would leave us with a long nested directory structure that in undesirable. See: https://github.com/ansible/ansible/issues/34043","commit_id":"e302fc37620aabae4783f47f8bacf1d51685aedc"}],"tripleo_ansible/roles/tripleo-persist/tasks/restore.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"c89e33e8f7b0ea9c822100e6d7a9074c392a73b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7faddb67_b1ea65a9","updated":"2019-07-11 19:01:15.000000000","message":"missing boilerplate","commit_id":"399e014b21bd213b2dae2747bd470a6e15037902"}],"tripleo_ansible/roles/tripleo-persist/test-playbook.yml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"c89e33e8f7b0ea9c822100e6d7a9074c392a73b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7faddb67_51d1b1fa","updated":"2019-07-11 19:01:15.000000000","message":"missing boilerplate","commit_id":"399e014b21bd213b2dae2747bd470a6e15037902"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"6d338bcd3fc8364731c35cb4cbe718b8c690391c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7faddb67_8deb77da","updated":"2019-07-12 21:12:32.000000000","message":"Given this is not actually used anywhere we can probably remove it.","commit_id":"44741e063f0fad19d65f887286b507e06a09c38a"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"0c077ef120571316ccf859c5d06d2a5daea1ae81","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7faddb67_21cfe7b0","in_reply_to":"7faddb67_8deb77da","updated":"2019-07-14 08:51:15.000000000","message":"+1","commit_id":"44741e063f0fad19d65f887286b507e06a09c38a"}],"zuul.d/molecule.yaml":[{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"b23b0af547fbdaf1e8a92fce5cc77dfdc979bd32","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- project-template:"},{"line_number":3,"context_line":"    check:"},{"line_number":4,"context_line":"      jobs:"},{"line_number":5,"context_line":"      - tripleo-ansible-centos-7-molecule-aide"},{"line_number":6,"context_line":"      - tripleo-ansible-centos-7-molecule-test_deps"},{"line_number":7,"context_line":"      - tripleo-ansible-centos-7-molecule-test_json_error_callback"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_d17921fc","line":4,"updated":"2019-07-11 19:03:21.000000000","message":"we need to make sure to add \"tripleo-ansible-centos-7-molecule-tripleo-persist\" here too","commit_id":"399e014b21bd213b2dae2747bd470a6e15037902"},{"author":{"_account_id":7353,"name":"Kevin Carter","email":"kevin@cloudnull.com","username":"cloudnull"},"change_message_id":"b23b0af547fbdaf1e8a92fce5cc77dfdc979bd32","unresolved":false,"context_lines":[{"line_number":16,"context_line":"      - tripleo-ansible-centos-7-molecule-tripleo-container-rm"},{"line_number":17,"context_line":"      - tripleo-ansible-centos-7-molecule-tripleo-image-serve"},{"line_number":18,"context_line":"      - tripleo-ansible-centos-7-molecule-tripleo-transfer"},{"line_number":19,"context_line":"    gate:"},{"line_number":20,"context_line":"      jobs:"},{"line_number":21,"context_line":"      - tripleo-ansible-centos-7-molecule-aide"},{"line_number":22,"context_line":"      - tripleo-ansible-centos-7-molecule-test_deps"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_f17c5dec","line":19,"updated":"2019-07-11 19:03:21.000000000","message":"ditto","commit_id":"399e014b21bd213b2dae2747bd470a6e15037902"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"change_message_id":"abc6f1a27b24e2745f0ef97b4e71dab409e6b395","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- project-template:"},{"line_number":3,"context_line":"    check:"},{"line_number":4,"context_line":"      jobs:"},{"line_number":5,"context_line":"      - tripleo-ansible-centos-7-molecule-aide"},{"line_number":6,"context_line":"      - tripleo-ansible-centos-7-molecule-test_deps"},{"line_number":7,"context_line":"      - tripleo-ansible-centos-7-molecule-test_json_error_callback"},{"line_number":8,"context_line":"      - tripleo-ansible-centos-7-molecule-test_package_action"},{"line_number":9,"context_line":"      - tripleo-ansible-centos-7-molecule-tripleo-bootstrap"},{"line_number":10,"context_line":"      - tripleo-ansible-centos-7-molecule-tuned"},{"line_number":11,"context_line":"      - tripleo-ansible-centos-7-role-addition"},{"line_number":12,"context_line":"      - tripleo-ansible-centos-7-molecule-tripleo-create-admin"},{"line_number":13,"context_line":"      - tripleo-ansible-centos-7-molecule-tripleo-module-load"},{"line_number":14,"context_line":"      - tripleo-ansible-centos-7-molecule-tripleo-ssh-known-hosts"},{"line_number":15,"context_line":"      - tripleo-ansible-centos-7-molecule-tripleo-container-tag"},{"line_number":16,"context_line":"      - tripleo-ansible-centos-7-molecule-tripleo-container-rm"},{"line_number":17,"context_line":"      - tripleo-ansible-centos-7-molecule-tripleo-image-serve"},{"line_number":18,"context_line":"      - tripleo-ansible-centos-7-molecule-tripleo-transfer"},{"line_number":19,"context_line":"      - tripleo-ansible-centos-7-molecule-tripleo-podman"},{"line_number":20,"context_line":"      - tripleo-ansible-centos-7-molecule-tripleo-persist"},{"line_number":21,"context_line":"    gate:"},{"line_number":22,"context_line":"      jobs:"},{"line_number":23,"context_line":"      - tripleo-ansible-centos-7-molecule-aide"},{"line_number":24,"context_line":"      - tripleo-ansible-centos-7-molecule-test_deps"},{"line_number":25,"context_line":"      - tripleo-ansible-centos-7-molecule-test_json_error_callback"},{"line_number":26,"context_line":"      - tripleo-ansible-centos-7-molecule-test_package_action"},{"line_number":27,"context_line":"      - tripleo-ansible-centos-7-molecule-tripleo-bootstrap"},{"line_number":28,"context_line":"      - tripleo-ansible-centos-7-molecule-tuned"},{"line_number":29,"context_line":"      - tripleo-ansible-centos-7-role-addition"},{"line_number":30,"context_line":"      - tripleo-ansible-centos-7-molecule-tripleo-create-admin"},{"line_number":31,"context_line":"      - tripleo-ansible-centos-7-molecule-tripleo-module-load"},{"line_number":32,"context_line":"      - tripleo-ansible-centos-7-molecule-tripleo-ssh-known-hosts"},{"line_number":33,"context_line":"      - tripleo-ansible-centos-7-molecule-tripleo-container-tag"},{"line_number":34,"context_line":"      - tripleo-ansible-centos-7-molecule-tripleo-container-rm"},{"line_number":35,"context_line":"      - tripleo-ansible-centos-7-molecule-tripleo-image-serve"},{"line_number":36,"context_line":"      - tripleo-ansible-centos-7-molecule-tripleo-transfer"},{"line_number":37,"context_line":"      - tripleo-ansible-centos-7-molecule-tripleo-podman"},{"line_number":38,"context_line":"      - tripleo-ansible-centos-7-molecule-tripleo-persist"},{"line_number":39,"context_line":"    name: tripleo-ansible-molecule-jobs"},{"line_number":40,"context_line":"- job:"},{"line_number":41,"context_line":"    files:"},{"line_number":42,"context_line":"    - ^tripleo_ansible/roles/aide/.*"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7faddb67_c5081893","line":39,"range":{"start_line":2,"start_character":2,"end_line":39,"end_character":0},"updated":"2019-07-18 14:53:42.000000000","message":"Job tripleo-ansible-centos-7-molecule-tripleo-persist not defined","commit_id":"9e765bf609dd2cc70ca8941a5fe7799ccae541b1"}]}