)]}'
{"tripleo_ansible/roles/tripleo-container-rm/tasks/tripleo_docker_container_rm.yml":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"66298610b3fd33d36953bd9fcf34f7a473d550ba","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- name: \"Check if {{ container }} is running in docker backend\""},{"line_number":18,"context_line":"  command: \"docker inspect --type container --format exists {{ container }}\""},{"line_number":19,"context_line":"  register: stat_docker_container"},{"line_number":20,"context_line":"  failed_when: false"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- name: remove \"{{ container }}\" container"},{"line_number":23,"context_line":"  docker_container:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_932a75d8","line":20,"range":{"start_line":17,"start_character":0,"end_line":20,"end_character":20},"updated":"2019-07-18 07:26:15.000000000","message":"seems redundant","commit_id":"e29aa0099040f8066683d8f355674c51361b44ed"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"b5e39f953a1eab307f98a939c87797f9d74ed09b","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- name: \"Check if {{ container }} is running in docker backend\""},{"line_number":18,"context_line":"  command: \"docker inspect --type container --format exists {{ container }}\""},{"line_number":19,"context_line":"  register: stat_docker_container"},{"line_number":20,"context_line":"  failed_when: false"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- name: remove \"{{ container }}\" container"},{"line_number":23,"context_line":"  docker_container:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_6967c8b8","line":20,"range":{"start_line":17,"start_character":0,"end_line":20,"end_character":20},"in_reply_to":"7faddb67_562dcba5","updated":"2019-07-18 09:11:48.000000000","message":"It doesn\u0027t check presence of docker-py, it\u0027s independent thing","commit_id":"e29aa0099040f8066683d8f355674c51361b44ed"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"2f54d0703eace5905515300a5ae977785534c268","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- name: \"Check if {{ container }} is running in docker backend\""},{"line_number":18,"context_line":"  command: \"docker inspect --type container --format exists {{ container }}\""},{"line_number":19,"context_line":"  register: stat_docker_container"},{"line_number":20,"context_line":"  failed_when: false"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"- name: remove \"{{ container }}\" container"},{"line_number":23,"context_line":"  docker_container:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_562dcba5","line":20,"range":{"start_line":17,"start_character":0,"end_line":20,"end_character":20},"in_reply_to":"7faddb67_932a75d8","updated":"2019-07-18 08:47:30.000000000","message":"guessing it is for that http://logs.openstack.org/96/670796/2/check/tripleo-ci-centos-7-standalone-upgrade/fefea6f/logs/undercloud/home/zuul/standalone_upgrade.log.txt.gz#_2019-07-16_12_50_09 \n\ncos there is no docker-py \n*similar to that we had it a while ago https://bugs.launchpad.net/tripleo/+bug/1824301","commit_id":"e29aa0099040f8066683d8f355674c51361b44ed"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"66298610b3fd33d36953bd9fcf34f7a473d550ba","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  docker_container:"},{"line_number":24,"context_line":"    name: \"{{ container }}\""},{"line_number":25,"context_line":"    state: absent"},{"line_number":26,"context_line":"  when:"},{"line_number":27,"context_line":"    - stat_docker_container.rc \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_331aa1cb","line":27,"range":{"start_line":26,"start_character":0,"end_line":27,"end_character":35},"updated":"2019-07-18 07:26:15.000000000","message":"Why do we need to check if it exists? \"state: absent\" is idempotent in docker","commit_id":"e29aa0099040f8066683d8f355674c51361b44ed"},{"author":{"_account_id":26343,"name":"Jose Luis Franco","email":"jfrancoa@redhat.com","username":"jfrancoa"},"change_message_id":"4927d9235bc08bbd47b12e056b53d39ae36f0374","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  docker_container:"},{"line_number":24,"context_line":"    name: \"{{ container }}\""},{"line_number":25,"context_line":"    state: absent"},{"line_number":26,"context_line":"  when:"},{"line_number":27,"context_line":"    - stat_docker_container.rc \u003d\u003d 0"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_f6acf79f","line":27,"range":{"start_line":26,"start_character":0,"end_line":27,"end_character":35},"in_reply_to":"7faddb67_331aa1cb","updated":"2019-07-18 08:15:14.000000000","message":"Even though the docker_container module is idempotent, it requires to have python2-docker installed to work properly and the rpm is missing in our master environments. That\u0027s mostly the reason why it\u0027s failing...The docker binary is present but it\u0027s python-docker what\u0027s missing and we end up getting the error:\n\"Failed to import docker or docker-py (Docker SDK for Python) - No module named docker. Try `pip install docker` or `pip install docker-py` (Python 2.6).\"\n\nSo, this is the best guard possible to avoid this bug...or we could change it into a check for the python2-docker rpm similar to the one we used to have in tripleo-docker-rm https://review.opendev.org/#/c/655511/1/roles/tripleo-docker-rm/tasks/main.yaml@2 which has been lost in the migration to tripleo-container-rm.","commit_id":"e29aa0099040f8066683d8f355674c51361b44ed"}]}